Re: [PR] [#5700] feat(CLI):Add extended help for catalogs in Gravitino CLI [gravitino]

2024-12-01 Thread via GitHub
justinmclean merged PR #5703: URL: https://github.com/apache/gravitino/pull/5703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gra

(gravitino) branch main updated: [#5700] feat(CLI):Add extended help for catalogs in Gravitino CLI (#5703)

2024-12-01 Thread jmclean
This is an automated email from the ASF dual-hosted git repository. jmclean pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 52d47500d [#5700] feat(CLI):Add extended help fo

Re: [I] [Improvement] Add extended help for Catalogs in Gravitino CLI [gravitino]

2024-12-01 Thread via GitHub
justinmclean closed issue #5700: [Improvement] Add extended help for Catalogs in Gravitino CLI URL: https://github.com/apache/gravitino/issues/5700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [I] [Improvement] Add extended help for Catalogs in Gravitino CLI [gravitino]

2024-12-01 Thread via GitHub
justinmclean closed issue #5700: [Improvement] Add extended help for Catalogs in Gravitino CLI URL: https://github.com/apache/gravitino/issues/5700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [I] [Improvement] User can create a paimon schema with comment ,but get the schema missing "comment" field [gravitino]

2024-12-01 Thread via GitHub
danhuawang commented on issue #5719: URL: https://github.com/apache/gravitino/issues/5719#issuecomment-2510793060 @FANNG1 Can you help check this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[I] [Improvement] User can create a paimon schema with comment ,but get the schema missing "comment" field [gravitino]

2024-12-01 Thread via GitHub
danhuawang opened a new issue, #5719: URL: https://github.com/apache/gravitino/issues/5719 ### What would you like to be improved? **1. Create a paimon catalog use jdbc as backend** https://github.com/user-attachments/assets/b88dad8e-e7eb-4e3f-9c41-bbb24ed4c98b";> **2. create a p

Re: [PR] [#5383] Add support for rename and update command command for Tables in Gravitino CLI [gravitino]

2024-12-01 Thread via GitHub
shaofengshi merged PR #5391: URL: https://github.com/apache/gravitino/pull/5391 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@grav

(gravitino) branch main updated: [#5383] Add support for rename and update command command for Tables in Gravitino CLI (#5391)

2024-12-01 Thread shaofengshi
This is an automated email from the ASF dual-hosted git repository. shaofengshi pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 12e50e50b [#5383] Add support for rename and

Re: [PR] [5201] feat(client-python): Implement expressions in python client [gravitino]

2024-12-01 Thread via GitHub
SophieTech88 commented on code in PR #5646: URL: https://github.com/apache/gravitino/pull/5646#discussion_r1865274947 ## clients/client-python/gravitino/api/expressions/literals/literals.py: ## @@ -0,0 +1,149 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or

Re: [PR] [minor] improvement(docs): adjust table properties docs [gravitino]

2024-12-01 Thread via GitHub
mchades commented on code in PR #5699: URL: https://github.com/apache/gravitino/pull/5699#discussion_r1865268161 ## docs/apache-hive-catalog.md: ## @@ -140,25 +140,27 @@ Since 0.6.0-incubating, the data types other than listed above are mapped to Gra Table properties supply or

Re: [PR] feat(helm-chart): remove helm-chart support [gravitino-playground]

2024-12-01 Thread via GitHub
xunliu commented on PR #110: URL: https://github.com/apache/gravitino-playground/pull/110#issuecomment-2510585174 @unknowntpo I will review this PR today, Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [5201] feat(client-python): Implement expressions in python client [gravitino]

2024-12-01 Thread via GitHub
xunliu commented on code in PR #5646: URL: https://github.com/apache/gravitino/pull/5646#discussion_r1865222574 ## clients/client-python/gravitino/api/expressions/literals/literals.py: ## @@ -0,0 +1,149 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

Re: [PR] [minor] improvement(docs): adjust table properties docs [gravitino]

2024-12-01 Thread via GitHub
orenccl commented on code in PR #5699: URL: https://github.com/apache/gravitino/pull/5699#discussion_r1865198156 ## docs/apache-hive-catalog.md: ## @@ -140,25 +140,29 @@ Since 0.6.0-incubating, the data types other than listed above are mapped to Gra Table properties supply or

Re: [PR] [minor] improvement(docs): adjust table properties docs [gravitino]

2024-12-01 Thread via GitHub
mchades commented on code in PR #5699: URL: https://github.com/apache/gravitino/pull/5699#discussion_r1865192568 ## docs/apache-hive-catalog.md: ## @@ -140,25 +140,29 @@ Since 0.6.0-incubating, the data types other than listed above are mapped to Gra Table properties supply or

Re: [PR] [MINOR] improve(build): Update the ASF yaml file's collaborator list [gravitino]

2024-12-01 Thread via GitHub
diqiu50 merged PR #5718: URL: https://github.com/apache/gravitino/pull/5718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitin

(gravitino) branch main updated: [MINOR] improve(build): Update the ASF yaml file's collaborator list (#5718)

2024-12-01 Thread diqiu50
This is an automated email from the ASF dual-hosted git repository. diqiu50 pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 867cb1e89 [MINOR] improve(build): Update the ASF

Re: [PR] [#5700] feat(CLI):Add extended help for catalogs in Gravitino CLI [gravitino]

2024-12-01 Thread via GitHub
jerryshao commented on PR #5703: URL: https://github.com/apache/gravitino/pull/5703#issuecomment-2510486866 OK, I see. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[PR] [MINOR] improve(build): Update the ASF yaml file's collaborator list [gravitino]

2024-12-01 Thread via GitHub
jerryshao opened a new pull request, #5718: URL: https://github.com/apache/gravitino/pull/5718 ### What changes were proposed in this pull request? This PR updates the collaborator list to remove some existing committer's name and one new active contributor. ### Why are the cha

Re: [PR] [#5700] feat(CLI):Add extended help for catalogs in Gravitino CLI [gravitino]

2024-12-01 Thread via GitHub
chenyuan99 commented on PR #5703: URL: https://github.com/apache/gravitino/pull/5703#issuecomment-2510476630 > Looks like this file misses the license header, I'm curious why it can still pass the CI? I think @justinmclean excluded txt files for the client help txt files in the rat c

Re: [PR] [#5700] feat(CLI):Add extended help for catalogs in Gravitino CLI [gravitino]

2024-12-01 Thread via GitHub
jerryshao commented on PR #5703: URL: https://github.com/apache/gravitino/pull/5703#issuecomment-2510472310 Looks like this file misses the license header, I'm curious why it can still pass the CI? -- This is an automated message from the Apache Git Service. To respond to the message, ple

[PR] [#5383] Add create table command to the Gravitino CLI [gravitino]

2024-12-01 Thread via GitHub
justinmclean opened a new pull request, #5717: URL: https://github.com/apache/gravitino/pull/5717 ### What changes were proposed in this pull request? Add the ability to create a table via the Gravitino CLI. ### Why are the changes needed? so we can create tables via the

Re: [PR] [minor] improvement(docs): adjust table properties docs [gravitino]

2024-12-01 Thread via GitHub
orenccl commented on code in PR #5699: URL: https://github.com/apache/gravitino/pull/5699#discussion_r1865164636 ## docs/apache-hive-catalog.md: ## @@ -140,25 +140,31 @@ Since 0.6.0-incubating, the data types other than listed above are mapped to Gra Table properties supply or

Re: [PR] [#5631] Add test cases for other supported catalogs in Trino Cascading [gravitino]

2024-12-01 Thread via GitHub
danhuawang commented on code in PR #5632: URL: https://github.com/apache/gravitino/pull/5632#discussion_r1865162056 ## trino-connector/integration-test/src/test/java/org/apache/gravitino/trino/connector/integration/test/TrinoQueryRunner.java: ## @@ -65,6 +67,29 @@ private QueryR

Re: [I] [FEATURE] Support web ui for creating topic [gravitino]

2024-12-01 Thread via GitHub
LauraXia123 commented on issue #5447: URL: https://github.com/apache/gravitino/issues/5447#issuecomment-2510458800 @liuchunhao hi, do you have time for this? If not, I'll take over. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [I] [FEATURE] Add formatted output to Gravitino CLI [gravitino]

2024-12-01 Thread via GitHub
jerryshao commented on issue #5506: URL: https://github.com/apache/gravitino/issues/5506#issuecomment-2510456770 Fixed by #5714 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [I] [FEATURE] Add formatted output to Gravitino CLI [gravitino]

2024-12-01 Thread via GitHub
jerryshao closed issue #5506: [FEATURE] Add formatted output to Gravitino CLI URL: https://github.com/apache/gravitino/issues/5506 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

(gravitino) branch main updated: [#5506] feat(CLI): Table formatted output (#5714)

2024-12-01 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 626bc7943 [#5506] feat(CLI): Table formatted outpu

Re: [PR] [#5506] feat(CLI): Table formatted output [gravitino]

2024-12-01 Thread via GitHub
jerryshao merged PR #5714: URL: https://github.com/apache/gravitino/pull/5714 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

Re: [PR] [#5383] Add support for Gravitino CLI table update commands [gravitino]

2024-12-01 Thread via GitHub
justinmclean closed pull request #5715: [#5383] Add support for Gravitino CLI table update commands URL: https://github.com/apache/gravitino/pull/5715 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [#5383] Add support for Gravitino CLI table update commands [gravitino]

2024-12-01 Thread via GitHub
justinmclean commented on PR #5715: URL: https://github.com/apache/gravitino/pull/5715#issuecomment-2510455830 Duplicate PR - this one is not needed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] [#5383] Add column command for the Gravitino CLI [gravitino]

2024-12-01 Thread via GitHub
justinmclean commented on PR #5432: URL: https://github.com/apache/gravitino/pull/5432#issuecomment-2510453917 Duplicate PR on an old branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] [#5383] Add column command for the Gravitino CLI [gravitino]

2024-12-01 Thread via GitHub
justinmclean closed pull request #5432: [#5383] Add column command for the Gravitino CLI URL: https://github.com/apache/gravitino/pull/5432 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] [#5383] Add support for rename and update command command for Tables in Gravitino CLI [gravitino]

2024-12-01 Thread via GitHub
justinmclean commented on PR #5391: URL: https://github.com/apache/gravitino/pull/5391#issuecomment-2510452904 @shaofengshi once CI is done this is ready to review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

(gravitino) branch main updated: [#5602] feat(core): Add storage schema for model (part-1) (#5689)

2024-12-01 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 74ecaeb93 [#5602] feat(core): Add storage schema f

Re: [I] [Subtask]Design and implement the storage schema for model [gravitino]

2024-12-01 Thread via GitHub
jerryshao closed issue #5602: [Subtask]Design and implement the storage schema for model URL: https://github.com/apache/gravitino/issues/5602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] [#5602] feat(core): Add storage schema for model (part-1) [gravitino]

2024-12-01 Thread via GitHub
jerryshao merged PR #5689: URL: https://github.com/apache/gravitino/pull/5689 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

Re: [I] [Subtask]Design and implement the storage schema for model [gravitino]

2024-12-01 Thread via GitHub
jerryshao closed issue #5602: [Subtask]Design and implement the storage schema for model URL: https://github.com/apache/gravitino/issues/5602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[PR] [#5383] Add column commands to the Gravitino CLI [gravitino]

2024-12-01 Thread via GitHub
justinmclean opened a new pull request, #5716: URL: https://github.com/apache/gravitino/pull/5716 ### What changes were proposed in this pull request? Add column commands to the Gravitino CLI ### Why are the changes needed? Expand Gravitino CLI. Fix: #5383 #

Re: [PR] [minor] fix(dev): fix ValueError when parsing config file with multiple '=' in one line [gravitino]

2024-12-01 Thread via GitHub
FANNG1 commented on PR #5713: URL: https://github.com/apache/gravitino/pull/5713#issuecomment-2510436957 Hi, @orenccl is it possible the configuration value contains '=' ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

(gravitino) branch main updated: [#5383] Add property commands for table in the Gravitino CLI (#5706)

2024-12-01 Thread shaofengshi
This is an automated email from the ASF dual-hosted git repository. shaofengshi pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 2254c7a12 [#5383] Add property commands for

Re: [PR] [#5383] Add property commands for table in the Gravitino CLI [gravitino]

2024-12-01 Thread via GitHub
shaofengshi merged PR #5706: URL: https://github.com/apache/gravitino/pull/5706 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@grav

Re: [I] [Improvement] A test case is needed to test the 'list-all-tables ' hive catalog property. [gravitino]

2024-12-01 Thread via GitHub
chenyuan99 commented on issue #3783: URL: https://github.com/apache/gravitino/issues/3783#issuecomment-2510424094 Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

(gravitino) branch main updated: [#5383] Add table property commands to Gravitino CLI (#5390)

2024-12-01 Thread shaofengshi
This is an automated email from the ASF dual-hosted git repository. shaofengshi pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new b0e4686b5 [#5383] Add table property command

Re: [I] Add support for tables in the Gravitio CLI [gravitino]

2024-12-01 Thread via GitHub
shaofengshi closed issue #5383: Add support for tables in the Gravitio CLI URL: https://github.com/apache/gravitino/issues/5383 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [#5383] Add table property commands to Gravitino CLI [gravitino]

2024-12-01 Thread via GitHub
shaofengshi merged PR #5390: URL: https://github.com/apache/gravitino/pull/5390 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@grav

Re: [I] Add support for tables in the Gravitio CLI [gravitino]

2024-12-01 Thread via GitHub
shaofengshi closed issue #5383: Add support for tables in the Gravitio CLI URL: https://github.com/apache/gravitino/issues/5383 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [#5631] Add test cases for other supported catalogs in Trino Cascading [gravitino]

2024-12-01 Thread via GitHub
danhuawang commented on code in PR #5632: URL: https://github.com/apache/gravitino/pull/5632#discussion_r1865127498 ## trino-connector/integration-test/src/test/java/org/apache/gravitino/trino/connector/integration/test/TrinoQueryIT.java: ## @@ -131,6 +132,23 @@ public void runO

Re: [PR] [#3783] improvement(test): add test 'list-all-tables' for the Hive catalog [gravitino]

2024-12-01 Thread via GitHub
mchades merged PR #5710: URL: https://github.com/apache/gravitino/pull/5710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitin

Re: [I] [Improvement] A test case is needed to test the 'list-all-tables ' hive catalog property. [gravitino]

2024-12-01 Thread via GitHub
mchades closed issue #3783: [Improvement] A test case is needed to test the 'list-all-tables ' hive catalog property. URL: https://github.com/apache/gravitino/issues/3783 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

(gravitino) branch main updated: [#3783] improvement(test): add test 'list-all-tables' for the Hive catalog (#5710)

2024-12-01 Thread mchades
This is an automated email from the ASF dual-hosted git repository. mchades pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 3b08dd7a4 [#3783] improvement(test): add test 'l

Re: [PR] [#5603] Add metalake extended help command to Gravitino CLI [gravitino]

2024-12-01 Thread via GitHub
shaofengshi merged PR #5604: URL: https://github.com/apache/gravitino/pull/5604 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@grav

Re: [PR] [#5383] Add table property commands to Gravitino CLI [gravitino]

2024-12-01 Thread via GitHub
justinmclean commented on PR #5390: URL: https://github.com/apache/gravitino/pull/5390#issuecomment-2510395707 @shaofengshi ready again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] [#5383] Add property commands for table in the Gravitino CLI [gravitino]

2024-12-01 Thread via GitHub
justinmclean commented on code in PR #5706: URL: https://github.com/apache/gravitino/pull/5706#discussion_r1865083053 ## docs/cli.md: ## @@ -527,6 +547,30 @@ gcli tag update --tag tagA --rename newTag gcli tag update --tag tagA --comment "new comment" ``` +### Fileset comman

[PR] [#5383] Add support for table update commands [gravitino]

2024-12-01 Thread via GitHub
justinmclean opened a new pull request, #5715: URL: https://github.com/apache/gravitino/pull/5715 ### What changes were proposed in this pull request? Add support for table update commands ### Why are the changes needed? Expand CLI support. Fix: #5383 ### Do

Re: [PR] [#5383] Add property commands for table in the Gravitino CLI [gravitino]

2024-12-01 Thread via GitHub
justinmclean commented on code in PR #5706: URL: https://github.com/apache/gravitino/pull/5706#discussion_r1865082946 ## docs/cli.md: ## @@ -527,6 +547,30 @@ gcli tag update --tag tagA --rename newTag gcli tag update --tag tagA --comment "new comment" ``` +### Fileset comman

Re: [PR] [#5383] Add property commands for table in the Gravitino CLI [gravitino]

2024-12-01 Thread via GitHub
shaofengshi commented on code in PR #5706: URL: https://github.com/apache/gravitino/pull/5706#discussion_r1865081742 ## docs/cli.md: ## @@ -527,6 +547,30 @@ gcli tag update --tag tagA --rename newTag gcli tag update --tag tagA --comment "new comment" ``` +### Fileset command

Re: [PR] [#5619] feat(api): supports credential api for Gravitino [gravitino]

2024-12-01 Thread via GitHub
FANNG1 commented on PR #5690: URL: https://github.com/apache/gravitino/pull/5690#issuecomment-2510352693 @jerryshao could you help to review this, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [I] Add extended help for metalakes in Gravitino CLI [gravitino]

2024-12-01 Thread via GitHub
shaofengshi closed issue #5603: Add extended help for metalakes in Gravitino CLI URL: https://github.com/apache/gravitino/issues/5603 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

(gravitino) branch main updated: [#5603] Add metalake extended help command to Gravitino CLI (#5604)

2024-12-01 Thread shaofengshi
This is an automated email from the ASF dual-hosted git repository. shaofengshi pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 8672ad73a [#5603] Add metalake extended help

Re: [PR] [#5383] Add property commands for table in the Gravitino CLI [gravitino]

2024-12-01 Thread via GitHub
shaofengshi commented on code in PR #5706: URL: https://github.com/apache/gravitino/pull/5706#discussion_r1865081549 ## docs/cli.md: ## @@ -527,6 +547,30 @@ gcli tag update --tag tagA --rename newTag gcli tag update --tag tagA --comment "new comment" ``` +### Fileset command

Re: [PR] [#5294] Add topic property command to Gravitino CLI [gravitino]

2024-12-01 Thread via GitHub
shaofengshi merged PR #5352: URL: https://github.com/apache/gravitino/pull/5352 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@grav

(gravitino) branch main updated: [#5294] Add topic property command to Gravitino CLI (#5352)

2024-12-01 Thread shaofengshi
This is an automated email from the ASF dual-hosted git repository. shaofengshi pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 2e034b26d [#5294] Add topic property command

[PR] feat(ci): add CI check for playground [gravitino-playground]

2024-12-01 Thread via GitHub
unknowntpo opened a new pull request, #111: URL: https://github.com/apache/gravitino-playground/pull/111 Resolves #75 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [#5383] Add table property commands to Gravitino CLI [gravitino]

2024-12-01 Thread via GitHub
justinmclean commented on PR #5390: URL: https://github.com/apache/gravitino/pull/5390#issuecomment-2510274202 Note this is failing due to an unrelated change in catalogs/catalog-lakehouse-paimon -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] [#5279] improvement(cli): Display sort order information for Tables in the Gravitino CLI [gravitino]

2024-12-01 Thread via GitHub
justinmclean commented on PR #5709: URL: https://github.com/apache/gravitino/pull/5709#issuecomment-2510269469 Thanks for the PR, looks fine to me, but would be great if you could add a test for this new option. -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] [#5294] Add topic property command to Gravitino CLI [gravitino]

2024-12-01 Thread via GitHub
justinmclean commented on PR #5352: URL: https://github.com/apache/gravitino/pull/5352#issuecomment-2510263564 @shaofengshi all fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [#5294] Add topic property command to Gravitino CLI [gravitino]

2024-12-01 Thread via GitHub
justinmclean commented on code in PR #5352: URL: https://github.com/apache/gravitino/pull/5352#discussion_r1865023962 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/SetTopicProperty.java: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] [minor] improvement(docs): adjust table properties docs [gravitino]

2024-12-01 Thread via GitHub
mchades commented on code in PR #5699: URL: https://github.com/apache/gravitino/pull/5699#discussion_r1864868816 ## docs/apache-hive-catalog.md: ## @@ -140,25 +140,31 @@ Since 0.6.0-incubating, the data types other than listed above are mapped to Gra Table properties supply or