[PR] [#5519] fix(CI): fix build CI missing new changes [gravitino]

2024-11-29 Thread via GitHub
mchades opened a new pull request, #5712: URL: https://github.com/apache/gravitino/pull/5712 ### What changes were proposed in this pull request? - Use file extension matching to enhance matching rules ### Why are the changes needed? Fix: #5519 ### Does this PR i

Re: [PR] [minor] improvement(docs): adjust table properties docs [gravitino]

2024-11-29 Thread via GitHub
mchades commented on code in PR #5699: URL: https://github.com/apache/gravitino/pull/5699#discussion_r1864096099 ## docs/apache-hive-catalog.md: ## @@ -140,25 +140,25 @@ Since 0.6.0-incubating, the data types other than listed above are mapped to Gra Table properties supply or

Re: [PR] [minor] improvement(docs): adjust table properties docs [gravitino]

2024-11-29 Thread via GitHub
mchades commented on code in PR #5699: URL: https://github.com/apache/gravitino/pull/5699#discussion_r1864093600 ## docs/apache-hive-catalog.md: ## @@ -140,15 +140,7 @@ Since 0.6.0-incubating, the data types other than listed above are mapped to Gra Table properties supply or

Re: [PR] [#3783] test(hive-catalog) add test for the 'list-all-tables' hive catalog pr… [gravitino]

2024-11-29 Thread via GitHub
mchades commented on PR #5710: URL: https://github.com/apache/gravitino/pull/5710#issuecomment-2508838827 plz update the PR description to follow the template -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] [#3783] test(hive-catalog) add test for the 'list-all-tables' hive catalog pr… [gravitino]

2024-11-29 Thread via GitHub
mchades commented on code in PR #5710: URL: https://github.com/apache/gravitino/pull/5710#discussion_r1864092443 ## catalogs/catalog-hive/src/test/java/org/apache/gravitino/catalog/hive/integration/test/CatalogHiveIT.java: ## @@ -629,6 +630,9 @@ public void testListTables() {

Re: [PR] #4591 Improvement: add regex to check the style of JDBC URL [gravitino]

2024-11-29 Thread via GitHub
shaofengshi commented on code in PR #4600: URL: https://github.com/apache/gravitino/pull/4600#discussion_r1864045246 ## iceberg/iceberg-common/src/main/java/org/apache/gravitino/iceberg/common/IcebergConfig.java: ## @@ -64,7 +65,7 @@ public class IcebergConfig extends Config imp

Re: [I] [FEATURE] Add Search Capablity to Garvitino Docs [gravitino]

2024-11-29 Thread via GitHub
chenyuan99 commented on issue #5702: URL: https://github.com/apache/gravitino/issues/5702#issuecomment-250850 for https://datastrato.ai/docs/0.5.1/ it does have search capability, could we use the same solution? is it allowed/made exceptions by ASF? -- This is an automated message fro

[PR] Implements log4j audit writer [gravitino]

2024-11-29 Thread via GitHub
puchengy opened a new pull request, #5711: URL: https://github.com/apache/gravitino/pull/5711 ### What changes were proposed in this pull request? (Please outline the changes and how this PR fixes the issue.) ### Why are the changes needed? (Please clarify why the

[PR] [#3783] test(hive-catalog) add test for the 'list-all-tables' hive catalog pr… [gravitino]

2024-11-29 Thread via GitHub
chenyuan99 opened a new pull request, #5710: URL: https://github.com/apache/gravitino/pull/5710 …operty ### What changes were proposed in this pull request? (Please outline the changes and how this PR fixes the issue.) ### Why are the changes needed? Fix: #

Re: [I] [Improvement] A test case is needed to test the 'list-all-tables ' hive catalog property. [gravitino]

2024-11-29 Thread via GitHub
chenyuan99 commented on issue #3783: URL: https://github.com/apache/gravitino/issues/3783#issuecomment-2508042002 I dont think it is reolved, could you assign it to me? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [I] [Improvement] Remove `gravitino-web` jar from release package [gravitino]

2024-11-29 Thread via GitHub
TungYuChiang commented on issue #5683: URL: https://github.com/apache/gravitino/issues/5683#issuecomment-2507747719 @yuqi1129 I try `./gradlew compileDistribution -x test -x :docs:lintOpenAPI ` in my Mac and get results like following picture https://github.com/user-attachments/assets/3a7

[PR] [#5279] improvement(cli): Display sort order information for Tables in the Gravitino CLI [gravitino]

2024-11-29 Thread via GitHub
TungYuChiang opened a new pull request, #5709: URL: https://github.com/apache/gravitino/pull/5709 ### What changes were proposed in this pull request? Add --sortorder option to display sort order information on Tables. ### Why are the changes needed? Closes: #5278

Re: [PR] [#5704] improve(core): Support enum catalog provider name [gravitino]

2024-11-29 Thread via GitHub
jerryshao commented on code in PR #5705: URL: https://github.com/apache/gravitino/pull/5705#discussion_r1863266053 ## api/src/main/java/org/apache/gravitino/CatalogProvider.java: ## @@ -26,7 +26,36 @@ */ @Evolving public interface CatalogProvider { + enum CatalogName { +

Re: [I] [Bug report] UI: edit some table would encounter the error: TypeError: e.type.match is not a function [gravitino]

2024-11-29 Thread via GitHub
orenccl commented on issue #5707: URL: https://github.com/apache/gravitino/issues/5707#issuecomment-2507438908 Sure, I will handle this simple solution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [EPIC] Support web ui for creating table [gravitino]

2024-11-29 Thread via GitHub
orenccl commented on issue #5449: URL: https://github.com/apache/gravitino/issues/5449#issuecomment-2507437841 Added new subtask #5708 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] [Bug report] UI: edit some table would encounter the error: TypeError: e.type.match is not a function [gravitino]

2024-11-29 Thread via GitHub
LauraXia123 commented on issue #5707: URL: https://github.com/apache/gravitino/issues/5707#issuecomment-2507436626 @orenccl hi, let's simply show only the type name so that the page doesn't crash. Support nested table column types is an another issue. -- This is an automated message f

Re: [I] [Bug report] UI: edit some table would encounter the error: TypeError: e.type.match is not a function [gravitino]

2024-11-29 Thread via GitHub
orenccl commented on issue #5707: URL: https://github.com/apache/gravitino/issues/5707#issuecomment-2507403005 And, do I need to open another issue to track the implementation of this feature? -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [I] [Bug report] UI: edit some table would encounter the error: TypeError: e.type.match is not a function [gravitino]

2024-11-29 Thread via GitHub
orenccl commented on issue #5707: URL: https://github.com/apache/gravitino/issues/5707#issuecomment-2507400542 @LauraXia123 Hi, I think the issue is that the system does not support nested table column types yet, so the edit dialog cannot resolve the unrecognized type. Do w

Re: [PR] [#5383] Add table property commands to Gravitino CLI [gravitino]

2024-11-29 Thread via GitHub
shaofengshi commented on code in PR #5390: URL: https://github.com/apache/gravitino/pull/5390#discussion_r1863208207 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListTableProperties.java: ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] [#5383] Add table property commands to Gravitino CLI [gravitino]

2024-11-29 Thread via GitHub
shaofengshi commented on code in PR #5390: URL: https://github.com/apache/gravitino/pull/5390#discussion_r1863208884 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListTableProperties.java: ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] [#5294] Add topic property command to Gravitino CLI [gravitino]

2024-11-29 Thread via GitHub
shaofengshi commented on code in PR #5352: URL: https://github.com/apache/gravitino/pull/5352#discussion_r1863206534 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListTopicProperties.java: ## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] [#5294] Add topic property command to Gravitino CLI [gravitino]

2024-11-29 Thread via GitHub
shaofengshi commented on code in PR #5352: URL: https://github.com/apache/gravitino/pull/5352#discussion_r1863203555 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/RemoveTopicProperty.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] [#5294] Add topic property command to Gravitino CLI [gravitino]

2024-11-29 Thread via GitHub
shaofengshi commented on code in PR #5352: URL: https://github.com/apache/gravitino/pull/5352#discussion_r1863204271 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/SetTopicProperty.java: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [I] [Bug report] UI: edit some table would encounter the error: TypeError: e.type.match is not a function [gravitino]

2024-11-29 Thread via GitHub
LauraXia123 commented on issue #5707: URL: https://github.com/apache/gravitino/issues/5707#issuecomment-2507387485 @orenccl Hi, can you help to have a check please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[I] [Bug report] UI: edit some table would encounter the error: TypeError: e.type.match is not a function [gravitino]

2024-11-29 Thread via GitHub
danhuawang opened a new issue, #5707: URL: https://github.com/apache/gravitino/issues/5707 ### Version main branch ### Describe what's wrong https://github.com/user-attachments/assets/dfb67223-5eca-432a-a946-7f17edbe03a6";> data type as following: https://githu

Re: [PR] [#5379] Add property commands for filesets in Gravitio CLI [gravitino]

2024-11-29 Thread via GitHub
shaofengshi merged PR #5382: URL: https://github.com/apache/gravitino/pull/5382 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@grav

(gravitino) branch main updated: [#5379] Add property commands for filesets in Gravitio CLI (#5382)

2024-11-29 Thread shaofengshi
This is an automated email from the ASF dual-hosted git repository. shaofengshi pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 9cd7674e7 [#5379] Add property commands for

Re: [I] [Improvement] Remove all tags from an entity in the Gravitino CLI. [gravitino]

2024-11-29 Thread via GitHub
suvaidkhan commented on issue #5529: URL: https://github.com/apache/gravitino/issues/5529#issuecomment-2507295208 @justinmclean hey sorry couldn't get the time to look into this. I'll start working on this from this weekend. -- This is an automated message from the Apache Git Servi