sunxiaojian commented on PR #5641:
URL: https://github.com/apache/gravitino/pull/5641#issuecomment-2495839227
> Thanks again for your work on this and adding the tests. I've added some
feedback, and you seem to have missed some of the previous comments.
@justinmclean I checked and the
justinmclean commented on PR #5641:
URL: https://github.com/apache/gravitino/pull/5641#issuecomment-2495771345
Thanks again for your work on this and adding the tests - I've added some
feedback, and you seem to have missed some of the previous comments.
--
This is an automated message fr
FANNG1 commented on issue #1686:
URL: https://github.com/apache/gravitino/issues/1686#issuecomment-2495725245
For Hive catalog, you could only drop columns with compatibility types for
the limitation of the Hive metastore, like drop column a from table with
schema(a int, b int). For non-Hiv
TungYuChiang opened a new pull request, #5652:
URL: https://github.com/apache/gravitino/pull/5652
### What changes were proposed in this pull request?
add fileset pre event to Gravitino event
### Why are the changes needed?
Fix: #5548
### Does this PR introduce _
FANNG1 commented on PR #5590:
URL: https://github.com/apache/gravitino/pull/5590#issuecomment-2495496911
@LiuQhahah ,LGTM except minor comments, could you fix it ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
FANNG1 commented on code in PR #5590:
URL: https://github.com/apache/gravitino/pull/5590#discussion_r1855203020
##
core/src/test/java/org/apache/gravitino/listener/api/event/TestPartitionEvent.java:
##
@@ -117,6 +117,14 @@ void testAddPartitionEvent() {
checkPartitionInfo(p
FANNG1 commented on code in PR #5651:
URL: https://github.com/apache/gravitino/pull/5651#discussion_r1855201198
##
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/dispatcher/IcebergNamespaceEventDispatcher.java:
##
@@ -0,0 +1,238 @@
+/*
+ * Licens
FANNG1 commented on code in PR #5590:
URL: https://github.com/apache/gravitino/pull/5590#discussion_r1855202743
##
core/src/test/java/org/apache/gravitino/listener/api/event/TestPartitionEvent.java:
##
@@ -117,6 +117,14 @@ void testAddPartitionEvent() {
checkPartitionInfo(p
FANNG1 commented on PR #5627:
URL: https://github.com/apache/gravitino/pull/5627#issuecomment-2495495742
> @FANNG1 can you please help to review again? If there's no blocking issue,
I think we can improve the building command in the following PRs, what do you
think?
Seems there're so
FANNG1 commented on code in PR #5651:
URL: https://github.com/apache/gravitino/pull/5651#discussion_r1855201198
##
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/dispatcher/IcebergNamespaceEventDispatcher.java:
##
@@ -0,0 +1,238 @@
+/*
+ * Licens
FANNG1 commented on PR #5651:
URL: https://github.com/apache/gravitino/pull/5651#issuecomment-2495492881
> 1. Should I use `OperationType.*_SCHEMA`, or should I create a new type
called `OperationType.*_NAMESPACE`?
I prefer to reuse `OperationType.*_SCHEMA`, because they are the s
11 matches
Mail list logo
