[PR] [#5626] feat (gvfs-fuse): Set up a submodule project for the Gvfs-fuse [gravitino]

2024-11-19 Thread via GitHub
diqiu50 opened a new pull request, #5627: URL: https://github.com/apache/gravitino/pull/5627 ### What changes were proposed in this pull request? Set up a submodule project for the Gvfs-fuse, layout the rust module environment for gvfs-fuse ### Why are the changes needed?

Re: [PR] [#5603] Add metalake extended help command to Gravitino CLI [gravitino]

2024-11-19 Thread via GitHub
justinmclean commented on code in PR #5604: URL: https://github.com/apache/gravitino/pull/5604#discussion_r1849780334 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java: ## @@ -514,6 +521,23 @@ private void handleColumnCommand() { } } + pr

(gravitino-playground) branch main updated: Add the demo about access control (#104)

2024-11-19 Thread liuxun
This is an automated email from the ASF dual-hosted git repository. liuxun pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino-playground.git The following commit(s) were added to refs/heads/main by this push: new b16d683 Add the demo about access con

Re: [PR] [#5294] Add basic topic commands to Gravitino CLI [gravitino]

2024-11-19 Thread via GitHub
justinmclean commented on code in PR #5331: URL: https://github.com/apache/gravitino/pull/5331#discussion_r1849690364 ## docs/cli.md: ## @@ -506,6 +506,38 @@ gcli tag update --tag tagA --rename newTag gcli tag update --tag tagA --comment "new comment" ``` +### Topic commands

Re: [PR] Add the demo about access control [gravitino-playground]

2024-11-19 Thread via GitHub
xunliu merged PR #104: URL: https://github.com/apache/gravitino-playground/pull/104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@

Re: [PR] [#5551] feat(core): add topic pre-event to Gravitino event. [gravitino]

2024-11-19 Thread via GitHub
xunliu commented on PR #5614: URL: https://github.com/apache/gravitino/pull/5614#issuecomment-2487725243 hi @LindaSummer Thank you for your contribution! I was trying to contact you, This is my email liu...@apache.org, Please send an email to me, Thank you :-) -- This is an automated m

Re: [PR] [#5603] Add metalake extended help command to Gravitino CLI [gravitino]

2024-11-19 Thread via GitHub
justinmclean commented on code in PR #5604: URL: https://github.com/apache/gravitino/pull/5604#discussion_r1849680996 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java: ## @@ -175,7 +180,9 @@ public static void displayHelp(Options options) { /*

Re: [PR] [#5556] feat(iceberg) support audit framework for Iceberg REST server [gravitino]

2024-11-19 Thread via GitHub
FANNG1 commented on PR #5580: URL: https://github.com/apache/gravitino/pull/5580#issuecomment-2487711169 @puchengy @jerryshao , it's ready to review now, please help to review, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [#5603] Add metalake extended help command to Gravitino CLI [gravitino]

2024-11-19 Thread via GitHub
justinmclean commented on code in PR #5604: URL: https://github.com/apache/gravitino/pull/5604#discussion_r1849679837 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java: ## @@ -514,6 +521,23 @@ private void handleColumnCommand() { } } + pr

Re: [PR] [#5603] Add metalake extended help command to Gravitino CLI [gravitino]

2024-11-19 Thread via GitHub
shaofengshi commented on code in PR #5604: URL: https://github.com/apache/gravitino/pull/5604#discussion_r1849678990 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java: ## @@ -175,7 +180,9 @@ public static void displayHelp(Options options) { /**

Re: [PR] [#5294] Add basic topic commands to Gravitino CLI [gravitino]

2024-11-19 Thread via GitHub
shaofengshi commented on code in PR #5331: URL: https://github.com/apache/gravitino/pull/5331#discussion_r1849683772 ## docs/cli.md: ## @@ -506,6 +506,38 @@ gcli tag update --tag tagA --rename newTag gcli tag update --tag tagA --comment "new comment" ``` +### Topic commands

Re: [PR] [#5603] Add metalake extended help command to Gravitino CLI [gravitino]

2024-11-19 Thread via GitHub
justinmclean commented on code in PR #5604: URL: https://github.com/apache/gravitino/pull/5604#discussion_r1849680996 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java: ## @@ -175,7 +180,9 @@ public static void displayHelp(Options options) { /*

Re: [PR] [#5603] Add metalake extended help command to Gravitino CLI [gravitino]

2024-11-19 Thread via GitHub
shaofengshi commented on code in PR #5604: URL: https://github.com/apache/gravitino/pull/5604#discussion_r1849673071 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java: ## @@ -514,6 +521,23 @@ private void handleColumnCommand() { } } + pri

(gravitino) branch main updated: [Minor] improvement to Partition Gravitino CLI code (#5617)

2024-11-19 Thread shaofengshi
This is an automated email from the ASF dual-hosted git repository. shaofengshi pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 092f58a92 [Minor] improvement to Partition G

Re: [PR] [Minor] improvement to Partition Gravitino CLI code [gravitino]

2024-11-19 Thread via GitHub
shaofengshi merged PR #5617: URL: https://github.com/apache/gravitino/pull/5617 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@grav

Re: [PR] [#5600] feat(API): Add Java API definition for ML model in Gravitino [gravitino]

2024-11-19 Thread via GitHub
jerryshao commented on PR #5612: URL: https://github.com/apache/gravitino/pull/5612#issuecomment-2487601414 @xloya @coolderli @zhoukangcn can you please also review this API design, to see if it is OK for you. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [#5556] feat(iceberg) support audit framework for Iceberg REST server [gravitino]

2024-11-19 Thread via GitHub
FANNG1 commented on PR #5580: URL: https://github.com/apache/gravitino/pull/5580#issuecomment-2487585286 > Is it ready for review or still draft? still draft, I will polish and do some test today -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [#5281] Add owner support to Gravitino CLI [gravitino]

2024-11-19 Thread via GitHub
shaofengshi commented on code in PR #5293: URL: https://github.com/apache/gravitino/pull/5293#discussion_r1849647920 ## docs/cli.md: ## @@ -506,6 +507,26 @@ gcli tag update --tag tagA --rename newTag gcli tag update --tag tagA --comment "new comment" ``` +### Owners commands

Re: [PR] [#102] improvement: improve startup script [gravitino-playground]

2024-11-19 Thread via GitHub
orenccl commented on code in PR #103: URL: https://github.com/apache/gravitino-playground/pull/103#discussion_r1849630574 ## playground.sh: ## @@ -18,186 +18,398 @@ # under the License. # -set -x - playground_dir="$(dirname "${BASH_SOURCE-$0}")" playground_dir="$( - cd "

Re: [PR] [#5556] feat(iceberg) support audit framework for Iceberg REST server [gravitino]

2024-11-19 Thread via GitHub
jerryshao commented on PR #5580: URL: https://github.com/apache/gravitino/pull/5580#issuecomment-2487581959 Is it ready for review or still draft? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [#5611] Improvement(iceberg): support schema exists interface for Iceberg REST server [gravitino]

2024-11-19 Thread via GitHub
jerryshao merged PR #5616: URL: https://github.com/apache/gravitino/pull/5616 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

(gravitino) branch main updated: [#5611] Improvement(iceberg): support schema exists interface for Iceberg REST server (#5616)

2024-11-19 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new d8a6ff815 [#5611] Improvement(iceberg): support sc

Re: [I] [Improvement] support schema exists interface for Iceberg REST server [gravitino]

2024-11-19 Thread via GitHub
jerryshao closed issue #5611: [Improvement] support schema exists interface for Iceberg REST server URL: https://github.com/apache/gravitino/issues/5611 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [I] [Improvement] support schema exists interface for Iceberg REST server [gravitino]

2024-11-19 Thread via GitHub
jerryshao closed issue #5611: [Improvement] support schema exists interface for Iceberg REST server URL: https://github.com/apache/gravitino/issues/5611 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [#4362] feat(web): Add GitHub stars and forks number for WebUI [gravitino]

2024-11-19 Thread via GitHub
SZL741023 commented on code in PR #5567: URL: https://github.com/apache/gravitino/pull/5567#discussion_r1849443633 ## web/web/src/app/rootLayout/AppBar.js: ## @@ -64,6 +66,7 @@ const AppBar = () => { const metalakeItems = store.metalakes.map(i => i.name) setMetalakes(m

Re: [PR] [#5281] Add owner support to Gravitino CLI [gravitino]

2024-11-19 Thread via GitHub
justinmclean commented on code in PR #5293: URL: https://github.com/apache/gravitino/pull/5293#discussion_r1849341313 ## docs/cli.md: ## @@ -506,6 +507,26 @@ gcli tag update --tag tagA --rename newTag gcli tag update --tag tagA --comment "new comment" ``` +### Owners command

[PR] [#5384] Added OAuth support to Gravitino CLI [gravitino]

2024-11-19 Thread via GitHub
justinmclean opened a new pull request, #5618: URL: https://github.com/apache/gravitino/pull/5618 ### What changes were proposed in this pull request? Added OAuth support to Gravitino CLI, Note this is supported by the configuration files. ### Why are the changes needed?

Re: [PR] [#5506] feat(CLI): Table formatted output [gravitino]

2024-11-19 Thread via GitHub
justinmclean commented on code in PR #5606: URL: https://github.com/apache/gravitino/pull/5606#discussion_r1849554303 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java: ## @@ -551,4 +551,8 @@ public String getUrl() { // Return the default local

Re: [PR] [#5281] Add owner support to Gravitino CLI [gravitino]

2024-11-19 Thread via GitHub
justinmclean commented on code in PR #5293: URL: https://github.com/apache/gravitino/pull/5293#discussion_r1849547143 ## docs/cli.md: ## @@ -506,6 +507,26 @@ gcli tag update --tag tagA --rename newTag gcli tag update --tag tagA --comment "new comment" ``` +### Owners command

Re: [PR] [#5506] feat(CLI): Table formatted output [gravitino]

2024-11-19 Thread via GitHub
xunliu commented on code in PR #5606: URL: https://github.com/apache/gravitino/pull/5606#discussion_r1849480387 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java: ## @@ -551,4 +551,8 @@ public String getUrl() { // Return the default localhost U

Re: [PR] Add the demo about access control [gravitino-playground]

2024-11-19 Thread via GitHub
jerqi commented on code in PR #104: URL: https://github.com/apache/gravitino-playground/pull/104#discussion_r1849491063 ## init/jupyter/init.sh: ## @@ -16,16 +16,11 @@ # specific language governing permissions and limitations # under the License. # -cp -r /tmp/gravitino/*.ip

Re: [PR] [#5281] Add owner support to Gravitino CLI [gravitino]

2024-11-19 Thread via GitHub
jerryshao commented on PR #5293: URL: https://github.com/apache/gravitino/pull/5293#issuecomment-2487367036 BTW, the lack of UTs for the CLI module makes the code vulnerable, we should add more UTs for the CLI module. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Add the demo about access control [gravitino-playground]

2024-11-19 Thread via GitHub
xunliu commented on code in PR #104: URL: https://github.com/apache/gravitino-playground/pull/104#discussion_r1849475843 ## init/jupyter/init.sh: ## @@ -16,16 +16,11 @@ # specific language governing permissions and limitations # under the License. # -cp -r /tmp/gravitino/*.i

Re: [PR] [#5281] Add owner support to Gravitino CLI [gravitino]

2024-11-19 Thread via GitHub
jerryshao commented on code in PR #5293: URL: https://github.com/apache/gravitino/pull/5293#discussion_r1849474586 ## docs/cli.md: ## @@ -506,6 +507,26 @@ gcli tag update --tag tagA --rename newTag gcli tag update --tag tagA --comment "new comment" ``` +### Owners commands +

Re: [PR] [#102] improvement: improve startup script [gravitino-playground]

2024-11-19 Thread via GitHub
danhuawang commented on code in PR #103: URL: https://github.com/apache/gravitino-playground/pull/103#discussion_r1849469517 ## playground.sh: ## @@ -18,186 +18,398 @@ # under the License. # -set -x - playground_dir="$(dirname "${BASH_SOURCE-$0}")" playground_dir="$( - c

Re: [PR] [#102] improvement: improve startup script [gravitino-playground]

2024-11-19 Thread via GitHub
danhuawang commented on code in PR #103: URL: https://github.com/apache/gravitino-playground/pull/103#discussion_r1849469112 ## playground.sh: ## @@ -18,186 +18,398 @@ # under the License. # -set -x - playground_dir="$(dirname "${BASH_SOURCE-$0}")" playground_dir="$( - c

Re: [PR] [#4362] feat(web): Add GitHub stars and forks number for WebUI [gravitino]

2024-11-19 Thread via GitHub
LauraXia123 commented on code in PR #5567: URL: https://github.com/apache/gravitino/pull/5567#discussion_r1846046848 ## web/web/src/app/rootLayout/GitHubInfo.js: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor licens

Re: [PR] [#4362] feat(web): Add GitHub stars and forks number for WebUI [gravitino]

2024-11-19 Thread via GitHub
SZL741023 commented on code in PR #5567: URL: https://github.com/apache/gravitino/pull/5567#discussion_r1849443633 ## web/web/src/app/rootLayout/AppBar.js: ## @@ -64,6 +66,7 @@ const AppBar = () => { const metalakeItems = store.metalakes.map(i => i.name) setMetalakes(m

Re: [PR] [#4362] feat(web): Add GitHub stars and forks number for WebUI [gravitino]

2024-11-19 Thread via GitHub
SZL741023 commented on code in PR #5567: URL: https://github.com/apache/gravitino/pull/5567#discussion_r1849443943 ## web/web/src/lib/api/github/index.js: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agree

Re: [PR] [#5281] Add owner support to Gravitino CLI [gravitino]

2024-11-19 Thread via GitHub
shaofengshi commented on code in PR #5293: URL: https://github.com/apache/gravitino/pull/5293#discussion_r1849437716 ## docs/cli.md: ## @@ -506,6 +507,26 @@ gcli tag update --tag tagA --rename newTag gcli tag update --tag tagA --comment "new comment" ``` +### Owners commands

Re: [PR] [#5551] feat(core): add topic pre-event to Gravitino event. [gravitino]

2024-11-19 Thread via GitHub
LindaSummer commented on PR #5614: URL: https://github.com/apache/gravitino/pull/5614#issuecomment-2487245098 Hi @FANNG1 , @jerryshao , Of course, I will add license headers today.😄 Best Regards, Edward -- This is an automated message from the Apache Git Service. To respon

Re: [PR] [#5551] feat(core): add topic pre-event to Gravitino event. [gravitino]

2024-11-19 Thread via GitHub
jerryshao commented on PR #5614: URL: https://github.com/apache/gravitino/pull/5614#issuecomment-2487228697 Can you please fix the license header issue for your newly added files? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [I] [Subtask] Different data table column types are supported depending on the provider [gravitino]

2024-11-19 Thread via GitHub
orenccl commented on issue #5454: URL: https://github.com/apache/gravitino/issues/5454#issuecomment-2487221063 Sorry, I didn't see that part. 🙇‍♂️ > These complex types involve nesting, so if you have the time to implement them, you can start a new subtask and prioritize it last

Re: [PR] [#5551] feat(core): add topic pre-event to Gravitino event. [gravitino]

2024-11-19 Thread via GitHub
FANNG1 commented on PR #5614: URL: https://github.com/apache/gravitino/pull/5614#issuecomment-2487214942 @LindaSummer , could you add LICENSE header to xxEvent to fix rat check error? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [#5506] feat(CLI): Table formatted output [gravitino]

2024-11-19 Thread via GitHub
justinmclean commented on code in PR #5606: URL: https://github.com/apache/gravitino/pull/5606#discussion_r1849409986 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java: ## @@ -551,4 +551,8 @@ public String getUrl() { // Return the default local

Re: [PR] [#5506] feat(CLI): Table formatted output [gravitino]

2024-11-19 Thread via GitHub
xunliu commented on code in PR #5606: URL: https://github.com/apache/gravitino/pull/5606#discussion_r1849396805 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java: ## @@ -551,4 +551,8 @@ public String getUrl() { // Return the default localhost U

Re: [PR] [Improvement] Remove gravitino-docs-*.jar from Gravitino release files [gravitino]

2024-11-19 Thread via GitHub
jerryshao commented on code in PR #5615: URL: https://github.com/apache/gravitino/pull/5615#discussion_r1849395412 ## build.gradle.kts: ## @@ -803,6 +803,7 @@ tasks { from("${it.name}/build/libs") into("distribution/package/libs") include("*.jar") +

Re: [I] [Subtask] add schema event for Iceberg REST server [gravitino]

2024-11-19 Thread via GitHub
FANNG1 commented on issue #5437: URL: https://github.com/apache/gravitino/issues/5437#issuecomment-2487158837 thanks @orenccl -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] Add the demo about access control [gravitino-playground]

2024-11-19 Thread via GitHub
jerqi commented on code in PR #104: URL: https://github.com/apache/gravitino-playground/pull/104#discussion_r1848218597 ## init/hive/core-site.xml: ## @@ -0,0 +1,51 @@ + + +fs.defaultFS +hdfs://__REPLACE__HOST_NAME:9000 + + + +name +Development Cluster +

Re: [PR] [#5281] Add owner support to Gravitino CLI [gravitino]

2024-11-19 Thread via GitHub
justinmclean commented on code in PR #5293: URL: https://github.com/apache/gravitino/pull/5293#discussion_r1849341313 ## docs/cli.md: ## @@ -506,6 +507,26 @@ gcli tag update --tag tagA --rename newTag gcli tag update --tag tagA --comment "new comment" ``` +### Owners command

Re: [PR] [#5281] Add owner support to Gravitino CLI [gravitino]

2024-11-19 Thread via GitHub
justinmclean commented on code in PR #5293: URL: https://github.com/apache/gravitino/pull/5293#discussion_r1849341313 ## docs/cli.md: ## @@ -506,6 +507,26 @@ gcli tag update --tag tagA --rename newTag gcli tag update --tag tagA --comment "new comment" ``` +### Owners command

Re: [PR] [#5281] Add owner support to Gravitino CLI [gravitino]

2024-11-19 Thread via GitHub
justinmclean commented on code in PR #5293: URL: https://github.com/apache/gravitino/pull/5293#discussion_r1849330748 ## docs/cli.md: ## @@ -506,6 +507,26 @@ gcli tag update --tag tagA --rename newTag gcli tag update --tag tagA --comment "new comment" ``` +### Owners command

Re: [PR] [#5278]improvement(cli):Display partition information for Tables in t… [gravitino]

2024-11-19 Thread via GitHub
justinmclean merged PR #5605: URL: https://github.com/apache/gravitino/pull/5605 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gra

[PR] [Minor] improvement to Partition Gravitino CLI code [gravitino]

2024-11-19 Thread via GitHub
justinmclean opened a new pull request, #5617: URL: https://github.com/apache/gravitino/pull/5617 ### What changes were proposed in this pull request? Minor improvements to Partition Gravitino CLI code. ### Why are the changes needed? Remove duplicate short command code a

Re: [I] [Improvement] Display partition information for Tables in the Gravitino CLI [gravitino]

2024-11-19 Thread via GitHub
justinmclean closed issue #5278: [Improvement] Display partition information for Tables in the Gravitino CLI URL: https://github.com/apache/gravitino/issues/5278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [I] [Improvement] Display partition information for Tables in the Gravitino CLI [gravitino]

2024-11-19 Thread via GitHub
justinmclean closed issue #5278: [Improvement] Display partition information for Tables in the Gravitino CLI URL: https://github.com/apache/gravitino/issues/5278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

(gravitino) branch main updated: [#5278]improvement(cli):Display partition information for Tables in t… (#5605)

2024-11-19 Thread jmclean
This is an automated email from the ASF dual-hosted git repository. jmclean pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 306c0e87b [#5278]improvement(cli):Display partit

Re: [PR] [#5506] feat(CLI): Table formatted output [gravitino]

2024-11-19 Thread via GitHub
justinmclean commented on code in PR #5606: URL: https://github.com/apache/gravitino/pull/5606#discussion_r1849060154 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java: ## @@ -551,4 +551,8 @@ public String getUrl() { // Return the default local

Re: [PR] [#5506] feat(CLI): Table formatted output [gravitino]

2024-11-19 Thread via GitHub
justinmclean commented on code in PR #5606: URL: https://github.com/apache/gravitino/pull/5606#discussion_r1849058732 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java: ## @@ -93,7 +93,7 @@ public class GravitinoCommandLine { private final Com

[PR] [#5611] Improvement(iceberg): support schema exists interface for Iceberg REST server [gravitino]

2024-11-19 Thread via GitHub
orenccl opened a new pull request, #5616: URL: https://github.com/apache/gravitino/pull/5616 ### What changes were proposed in this pull request? schema exists interface for Iceberg REST server ### Why are the changes needed? Close: #5611 ### Does this PR introduce

[PR] [Improvement] Remove gravitino-docs-*.jar from Gravitino release files [gravitino]

2024-11-19 Thread via GitHub
hdygxsj opened a new pull request, #5615: URL: https://github.com/apache/gravitino/pull/5615 ### What changes were proposed in this pull request? Remove gravitino-docs-*.jar from Gravitino release files ### Why are the changes needed? close #5490 ### Does this

Re: [I] [Improvement] Remove `gravitino-docs-0.7.0-incubating.jar` from Gravitino release files as it's a useless and empty files. [gravitino]

2024-11-19 Thread via GitHub
hdygxsj commented on issue #5490: URL: https://github.com/apache/gravitino/issues/5490#issuecomment-2485975026 Please assgn this to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] [#102] improvement: improve startup script [gravitino-playground]

2024-11-19 Thread via GitHub
danhuawang commented on code in PR #103: URL: https://github.com/apache/gravitino-playground/pull/103#discussion_r1848261037 ## playground.sh: ## @@ -18,186 +18,398 @@ # under the License. # -set -x - playground_dir="$(dirname "${BASH_SOURCE-$0}")" playground_dir="$( - c

Re: [PR] [#5506] feat(CLI): Table formatted output [gravitino]

2024-11-19 Thread via GitHub
waukin commented on PR #5606: URL: https://github.com/apache/gravitino/pull/5606#issuecomment-2485811403 Hi @xunliu, thank you for the update! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [#5506] feat(CLI): Table formatted output [gravitino]

2024-11-19 Thread via GitHub
waukin commented on code in PR #5606: URL: https://github.com/apache/gravitino/pull/5606#discussion_r1848424335 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/MetalakeDetails.java: ## @@ -54,6 +58,10 @@ public void handle() { return; } -System.o

Re: [I] [Subtask] Different data table column types are supported depending on the provider [gravitino]

2024-11-19 Thread via GitHub
orenccl commented on issue #5454: URL: https://github.com/apache/gravitino/issues/5454#issuecomment-2485785866 So, aside from Iceberg, do others (MySQL, PostgreSQL, etc...) use the Gravino type? And previously, the two issues didn't support Struct, Map, or List. Do I need to handle t

[I] [Improvement]: Mark helm chart as experimental feature and revert any docker compose unrelated changes [gravitino-playground]

2024-11-19 Thread via GitHub
unknowntpo opened a new issue, #108: URL: https://github.com/apache/gravitino-playground/issues/108 We need to mark helm chart as experimental feature, and revert any docker compose unrelated changes. Such as env var like `GRAVITINO_HOST_IP` in jupyter notebook. c.c. @xunliu --

Re: [PR] [#102] improvement: improve startup script [gravitino-playground]

2024-11-19 Thread via GitHub
danhuawang commented on code in PR #103: URL: https://github.com/apache/gravitino-playground/pull/103#discussion_r1848248908 ## README.md: ## @@ -63,100 +62,87 @@ git clone g...@github.com:apache/gravitino-playground.git cd gravitino-playground ``` - Docker +### Command

Re: [PR] Add the demo about access control [gravitino-playground]

2024-11-19 Thread via GitHub
xunliu commented on code in PR #104: URL: https://github.com/apache/gravitino-playground/pull/104#discussion_r1848341328 ## init/ranger/init.sh: ## @@ -0,0 +1,32 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

Re: [PR] [#102] improvement: improve startup script [gravitino-playground]

2024-11-19 Thread via GitHub
orenccl commented on code in PR #103: URL: https://github.com/apache/gravitino-playground/pull/103#discussion_r1848343376 ## playground.sh: ## @@ -18,186 +18,398 @@ # under the License. # -set -x - playground_dir="$(dirname "${BASH_SOURCE-$0}")" playground_dir="$( - cd "

Re: [PR] [#102] improvement: improve startup script [gravitino-playground]

2024-11-19 Thread via GitHub
danhuawang commented on code in PR #103: URL: https://github.com/apache/gravitino-playground/pull/103#discussion_r1848248908 ## README.md: ## @@ -63,100 +62,87 @@ git clone g...@github.com:apache/gravitino-playground.git cd gravitino-playground ``` - Docker +### Command

Re: [PR] [#5600] feat(API): Add Java API definition for ML model in Gravitino [gravitino]

2024-11-19 Thread via GitHub
jerryshao commented on code in PR #5612: URL: https://github.com/apache/gravitino/pull/5612#discussion_r1848253207 ## api/src/main/java/org/apache/gravitino/model/ModelVersion.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

Re: [PR] [#5600] feat(API): Add Java API definition for ML model in Gravitino [gravitino]

2024-11-19 Thread via GitHub
jerryshao commented on code in PR #5612: URL: https://github.com/apache/gravitino/pull/5612#discussion_r1848170364 ## api/src/main/java/org/apache/gravitino/model/Model.java: ## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more cont

Re: [PR] [#5281] Add owner support to Gravitino CLI [gravitino]

2024-11-19 Thread via GitHub
jerryshao commented on code in PR #5293: URL: https://github.com/apache/gravitino/pull/5293#discussion_r1848144501 ## docs/cli.md: ## @@ -506,6 +507,26 @@ gcli tag update --tag tagA --rename newTag gcli tag update --tag tagA --comment "new comment" ``` +### Owners commands +

Re: [PR] [#5281] Add owner support to Gravitino CLI [gravitino]

2024-11-19 Thread via GitHub
shaofengshi commented on code in PR #5293: URL: https://github.com/apache/gravitino/pull/5293#discussion_r1848004206 ## docs/cli.md: ## @@ -506,6 +507,26 @@ gcli tag update --tag tagA --rename newTag gcli tag update --tag tagA --comment "new comment" ``` +### Owners commands

Re: [PR] [#5281] Add owner support to Gravitino CLI [gravitino]

2024-11-19 Thread via GitHub
shaofengshi commented on code in PR #5293: URL: https://github.com/apache/gravitino/pull/5293#discussion_r1848004206 ## docs/cli.md: ## @@ -506,6 +507,26 @@ gcli tag update --tag tagA --rename newTag gcli tag update --tag tagA --comment "new comment" ``` +### Owners commands

Re: [PR] Add the demo about access control [gravitino-playground]

2024-11-19 Thread via GitHub
jerqi commented on code in PR #104: URL: https://github.com/apache/gravitino-playground/pull/104#discussion_r1847971249 ## init/ranger/init.sh: ## @@ -0,0 +1,32 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See t

Re: [PR] Add the demo about access control [gravitino-playground]

2024-11-19 Thread via GitHub
jerqi commented on code in PR #104: URL: https://github.com/apache/gravitino-playground/pull/104#discussion_r1847970325 ## README.md: ## @@ -378,6 +378,22 @@ os.environ["OPENAI_API_KEY"] = "" os.environ["OPENAI_API_BASE"] = "" ``` +### Using Gravitino with Ranger authorizat

Re: [PR] Add the demo about access control [gravitino-playground]

2024-11-19 Thread via GitHub
jerqi commented on code in PR #104: URL: https://github.com/apache/gravitino-playground/pull/104#discussion_r1847970833 ## README.md: ## @@ -378,6 +378,22 @@ os.environ["OPENAI_API_KEY"] = "" os.environ["OPENAI_API_BASE"] = "" ``` +### Using Gravitino with Ranger authorizat

Re: [PR] Add the demo about access control [gravitino-playground]

2024-11-19 Thread via GitHub
jerryshao commented on code in PR #104: URL: https://github.com/apache/gravitino-playground/pull/104#discussion_r1847938771 ## init/ranger/init.sh: ## @@ -0,0 +1,32 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. S

[PR] [#5213] fix(test): Increase the timeout to avoid flaky test [gravitino]

2024-11-19 Thread via GitHub
jerryshao opened a new pull request, #5613: URL: https://github.com/apache/gravitino/pull/5613 ### What changes were proposed in this pull request? Increase the timeout to avoid flaky issue. ### Why are the changes needed? Previously we increased the retry times, but not

Re: [I] [Subtask] add schema event for Iceberg REST server [gravitino]

2024-11-19 Thread via GitHub
orenccl commented on issue #5437: URL: https://github.com/apache/gravitino/issues/5437#issuecomment-2485013889 I’ll work on this within a few days. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] [Improvement] Fix the flaky test [gravitino]

2024-11-19 Thread via GitHub
jerryshao commented on issue #5213: URL: https://github.com/apache/gravitino/issues/5213#issuecomment-2484970793 Reopen this issue, since the test is still quite flaky. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] [#5506] feat(CLI): Table formatted output [gravitino]

2024-11-19 Thread via GitHub
xunliu commented on code in PR #5606: URL: https://github.com/apache/gravitino/pull/5606#discussion_r1847846692 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListMetalakes.java: ## @@ -50,13 +51,12 @@ public void handle() { return; } -List meta