Re: [PR] [#50] Add support for helm chart [gravitino-playground]

2024-08-05 Thread via GitHub
danhuawang commented on code in PR #56: URL: https://github.com/apache/gravitino-playground/pull/56#discussion_r1705010451 ## .DS_Store: ## Review Comment: Why this .DS_Store is uploaded? I suppose it's not necessary. -- This is an automated message from the Apache Git

Re: [PR] [#3173] fix(doris-catalog): Fix the bug when create doris table with empty property [gravitino]

2024-08-05 Thread via GitHub
yuqi1129 commented on code in PR #4343: URL: https://github.com/apache/gravitino/pull/4343#discussion_r1705008833 ## catalogs/catalog-jdbc-doris/src/main/java/org/apache/gravitino/catalog/doris/operation/DorisTableOperations.java: ## @@ -164,6 +168,37 @@ protected String generat

Re: [I] [Bug report] create MySQL table using func in default value can be done, but cannot load it [gravitino]

2024-08-05 Thread via GitHub
zhoukangcn commented on issue #2946: URL: https://github.com/apache/gravitino/issues/2946#issuecomment-2270525362 > Have you updated your local code to the latest version? I still cannot reproduce the issue in MySQL, and I found that the existing integration tests already include your case:

Re: [PR] [#4295] feat(server): Add REST API for the owner [gravitino]

2024-08-05 Thread via GitHub
yuqi1129 closed pull request #4385: [#4295] feat(server): Add REST API for the owner URL: https://github.com/apache/gravitino/pull/4385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] [#4295] feat(server): Add REST API for the owner [gravitino]

2024-08-05 Thread via GitHub
jerqi commented on PR #4385: URL: https://github.com/apache/gravitino/pull/4385#issuecomment-2270519655 Assign to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [#3173] fix(doris-catalog): Fix the bug when create doris table with empty property [gravitino]

2024-08-05 Thread via GitHub
mchades commented on code in PR #4343: URL: https://github.com/apache/gravitino/pull/4343#discussion_r1704998861 ## catalogs/catalog-jdbc-doris/src/main/java/org/apache/gravitino/catalog/doris/operation/DorisTableOperations.java: ## @@ -164,6 +168,37 @@ protected String generate

[PR] [#4295] feat(server): Add REST API for the owner [gravitino]

2024-08-05 Thread via GitHub
github-actions[bot] opened a new pull request, #4385: URL: https://github.com/apache/gravitino/pull/4385 ### What changes were proposed in this pull request? Add REST API for the owner. ### Why are the changes needed? Fix: #4295 ### Does this PR introduce _any_ user-f

Re: [PR] [#4295] feat(server): Add REST API for the owner [gravitino]

2024-08-05 Thread via GitHub
xunliu merged PR #4354: URL: https://github.com/apache/gravitino/pull/4354 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino

(gravitino) branch cherry-pick-branch-0.6-a314b410eaa834edacf2b2a808ae12e385fbaf25 created (now e0d29e737)

2024-08-05 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch cherry-pick-branch-0.6-a314b410eaa834edacf2b2a808ae12e385fbaf25 in repository https://gitbox.apache.org/repos/asf/gravitino.git at e0d29e737 [#4295] feat(server): Add REST API for the

Re: [I] [FEATURE] Ownership REST service api [gravitino]

2024-08-05 Thread via GitHub
xunliu closed issue #4295: [FEATURE] Ownership REST service api URL: https://github.com/apache/gravitino/issues/4295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

(gravitino) branch main updated: [#4295] feat(server): Add REST API for the owner (#4354)

2024-08-05 Thread liuxun
This is an automated email from the ASF dual-hosted git repository. liuxun pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new a314b410e [#4295] feat(server): Add REST API for

Re: [I] [FEATURE] Ownership REST service api [gravitino]

2024-08-05 Thread via GitHub
xunliu closed issue #4295: [FEATURE] Ownership REST service api URL: https://github.com/apache/gravitino/issues/4295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] [#3173] fix(doris-catalog): Fix the bug when create doris table with empty property [gravitino]

2024-08-05 Thread via GitHub
yuqi1129 commented on code in PR #4343: URL: https://github.com/apache/gravitino/pull/4343#discussion_r1704990332 ## catalogs/catalog-jdbc-doris/src/main/java/org/apache/gravitino/catalog/doris/operation/DorisTableOperations.java: ## @@ -164,6 +168,37 @@ protected String generat

(gravitino-site) 01/01: Merge pull request #14 from LauraXia123/adapted-mini

2024-08-05 Thread jmclean
This is an automated email from the ASF dual-hosted git repository. jmclean pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino-site.git commit 3d6f0da1cc7e181c2bdbe4dd4cb9a721135dfb0f Merge: ecc91f8 a39dd42 Author: Justin Mclean AuthorDate: Tue Aug 6 14:36

Re: [PR] adapted to mobile layout for homepage [gravitino-site]

2024-08-05 Thread via GitHub
justinmclean merged PR #14: URL: https://github.com/apache/gravitino-site/pull/14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gr

(gravitino-site) branch asf-site updated: deploy: 3d6f0da1cc7e181c2bdbe4dd4cb9a721135dfb0f

2024-08-05 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/gravitino-site.git The following commit(s) were added to refs/heads/asf-site by this push: new cc477d0 deploy: 3d6f0da1cc7e181

Re: [PR] [#4115] feat(api): add validate check for decimal(0,0) [gravitino]

2024-08-05 Thread via GitHub
FANNG1 commented on code in PR #4375: URL: https://github.com/apache/gravitino/pull/4375#discussion_r1704987035 ## api/src/main/java/org/apache/gravitino/rel/types/Types.java: ## Review Comment: updated -- This is an automated message from the Apache Git Service. To res

(gravitino-site) branch main updated (ecc91f8 -> 3d6f0da)

2024-08-05 Thread jmclean
This is an automated email from the ASF dual-hosted git repository. jmclean pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/gravitino-site.git from ecc91f8 update homepage (#12) add a39dd42 adapted to mobile layout for homepage new 3d6f0da Merge

Re: [PR] [#3173] fix(doris-catalog): Fix the bug when create doris table with empty property [gravitino]

2024-08-05 Thread via GitHub
yuqi1129 commented on code in PR #4343: URL: https://github.com/apache/gravitino/pull/4343#discussion_r1704981415 ## catalogs/catalog-jdbc-doris/src/main/java/org/apache/gravitino/catalog/doris/DorisTablePropertiesMetadata.java: ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache

Re: [PR] [#4277] feat(client/server): Add the `getFilesetContext` interface in the Java Client/Server [gravitino]

2024-08-05 Thread via GitHub
xloya commented on code in PR #4281: URL: https://github.com/apache/gravitino/pull/4281#discussion_r1704979590 ## api/src/main/java/org/apache/gravitino/file/FilesetDataOperationCtx.java: ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] [#4277] feat(client/server): Add the `getFilesetContext` interface in the Java Client/Server [gravitino]

2024-08-05 Thread via GitHub
xloya commented on code in PR #4281: URL: https://github.com/apache/gravitino/pull/4281#discussion_r1704979590 ## api/src/main/java/org/apache/gravitino/file/FilesetDataOperationCtx.java: ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] [#4277] feat(client/server): Add the `getFilesetContext` interface in the Java Client/Server [gravitino]

2024-08-05 Thread via GitHub
xloya commented on code in PR #4281: URL: https://github.com/apache/gravitino/pull/4281#discussion_r1704979590 ## api/src/main/java/org/apache/gravitino/file/FilesetDataOperationCtx.java: ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] [#4277] feat(client/server): Add the `getFilesetContext` interface in the Java Client/Server [gravitino]

2024-08-05 Thread via GitHub
xloya commented on code in PR #4281: URL: https://github.com/apache/gravitino/pull/4281#discussion_r1704979590 ## api/src/main/java/org/apache/gravitino/file/FilesetDataOperationCtx.java: ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] [#3173] fix(doris-catalog): Fix the bug when create doris table with empty property [gravitino]

2024-08-05 Thread via GitHub
xiaozcy commented on code in PR #4343: URL: https://github.com/apache/gravitino/pull/4343#discussion_r1704978378 ## catalogs/catalog-jdbc-doris/src/main/java/org/apache/gravitino/catalog/doris/DorisTablePropertiesMetadata.java: ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache

[PR] adapted to mobile layout for homepage [gravitino-site]

2024-08-05 Thread via GitHub
LauraXia123 opened a new pull request, #14: URL: https://github.com/apache/gravitino-site/pull/14 https://github.com/user-attachments/assets/259d24a2-f73b-454e-8c57-c42d70f86d84";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [#4154] improvment(client): Move access control function to GravitinoClient [gravitino]

2024-08-05 Thread via GitHub
jerqi commented on PR #4215: URL: https://github.com/apache/gravitino/pull/4215#issuecomment-2270451632 > > > why moving access control function from `GravitinoAdminClient` to `GravitinoClient`? > > > > > > Access control operations can be executed by normal users instead of admi

Re: [PR] [#4154] improvment(client): Move access control function to GravitinoClient [gravitino]

2024-08-05 Thread via GitHub
FANNG1 commented on PR #4215: URL: https://github.com/apache/gravitino/pull/4215#issuecomment-2270411986 > > why moving access control function from `GravitinoAdminClient` to `GravitinoClient`? > > Access control operations can be executed by normal users instead of admins. IM

Re: [PR] [#4277] feat(client/server): Add the `getFilesetContext` interface in the Java Client/Server [gravitino]

2024-08-05 Thread via GitHub
jerryshao commented on code in PR #4281: URL: https://github.com/apache/gravitino/pull/4281#discussion_r1704912757 ## api/src/main/java/org/apache/gravitino/file/FilesetDataOperationCtx.java: ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Fix potential NullPointerException in UserContext by adding null check for parentContext. [gravitino]

2024-08-05 Thread via GitHub
justinmclean commented on PR #4348: URL: https://github.com/apache/gravitino/pull/4348#issuecomment-2270331271 Please remove the "// Improvement: Check if parentContext is not null before using it" there is no need for this comment in the code. -- This is an automated message from the Apa

Re: [PR] [#3173] fix(doris-catalog): Fix the bug when create doris table with empty property [gravitino]

2024-08-05 Thread via GitHub
mchades commented on code in PR #4343: URL: https://github.com/apache/gravitino/pull/4343#discussion_r170484 ## catalogs/catalog-jdbc-doris/src/main/java/org/apache/gravitino/catalog/doris/operation/DorisTableOperations.java: ## @@ -164,6 +168,37 @@ protected String generate

Re: [I] [FEATURE] Support Clickhouse catalog [gravitino]

2024-08-05 Thread via GitHub
shaofengshi commented on issue #3888: URL: https://github.com/apache/gravitino/issues/3888#issuecomment-2270294349 +1, many users are using Clickhouse; Support Clickhouse is reasonable for Gravitino. @flaming-archer you already work on it, right? -- This is an automated message fro

Re: [PR] [#4154] improvment(client): Move access control function to GravitinoClient [gravitino]

2024-08-05 Thread via GitHub
jerqi commented on PR #4215: URL: https://github.com/apache/gravitino/pull/4215#issuecomment-2270290333 > why moving access control function from `GravitinoAdminClient` to `GravitinoClient`? Access control operations can be executed by normal users instead of admins. -- This is an

Re: [PR] [#4154] improvment(client): Move access control function to GravitinoClient [gravitino]

2024-08-05 Thread via GitHub
FANNG1 commented on PR #4215: URL: https://github.com/apache/gravitino/pull/4215#issuecomment-2270286042 why moving access control function from `GravitinoAdminClient` to `GravitinoClient`? -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] [#4115] feat(api): add validate check for decimal(0,0) [gravitino]

2024-08-05 Thread via GitHub
FANNG1 commented on code in PR #4375: URL: https://github.com/apache/gravitino/pull/4375#discussion_r1704838057 ## api/src/main/java/org/apache/gravitino/rel/types/Types.java: ## Review Comment: ok -- This is an automated message from the Apache Git Service. To respond

[I] [Improvement] UI: Replace to password input for all jdbc-password value [gravitino]

2024-08-05 Thread via GitHub
LauraXia123 opened a new issue, #4384: URL: https://github.com/apache/gravitino/issues/4384 ### What would you like to be improved? https://github.com/user-attachments/assets/68316b8b-9e4b-4c44-bb92-e16ebc0cb6aa";> ### How should we improve? _No response_ -- This i

Re: [PR] [#3916] feat(catalog-lakehouse-paimon): Support alter table for Paimon Catalog [gravitino]

2024-08-05 Thread via GitHub
caican00 commented on code in PR #4349: URL: https://github.com/apache/gravitino/pull/4349#discussion_r1704828729 ## catalogs/catalog-lakehouse-paimon/src/main/java/org/apache/gravitino/catalog/lakehouse/paimon/utils/TableOpsUtils.java: ## @@ -46,4 +153,39 @@ private static void

Re: [PR] [#4154] improvment(client): Move access control function to GravitinoClient [gravitino]

2024-08-05 Thread via GitHub
jerryshao commented on PR #4215: URL: https://github.com/apache/gravitino/pull/4215#issuecomment-2270255615 I'm OK with the changes, @yuqi1129 can you please take another look, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [#4227] improvement(client-python): Add Catalog Error Handler and related exceptions, test cases in client-python [gravitino]

2024-08-05 Thread via GitHub
jerryshao commented on PR #4345: URL: https://github.com/apache/gravitino/pull/4345#issuecomment-2270251862 @jingjia88 would you please fix the conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

(gravitino) branch cherry-pick-branch-0.6-97839ee6b19fd11484ae4a1de7942e7c3918b876 deleted (was de2446bf4)

2024-08-05 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a change to branch cherry-pick-branch-0.6-97839ee6b19fd11484ae4a1de7942e7c3918b876 in repository https://gitbox.apache.org/repos/asf/gravitino.git was de2446bf4 [#4291] feat(catalog-lakehouse-paimon): Support

(gravitino) branch branch-0.6 updated: [#4291] feat(catalog-lakehouse-paimon): Support Paimon table with primary keys in Gravitino (#4383)

2024-08-05 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch branch-0.6 in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/branch-0.6 by this push: new 5f4d733b3 [#4291] feat(catalog-lakehou

Re: [PR] [#4291] feat(catalog-lakehouse-paimon): Support Paimon table with primary keys in Gravitino [gravitino]

2024-08-05 Thread via GitHub
jerryshao merged PR #4383: URL: https://github.com/apache/gravitino/pull/4383 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

Re: [PR] Remove `RemoveResponse` and merge functionality into `DeleteResponse` [gravitino]

2024-08-05 Thread via GitHub
jerryshao commented on PR #4380: URL: https://github.com/apache/gravitino/pull/4380#issuecomment-2270246957 I don't think simply removing `RemoveResponse` class is enough, you need to do some code changes in other places. -- This is an automated message from the Apache Git Service. To res

Re: [I] [Improvement] UI: Switch catalog properties from immutable to mutable [gravitino]

2024-08-05 Thread via GitHub
LauraXia123 commented on issue #4351: URL: https://github.com/apache/gravitino/issues/4351#issuecomment-2270244290 @yuqi1129 I have fixed it on [PR](https://github.com/apache/gravitino/pull/4355) -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [I] [Bug report] create MySQL table using func in default value can be done, but cannot load it [gravitino]

2024-08-05 Thread via GitHub
mchades commented on issue #2946: URL: https://github.com/apache/gravitino/issues/2946#issuecomment-2270243079 Have you updated your local code to the latest version? I still cannot reproduce the issue in MySQL, and I found that the existing integration tests already include your case:

Re: [I] [FEATURE] Add github logo, stars number and forks number for UI [gravitino]

2024-08-05 Thread via GitHub
LauraXia123 commented on issue #4362: URL: https://github.com/apache/gravitino/issues/4362#issuecomment-2270241954 @justinmclean yeah, I mean clicking on the clicking on the new logo in the top right corner. -- This is an automated message from the Apache Git Service. To respond to the

Re: [I] [Bug report] create MySQL table using func in default value can be done, but cannot load it [gravitino]

2024-08-05 Thread via GitHub
zhoukangcn commented on issue #2946: URL: https://github.com/apache/gravitino/issues/2946#issuecomment-2270223206 ``` 2024-08-06 10:01:37.474 ERROR [Gravitino-webserver-48] [org.apache.gravitino.server.web.rest.ExceptionHandlers$BaseExceptionHandler.handle(ExceptionHandlers.java:583)] -

Re: [I] [Bug report] create MySQL table using func in default value can be done, but cannot load it [gravitino]

2024-08-05 Thread via GitHub
mchades commented on issue #2946: URL: https://github.com/apache/gravitino/issues/2946#issuecomment-2270221802 > > > @mchades I had test it with main branch, I found this bug still exists. So I will reopen this issue. > > > > > > I used the table creation request described by you

Re: [I] [Bug report] create MySQL table using func in default value can be done, but cannot load it [gravitino]

2024-08-05 Thread via GitHub
zhoukangcn commented on issue #2946: URL: https://github.com/apache/gravitino/issues/2946#issuecomment-2270218933 > > @mchades I had test it with main branch, I found this bug still exists. So I will reopen this issue. > > I used the table creation request described by you and was abl

Re: [I] [Bug report] CI: occasionally run trino tpcds testsets failed because clean up test env unsuccessfully [gravitino]

2024-08-05 Thread via GitHub
diqiu50 commented on issue #3792: URL: https://github.com/apache/gravitino/issues/3792#issuecomment-2270213705 @danhuawang If the last round of testing failed, you'd better clear all the test resources manually. The Drop Catalog interface on the Gravitino server has some limitations for non

Re: [PR] [#2286] Distribution.java correct equals method. [gravitino]

2024-08-05 Thread via GitHub
diqiu50 commented on code in PR #4378: URL: https://github.com/apache/gravitino/pull/4378#discussion_r1704801646 ## api/src/main/java/org/apache/gravitino/rel/expressions/distributions/Distribution.java: ## @@ -46,16 +46,29 @@ default Expression[] children() { /** * Indic

(gravitino) branch branch-0.6 updated: [#4351] [improvement] UI: Switch catalog properties from immutable to mutable (#4379)

2024-08-05 Thread yuqi4733
This is an automated email from the ASF dual-hosted git repository. yuqi4733 pushed a commit to branch branch-0.6 in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/branch-0.6 by this push: new e7ca642e1 [#4351] [improvement] UI:

Re: [PR] [#4351] [improvement] UI: Switch catalog properties from immutable to mutable [gravitino]

2024-08-05 Thread via GitHub
yuqi1129 merged PR #4379: URL: https://github.com/apache/gravitino/pull/4379 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graviti

(gravitino) branch cherry-pick-branch-0.6-137bda18d3440c751b277f49fa6f9b9eaaf5bf33 deleted (was aeadbea8b)

2024-08-05 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a change to branch cherry-pick-branch-0.6-137bda18d3440c751b277f49fa6f9b9eaaf5bf33 in repository https://gitbox.apache.org/repos/asf/gravitino.git was aeadbea8b [#4228] improvement(client-python): Add Schema E

(gravitino) branch branch-0.6 updated: [#4228] improvement(client-python): Add Schema Error Handler and related exceptions, test cases in client-python (#4381)

2024-08-05 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch branch-0.6 in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/branch-0.6 by this push: new fd8c7755d [#4228] improvement(client-p

Re: [PR] [#4228] improvement(client-python): Add Schema Error Handler and related exceptions, test cases in client-python [gravitino]

2024-08-05 Thread via GitHub
jerryshao merged PR #4381: URL: https://github.com/apache/gravitino/pull/4381 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

Re: [PR] [#4115] feat(api): add validate check for decimal(0,0) [gravitino]

2024-08-05 Thread via GitHub
mchades commented on code in PR #4375: URL: https://github.com/apache/gravitino/pull/4375#discussion_r1704780005 ## api/src/main/java/org/apache/gravitino/rel/types/Types.java: ## Review Comment: Could you also add the limitations to the doc `manage-relational-metadata-usi

Re: [PR] [#3173] fix(doris-catalog): Fix the bug when create doris table with empty property [gravitino]

2024-08-05 Thread via GitHub
mchades commented on PR #4343: URL: https://github.com/apache/gravitino/pull/4343#issuecomment-2270167178 > > `jdbc-doris-catalog.md` also need to be updated? > > As Doris catalog has many other properties like this, I'm not entirely sure if we need to include it in the document. Shou

Re: [PR] [#3173] fix(doris-catalog): Fix the bug when create doris table with empty property [gravitino]

2024-08-05 Thread via GitHub
mchades commented on code in PR #4343: URL: https://github.com/apache/gravitino/pull/4343#discussion_r1704768108 ## catalogs/catalog-jdbc-doris/src/main/java/org/apache/gravitino/catalog/doris/DorisTablePropertiesMetadata.java: ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache

Re: [I] [Bug report] create MySQL table using func in default value can be done, but cannot load it [gravitino]

2024-08-05 Thread via GitHub
mchades commented on issue #2946: URL: https://github.com/apache/gravitino/issues/2946#issuecomment-2270163141 > @mchades I had test it with main branch, I found this bug still exists. So I will reopen this issue. I used the table creation request described by you and was able to crea

Re: [PR] [#4291] feat(catalog-lakehouse-paimon): Support Paimon table with primary keys in Gravitino [gravitino]

2024-08-05 Thread via GitHub
FANNG1 closed pull request #4383: [#4291] feat(catalog-lakehouse-paimon): Support Paimon table with primary keys in Gravitino URL: https://github.com/apache/gravitino/pull/4383 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [I] [Subtask] Support Paimon table with primary keys in Gravitino [gravitino]

2024-08-05 Thread via GitHub
FANNG1 closed issue #4291: [Subtask] Support Paimon table with primary keys in Gravitino URL: https://github.com/apache/gravitino/issues/4291 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

(gravitino) branch main updated: [#4291] feat(catalog-lakehouse-paimon): Support Paimon table with primary keys in Gravitino (#4292)

2024-08-05 Thread fanng
This is an automated email from the ASF dual-hosted git repository. fanng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 97839ee6b [#4291] feat(catalog-lakehouse-paimon):

Re: [PR] [#4291] feat(catalog-lakehouse-paimon): Support Paimon table with primary keys in Gravitino [gravitino]

2024-08-05 Thread via GitHub
FANNG1 merged PR #4292: URL: https://github.com/apache/gravitino/pull/4292 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino

Re: [PR] [#4291] feat(catalog-lakehouse-paimon): Support Paimon table with primary keys in Gravitino [gravitino]

2024-08-05 Thread via GitHub
FANNG1 commented on PR #4292: URL: https://github.com/apache/gravitino/pull/4292#issuecomment-2270135225 merged to main, thanks for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

(gravitino) branch cherry-pick-branch-0.6-97839ee6b19fd11484ae4a1de7942e7c3918b876 created (now de2446bf4)

2024-08-05 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch cherry-pick-branch-0.6-97839ee6b19fd11484ae4a1de7942e7c3918b876 in repository https://gitbox.apache.org/repos/asf/gravitino.git at de2446bf4 [#4291] feat(catalog-lakehouse-paimon): Sup

[PR] [#4291] feat(catalog-lakehouse-paimon): Support Paimon table with primary keys in Gravitino [gravitino]

2024-08-05 Thread via GitHub
github-actions[bot] opened a new pull request, #4383: URL: https://github.com/apache/gravitino/pull/4383 ### What changes were proposed in this pull request? Support Paimon table with primary keys in Gravitino ### Why are the changes needed? Fix: https://github.com/apach

Re: [I] [Subtask] Support Paimon table with primary keys in Gravitino [gravitino]

2024-08-05 Thread via GitHub
FANNG1 closed issue #4291: [Subtask] Support Paimon table with primary keys in Gravitino URL: https://github.com/apache/gravitino/issues/4291 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [I] [Improvement] Use of regex on error messages can be fragile in DorisExceptionConverter.java [gravitino]

2024-08-05 Thread via GitHub
ashwin1596 commented on issue #3027: URL: https://github.com/apache/gravitino/issues/3027#issuecomment-2270119423 In that case, may I suggest using exact string matching for errors within the same file as an alternative to using regex? This approach is less resource-intensive and can provid

Re: [PR] [#1908] Fix: In HadoopCatalogOperations.java field entity is not used [gravitino]

2024-08-05 Thread via GitHub
justinmclean commented on PR #4350: URL: https://github.com/apache/gravitino/pull/4350#issuecomment-2270114253 You ned to run `./gradlew :catalogs:catalog-hadoop:spotlessApply` and commit the changes to fix the CI issue. -- This is an automated message from the Apache Git Service. To resp

Re: [I] [FEATURE] Add github logo, stars number and forks number for UI [gravitino]

2024-08-05 Thread via GitHub
justinmclean commented on issue #4362: URL: https://github.com/apache/gravitino/issues/4362#issuecomment-2270090584 I think people will expect that clicking on the logo will take you to the first page of the application, not the GitHub repo. -- This is an automated message from the Apache

Re: [PR] Fix potential NullPointerException in UserContext by adding null check for parentContext. [gravitino]

2024-08-05 Thread via GitHub
justinmclean commented on PR #4348: URL: https://github.com/apache/gravitino/pull/4348#issuecomment-2270088303 @mrkartik00 It looks like the comments have still been removed. Can you please add them back? -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [I] [Improvement] In `ExceptionHandlers.java` field `INSTANCE` is not used [gravitino]

2024-08-05 Thread via GitHub
justinmclean commented on issue #1895: URL: https://github.com/apache/gravitino/issues/1895#issuecomment-2270085995 @lokendra005 this may have already been fixed - can check that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[PR] [#4266] feat: simplify compilation by compiling scripts [gravitino]

2024-08-05 Thread via GitHub
featherchen opened a new pull request, #4382: URL: https://github.com/apache/gravitino/pull/4382 ### What changes were proposed in this pull request? Script for the more friendly building configuration ### Why are the changes needed? Fix: #4266 ### Does thi

[I] [Bug report] create MySQL table using func in default value can be done, but cannot load it [gravitino]

2024-08-05 Thread via GitHub
zhoukangcn opened a new issue, #2946: URL: https://github.com/apache/gravitino/issues/2946 ### Version main branch ### Describe what's wrong create a MySQL table using funciton in default value, this request get an excepiton ``` Failed to operate object [test_

Re: [I] [Bug report] create MySQL table using func in default value can be done, but cannot load it [gravitino]

2024-08-05 Thread via GitHub
zhoukangcn commented on issue #2946: URL: https://github.com/apache/gravitino/issues/2946#issuecomment-2269477127 @mchades I had test it with main branch, I found this bug still exists. So I will reopen this issue. -- This is an automated message from the Apache Git Service. To respond to

Re: [I] [Subtask] Add Schema Error Handler and related exceptions, test cases in client-python [gravitino]

2024-08-05 Thread via GitHub
jingjia88 commented on issue #4228: URL: https://github.com/apache/gravitino/issues/4228#issuecomment-2269459238 @jerryshao coming ʕ •ᴥ•ʔ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [I] [FEATURE] Add github logo, stars number and forks number for UI [gravitino]

2024-08-05 Thread via GitHub
jenish-thapa commented on issue #4362: URL: https://github.com/apache/gravitino/issues/4362#issuecomment-2269451133 Hey @LauraXia123, I would like to work on this issue. Can you please assign it to me? -- This is an automated message from the Apache Git Service. To respond to the m

Re: [I] [Improvement] HTTPClient.java has no unit tests/coverage [gravitino]

2024-08-05 Thread via GitHub
zzzk1 commented on issue #2182: URL: https://github.com/apache/gravitino/issues/2182#issuecomment-2269345176 > @zzzk1 how are you going with this issue? Sorry for the late reply. It looks like HTTPClient.java already has a test case. I am trying to improve the test coverage. -- Thi

Re: [PR] [#4228] improvement(client-python): Add Schema Error Handler and related exceptions, test cases in client-python [gravitino]

2024-08-05 Thread via GitHub
jerryshao closed pull request #4381: [#4228] improvement(client-python): Add Schema Error Handler and related exceptions, test cases in client-python URL: https://github.com/apache/gravitino/pull/4381 -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [I] [Subtask] Add Schema Error Handler and related exceptions, test cases in client-python [gravitino]

2024-08-05 Thread via GitHub
jerryshao commented on issue #4228: URL: https://github.com/apache/gravitino/issues/4228#issuecomment-2269324932 @jingjia88 can you please leave a message here, so I can assign to you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [#4228] improvement(client-python): Add Schema Error Handler and related exceptions, test cases in client-python [gravitino]

2024-08-05 Thread via GitHub
jerryshao merged PR #4347: URL: https://github.com/apache/gravitino/pull/4347 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

(gravitino) branch main updated: [#4228] improvement(client-python): Add Schema Error Handler and related exceptions, test cases in client-python (#4347)

2024-08-05 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 137bda18d [#4228] improvement(client-python): Add

(gravitino) branch cherry-pick-branch-0.6-137bda18d3440c751b277f49fa6f9b9eaaf5bf33 created (now aeadbea8b)

2024-08-05 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch cherry-pick-branch-0.6-137bda18d3440c751b277f49fa6f9b9eaaf5bf33 in repository https://gitbox.apache.org/repos/asf/gravitino.git at aeadbea8b [#4228] improvement(client-python): Add Sch

Re: [I] [Subtask] Add Schema Error Handler and related exceptions, test cases in client-python [gravitino]

2024-08-05 Thread via GitHub
jerryshao closed issue #4228: [Subtask] Add Schema Error Handler and related exceptions, test cases in client-python URL: https://github.com/apache/gravitino/issues/4228 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[PR] [#4228] improvement(client-python): Add Schema Error Handler and related exceptions, test cases in client-python [gravitino]

2024-08-05 Thread via GitHub
github-actions[bot] opened a new pull request, #4381: URL: https://github.com/apache/gravitino/pull/4381 ### What changes were proposed in this pull request? Add Schema Error Handler and related exceptions, test cases in `client-python` based on `client-java` ### Why are the ch

Re: [PR] [#3817] fix(catalog-postgresql): Fix bugs when creating a schema or table using upper-case name. [gravitino]

2024-08-05 Thread via GitHub
yuqi1129 commented on PR #4376: URL: https://github.com/apache/gravitino/pull/4376#issuecomment-2269301605 I also noticed it but I can't trigger it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [#3817] fix(catalog-postgresql): Fix bugs when creating a schema or table using upper-case name. [gravitino]

2024-08-05 Thread via GitHub
FANNG1 commented on PR #4376: URL: https://github.com/apache/gravitino/pull/4376#issuecomment-2269297664 @jerryshao @yuqi1129 , seems the ci of cherry-picked PR doesn't run automatically. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [#4351] [improvement] UI: Switch catalog properties from immutable to mutable [gravitino]

2024-08-05 Thread via GitHub
jerryshao closed pull request #4379: [#4351] [improvement] UI: Switch catalog properties from immutable to mutable URL: https://github.com/apache/gravitino/pull/4379 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

(gravitino) branch cherry-pick-branch-0.6-1226fb10fae8fb00f254645466943a49c53580d5 created (now 97f4c446d)

2024-08-05 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch cherry-pick-branch-0.6-1226fb10fae8fb00f254645466943a49c53580d5 in repository https://gitbox.apache.org/repos/asf/gravitino.git at 97f4c446d [#4351] [improvement] UI: Switch catalog pr

Re: [PR] [#4351] [improvement] UI: Switch catalog properties from immutable to mutable [gravitino]

2024-08-05 Thread via GitHub
jerryshao merged PR #4355: URL: https://github.com/apache/gravitino/pull/4355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

(gravitino) branch main updated: [#4351] [improvement] UI: Switch catalog properties from immutable to mutable (#4355)

2024-08-05 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 1226fb10f [#4351] [improvement] UI: Switch catalog

[PR] [#4351] [improvement] UI: Switch catalog properties from immutable to mutable [gravitino]

2024-08-05 Thread via GitHub
github-actions[bot] opened a new pull request, #4379: URL: https://github.com/apache/gravitino/pull/4379 ### What changes were proposed in this pull request? switch catalog properties value input disable to enable hive catalog before: https://github.com/user-attachments/asse

Re: [I] [Improvement] UI: Switch catalog properties from immutable to mutable [gravitino]

2024-08-05 Thread via GitHub
jerryshao closed issue #4351: [Improvement] UI: Switch catalog properties from immutable to mutable URL: https://github.com/apache/gravitino/issues/4351 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [I] [Improvement] UI: Switch catalog properties from immutable to mutable [gravitino]

2024-08-05 Thread via GitHub
jerryshao closed issue #4351: [Improvement] UI: Switch catalog properties from immutable to mutable URL: https://github.com/apache/gravitino/issues/4351 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

(gravitino) branch cherry-pick-branch-0.6-f0ef7a87703b103fd56ae9ce4d17470b0ec4b2b6 deleted (was a5561ca22)

2024-08-05 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a change to branch cherry-pick-branch-0.6-f0ef7a87703b103fd56ae9ce4d17470b0ec4b2b6 in repository https://gitbox.apache.org/repos/asf/gravitino.git was a5561ca22 [#3817] fix(catalog-postgresql): Fix bugs when c

(gravitino) branch branch-0.6 updated: [#3817] fix(catalog-postgresql): Fix bugs when creating a schema or table using upper-case name. (#4376)

2024-08-05 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch branch-0.6 in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/branch-0.6 by this push: new a7b136af1 [#3817] fix(catalog-postgres

Re: [PR] [#3817] fix(catalog-postgresql): Fix bugs when creating a schema or table using upper-case name. [gravitino]

2024-08-05 Thread via GitHub
jerryshao merged PR #4376: URL: https://github.com/apache/gravitino/pull/4376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

Re: [I] [Improvement] In Distribution.java correct equals method [gravitino]

2024-08-05 Thread via GitHub
lokendra005 commented on issue #2286: URL: https://github.com/apache/gravitino/issues/2286#issuecomment-2269236336 Kindly review my PR for this issue and let me know if any changes are needed!! @justinmclean -- This is an automated message from the Apache Git Service. To respond to the m

[PR] [#2286] Distribution.java correct equals method. [gravitino]

2024-08-05 Thread via GitHub
lokendra005 opened a new pull request, #4378: URL: https://github.com/apache/gravitino/pull/4378 ### What changes were proposed in this pull request? This pull request addresses the issue with the equals method in Distribution.java. The equals method is updated to correctly ov

Re: [PR] [#4291] feat(catalog-lakehouse-paimon): Support Paimon table with primary keys in Gravitino [gravitino]

2024-08-05 Thread via GitHub
caican00 commented on PR #4292: URL: https://github.com/apache/gravitino/pull/4292#issuecomment-2269178809 ![image](https://github.com/user-attachments/assets/1526f1ec-7eac-42b0-a45c-8ada25c964a3) Tested IT locally. -- This is an automated message from the Apache Git Service. To re

  1   2   3   >