Re: [I] feat(java): shade protobuf dependency in Java info [incubator-graphar]

2025-03-03 Thread via GitHub
SemyonSinchenko closed issue #662: feat(java): shade protobuf dependency in Java info URL: https://github.com/apache/incubator-graphar/issues/662 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] feat(java): shade protobuf dependency in Java info [incubator-graphar]

2025-03-02 Thread via GitHub
Thespica commented on issue #662: URL: https://github.com/apache/incubator-graphar/issues/662#issuecomment-2693456575 > [@Thespica](https://github.com/Thespica) cc Is this PR ready? It seems that the `dependency-reduce-pom.xml` file is temporary, and we do not need to add it to g

Re: [I] feat(java): shade protobuf dependency in Java info [incubator-graphar]

2025-03-02 Thread via GitHub
SemyonSinchenko commented on issue #662: URL: https://github.com/apache/incubator-graphar/issues/662#issuecomment-2692626793 Exactly! I slightly changed the pom (will describe in the future commit). And I have now two generated JARs: - info - original info ![Image](https://git

Re: [I] feat(java): shade protobuf dependency in Java info [incubator-graphar]

2025-03-02 Thread via GitHub
SemyonSinchenko commented on issue #662: URL: https://github.com/apache/incubator-graphar/issues/662#issuecomment-2692627092 @Thespica cc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [I] feat(java): shade protobuf dependency in Java info [incubator-graphar]

2025-03-01 Thread via GitHub
SemyonSinchenko commented on issue #662: URL: https://github.com/apache/incubator-graphar/issues/662#issuecomment-2692403189 @Thespica You can check in #663 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [I] feat(java): shade protobuf dependency in Java info [incubator-graphar]

2025-03-01 Thread via GitHub
SemyonSinchenko commented on issue #662: URL: https://github.com/apache/incubator-graphar/issues/662#issuecomment-2692255500 > Is it means that we generate the proto-code once and save them, so we no longer need protobuf related dependencies when releasing? Yes. All the needed classe

Re: [I] feat(java): shade protobuf dependency in Java info [incubator-graphar]

2025-03-01 Thread via GitHub
SemyonSinchenko commented on issue #662: URL: https://github.com/apache/incubator-graphar/issues/662#issuecomment-2692255654 I can actually open a draft PR to explain it by the code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [I] feat(java): shade protobuf dependency in Java info [incubator-graphar]

2025-03-01 Thread via GitHub
Thespica commented on issue #662: URL: https://github.com/apache/incubator-graphar/issues/662#issuecomment-2692254211 > [@Thespica](https://github.com/Thespica) [@acezen](https://github.com/acezen) what do you think? Is it means that we generate the proto-code once and save them, so

Re: [I] feat(java): shade protobuf dependency in Java info [incubator-graphar]

2025-03-01 Thread via GitHub
SemyonSinchenko commented on issue #662: URL: https://github.com/apache/incubator-graphar/issues/662#issuecomment-2692130833 @Thespica @acezen what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL