Re: [PR] feat: shade proto [incubator-graphar]

2025-03-02 Thread via GitHub
SemyonSinchenko commented on PR #663: URL: https://github.com/apache/incubator-graphar/pull/663#issuecomment-2693536931 @Thespica Yes! From now it is ready for the review. **Changes:** - Shading snakeyaml too (it is a hadoop dependency and may cause dependency hell) - Updating

Re: [PR] feat: shade proto [incubator-graphar]

2025-03-02 Thread via GitHub
Thespica commented on PR #663: URL: https://github.com/apache/incubator-graphar/pull/663#issuecomment-2693470176 Is this PR ready? It seems that the dependency-reduce-pom.xml file is temporary, and we do not need to add it to git(from [stackoverflow.com/a/35155294](https://stackoverflow

Re: [I] feat(java): remove the hadoop dependency from java-info [incubator-graphar]

2025-03-02 Thread via GitHub
Thespica commented on issue #664: URL: https://github.com/apache/incubator-graphar/issues/664#issuecomment-2693467741 > [@Thespica](https://github.com/Thespica) cc I remembered that I imported the hadoop dependency so that we can read and wire file from in different places(e.g. file,

Re: [I] feat(java): shade protobuf dependency in Java info [incubator-graphar]

2025-03-02 Thread via GitHub
Thespica commented on issue #662: URL: https://github.com/apache/incubator-graphar/issues/662#issuecomment-2693456575 > [@Thespica](https://github.com/Thespica) cc Is this PR ready? It seems that the `dependency-reduce-pom.xml` file is temporary, and we do not need to add it to g

Re: [I] feat(java): remove the hadoop dependency from java-info [incubator-graphar]

2025-03-02 Thread via GitHub
SemyonSinchenko commented on issue #664: URL: https://github.com/apache/incubator-graphar/issues/664#issuecomment-2692634617 @Thespica cc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [I] feat(java): shade protobuf dependency in Java info [incubator-graphar]

2025-03-02 Thread via GitHub
SemyonSinchenko commented on issue #662: URL: https://github.com/apache/incubator-graphar/issues/662#issuecomment-2692626793 Exactly! I slightly changed the pom (will describe in the future commit). And I have now two generated JARs: - info - original info ![Image](https://git

Re: [PR] feat: shade proto [incubator-graphar]

2025-03-02 Thread via GitHub
SemyonSinchenko commented on PR #663: URL: https://github.com/apache/incubator-graphar/pull/663#issuecomment-2692631944 > Looks cool! By shading like this, we can get a jar with info package, right? I answered in the issue -- This is an automated message from the Apache Git Servic

[I] feat(java): remove the hadoop dependency from java-info [incubator-graphar]

2025-03-02 Thread via GitHub
SemyonSinchenko opened a new issue, #664: URL: https://github.com/apache/incubator-graphar/issues/664 ### Describe the enhancement requested At the moment Hadoop is a dependency of the java-info package. But by the design this package was supposed to be a lightweight and (almost) depe

Re: [I] feat(java): shade protobuf dependency in Java info [incubator-graphar]

2025-03-02 Thread via GitHub
SemyonSinchenko commented on issue #662: URL: https://github.com/apache/incubator-graphar/issues/662#issuecomment-2692627092 @Thespica cc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec