Re: [PR] feat: shade proto [incubator-graphar]

2025-03-01 Thread via GitHub
Thespica commented on PR #663: URL: https://github.com/apache/incubator-graphar/pull/663#issuecomment-2692583038 Looks cool! By shading like this, we can get a jar with info package, right? -- This is an automated message from the Apache Git Service. To respond to the message, please l

[PR] feat: shade proto [incubator-graphar]

2025-03-01 Thread via GitHub
SemyonSinchenko opened a new pull request, #663: URL: https://github.com/apache/incubator-graphar/pull/663 ### Reason for this PR As described in #662 ### What changes are included in this PR? Only shading rules ### Are these changes tested? Changes

Re: [I] feat(java): shade protobuf dependency in Java info [incubator-graphar]

2025-03-01 Thread via GitHub
SemyonSinchenko commented on issue #662: URL: https://github.com/apache/incubator-graphar/issues/662#issuecomment-2692403189 @Thespica You can check in #663 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [I] feat(java): shade protobuf dependency in Java info [incubator-graphar]

2025-03-01 Thread via GitHub
SemyonSinchenko commented on issue #662: URL: https://github.com/apache/incubator-graphar/issues/662#issuecomment-2692255500 > Is it means that we generate the proto-code once and save them, so we no longer need protobuf related dependencies when releasing? Yes. All the needed classe

Re: [I] feat(java): shade protobuf dependency in Java info [incubator-graphar]

2025-03-01 Thread via GitHub
SemyonSinchenko commented on issue #662: URL: https://github.com/apache/incubator-graphar/issues/662#issuecomment-2692255654 I can actually open a draft PR to explain it by the code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [I] feat(java): shade protobuf dependency in Java info [incubator-graphar]

2025-03-01 Thread via GitHub
Thespica commented on issue #662: URL: https://github.com/apache/incubator-graphar/issues/662#issuecomment-2692254211 > [@Thespica](https://github.com/Thespica) [@acezen](https://github.com/acezen) what do you think? Is it means that we generate the proto-code once and save them, so

Re: [I] feat(java): shade protobuf dependency in Java info [incubator-graphar]

2025-03-01 Thread via GitHub
SemyonSinchenko commented on issue #662: URL: https://github.com/apache/incubator-graphar/issues/662#issuecomment-2692130833 @Thespica @acezen what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[I] feat: shade protobuf dependency in Java info [incubator-graphar]

2025-03-01 Thread via GitHub
SemyonSinchenko opened a new issue, #662: URL: https://github.com/apache/incubator-graphar/issues/662 ### Describe the enhancement requested Protobuf is very popular but version-sensitive dependency that is used literally everywhere. We should shade it in Java info to simplify the in