Re: [PR] [fix](jdbc) fix Unknown command(27) [doris]

2024-10-09 Thread via GitHub
dataroaring merged PR #41621: URL: https://github.com/apache/doris/pull/41621 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

Re: [PR] [fix](parquet) fix dict page offset zero incompatible behaviour [doris]

2024-10-09 Thread via GitHub
morningman merged PR #41506: URL: https://github.com/apache/doris/pull/41506 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.a

Re: [PR] [Refactor] (inverted index) Refactor Inverted index file writer [doris]

2024-10-09 Thread via GitHub
airborne12 commented on code in PR #41625: URL: https://github.com/apache/doris/pull/41625#discussion_r1794494501 ## be/src/olap/rowset/segment_creator.cpp: ## @@ -245,17 +252,16 @@ Status SegmentFlusher::_flush_segment_writer( uint32_t segment_id = writer->segment_id();

Re: [I] [Bug] Error when executing executeBatch() after performing batch updates in Doris [doris]

2024-10-09 Thread via GitHub
dataroaring closed issue #35980: [Bug] Error when executing executeBatch() after performing batch updates in Doris URL: https://github.com/apache/doris/issues/35980 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] [Bug] Error when executing executeBatch() after performing batch updates in Doris [doris]

2024-10-09 Thread via GitHub
dataroaring closed issue #35980: [Bug] Error when executing executeBatch() after performing batch updates in Doris URL: https://github.com/apache/doris/issues/35980 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

(doris) branch master updated (7229aeac549 -> 0d2550f3f82)

2024-10-09 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 7229aeac549 [refactor](wg&memtracker) using weak ptr to delete memtracker and query context automatically (#41549)

(doris) branch master updated: [fix](jdbc) fix Unknown command(27) (#41621)

2024-10-09 Thread dataroaring
This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 469f04ed4ec [fix](jdbc) fix Unknown command(

Re: [PR] [Feature](partial update) Support flexible partial update in stream load with json files [doris]

2024-10-09 Thread via GitHub
dataroaring merged PR #39756: URL: https://github.com/apache/doris/pull/39756 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

Re: [PR] [fix](pipeline) Stop execution if task is finished [doris]

2024-10-09 Thread via GitHub
github-actions[bot] commented on PR #41628: URL: https://github.com/apache/doris/pull/41628#issuecomment-2403788253 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Opt](load) Optimize the error messages of -235 and -238 for loading #41048 [doris]

2024-10-09 Thread via GitHub
doris-robot commented on PR #41645: URL: https://github.com/apache/doris/pull/41645#issuecomment-2403943406 TPC-H: Total hot run time: 48815 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](is_exclusive) fix is_exlusive func for nested types [doris]

2024-10-09 Thread via GitHub
github-actions[bot] commented on code in PR #41646: URL: https://github.com/apache/doris/pull/41646#discussion_r1794615699 ## be/src/vec/columns/column_struct.h: ## @@ -89,6 +89,15 @@ class ColumnStruct final : public COWHelper { MutableColumnPtr clone_resized(size_t size)

Re: [PR] [Refactor](exec) refactor schema scanner del unless code [doris]

2024-10-09 Thread via GitHub
github-actions[bot] commented on PR #41540: URL: https://github.com/apache/doris/pull/41540#issuecomment-2403970505 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [improve](txn insert) make sub transactions visible [doris]

2024-10-09 Thread via GitHub
morrySnow commented on code in PR #41362: URL: https://github.com/apache/doris/pull/41362#discussion_r1794613107 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PruneEmptyPartition.java: ## @@ -18,30 +18,59 @@ package org.apache.doris.nereids.rules.rewrite;

Re: [PR] [Opt](load) Optimize the error messages of -235 and -238 for loading #41048 [doris]

2024-10-09 Thread via GitHub
doris-robot commented on PR #41645: URL: https://github.com/apache/doris/pull/41645#issuecomment-2403980268 TPC-DS: Total hot run time: 211929 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Opt](load) Optimize the error messages of -235 and -238 for loading #41048 [doris]

2024-10-09 Thread via GitHub
doris-robot commented on PR #41645: URL: https://github.com/apache/doris/pull/41645#issuecomment-2403985425 ClickBench: Total hot run time: 30.89 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Opt](load) Optimize the error messages of -235 and -238 for loading #41048 [doris]

2024-10-09 Thread via GitHub
doris-robot commented on PR #41645: URL: https://github.com/apache/doris/pull/41645#issuecomment-2403992306 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 41e93af2cff17875c7e0695aa34eadddc10939fa with default session variables Stream

Re: [PR] [fix](counters) fix MemoryUsage and PeakMemoryUsage counters of some operators [doris]

2024-10-09 Thread via GitHub
yiguolei commented on code in PR #41602: URL: https://github.com/apache/doris/pull/41602#discussion_r1794649212 ## be/src/pipeline/exec/aggregation_sink_operator.cpp: ## @@ -423,11 +416,10 @@ Status AggSinkLocalState::_merge_without_key(vectorized::Block* block) { } void Ag

Re: [PR] [Fix]count tablet meta's static memory load from disk [doris]

2024-10-09 Thread via GitHub
wangbo commented on PR #41429: URL: https://github.com/apache/doris/pull/41429#issuecomment-2404009925 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [fix](counters) fix MemoryUsage and PeakMemoryUsage counters of some operators [doris]

2024-10-09 Thread via GitHub
yiguolei commented on code in PR #41602: URL: https://github.com/apache/doris/pull/41602#discussion_r1794649889 ## be/src/pipeline/exec/aggregation_sink_operator.h: ## @@ -109,7 +109,7 @@ class AggSinkLocalState : public PipelineXSinkLocalState { RuntimeProfile::Counter* _

Re: [PR] [fix](counters) fix MemoryUsage and PeakMemoryUsage counters of some operators [doris]

2024-10-09 Thread via GitHub
yiguolei commented on code in PR #41602: URL: https://github.com/apache/doris/pull/41602#discussion_r1794652247 ## be/src/pipeline/exec/exchange_sink_operator.cpp: ## @@ -458,8 +455,11 @@ Status ExchangeSinkOperatorX::sink(RuntimeState* state, vectorized::Block* block

Re: [PR] [Fix]count tablet meta's static memory load from disk [doris]

2024-10-09 Thread via GitHub
github-actions[bot] commented on code in PR #41429: URL: https://github.com/apache/doris/pull/41429#discussion_r1794653385 ## be/src/olap/metadata_adder.h: ## @@ -0,0 +1,143 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreeme

Re: [PR] [fix](counters) fix MemoryUsage and PeakMemoryUsage counters of some operators [doris]

2024-10-09 Thread via GitHub
yiguolei commented on code in PR #41602: URL: https://github.com/apache/doris/pull/41602#discussion_r1794653854 ## be/src/pipeline/exec/operator.cpp: ## @@ -345,9 +345,8 @@ void PipelineXLocalStateBase::reached_limit(vectorized::Block* block, bool* eos) }); if (auto

Re: [PR] [Refactor] (inverted index) Refactor Inverted index file writer [doris]

2024-10-09 Thread via GitHub
doris-robot commented on PR #41625: URL: https://github.com/apache/doris/pull/41625#issuecomment-2403662027 TPC-H: Total hot run time: 40815 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](schema change)support schema change operation between IPv4/IPv6 and VARCHAR/STRING/TEXT [doris]

2024-10-09 Thread via GitHub
github-actions[bot] closed pull request #32513: [fix](schema change)support schema change operation between IPv4/IPv6 and VARCHAR/STRING/TEXT URL: https://github.com/apache/doris/pull/32513 -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] [fix](es-catalog) Add support for IPv6 resolution in publish_address [doris]

2024-10-09 Thread via GitHub
github-actions[bot] closed pull request #31898: [fix](es-catalog) Add support for IPv6 resolution in publish_address URL: https://github.com/apache/doris/pull/31898 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](counters) fix MemoryUsage and PeakMemoryUsage counters of some operators [doris]

2024-10-09 Thread via GitHub
yiguolei commented on code in PR #41602: URL: https://github.com/apache/doris/pull/41602#discussion_r1794655517 ## be/src/pipeline/exec/partitioned_hash_join_sink_operator.cpp: ## @@ -161,7 +161,7 @@ Status PartitionedHashJoinSinkLocalState::_revoke_unpartitioned_block(RuntimeS

Re: [PR] [fix](counters) fix MemoryUsage and PeakMemoryUsage counters of some operators [doris]

2024-10-09 Thread via GitHub
yiguolei commented on code in PR #41602: URL: https://github.com/apache/doris/pull/41602#discussion_r1794655167 ## be/src/pipeline/exec/aggregation_source_operator.cpp: ## @@ -460,18 +460,16 @@ void AggLocalState::do_agg_limit(vectorized::Block* block, bool* eos) { if

Re: [PR] [Refactor] (inverted index) Refactor Inverted index file writer [doris]

2024-10-09 Thread via GitHub
doris-robot commented on PR #41625: URL: https://github.com/apache/doris/pull/41625#issuecomment-240405 TeamCity be ut coverage result: Function Coverage: 37.24% (9645/25900) Line Coverage: 28.54% (79930/280078) Region Coverage: 27.99% (41344/147721) Branch Coverage: 24.6

Re: [PR] [fix](pipelinex) fix fragment instance progress reports (part 2) (#40694) [doris]

2024-10-09 Thread via GitHub
doris-robot commented on PR #41641: URL: https://github.com/apache/doris/pull/41641#issuecomment-2404039583 TeamCity be ut coverage result: Function Coverage: 36.09% (9339/25877) Line Coverage: 27.66% (76722/277347) Region Coverage: 26.44% (39371/148895) Branch Coverage: 23.2

Re: [PR] [bugfix](segmentload) should remove segment from segment cache if load segment failed [doris]

2024-10-09 Thread via GitHub
doris-robot commented on PR #41608: URL: https://github.com/apache/doris/pull/41608#issuecomment-2404042445 TeamCity be ut coverage result: Function Coverage: 37.24% (9643/25893) Line Coverage: 28.56% (79991/280122) Region Coverage: 27.98% (41344/147751) Branch Coverage: 24.6

Re: [PR] [fix](is_exclusive) fix is_exlusive func for nested types [doris]

2024-10-09 Thread via GitHub
doris-robot commented on PR #41646: URL: https://github.com/apache/doris/pull/41646#issuecomment-2404055187 TeamCity be ut coverage result: Function Coverage: 37.81% (8148/21549) Line Coverage: 29.55% (67076/226974) Region Coverage: 29.02% (34578/119140) Branch Coverage: 24.9

<    2   3   4   5   6   7