Re: [PR] [feat](nereids) support Iceberg time travel syntax [doris]

2024-05-17 Thread via GitHub
wuwenchi commented on code in PR #34681: URL: https://github.com/apache/doris/pull/34681#discussion_r1604433431 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/BindRelation.java: ## @@ -273,6 +273,7 @@ private LogicalPlan getLogicalPlan(TableIf table, Unboun

Re: [PR] [enhancement](delete) print all debug mode session variables on error [doris]

2024-05-17 Thread via GitHub
zhannngchen commented on PR #35006: URL: https://github.com/apache/doris/pull/35006#issuecomment-2116887058 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [feat](Nereids): lazy get expression map when comparing hypergraph [doris]

2024-05-17 Thread via GitHub
morrySnow commented on PR #34753: URL: https://github.com/apache/doris/pull/34753#issuecomment-2116889555 run performance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [enhancement](delete) print all debug mode session variables on error [doris]

2024-05-17 Thread via GitHub
gavinchou commented on code in PR #35006: URL: https://github.com/apache/doris/pull/35006#discussion_r160866 ## fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java: ## @@ -2046,6 +2046,33 @@ public boolean isInDebugMode() { return showHiddenColumns ||

Re: [PR] [feat](Nereids): lazy get expression map when comparing hypergraph [doris]

2024-05-17 Thread via GitHub
github-actions[bot] commented on PR #34753: URL: https://github.com/apache/doris/pull/34753#issuecomment-2116891586 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [feat](Nereids): lazy get expression map when comparing hypergraph [doris]

2024-05-17 Thread via GitHub
morrySnow merged PR #34753: URL: https://github.com/apache/doris/pull/34753 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

(doris) branch master updated (d796c43bb60 -> 5a2a0132c48)

2024-05-17 Thread morrysnow
This is an automated email from the ASF dual-hosted git repository. morrysnow pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from d796c43bb60 [Improve](inverted index) improve performance by introducing bulk contains for bitmap in _build_index_r

Re: [PR] [improvement](mtmv) Add threshold for relation mapping num when query rewrite [doris]

2024-05-17 Thread via GitHub
morrySnow commented on PR #34694: URL: https://github.com/apache/doris/pull/34694#issuecomment-2116896904 run performance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [improvement](mtmv) Add threshold for relation mapping num when query rewrite [doris]

2024-05-17 Thread via GitHub
github-actions[bot] commented on PR #34694: URL: https://github.com/apache/doris/pull/34694#issuecomment-2116897351 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [improvement](mtmv) Add threshold for relation mapping num when query rewrite [doris]

2024-05-17 Thread via GitHub
github-actions[bot] commented on PR #34694: URL: https://github.com/apache/doris/pull/34694#issuecomment-2116897305 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [enhancement](delete) print all debug mode session variables on error [doris]

2024-05-17 Thread via GitHub
zhannngchen commented on code in PR #35006: URL: https://github.com/apache/doris/pull/35006#discussion_r1604453198 ## fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java: ## @@ -2046,6 +2046,33 @@ public boolean isInDebugMode() { return showHiddenColumns |

Re: [PR] [improvement](mtmv) Add threshold for relation mapping num when query rewrite [doris]

2024-05-17 Thread via GitHub
morrySnow merged PR #34694: URL: https://github.com/apache/doris/pull/34694 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

(doris) branch master updated (5a2a0132c48 -> 21c35791337)

2024-05-17 Thread morrysnow
This is an automated email from the ASF dual-hosted git repository. morrysnow pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 5a2a0132c48 [opt](nereids) lazy get expression map when comparing hypergraph (#34753) add 21c35791337 [opt](m

Re: [PR] [test](regression) add cases for data quality error url [doris]

2024-05-17 Thread via GitHub
github-actions[bot] commented on PR #34987: URL: https://github.com/apache/doris/pull/34987#issuecomment-2116908766 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [opt](log)password should not be output in log [doris]

2024-05-17 Thread via GitHub
390008457 commented on PR #34324: URL: https://github.com/apache/doris/pull/34324#issuecomment-2116909328 run beut: BE UT -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](load) fix error due to jsonpaths resolution results [doris]

2024-05-17 Thread via GitHub
felixwluo commented on PR #34941: URL: https://github.com/apache/doris/pull/34941#issuecomment-2116913538 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-17 Thread via GitHub
gavinchou commented on code in PR #34384: URL: https://github.com/apache/doris/pull/34384#discussion_r1604462412 ## fe/fe-core/src/main/java/org/apache/doris/tablefunction/MetadataGenerator.java: ## @@ -873,4 +892,75 @@ private static TFetchSchemaTableDataResult routineInfoMeta

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-17 Thread via GitHub
gavinchou commented on code in PR #34384: URL: https://github.com/apache/doris/pull/34384#discussion_r1604463773 ## fe/fe-core/src/main/java/org/apache/doris/tablefunction/MetadataGenerator.java: ## @@ -873,4 +892,75 @@ private static TFetchSchemaTableDataResult routineInfoMeta

Re: [PR] [refactor](datalake) return the error status instead of static_cast [doris]

2024-05-17 Thread via GitHub
github-actions[bot] commented on PR #34873: URL: https://github.com/apache/doris/pull/34873#issuecomment-2116918665 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [opt](log)password should not be output in log [doris]

2024-05-17 Thread via GitHub
github-actions[bot] commented on PR #34324: URL: https://github.com/apache/doris/pull/34324#issuecomment-2116919107 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](Nereids): add project for joinreorder [doris]

2024-05-17 Thread via GitHub
jackwener commented on PR #34993: URL: https://github.com/apache/doris/pull/34993#issuecomment-2116919671 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-17 Thread via GitHub
gavinchou commented on code in PR #34384: URL: https://github.com/apache/doris/pull/34384#discussion_r1604470422 ## be/src/exec/schema_scanner/schema_table_options_scanner.cpp: ## @@ -0,0 +1,134 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contri

Re: [PR] [Fix](bloom filter) Fix bloom filter memory leak [doris]

2024-05-17 Thread via GitHub
Yukang-Lian commented on PR #34871: URL: https://github.com/apache/doris/pull/34871#issuecomment-2116929775 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [enhancement](plsql) improve exception message [doris]

2024-05-17 Thread via GitHub
xinyiZzz commented on PR #34452: URL: https://github.com/apache/doris/pull/34452#issuecomment-2116929929 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [chore] rename method name and improve logging and comments [doris]

2024-05-17 Thread via GitHub
xinyiZzz commented on PR #34321: URL: https://github.com/apache/doris/pull/34321#issuecomment-2116930518 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [Fix](bloom filter) Fix bloom filter memory leak [doris]

2024-05-17 Thread via GitHub
github-actions[bot] commented on PR #34871: URL: https://github.com/apache/doris/pull/34871#issuecomment-2116937736 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](planner) fix unrequired slot bug when join node introduced by #25204 [doris]

2024-05-17 Thread via GitHub
github-actions[bot] commented on PR #34923: URL: https://github.com/apache/doris/pull/34923#issuecomment-2116939379 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](planner) fix unrequired slot bug when join node introduced by #25204 [doris]

2024-05-17 Thread via GitHub
github-actions[bot] commented on PR #34923: URL: https://github.com/apache/doris/pull/34923#issuecomment-2116939426 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](planner) fix unrequired slot bug when join node introduced by #25204 [doris]

2024-05-17 Thread via GitHub
morrySnow commented on PR #34923: URL: https://github.com/apache/doris/pull/34923#issuecomment-2116939595 could desc the detail of bug? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] [chore](log) remove redundant log in segment.cpp [doris]

2024-05-17 Thread via GitHub
doris-robot commented on PR #35008: URL: https://github.com/apache/doris/pull/35008#issuecomment-2116941815 TeamCity be ut coverage result: Function Coverage: 37.78% (8074/21369) Line Coverage: 29.44% (65927/223904) Region Coverage: 28.91% (33937/117386) Branch Coverage: 24.7

Re: [PR] [chore](thrift exception) do not log message in thrift exception [doris]

2024-05-17 Thread via GitHub
github-actions[bot] commented on PR #34994: URL: https://github.com/apache/doris/pull/34994#issuecomment-2116941758 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](default value): enable HLL_EMPTY_DEFAULT_VALUE [doris]

2024-05-17 Thread via GitHub
Yukang-Lian commented on PR #34447: URL: https://github.com/apache/doris/pull/34447#issuecomment-2116942700 run performance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [feature](iceberg)support iceberg insert grammar [doris]

2024-05-17 Thread via GitHub
wuwenchi commented on PR #34257: URL: https://github.com/apache/doris/pull/34257#issuecomment-2116946481 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [chore](thrift exception) do not log message in thrift exception [doris]

2024-05-17 Thread via GitHub
dataroaring merged PR #34994: URL: https://github.com/apache/doris/pull/34994 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

Re: [PR] [chore](thrift exception) do not log message in thrift exception [doris]

2024-05-17 Thread via GitHub
github-actions[bot] commented on PR #34994: URL: https://github.com/apache/doris/pull/34994#issuecomment-2116946869 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

(doris) branch master updated: [chore](thrift exception) do not log message in thrift exception (#34994)

2024-05-17 Thread dataroaring
This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 7a6c0b1b478 [chore](thrift exception) do not

Re: [PR] [enhancement](delete) print all debug mode session variables on error [doris]

2024-05-17 Thread via GitHub
github-actions[bot] commented on PR #35006: URL: https://github.com/apache/doris/pull/35006#issuecomment-2116948814 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [enhancement](delete) print all debug mode session variables on error [doris]

2024-05-17 Thread via GitHub
github-actions[bot] commented on PR #35006: URL: https://github.com/apache/doris/pull/35006#issuecomment-2116948866 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](jdbc_catalog) fix error datetime literal caused be core [doris]

2024-05-17 Thread via GitHub
Yulei-Yang commented on PR #34977: URL: https://github.com/apache/doris/pull/34977#issuecomment-2116949961 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [improve](exchange) the sink could eos early when all queues have enough rows [doris]

2024-05-17 Thread via GitHub
zhangstar333 commented on PR #34541: URL: https://github.com/apache/doris/pull/34541#issuecomment-2116950404 run performance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[I] [Bug] couldn't resolve slot descriptor when join [doris]

2024-05-17 Thread via GitHub
nextdreamblue opened a new issue, #35009: URL: https://github.com/apache/doris/issues/35009 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version master ###

Re: [PR] [feature](iceberg)support iceberg insert grammar [doris]

2024-05-17 Thread via GitHub
github-actions[bot] commented on PR #34257: URL: https://github.com/apache/doris/pull/34257#issuecomment-2116952422 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [atomicstatus](be) add atomic status to share state between multi thread [doris]

2024-05-17 Thread via GitHub
yiguolei commented on PR #35002: URL: https://github.com/apache/doris/pull/35002#issuecomment-2116953504 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [exceptionsafe](be) only throw exception in get block and sink method , since open and prepare maybe not exception safe [doris]

2024-05-17 Thread via GitHub
yiguolei commented on PR #34998: URL: https://github.com/apache/doris/pull/34998#issuecomment-2116954610 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [test](regression) add cases for data quality error url [doris]

2024-05-17 Thread via GitHub
kaijchen commented on PR #34987: URL: https://github.com/apache/doris/pull/34987#issuecomment-2116960665 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[PR] [feature](tools) embed async profiler to help user generate flame graph for frontend [doris]

2024-05-17 Thread via GitHub
924060929 opened a new pull request, #35010: URL: https://github.com/apache/doris/pull/35010 ## Proposed changes embed async profiler to help user generate flame graph for frontend There has a script file `${FE_DEPLOY_PATH}/bin/profile_fe.sh` do the profile: This is the e

Re: [PR] [feature](tools) embed async profiler to help user generate flame graph for frontend [doris]

2024-05-17 Thread via GitHub
doris-robot commented on PR #35010: URL: https://github.com/apache/doris/pull/35010#issuecomment-2116962114 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [feature](tools) embed async profiler to help user generate flame graph for frontend [doris]

2024-05-17 Thread via GitHub
github-actions[bot] commented on PR #35010: URL: https://github.com/apache/doris/pull/35010#issuecomment-2116963200 `sh-checker report` To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/9124837824";) output. shellcheck err

Re: [PR] [feature](tools) embed async profiler to help user generate flame graph for frontend [doris]

2024-05-17 Thread via GitHub
morrySnow commented on code in PR #35010: URL: https://github.com/apache/doris/pull/35010#discussion_r1604509072 ## fe/fe-core/pom.xml: ## @@ -783,6 +783,11 @@ under the License. io.airlift concurrent + +me.bechberger +

Re: [PR] [test](regression) add cases for data quality error url [doris]

2024-05-17 Thread via GitHub
github-actions[bot] commented on PR #34987: URL: https://github.com/apache/doris/pull/34987#issuecomment-2116967527 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Improvement](hive view) support inner name like _c0,_c1 for derived column in inline view for hive view [doris]

2024-05-17 Thread via GitHub
Yulei-Yang commented on code in PR #33193: URL: https://github.com/apache/doris/pull/33193#discussion_r1604511918 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/BindRelation.java: ## @@ -328,13 +333,57 @@ private Plan parseAndAnalyzeHiveView( return

Re: [PR] [fix](move-memtable) fix nullptr and token num in TabletStream::close [doris]

2024-05-17 Thread via GitHub
kaijchen commented on PR #34485: URL: https://github.com/apache/doris/pull/34485#issuecomment-2116971771 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](statistics)Cast min/max in partition stats table to double for numeric column to get correct table level min/max value. [doris]

2024-05-17 Thread via GitHub
Jibing-Li commented on PR #34919: URL: https://github.com/apache/doris/pull/34919#issuecomment-2116973586 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [fix](planner) fix unrequired slot bug when join node introduced by #25204 [doris]

2024-05-17 Thread via GitHub
nextdreamblue commented on PR #34923: URL: https://github.com/apache/doris/pull/34923#issuecomment-2116972940 > could desc the detail of bug? add a issue for it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] [feat](Nereids): Refactor `Eliminate_Group_By_Key` by functional dependencies [doris]

2024-05-17 Thread via GitHub
XieJiann commented on PR #34948: URL: https://github.com/apache/doris/pull/34948#issuecomment-2116977553 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [bug](Fe) fix potential deadlock in show proc statement [doris]

2024-05-17 Thread via GitHub
lide-reed commented on PR #34988: URL: https://github.com/apache/doris/pull/34988#issuecomment-2116979110 It's said that java.util.concurrent.ForkJoinPool may degrade performance. Please confirm whether the changes here involve high-frequency operations. -- This is an automated message fr

Re: [PR] [fix](load) fix error due to jsonpaths resolution results [doris]

2024-05-17 Thread via GitHub
felixwluo commented on PR #34941: URL: https://github.com/apache/doris/pull/34941#issuecomment-2116979740 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [fix](move-memtable) fix nullptr and token num in TabletStream::close [doris]

2024-05-17 Thread via GitHub
github-actions[bot] commented on PR #34485: URL: https://github.com/apache/doris/pull/34485#issuecomment-2116980700 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Opt](Iceberg) handle count pushdown in fe side [doris]

2024-05-17 Thread via GitHub
morrySnow merged PR #34928: URL: https://github.com/apache/doris/pull/34928 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

(doris) branch master updated (7a6c0b1b478 -> e4df4b437ed)

2024-05-17 Thread morrysnow
This is an automated email from the ASF dual-hosted git repository. morrysnow pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 7a6c0b1b478 [chore](thrift exception) do not log message in thrift exception (#34994) add e4df4b437ed [Opt](Ic

Re: [PR] [bugfix](hive)fix testcase for viewfs [doris]

2024-05-17 Thread via GitHub
morningman merged PR #34790: URL: https://github.com/apache/doris/pull/34790 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.a

(doris) branch master updated: [bugfix](hive)fix testcase for viewfs (#34790)

2024-05-17 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 813a6977b7b [bugfix](hive)fix testcase for vi

Re: [PR] [improve](http action) add http interface to calculate the crc of all files in tablet [doris]

2024-05-17 Thread via GitHub
airborne12 commented on code in PR #34915: URL: https://github.com/apache/doris/pull/34915#discussion_r1604522885 ## be/src/olap/tablet.h: ## @@ -476,6 +476,8 @@ class Tablet final : public BaseTablet { } inline bool is_full_compaction_running() const { return _is_ful

Re: [PR] [fix](default value): enable HLL_EMPTY_DEFAULT_VALUE [doris]

2024-05-17 Thread via GitHub
github-actions[bot] commented on PR #34447: URL: https://github.com/apache/doris/pull/34447#issuecomment-2116985660 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](snappy) fix error when reading empty snappy file [doris]

2024-05-17 Thread via GitHub
morningman closed pull request #34828: [fix](snappy) fix error when reading empty snappy file URL: https://github.com/apache/doris/pull/34828 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] [fix](default value): enable HLL_EMPTY_DEFAULT_VALUE [doris]

2024-05-17 Thread via GitHub
morrySnow merged PR #34447: URL: https://github.com/apache/doris/pull/34447 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

(doris) branch master updated: [fix](default value) enable HLL_EMPTY_DEFAULT_VALUE (#34447)

2024-05-17 Thread morrysnow
This is an automated email from the ASF dual-hosted git repository. morrysnow pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 6b50368d384 [fix](default value) enable HLL_EM

[PR] [fix](agg) fix DCHECK failure of agg when failed to alloc memory [doris]

2024-05-17 Thread via GitHub
jacktengg opened a new pull request, #35011: URL: https://github.com/apache/doris/pull/35011 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailt

Re: [PR] [fix](agg) fix DCHECK failure of agg when failed to alloc memory [doris]

2024-05-17 Thread via GitHub
jacktengg commented on PR #35011: URL: https://github.com/apache/doris/pull/35011#issuecomment-2116987609 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [fix](agg) fix DCHECK failure of agg when failed to alloc memory [doris]

2024-05-17 Thread via GitHub
doris-robot commented on PR #35011: URL: https://github.com/apache/doris/pull/35011#issuecomment-2116987447 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [fix](move-memtable) fix nullptr and token num in TabletStream::close [doris]

2024-05-17 Thread via GitHub
liaoxin01 commented on code in PR #34485: URL: https://github.com/apache/doris/pull/34485#discussion_r1604526302 ## be/src/runtime/load_stream.cpp: ## @@ -226,7 +226,9 @@ Status TabletStream::close() { auto wait_func = [this, &mu, &cv] { signal::set_signal_task_id(

[PR] [Configurations](multi-catalog) Add `enable_parquet_filter_by_min_max` and `enable_orc_filter_by_min_max` Session variables. [doris]

2024-05-17 Thread via GitHub
kaka11chen opened a new pull request, #35012: URL: https://github.com/apache/doris/pull/35012 ## Proposed changes [Configurations] (multi-catalog) Add `enable_parquet_filter_by_min_max` and `enable_orc_filter_by_min_max` Session variables for workaround. ## Further comments

Re: [PR] [opt](fe) exit FE when transfer to (non)master failed [doris]

2024-05-17 Thread via GitHub
morningman commented on PR #34809: URL: https://github.com/apache/doris/pull/34809#issuecomment-2116991018 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [Configurations](multi-catalog) Add `enable_parquet_filter_by_min_max` and `enable_orc_filter_by_min_max` Session variables. [doris]

2024-05-17 Thread via GitHub
doris-robot commented on PR #35012: URL: https://github.com/apache/doris/pull/35012#issuecomment-2116989875 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [tmp] add debug log [doris]

2024-05-17 Thread via GitHub
morningman closed pull request #34723: [tmp] add debug log URL: https://github.com/apache/doris/pull/34723 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

Re: [PR] [fix](agg) fix DCHECK failure of agg when failed to alloc memory [doris]

2024-05-17 Thread via GitHub
github-actions[bot] commented on PR #35011: URL: https://github.com/apache/doris/pull/35011#issuecomment-2116998946 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Configurations](multi-catalog) Add `enable_parquet_filter_by_min_max` and `enable_orc_filter_by_min_max` Session variables. [doris]

2024-05-17 Thread via GitHub
kaka11chen commented on PR #35012: URL: https://github.com/apache/doris/pull/35012#issuecomment-2116999705 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [conf](pipeline) Disable non-pipeline engine [doris]

2024-05-17 Thread via GitHub
doris-robot commented on PR #34812: URL: https://github.com/apache/doris/pull/34812#issuecomment-2117000245 TeamCity be ut coverage result: Function Coverage: 35.70% (9006/25226) Line Coverage: 27.37% (74525/272265) Region Coverage: 26.61% (38533/144780) Branch Coverage: 23.4

Re: [PR] [Configurations](multi-catalog) Add `enable_parquet_filter_by_min_max` and `enable_orc_filter_by_min_max` Session variables. [doris]

2024-05-17 Thread via GitHub
github-actions[bot] commented on code in PR #35012: URL: https://github.com/apache/doris/pull/35012#discussion_r1604534174 ## be/src/vec/exec/format/orc/vorc_reader.cpp: ## @@ -169,6 +170,7 @@ OrcReader::OrcReader(const TFileScanRangeParams& params, const TFileRangeDesc& r

Re: [PR] [opt](fe) exit FE when transfer to (non)master failed [doris]

2024-05-17 Thread via GitHub
github-actions[bot] commented on PR #34809: URL: https://github.com/apache/doris/pull/34809#issuecomment-2117002238 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Refactor](Variant) refactor flush logic to support partial update [doris]

2024-05-17 Thread via GitHub
doris-robot commented on PR #34925: URL: https://github.com/apache/doris/pull/34925#issuecomment-2117004308 TeamCity be ut coverage result: Function Coverage: 35.70% (9009/25234) Line Coverage: 27.37% (74547/272374) Region Coverage: 26.61% (38546/144833) Branch Coverage: 23.4

Re: [PR] [feature](tools) embed async profiler to help user generate flame graph for frontend [doris]

2024-05-17 Thread via GitHub
github-actions[bot] commented on PR #35010: URL: https://github.com/apache/doris/pull/35010#issuecomment-2117005245 `sh-checker report` To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/9125154944";) output. shellcheck err

[PR] [update](hudi) update hudi-spark bundle to 3.4.3 [doris]

2024-05-17 Thread via GitHub
AshinGau opened a new pull request, #35013: URL: https://github.com/apache/doris/pull/35013 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto

Re: [PR] [update](hudi) update hudi-spark bundle to 3.4.3 [doris]

2024-05-17 Thread via GitHub
doris-robot commented on PR #35013: URL: https://github.com/apache/doris/pull/35013#issuecomment-2117008399 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [feature](tools) embed async profiler to help user generate flame graph for frontend [doris]

2024-05-17 Thread via GitHub
github-actions[bot] commented on PR #35010: URL: https://github.com/apache/doris/pull/35010#issuecomment-2117009604 `sh-checker report` To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/9125189874";) output. shellcheck err

Re: [PR] [fix](statistics)Cast min/max in partition stats table to double for numeric column to get correct table level min/max value. [doris]

2024-05-17 Thread via GitHub
github-actions[bot] commented on PR #34919: URL: https://github.com/apache/doris/pull/34919#issuecomment-2117010550 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](hive-ctas) allow use qualified name when create hive table [doris]

2024-05-17 Thread via GitHub
morrySnow commented on PR #34984: URL: https://github.com/apache/doris/pull/34984#issuecomment-2117011064 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[PR] [opt](memory) In Debug compile, QueryMemTracker not equal to 0 will crash at query end [doris]

2024-05-17 Thread via GitHub
xinyiZzz opened a new pull request, #35014: URL: https://github.com/apache/doris/pull/35014 ## Proposed changes to eliminate query memory leaks !!! ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mai

Re: [PR] [opt](memory) In Debug compile, QueryMemTracker not equal to 0 will crash at query end [doris]

2024-05-17 Thread via GitHub
doris-robot commented on PR #35014: URL: https://github.com/apache/doris/pull/35014#issuecomment-2117011779 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [opt](memory) In Debug compile, QueryMemTracker not equal to 0 will crash at query end [doris]

2024-05-17 Thread via GitHub
xinyiZzz commented on PR #35014: URL: https://github.com/apache/doris/pull/35014#issuecomment-2117011984 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [opt](nereids)new way to set pre-agg status [doris]

2024-05-17 Thread via GitHub
github-actions[bot] commented on PR #34738: URL: https://github.com/apache/doris/pull/34738#issuecomment-2117015246 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [opt](nereids)new way to set pre-agg status [doris]

2024-05-17 Thread via GitHub
github-actions[bot] commented on PR #34738: URL: https://github.com/apache/doris/pull/34738#issuecomment-2117015320 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [opt](memory) In Debug compile, QueryMemTracker not equal to 0 will crash at query end [doris]

2024-05-17 Thread via GitHub
github-actions[bot] commented on PR #35014: URL: https://github.com/apache/doris/pull/35014#issuecomment-2117021184 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](move-memtable) fix nullptr and token num in TabletStream::close [doris]

2024-05-17 Thread via GitHub
kaijchen commented on PR #34485: URL: https://github.com/apache/doris/pull/34485#issuecomment-2117021543 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [refactor](datalake) return the error status instead of static_cast [doris]

2024-05-17 Thread via GitHub
AshinGau commented on PR #34873: URL: https://github.com/apache/doris/pull/34873#issuecomment-2117024949 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](statistics)Cast min/max in partition stats table to double for numeric column to get correct table level min/max value. [doris]

2024-05-17 Thread via GitHub
Jibing-Li commented on PR #34919: URL: https://github.com/apache/doris/pull/34919#issuecomment-2117025208 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [fix](load) fix error due to jsonpaths resolution results [doris]

2024-05-17 Thread via GitHub
doris-robot commented on PR #34941: URL: https://github.com/apache/doris/pull/34941#issuecomment-2117028771 TeamCity be ut coverage result: Function Coverage: 35.70% (9005/25226) Line Coverage: 27.37% (74529/272266) Region Coverage: 26.62% (38548/144804) Branch Coverage: 23.4

Re: [PR] [fix](move-memtable) fix nullptr and token num in TabletStream::close [doris]

2024-05-17 Thread via GitHub
github-actions[bot] commented on PR #34485: URL: https://github.com/apache/doris/pull/34485#issuecomment-2117030490 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [improve](http action) add http interface to calculate the crc of all files in tablet [doris]

2024-05-17 Thread via GitHub
csun5285 commented on code in PR #34915: URL: https://github.com/apache/doris/pull/34915#discussion_r1604558667 ## be/src/olap/tablet.h: ## @@ -476,6 +476,8 @@ class Tablet final : public BaseTablet { } inline bool is_full_compaction_running() const { return _is_full_

Re: [PR] [opt](fe) exit FE when transfer to (non)master failed [doris]

2024-05-17 Thread via GitHub
doris-robot commented on PR #34809: URL: https://github.com/apache/doris/pull/34809#issuecomment-2117034536 TeamCity be ut coverage result: Function Coverage: 35.69% (9004/25226) Line Coverage: 27.37% (74508/272237) Region Coverage: 26.60% (38516/144773) Branch Coverage: 23.4

  1   2   3   4   >