Re: [PR] [fix](group_commit) Wal reader should check block length to avoid reading empty block [doris]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #34792: URL: https://github.com/apache/doris/pull/34792#issuecomment-2109426309 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [Fix] Fix clang-18 and libc++ compile problems [doris]

2024-05-14 Thread via GitHub
doris-robot commented on PR #34715: URL: https://github.com/apache/doris/pull/34715#issuecomment-2109429452 TPC-DS: Total hot run time: 188104 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [opt](fe) exit FE when transfer to (non)master failed [doris]

2024-05-14 Thread via GitHub
doris-robot commented on PR #34809: URL: https://github.com/apache/doris/pull/34809#issuecomment-2109430953 TPC-H: Total hot run time: 41388 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [debug](thrift rpc) debug thrift rpc [doris]

2024-05-14 Thread via GitHub
doris-robot commented on PR #34813: URL: https://github.com/apache/doris/pull/34813#issuecomment-2109431089 TPC-H: Total hot run time: 41769 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

(doris) branch branch-2.1 updated (27d88b39834 -> 5ece07ab8c9)

2024-05-14 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a change to branch branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git discard 27d88b39834 [faultinjection](test) add some fault injection in pipeline task method new 5ece07ab8c9 [faulti

(doris) 01/01: [faultinjection](test) add some fault injection in pipeline task method

2024-05-14 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git commit 5ece07ab8c9ae4b1763aa792743a969579cb1529 Author: yiguolei AuthorDate: Tue May 14 14:51:51 2024 +0800 [faultinj

[PR] [chore](agg) check function's arguments count [doris]

2024-05-14 Thread via GitHub
mrhhsg opened a new pull request, #34822: URL: https://github.com/apache/doris/pull/34822 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d

Re: [PR] [chore](agg) check function's arguments count [doris]

2024-05-14 Thread via GitHub
doris-robot commented on PR #34822: URL: https://github.com/apache/doris/pull/34822#issuecomment-2109432787 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [chore](agg) check function's arguments count [doris]

2024-05-14 Thread via GitHub
mrhhsg commented on PR #34822: URL: https://github.com/apache/doris/pull/34822#issuecomment-2109432934 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [fix](Nereids): clone the producer plan and put logicalAnchor generated by `Or_Expansion` above `logicalSink` [doris]

2024-05-14 Thread via GitHub
yiguolei merged PR #34771: URL: https://github.com/apache/doris/pull/34771 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

(doris) branch master updated (82596e63bf1 -> 3a20f88af0d)

2024-05-14 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 82596e63bf1 [fix](iceberg) prevent coredump if read position delete file failed (#34797) add 3a20f88af0d [fix](

(doris) branch branch-2.1 updated: [fix](Nereids): clone the producer plan and put logicalAnchor generated by `Or_Expansion` above `logicalSink` (#34771)

2024-05-14 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/branch-2.1 by this push: new 0deb629d07a [fix](Nereids): clone the p

Re: [PR] [Fix] Fix clang-18 and libc++ compile problems [doris]

2024-05-14 Thread via GitHub
doris-robot commented on PR #34715: URL: https://github.com/apache/doris/pull/34715#issuecomment-2109437947 ClickBench: Total hot run time: 30.73 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Fix](function) money format [doris]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #34680: URL: https://github.com/apache/doris/pull/34680#issuecomment-2109439404 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Fix](function) money format [doris]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #34680: URL: https://github.com/apache/doris/pull/34680#issuecomment-2109439459 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [chore](agg) check function's arguments count [doris]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #34822: URL: https://github.com/apache/doris/pull/34822#issuecomment-2109441569 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] [opt](exec) opt const expr exec in set operator [doris]

2024-05-14 Thread via GitHub
HappenLee opened a new pull request, #34823: URL: https://github.com/apache/doris/pull/34823 ## Proposed changes before: ``` (select 0 from lineorder) intersect (select null); cost: 14s ``` after: ``` (select 0 from lineorder) intersect (select null);

Re: [PR] [opt](exec) opt const expr exec in set operator [doris]

2024-05-14 Thread via GitHub
doris-robot commented on PR #34823: URL: https://github.com/apache/doris/pull/34823#issuecomment-2109442344 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [opt](exec) opt const expr exec in set operator [doris]

2024-05-14 Thread via GitHub
HappenLee commented on PR #34823: URL: https://github.com/apache/doris/pull/34823#issuecomment-2109443232 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [fix][nereids] fix misunderstanding about bothSideShuffleKeysAreSameOrder [doris]

2024-05-14 Thread via GitHub
doris-robot commented on PR #34811: URL: https://github.com/apache/doris/pull/34811#issuecomment-2109448421 TPC-H: Total hot run time: 40909 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [opt](fe) exit FE when transfer to (non)master failed [doris]

2024-05-14 Thread via GitHub
doris-robot commented on PR #34809: URL: https://github.com/apache/doris/pull/34809#issuecomment-2109449219 TPC-DS: Total hot run time: 187386 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [debug](thrift rpc) debug thrift rpc [doris]

2024-05-14 Thread via GitHub
doris-robot commented on PR #34813: URL: https://github.com/apache/doris/pull/34813#issuecomment-2109449356 TPC-DS: Total hot run time: 188270 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Enhencement](trino-connector) The trino-connector catalog supports pushdown predicates to the connector [doris]

2024-05-14 Thread via GitHub
doris-robot commented on PR #34422: URL: https://github.com/apache/doris/pull/34422#issuecomment-2109449706 TPC-H: Total hot run time: 41202 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [enhancement](profile) Store profile on disk so that we can hold more profile in memory [doris]

2024-05-14 Thread via GitHub
doris-robot commented on PR #33690: URL: https://github.com/apache/doris/pull/33690#issuecomment-2109449753 TPC-H: Total hot run time: 41664 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [opt](exec) opt const expr exec in set operator [doris]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #34823: URL: https://github.com/apache/doris/pull/34823#issuecomment-2109450866 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix][nereids] fix misunderstanding about bothSideShuffleKeysAreSameO… [doris]

2024-05-14 Thread via GitHub
doris-robot commented on PR #34824: URL: https://github.com/apache/doris/pull/34824#issuecomment-2109452221 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [fix][nereids] fix misunderstanding about bothSideShuffleKeysAreSameO… [doris]

2024-05-14 Thread via GitHub
xzj7019 opened a new pull request, #34824: URL: https://github.com/apache/doris/pull/34824 ## Proposed changes Fix misunderstanding about bothSideShuffleKeysAreSameOrder, which originally should ensure the order of shuffle column lists. ## Further comments If this is a r

Re: [PR] [Bug](materialized-view) check groupby in agg-bottom-plan when rewrite agg query by mv [doris]

2024-05-14 Thread via GitHub
seawinde commented on PR #34274: URL: https://github.com/apache/doris/pull/34274#issuecomment-2109455365 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix][nereids] fix misunderstanding about bothSideShuffleKeysAreSameO… [doris]

2024-05-14 Thread via GitHub
yiguolei merged PR #34824: URL: https://github.com/apache/doris/pull/34824 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

(doris) branch branch-2.1 updated: [fix][nereids] fix misunderstanding about bothSideShuffleKeysAreSameOrder (#34824)

2024-05-14 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/branch-2.1 by this push: new 47f0a6734ba [fix][nereids] fix misunder

Re: [PR] [opt](fe) exit FE when transfer to (non)master failed [doris]

2024-05-14 Thread via GitHub
doris-robot commented on PR #34809: URL: https://github.com/apache/doris/pull/34809#issuecomment-2109458191 ClickBench: Total hot run time: 30.25 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [debug](thrift rpc) debug thrift rpc [doris]

2024-05-14 Thread via GitHub
doris-robot commented on PR #34813: URL: https://github.com/apache/doris/pull/34813#issuecomment-2109458375 ClickBench: Total hot run time: 30.51 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](SegComp) Don't call file writer close multi times for segcompaction [doris]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #34818: URL: https://github.com/apache/doris/pull/34818#issuecomment-2109460272 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [I] [Enhancement] Support starting with a number When creating a table [doris]

2024-05-14 Thread via GitHub
steveGuRen commented on issue #32425: URL: https://github.com/apache/doris/issues/32425#issuecomment-2109461649 我需要这个,有人知道怎么搞吗? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] [chore](agg) check function's arguments count [doris]

2024-05-14 Thread via GitHub
doris-robot commented on PR #34822: URL: https://github.com/apache/doris/pull/34822#issuecomment-2109462814 TPC-H: Total hot run time: 41829 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [ui](profile) Do not do profile format in the FE [doris]

2024-05-14 Thread via GitHub
HappenLee merged PR #34757: URL: https://github.com/apache/doris/pull/34757 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

(doris) branch master updated: [ui](profile) Do not do profile format in the FE (#34757)

2024-05-14 Thread lihaopeng
This is an automated email from the ASF dual-hosted git repository. lihaopeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 705ce9615a1 [ui](profile) Do not do profile fo

Re: [PR] [Improvement](pipeline) blocking tasks before putting in runnable queue [doris]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #34805: URL: https://github.com/apache/doris/pull/34805#issuecomment-2109464298 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Improvement](pipeline) blocking tasks before putting in runnable queue [doris]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #34805: URL: https://github.com/apache/doris/pull/34805#issuecomment-2109464339 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](decimal) Fix wrong result produced by decimal128 multiply [doris]

2024-05-14 Thread via GitHub
doris-robot commented on PR #34825: URL: https://github.com/apache/doris/pull/34825#issuecomment-2109467727 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [fix](decimal) Fix wrong result produced by decimal128 multiply [doris]

2024-05-14 Thread via GitHub
Gabriel39 opened a new pull request, #34825: URL: https://github.com/apache/doris/pull/34825 ## Proposed changes Now: ![image](https://github.com/apache/doris/assets/37700562/c3812365-6be2-4bdd-a91f-78b7ba5bc762) After fixing: ![image](https://github.com/apache/doris/ass

Re: [PR] [fix][nereids] fix misunderstanding about bothSideShuffleKeysAreSameOrder [doris]

2024-05-14 Thread via GitHub
doris-robot commented on PR #34811: URL: https://github.com/apache/doris/pull/34811#issuecomment-2109468329 TPC-DS: Total hot run time: 187381 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [enhancement](profile) Store profile on disk so that we can hold more profile in memory [doris]

2024-05-14 Thread via GitHub
doris-robot commented on PR #33690: URL: https://github.com/apache/doris/pull/33690#issuecomment-2109470486 TPC-DS: Total hot run time: 187486 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](decimal) Fix wrong result produced by decimal128 multiply [doris]

2024-05-14 Thread via GitHub
Gabriel39 commented on PR #34825: URL: https://github.com/apache/doris/pull/34825#issuecomment-2109468713 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[PR] [fix](nereids)4 phase agg may lost parameter in some case [doris]

2024-05-14 Thread via GitHub
starocean999 opened a new pull request, #34826: URL: https://github.com/apache/doris/pull/34826 ## Proposed changes pick from master https://github.com/apache/doris/pull/34816 ## Further comments If this is a relatively large or complex change, kick off the discus

Re: [PR] [fix](nereids)4 phase agg may lost parameter in some case [doris]

2024-05-14 Thread via GitHub
starocean999 commented on PR #34826: URL: https://github.com/apache/doris/pull/34826#issuecomment-2109469545 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](nereids)4 phase agg may lost parameter in some case [doris]

2024-05-14 Thread via GitHub
doris-robot commented on PR #34826: URL: https://github.com/apache/doris/pull/34826#issuecomment-2109469365 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [Enhencement](trino-connector) The trino-connector catalog supports pushdown predicates to the connector [doris]

2024-05-14 Thread via GitHub
doris-robot commented on PR #34422: URL: https://github.com/apache/doris/pull/34422#issuecomment-2109470412 TPC-DS: Total hot run time: 186911 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](decimal) Fix wrong result produced by decimal128 multiply [doris]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #34825: URL: https://github.com/apache/doris/pull/34825#issuecomment-2109476572 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](decimal) Fix wrong result produced by decimal128 multiply [doris]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #34825: URL: https://github.com/apache/doris/pull/34825#issuecomment-2109476635 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](decimal) Fix wrong result produced by decimal128 multiply [doris]

2024-05-14 Thread via GitHub
yiguolei commented on code in PR #34825: URL: https://github.com/apache/doris/pull/34825#discussion_r1599517312 ## be/src/vec/common/arithmetic_overflow.h: ## @@ -123,7 +123,7 @@ inline bool mul_overflow(__int128 x, __int128 y, __int128& res) { unsigned __int128 a = (x >

Re: [PR] [fix](decimal) Fix wrong result produced by decimal128 multiply [doris]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #34825: URL: https://github.com/apache/doris/pull/34825#issuecomment-2109478335 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [chore](agg) check function's arguments count [doris]

2024-05-14 Thread via GitHub
doris-robot commented on PR #34822: URL: https://github.com/apache/doris/pull/34822#issuecomment-2109478710 TeamCity be ut coverage result: Function Coverage: 35.67% (8981/25180) Line Coverage: 27.33% (74255/271743) Region Coverage: 26.56% (38366/144451) Branch Coverage: 23.3

Re: [PR] [fix][nereids] fix misunderstanding about bothSideShuffleKeysAreSameOrder [doris]

2024-05-14 Thread via GitHub
doris-robot commented on PR #34811: URL: https://github.com/apache/doris/pull/34811#issuecomment-2109478945 ClickBench: Total hot run time: 30.32 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Enhencement](trino-connector) The trino-connector catalog supports pushdown predicates to the connector [doris]

2024-05-14 Thread via GitHub
doris-robot commented on PR #34422: URL: https://github.com/apache/doris/pull/34422#issuecomment-2109480272 ClickBench: Total hot run time: 30.34 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [enhancement](profile) Store profile on disk so that we can hold more profile in memory [doris]

2024-05-14 Thread via GitHub
doris-robot commented on PR #33690: URL: https://github.com/apache/doris/pull/33690#issuecomment-2109480322 ClickBench: Total hot run time: 31.33 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Improvement](pipeline) blocking tasks before putting in runnable queue [doris]

2024-05-14 Thread via GitHub
yiguolei commented on code in PR #34805: URL: https://github.com/apache/doris/pull/34805#discussion_r1599522308 ## be/src/pipeline/dependency.h: ## @@ -84,24 +83,27 @@ struct BasicSharedState { Dependency* create_sink_dependency(int dest_id, int node_id, std::string name);

Re: [PR] [chore](agg) check function's arguments count [doris]

2024-05-14 Thread via GitHub
doris-robot commented on PR #34822: URL: https://github.com/apache/doris/pull/34822#issuecomment-2109484910 TPC-DS: Total hot run time: 188674 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](regression test)fix test_hive_parquet_alter_column p2 case. [doris]

2024-05-14 Thread via GitHub
morningman merged PR #34727: URL: https://github.com/apache/doris/pull/34727 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.a

(doris) branch master updated: [fix](regression test)fix test_hive_parquet_alter_column p2 case. (#34727)

2024-05-14 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new ad9c10e4873 [fix](regression test)fix test_hi

Re: [PR] [opt](exec) opt const expr exec in set operator [doris]

2024-05-14 Thread via GitHub
doris-robot commented on PR #34823: URL: https://github.com/apache/doris/pull/34823#issuecomment-2109490738 TPC-H: Total hot run time: 40873 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [chore](agg) check function's arguments count [doris]

2024-05-14 Thread via GitHub
doris-robot commented on PR #34822: URL: https://github.com/apache/doris/pull/34822#issuecomment-2109493652 ClickBench: Total hot run time: 30.33 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](prepare) fix datetimev2 return err when binary_row_format [doris]

2024-05-14 Thread via GitHub
nextdreamblue commented on code in PR #34662: URL: https://github.com/apache/doris/pull/34662#discussion_r1599534845 ## fe/fe-core/src/main/java/org/apache/doris/mysql/MysqlSerializer.java: ## @@ -298,6 +298,8 @@ public int getMysqlDecimals(Type type) { case DECIMAL

Re: [PR] [fix](decimal) Fix wrong result produced by decimal128 multiply [doris]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #34825: URL: https://github.com/apache/doris/pull/34825#issuecomment-2109499422 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [opt](exec) opt const expr exec in set operator [doris]

2024-05-14 Thread via GitHub
doris-robot commented on PR #34823: URL: https://github.com/apache/doris/pull/34823#issuecomment-2109500882 TeamCity be ut coverage result: Function Coverage: 35.67% (8982/25180) Line Coverage: 27.33% (74272/271761) Region Coverage: 26.56% (38375/144468) Branch Coverage: 23.3

Re: [PR] [fix](nereids)4 phase agg may lost parameter in some case [doris]

2024-05-14 Thread via GitHub
doris-robot commented on PR #34826: URL: https://github.com/apache/doris/pull/34826#issuecomment-2109510311 TPC-H: Total hot run time: 49247 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [opt](exec) opt const expr exec in set operator [doris]

2024-05-14 Thread via GitHub
doris-robot commented on PR #34823: URL: https://github.com/apache/doris/pull/34823#issuecomment-2109509966 TPC-DS: Total hot run time: 187838 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [feature](block) add check type in block data type and column [doris]

2024-05-14 Thread via GitHub
Mryange commented on PR #34314: URL: https://github.com/apache/doris/pull/34314#issuecomment-2109512368 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [fix](decimal) Fix wrong result produced by decimal128 multiply [doris]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #34825: URL: https://github.com/apache/doris/pull/34825#issuecomment-2109515537 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [conf](pipeline) Disable non-pipeline engine [doris]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #34812: URL: https://github.com/apache/doris/pull/34812#issuecomment-2109517880 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [opt](exec) opt const expr exec in set operator [doris]

2024-05-14 Thread via GitHub
doris-robot commented on PR #34823: URL: https://github.com/apache/doris/pull/34823#issuecomment-2109518739 ClickBench: Total hot run time: 30.5 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools C

Re: [PR] [feature](block) add check type in block data type and column [doris]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #34314: URL: https://github.com/apache/doris/pull/34314#issuecomment-2109523924 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](nereids)4 phase agg may lost parameter in some case [doris]

2024-05-14 Thread via GitHub
doris-robot commented on PR #34826: URL: https://github.com/apache/doris/pull/34826#issuecomment-2109532278 TPC-DS: Total hot run time: 204046 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Fix](function) money format [doris]

2024-05-14 Thread via GitHub
jacktengg commented on code in PR #34680: URL: https://github.com/apache/doris/pull/34680#discussion_r1599563003 ## be/src/vec/functions/function_string.h: ## @@ -3058,70 +3121,55 @@ struct MoneyFormatDecimalImpl { size_t input_rows_count) { if

Re: [PR] [Fix](function) money format [doris]

2024-05-14 Thread via GitHub
jacktengg commented on code in PR #34680: URL: https://github.com/apache/doris/pull/34680#discussion_r1599563003 ## be/src/vec/functions/function_string.h: ## @@ -3058,70 +3121,55 @@ struct MoneyFormatDecimalImpl { size_t input_rows_count) { if

Re: [PR] [Fix](function) money format [doris]

2024-05-14 Thread via GitHub
jacktengg commented on code in PR #34680: URL: https://github.com/apache/doris/pull/34680#discussion_r1599563003 ## be/src/vec/functions/function_string.h: ## @@ -3058,70 +3121,55 @@ struct MoneyFormatDecimalImpl { size_t input_rows_count) { if

Re: [PR] [Fix](function) money format [doris]

2024-05-14 Thread via GitHub
jacktengg commented on code in PR #34680: URL: https://github.com/apache/doris/pull/34680#discussion_r1599563003 ## be/src/vec/functions/function_string.h: ## @@ -3058,70 +3121,55 @@ struct MoneyFormatDecimalImpl { size_t input_rows_count) { if

[PR] [Fix](index writer) fix docWriter is null, when reenter close [doris-thirdparty]

2024-05-14 Thread via GitHub
airborne12 opened a new pull request, #214: URL: https://github.com/apache/doris-thirdparty/pull/214 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] [opt](nereids)new way to set pre-agg status [doris]

2024-05-14 Thread via GitHub
starocean999 commented on PR #34738: URL: https://github.com/apache/doris/pull/34738#issuecomment-2109540429 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [conf](pipeline) Disable non-pipeline engine [doris]

2024-05-14 Thread via GitHub
Gabriel39 commented on PR #34812: URL: https://github.com/apache/doris/pull/34812#issuecomment-2109542575 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [fix](nereids)4 phase agg may lost parameter in some case [doris]

2024-05-14 Thread via GitHub
doris-robot commented on PR #34826: URL: https://github.com/apache/doris/pull/34826#issuecomment-2109542976 ClickBench: Total hot run time: 30.19 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](nereids)4 phase agg may lost parameter in some case [doris]

2024-05-14 Thread via GitHub
doris-robot commented on PR #34826: URL: https://github.com/apache/doris/pull/34826#issuecomment-2109549169 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 1132ab760a95c6dd869eface5bf1d1941ae0b4bf with default session variables Stream

Re: [PR] [Enhancement] (doris-future) Support auto partition name function [doris]

2024-05-14 Thread via GitHub
wyxxxcat commented on PR #34258: URL: https://github.com/apache/doris/pull/34258#issuecomment-2109551837 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [conf](pipeline) Disable non-pipeline engine [doris]

2024-05-14 Thread via GitHub
zclllyybb commented on code in PR #34812: URL: https://github.com/apache/doris/pull/34812#discussion_r1599583573 ## regression-test/suites/query_p0/sql_functions/window_functions/test_select_stddev_variance_window.groovy: ## @@ -172,8 +172,6 @@ suite("test_select_stddev_variance

Re: [PR] [fix](decimal) Fix wrong result produced by decimal128 multiply [doris]

2024-05-14 Thread via GitHub
doris-robot commented on PR #34825: URL: https://github.com/apache/doris/pull/34825#issuecomment-2109575233 TPC-H: Total hot run time: 40969 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](prepare) fix datetimev2 return err when binary_row_format #34662 [doris]

2024-05-14 Thread via GitHub
nextdreamblue commented on PR #34807: URL: https://github.com/apache/doris/pull/34807#issuecomment-2109577152 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [fix](decimal) Fix wrong result produced by decimal128 multiply [doris]

2024-05-14 Thread via GitHub
Gabriel39 commented on PR #34825: URL: https://github.com/apache/doris/pull/34825#issuecomment-2109585467 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Chore](case) move test_ctas_mv,test_mv_case to single directory [doris]

2024-05-14 Thread via GitHub
BiteThet merged PR #34801: URL: https://github.com/apache/doris/pull/34801 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris

(doris) branch master updated: [Chore](case) move test_ctas_mv,test_mv_case to single directory (#34801)

2024-05-14 Thread panxiaolei
This is an automated email from the ASF dual-hosted git repository. panxiaolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 180eefec0a9 [Chore](case) move test_ctas_mv,

[PR] [Chore](rollup) check duplicate column name when create table with rollup [doris]

2024-05-14 Thread via GitHub
BiteThet opened a new pull request, #34827: URL: https://github.com/apache/doris/pull/34827 ## Proposed changes check duplicate column name when create table with rollup ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@dor

Re: [PR] [Chore](rollup) check duplicate column name when create table with rollup [doris]

2024-05-14 Thread via GitHub
doris-robot commented on PR #34827: URL: https://github.com/apache/doris/pull/34827#issuecomment-2109590992 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [Chore](rollup) check duplicate column name when create table with rollup [doris]

2024-05-14 Thread via GitHub
BiteThet commented on PR #34827: URL: https://github.com/apache/doris/pull/34827#issuecomment-2109591287 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [enhancement](cloud) batching get visible version from MetaService [doris]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #34615: URL: https://github.com/apache/doris/pull/34615#issuecomment-2109591732 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [enhancement](cloud) batching get visible version from MetaService [doris]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #34615: URL: https://github.com/apache/doris/pull/34615#issuecomment-2109597047 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] [fix](snappy) fix error when reading empty snappy file [doris]

2024-05-14 Thread via GitHub
morningman opened a new pull request, #34828: URL: https://github.com/apache/doris/pull/34828 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mail

Re: [PR] [fix](snappy) fix error when reading empty snappy file [doris]

2024-05-14 Thread via GitHub
doris-robot commented on PR #34828: URL: https://github.com/apache/doris/pull/34828#issuecomment-2109596964 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [fix](snappy) fix error when reading empty snappy file [doris]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #34828: URL: https://github.com/apache/doris/pull/34828#issuecomment-2109608043 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [enhancement](cloud) batching get visible version from MetaService [doris]

2024-05-14 Thread via GitHub
freemandealer commented on PR #34615: URL: https://github.com/apache/doris/pull/34615#issuecomment-2109615539 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[PR] [security]get_log_file should not allow download files from non standard directory [doris]

2024-05-14 Thread via GitHub
rohitrs1983 opened a new pull request, #34829: URL: https://github.com/apache/doris/pull/34829 get_log_file should not allow download files from non standard directory ## Proposed changes [security]get_log_file currently does not restrict the download of files from non standard dir

Re: [PR] [security]get_log_file should not allow download files from non standard directory [doris]

2024-05-14 Thread via GitHub
doris-robot commented on PR #34829: URL: https://github.com/apache/doris/pull/34829#issuecomment-2109617335 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

  1   2   3   4   5   6   7   8   9   >