Re: [PR] [fix](schema change) reduce memory usage of alter multi-column statement [doris]

2024-04-22 Thread via GitHub
luwei16 commented on PR #33073: URL: https://github.com/apache/doris/pull/33073#issuecomment-2071495151 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [fix](compile) fix two compile errors on MacOS (#33834) [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #34005: URL: https://github.com/apache/doris/pull/34005#issuecomment-2071496674 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Feature](hive-writer) Implements s3 file committer. [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #33937: URL: https://github.com/apache/doris/pull/33937#issuecomment-2071495519 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] [enhance](Cloud) Add case to test if vault is forbid for cloud mode without vault [doris]

2024-04-22 Thread via GitHub
ByteYue opened a new pull request, #34006: URL: https://github.com/apache/doris/pull/34006 ## Proposed changes Issue Number: close #xxx Ideally we want vault only works for cloud mode with vault, this pr mainly adds case to test if the vault stmt if forbidden for cloud mode wit

Re: [PR] [enhance](Cloud) Add case to test if vault is forbid for cloud mode without vault [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #34006: URL: https://github.com/apache/doris/pull/34006#issuecomment-2071501217 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [enhance](Cloud) Add case to test if vault is forbid for cloud mode without vault [doris]

2024-04-22 Thread via GitHub
ByteYue commented on PR #34006: URL: https://github.com/apache/doris/pull/34006#issuecomment-2071501259 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [improve](table function) opt explode/explode_map/explode_json table function [doris]

2024-04-22 Thread via GitHub
zhangstar333 commented on PR #33904: URL: https://github.com/apache/doris/pull/33904#issuecomment-2071505370 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](fd) remove fd from cache when tablet is deleted [doris]

2024-04-22 Thread via GitHub
dataroaring commented on PR #34004: URL: https://github.com/apache/doris/pull/34004#issuecomment-2071505739 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Feature](hive-writer) Implements s3 file committer. [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #33937: URL: https://github.com/apache/doris/pull/33937#issuecomment-2071506362 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Feature](hive-writer) Implements s3 file committer. [doris]

2024-04-22 Thread via GitHub
kaka11chen commented on PR #33937: URL: https://github.com/apache/doris/pull/33937#issuecomment-2071507607 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[PR] [fix](jni-connector) avoid core dump if init connector failed [doris]

2024-04-22 Thread via GitHub
morningman opened a new pull request, #34007: URL: https://github.com/apache/doris/pull/34007 ## Proposed changes `_jni_scanner_cls` may be null if connector init failed. So need to check it before delete it. ## Further comments If this is a relatively large or complex

Re: [PR] [enhance](Cloud) Add case to test if vault is forbid for cloud mode without vault [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #34006: URL: https://github.com/apache/doris/pull/34006#issuecomment-2071507866 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](jni-connector) avoid core dump if init connector failed [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #34007: URL: https://github.com/apache/doris/pull/34007#issuecomment-2071507711 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [fix](fd) remove fd from cache when tablet is deleted [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #34004: URL: https://github.com/apache/doris/pull/34004#issuecomment-2071508352 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [enhance](Cloud) Add case to test if vault is forbid for cloud mode without vault [doris]

2024-04-22 Thread via GitHub
gavinchou commented on code in PR #34006: URL: https://github.com/apache/doris/pull/34006#discussion_r1575711136 ## regression-test/suites/vaults/forbid/forbid.groovy: ## @@ -0,0 +1,45 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor lice

Re: [PR] [test](hll) fix unstable case without order by clause [doris]

2024-04-22 Thread via GitHub
zhangstar333 merged PR #33947: URL: https://github.com/apache/doris/pull/33947 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris

(doris) branch master updated: [test](hll) fix unstable case without order by clause (#33947)

2024-04-22 Thread zhangstar333
This is an automated email from the ASF dual-hosted git repository. zhangstar333 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new b7381c13017 [test](hll) fix unstable case w

Re: [PR] [fix](fd) release fd for shutdown tablets [doris]

2024-04-22 Thread via GitHub
gavinchou commented on code in PR #34003: URL: https://github.com/apache/doris/pull/34003#discussion_r1575712460 ## be/src/olap/rowset/rowset.h: ## @@ -303,6 +303,9 @@ class Rowset : public std::enable_shared_from_this { std::string get_rowset_info_str(); +virtual v

Re: [PR] [Bug](join) fix core dump on empty_right_table_need_probe_dispose [doris]

2024-04-22 Thread via GitHub
BiteThet closed pull request #33913: [Bug](join) fix core dump on empty_right_table_need_probe_dispose URL: https://github.com/apache/doris/pull/33913 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] [improve](table function) opt explode/explode_map/explode_json table function [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #33904: URL: https://github.com/apache/doris/pull/33904#issuecomment-2071510301 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [improve](table function) opt explode/explode_map/explode_json table function [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #33904: URL: https://github.com/apache/doris/pull/33904#issuecomment-2071510340 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](jni-connector) avoid core dump if init connector failed [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #34007: URL: https://github.com/apache/doris/pull/34007#issuecomment-2071511647 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](jni-connector) avoid core dump if init connector failed [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #34007: URL: https://github.com/apache/doris/pull/34007#issuecomment-2071511693 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](fd) release fd for shutdown tablets [doris]

2024-04-22 Thread via GitHub
dataroaring commented on code in PR #34003: URL: https://github.com/apache/doris/pull/34003#discussion_r1575714223 ## be/src/olap/rowset/rowset.h: ## @@ -303,6 +303,9 @@ class Rowset : public std::enable_shared_from_this { std::string get_rowset_info_str(); +virtual

Re: [PR] [fix](tablet invert index) fix tablet invert index leaky caused by auto partition [doris]

2024-04-22 Thread via GitHub
yujun777 commented on PR #33973: URL: https://github.com/apache/doris/pull/33973#issuecomment-2071511987 run feut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] [Feature](hive-writer) Implements s3 file committer. [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #33937: URL: https://github.com/apache/doris/pull/33937#issuecomment-2071514124 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](jni-connector) avoid core dump if init connector failed [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #34007: URL: https://github.com/apache/doris/pull/34007#issuecomment-2071514520 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [chore](config) Add config to control BufferedReader and S3FileWriter's thread pool's min max nums [doris]

2024-04-22 Thread via GitHub
ByteYue commented on PR #33974: URL: https://github.com/apache/doris/pull/33974#issuecomment-2071515584 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [enhance](Cloud) Add case to test if vault is forbid for cloud mode without vault [doris]

2024-04-22 Thread via GitHub
ByteYue commented on code in PR #34006: URL: https://github.com/apache/doris/pull/34006#discussion_r1575719433 ## regression-test/suites/vaults/forbid/forbid.groovy: ## @@ -0,0 +1,45 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor licens

Re: [PR] [fix](fd) remove fd from cache when tablet is deleted [doris]

2024-04-22 Thread via GitHub
dataroaring commented on PR #34004: URL: https://github.com/apache/doris/pull/34004#issuecomment-2071520017 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [chore](config) Add config to control BufferedReader and S3FileWriter's thread pool's min max nums [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #33974: URL: https://github.com/apache/doris/pull/33974#issuecomment-2071522134 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](exception) Fix Block noexcept method not throw exception [doris]

2024-04-22 Thread via GitHub
xinyiZzz commented on PR #34002: URL: https://github.com/apache/doris/pull/34002#issuecomment-2071525767 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](case) test_alter_colocate_table.groovy [doris]

2024-04-22 Thread via GitHub
dataroaring merged PR #33981: URL: https://github.com/apache/doris/pull/33981 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

(doris) branch master updated (b7381c13017 -> 3f2904b35b9)

2024-04-22 Thread dataroaring
This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from b7381c13017 [test](hll) fix unstable case without order by clause (#33947) add 3f2904b35b9 [fix](case) test_

Re: [PR] [fix](fd) remove fd from cache when tablet is deleted [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #34004: URL: https://github.com/apache/doris/pull/34004#issuecomment-2071542010 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](exception) Fix Block noexcept method not throw exception [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #34002: URL: https://github.com/apache/doris/pull/34002#issuecomment-2071545595 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](jni-connector) avoid core dump if init connector failed [doris]

2024-04-22 Thread via GitHub
yiguolei commented on PR #34007: URL: https://github.com/apache/doris/pull/34007#issuecomment-2071563157 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [Feature](hive-writer) Implements s3 file committer. [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #33937: URL: https://github.com/apache/doris/pull/33937#issuecomment-2071563642 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](fd) remove fd from cache when tablet is deleted [doris]

2024-04-22 Thread via GitHub
dataroaring commented on PR #34004: URL: https://github.com/apache/doris/pull/34004#issuecomment-2071568304 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

<    2   3   4   5   6   7