Re: [PR] [Enhencement](Nereids) rules to optimize length function with aggregate function [doris]

2024-04-22 Thread via GitHub
LiBinfeng-01 commented on PR #33837: URL: https://github.com/apache/doris/pull/33837#issuecomment-2071284418 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [feat](nereids)column prune on olapScan [doris]

2024-04-22 Thread via GitHub
wm1581066 commented on PR #33995: URL: https://github.com/apache/doris/pull/33995#issuecomment-2071284807 any test cases ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[PR] chores: diff between 2.1 and 2.0 [doris-website]

2024-04-22 Thread via GitHub
jeffreys-cat opened a new pull request, #581: URL: https://github.com/apache/doris-website/pull/581 [chores: diff between 2.1 and 2.0](https://github.com/apache/doris-website/commit/857f11a3061c523f0ea79fe74ed176dc22018596) -- This is an automated message from the Apache Git Service. To r

Re: [PR] [FIX]fix cidr func with const param [doris]

2024-04-22 Thread via GitHub
zhiqiang- commented on code in PR #33968: URL: https://github.com/apache/doris/pull/33968#discussion_r1575559245 ## regression-test/suites/query_p0/sql_functions/ip_functions/test_ipv6_cidr_to_range_function.groovy: ## @@ -48,6 +48,7 @@ suite("test_ipv6_cidr_to_range_functio

Re: [PR] [fix](tablet invert index) fix tablet invert index leaky caused by auto partition [doris]

2024-04-22 Thread via GitHub
yujun777 commented on PR #33973: URL: https://github.com/apache/doris/pull/33973#issuecomment-2071288380 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [Fix](nereids) fix rule merge_aggregate when has project [doris]

2024-04-22 Thread via GitHub
feiniaofeiafei commented on PR #33892: URL: https://github.com/apache/doris/pull/33892#issuecomment-2071289257 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FIX]fix cidr func with const param [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33968: URL: https://github.com/apache/doris/pull/33968#issuecomment-2071290174 TeamCity be ut coverage result: Function Coverage: 35.36% (8914/25210) Line Coverage: 27.08% (73308/270719) Region Coverage: 26.21% (37861/144436) Branch Coverage: 23.0

Re: [PR] [bug](random distribution) fix data loss and incorrect in random distribution table [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33962: URL: https://github.com/apache/doris/pull/33962#issuecomment-2071290355 TeamCity be ut coverage result: Function Coverage: 35.37% (8916/25210) Line Coverage: 27.09% (73322/270671) Region Coverage: 26.23% (37875/144405) Branch Coverage: 23.0

Re: [PR] [bug](branch-2.0) fix data loss and incorrect in random distribution table in 2.0 [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33920: URL: https://github.com/apache/doris/pull/33920#issuecomment-2071292853 TPC-H: Total hot run time: 49552 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [chore](ci) adjust conf of external pipepline [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #33964: URL: https://github.com/apache/doris/pull/33964#issuecomment-2071293917 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [chore](ci) adjust conf of external pipepline [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #33964: URL: https://github.com/apache/doris/pull/33964#issuecomment-2071293942 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [improve](regression test)Add test for time series compact empty rowset [doris]

2024-04-22 Thread via GitHub
eldenmoon merged PR #29509: URL: https://github.com/apache/doris/pull/29509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

(doris) branch master updated (c5c49686ca9 -> e43ed06bf7d)

2024-04-22 Thread eldenmoon
This is an automated email from the ASF dual-hosted git repository. eldenmoon pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from c5c49686ca9 [chore](dependencies)Upgrade paimon to 0.7.0 (#33987) add e43ed06bf7d [improve](regression test)Add

Re: [PR] [chore](ci) adjust conf of external pipepline [doris]

2024-04-22 Thread via GitHub
morningman merged PR #33964: URL: https://github.com/apache/doris/pull/33964 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.a

(doris) branch master updated: [chore](ci) adjust conf of external pipepline (#33964)

2024-04-22 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new d5eac60734f [chore](ci) adjust conf of extern

(doris-website) branch master updated: Update java-user-defined-function.md

2024-04-22 Thread luzhijing
This is an automated email from the ASF dual-hosted git repository. luzhijing pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris-website.git The following commit(s) were added to refs/heads/master by this push: new 7c6162ce3a Update java-user-defined-fu

(doris-website) branch master updated: Update java-user-defined-function.md

2024-04-22 Thread luzhijing
This is an automated email from the ASF dual-hosted git repository. luzhijing pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris-website.git The following commit(s) were added to refs/heads/master by this push: new 647e248682 Update java-user-defined-fu

Re: [PR] [Feat](nereids) add rewrite rule PushCountIntoUnionAll [doris]

2024-04-22 Thread via GitHub
feiniaofeiafei commented on PR #33530: URL: https://github.com/apache/doris/pull/33530#issuecomment-2071302370 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] [Bug] select with round function leads to BE crash [doris]

2024-04-22 Thread via GitHub
zhiqiang- commented on issue #33895: URL: https://github.com/apache/doris/issues/33895#issuecomment-2071305128 @panyanye hello, is this sql generated by some test utils? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [bug](branch-2.0) fix data loss and incorrect in random distribution table in 2.0 [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33920: URL: https://github.com/apache/doris/pull/33920#issuecomment-2071303544 TPC-DS: Total hot run time: 203459 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](tablet invert index) fix tablet invert index leaky caused by auto partition [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #33973: URL: https://github.com/apache/doris/pull/33973#issuecomment-2071305503 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [bug](branch-2.0) fix data loss and incorrect in random distribution table in 2.0 [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33920: URL: https://github.com/apache/doris/pull/33920#issuecomment-2071307733 ClickBench: Total hot run time: 30.27 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] chores: diff between 2.1 and 2.0 [doris-website]

2024-04-22 Thread via GitHub
jeffreys-cat closed pull request #581: chores: diff between 2.1 and 2.0 URL: https://github.com/apache/doris-website/pull/581 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [bug](branch-2.0) fix data loss and incorrect in random distribution table in 2.0 [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33920: URL: https://github.com/apache/doris/pull/33920#issuecomment-2071310033 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit f34370f1e7050cbc0797f4fbbeaa7355e4450e18 with default session variables Stream

Re: [PR] [fix](statistics)Improve analyze timeout logic. [doris]

2024-04-22 Thread via GitHub
Jibing-Li commented on code in PR #33836: URL: https://github.com/apache/doris/pull/33836#discussion_r1575576413 ## fe/fe-core/src/main/java/org/apache/doris/qe/ConnectContext.java: ## @@ -995,7 +996,7 @@ public int getExecTimeout() { // particular for insert stmt,

Re: [PR] [Fix](auto-partition) fix auto partition load lost data in multi sender [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #33996: URL: https://github.com/apache/doris/pull/33996#issuecomment-2071314301 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [Fix](auto-partition) fix auto partition load lost data in multi sender [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #33996: URL: https://github.com/apache/doris/pull/33996#issuecomment-2071314268 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](mtmv)Fix exception when create materialized view with cte [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #33988: URL: https://github.com/apache/doris/pull/33988#issuecomment-2071316987 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](routine-load) fix routine load lag is negative [doris]

2024-04-22 Thread via GitHub
HHoflittlefish777 commented on code in PR #33846: URL: https://github.com/apache/doris/pull/33846#discussion_r1575582527 ## fe/fe-core/src/main/java/org/apache/doris/load/routineload/KafkaRoutineLoadJob.java: ## @@ -319,16 +319,27 @@ protected boolean checkCommitInfo(RLTaskTxnC

Re: [PR] [bug](branch-2.0) fix data loss and incorrect in random distribution table in 2.0 [doris]

2024-04-22 Thread via GitHub
lide-reed merged PR #33920: URL: https://github.com/apache/doris/pull/33920 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

Re: [PR] [Fix](hdfs-writer) Fix hdfs file writer core with `check failed: _ref_cnt == 0` in dtor of `HdfsFileWriter`. [doris]

2024-04-22 Thread via GitHub
platoneko commented on code in PR #33959: URL: https://github.com/apache/doris/pull/33959#discussion_r1575582230 ## be/src/io/fs/hdfs_file_system.h: ## @@ -88,9 +88,7 @@ class HdfsFileSystem final : public RemoteFileSystem { RuntimeProfile* profile, std::stri

(doris) branch high-priority-column updated (d5fbcfd0b50 -> 18b5c3d193f)

2024-04-22 Thread lijibing
This is an automated email from the ASF dual-hosted git repository. lijibing pushed a change to branch high-priority-column in repository https://gitbox.apache.org/repos/asf/doris.git omit d5fbcfd0b50 Support high priority column stats auto collection. * fix visible column (#33023) * Collec

Re: [PR] [enhancement] (plsql) support show procedure status filters [doris]

2024-04-22 Thread via GitHub
Vallishp commented on PR #33264: URL: https://github.com/apache/doris/pull/33264#issuecomment-2071334195 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](case) test_alter_colocate_table.groovy [doris]

2024-04-22 Thread via GitHub
hello-stephen commented on PR #33981: URL: https://github.com/apache/doris/pull/33981#issuecomment-2071338435 run external -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[PR] [fix](nereids)move ReplaceVariableByLiteral rule to analyze phase [doris]

2024-04-22 Thread via GitHub
starocean999 opened a new pull request, #33997: URL: https://github.com/apache/doris/pull/33997 consider sql with user defined var @t_zone ``` set @t_zone='GMT'; SELECT DATE_FORMAT(convert_tz(dt, time_zone, @t_zone),'%Y-%m-%d') day FROM t GROUP BY 1;

Re: [PR] [fix](nereids)move ReplaceVariableByLiteral rule to analyze phase [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33997: URL: https://github.com/apache/doris/pull/33997#issuecomment-2071339593 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [fix](nereids)move ReplaceVariableByLiteral rule to analyze phase [doris]

2024-04-22 Thread via GitHub
starocean999 commented on PR #33997: URL: https://github.com/apache/doris/pull/33997#issuecomment-2071339948 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [improve](txn insert) txn insert support write to one table many times [doris]

2024-04-22 Thread via GitHub
mymeiyi commented on PR #32980: URL: https://github.com/apache/doris/pull/32980#issuecomment-2071341468 run feut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] [feature](statistics)Support high priority column stats auto collection. [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #33703: URL: https://github.com/apache/doris/pull/33703#issuecomment-2071346723 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

(doris) branch high-priority-column updated (18b5c3d193f -> 858f4bf078a)

2024-04-22 Thread lijibing
This is an automated email from the ASF dual-hosted git repository. lijibing pushed a change to branch high-priority-column in repository https://gitbox.apache.org/repos/asf/doris.git omit 18b5c3d193f Support high priority column stats auto collection. * fix visible column (#33023) * Collec

Re: [PR] [feature](statistics)Support high priority column stats auto collection. [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #33703: URL: https://github.com/apache/doris/pull/33703#issuecomment-2071351976 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](file-hanlder) comment out ref DCHECH temporarily [doris]

2024-04-22 Thread via GitHub
morningman closed pull request #33991: [fix](file-hanlder) comment out ref DCHECH temporarily URL: https://github.com/apache/doris/pull/33991 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[PR] [test](don't-merge) revert use single instance only with small limit (#33888) [doris]

2024-04-22 Thread via GitHub
liaoxin01 opened a new pull request, #33998: URL: https://github.com/apache/doris/pull/33998 This reverts commit b840c66a3c680b5f832612bdf669b22043660b6c. ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or comp

Re: [PR] [test](don't-merge) revert use single instance only with small limit (#33888) [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33998: URL: https://github.com/apache/doris/pull/33998#issuecomment-2071357306 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [chore](config) Add config to control BufferedReader and S3FileWriter's thread pool's min max nums [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #33974: URL: https://github.com/apache/doris/pull/33974#issuecomment-2071372259 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [chore](config) Add config to control BufferedReader and S3FileWriter's thread pool's min max nums [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #33974: URL: https://github.com/apache/doris/pull/33974#issuecomment-2071372233 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Feature](top-n) support topn filter on vscan node [doris]

2024-04-22 Thread via GitHub
HappenLee commented on code in PR #33496: URL: https://github.com/apache/doris/pull/33496#discussion_r1575616536 ## be/src/vec/utils/util.hpp: ## @@ -169,6 +170,63 @@ inline std::string remove_suffix(const std::string& name, const std::string& suf return name.substr(0, nam

[PR] [fix](gc) remove useless code due to #25921 [doris]

2024-04-22 Thread via GitHub
deardeng opened a new pull request, #33999: URL: https://github.com/apache/doris/pull/33999 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto

Re: [PR] [fix](gc) remove useless code due to #25921 [doris]

2024-04-22 Thread via GitHub
deardeng commented on PR #33999: URL: https://github.com/apache/doris/pull/33999#issuecomment-2071384909 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](gc) remove useless code due to #25921 [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33999: URL: https://github.com/apache/doris/pull/33999#issuecomment-2071384820 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [fix](gc) remove useless code due to #25921 [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #33999: URL: https://github.com/apache/doris/pull/33999#issuecomment-2071386561 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] (cloud-merge) Support more multi case strategies about cache [doris]

2024-04-22 Thread via GitHub
dataroaring merged PR #32804: URL: https://github.com/apache/doris/pull/32804 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

Re: [PR] [fix](gc) remove useless code due to #25921 [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #33999: URL: https://github.com/apache/doris/pull/33999#issuecomment-2071389055 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] (cloud-merge) Support more multi case strategies about cache [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #32804: URL: https://github.com/apache/doris/pull/32804#issuecomment-2071389060 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Fix](hdfs-writer) Fix hdfs file writer core with `check failed: _ref_cnt == 0` in dtor of `HdfsFileWriter`. [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on code in PR #33959: URL: https://github.com/apache/doris/pull/33959#discussion_r1575627693 ## be/src/io/hdfs_util.h: ## @@ -73,17 +71,14 @@ class HdfsHandler { int64_t last_access_time() { return _last_access_time; } -void inc_ref() {

Re: [PR] [FIX]fix cidr func with const param [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #33968: URL: https://github.com/apache/doris/pull/33968#issuecomment-2071394168 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Fix](hdfs-writer) Fix hdfs file writer core with `check failed: _ref_cnt == 0` in dtor of `HdfsFileWriter`. [doris]

2024-04-22 Thread via GitHub
kaka11chen commented on PR #33959: URL: https://github.com/apache/doris/pull/33959#issuecomment-2071395309 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [fix](case) test_alter_colocate_table.groovy [doris]

2024-04-22 Thread via GitHub
hello-stephen commented on PR #33981: URL: https://github.com/apache/doris/pull/33981#issuecomment-2071396597 run external -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [FIX]fix cidr func with const param [doris]

2024-04-22 Thread via GitHub
amorynan commented on PR #33968: URL: https://github.com/apache/doris/pull/33968#issuecomment-2071403103 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [only test] [doris]

2024-04-22 Thread via GitHub
Mryange commented on PR #33994: URL: https://github.com/apache/doris/pull/33994#issuecomment-2071408130 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[PR] [test](hive)add subnet for hive docker compose [doris]

2024-04-22 Thread via GitHub
suxiaogang223 opened a new pull request, #34000: URL: https://github.com/apache/doris/pull/34000 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](m

Re: [PR] [test](hive)add subnet for hive docker compose [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #34000: URL: https://github.com/apache/doris/pull/34000#issuecomment-2071413710 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [Chore](build) remove all vla usage and enable vla check [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #34001: URL: https://github.com/apache/doris/pull/34001#issuecomment-2071439737 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [Chore](build) remove all vla usage and enable vla check [doris]

2024-04-22 Thread via GitHub
BiteThet commented on PR #34001: URL: https://github.com/apache/doris/pull/34001#issuecomment-2071439817 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] [Chore](build) remove all vla usage and enable vla check [doris]

2024-04-22 Thread via GitHub
BiteThet opened a new pull request, #34001: URL: https://github.com/apache/doris/pull/34001 ## Proposed changes remove all vla usage and enable vla check ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](m

Re: [PR] [fix](exception) Fix Block noexcept method not throw exception [doris]

2024-04-22 Thread via GitHub
xinyiZzz commented on PR #34002: URL: https://github.com/apache/doris/pull/34002#issuecomment-2071445361 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](exception) Fix Block noexcept method not throw exception [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #34002: URL: https://github.com/apache/doris/pull/34002#issuecomment-2071445331 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [fix](exception) Fix Block noexcept method not throw exception [doris]

2024-04-22 Thread via GitHub
xinyiZzz opened a new pull request, #34002: URL: https://github.com/apache/doris/pull/34002 ## Proposed changes fix: ``` terminate called after throwing an instance of 'doris::Exception' 05:02:23 what(): [E11] Allocator sys memory check failed: Cannot alloc:4096, consumi

Re: [PR] [Chore](build) remove all vla usage and enable vla check [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #34001: URL: https://github.com/apache/doris/pull/34001#issuecomment-2071448563 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](exception) Fix Block noexcept method not throw exception [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #34002: URL: https://github.com/apache/doris/pull/34002#issuecomment-2071450787 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](exception) Fix Block noexcept method not throw exception [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #34002: URL: https://github.com/apache/doris/pull/34002#issuecomment-2071459336 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](exception) Fix Block noexcept method not throw exception [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #34002: URL: https://github.com/apache/doris/pull/34002#issuecomment-2071459369 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [FIX]fix cidr func with const param [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33968: URL: https://github.com/apache/doris/pull/33968#issuecomment-2071462260 TeamCity be ut coverage result: Function Coverage: 35.23% (8914/25304) Line Coverage: 26.98% (73304/271711) Region Coverage: 26.15% (37868/144795) Branch Coverage: 22.9

Re: [PR] [Fix](hdfs-writer) Fix hdfs file writer core with `check failed: _ref_cnt == 0` in dtor of `HdfsFileWriter`. [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33959: URL: https://github.com/apache/doris/pull/33959#issuecomment-2071462181 TeamCity be ut coverage result: Function Coverage: 35.24% (8916/25302) Line Coverage: 27.00% (73325/271622) Region Coverage: 26.17% (37878/144735) Branch Coverage: 22.9

Re: [PR] [fix](gc) remove useless code due to #25921 [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33999: URL: https://github.com/apache/doris/pull/33999#issuecomment-2071463286 TeamCity be ut coverage result: Function Coverage: 35.24% (8916/25304) Line Coverage: 26.99% (73323/271642) Region Coverage: 26.17% (37880/144741) Branch Coverage: 22.9

Re: [PR] [fix](fd) release fd for shutdown tablets [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #34003: URL: https://github.com/apache/doris/pull/34003#issuecomment-2071464412 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [fix](fd) release fd for shutdown tablets [doris]

2024-04-22 Thread via GitHub
dataroaring commented on PR #34003: URL: https://github.com/apache/doris/pull/34003#issuecomment-2071465444 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] [fix](fd) release fd for shutdown tablets [doris]

2024-04-22 Thread via GitHub
dataroaring opened a new pull request, #34003: URL: https://github.com/apache/doris/pull/34003 When a tablet is shutdown, maybe there is a running compaction on it, the compaction would put fd in cache, so we should clear them when remove the directory and the compaction fails due to shutdo

Re: [PR] [fix](fd) release fd for shutdown tablets [doris]

2024-04-22 Thread via GitHub
dataroaring commented on PR #34003: URL: https://github.com/apache/doris/pull/34003#issuecomment-2071464511 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](fd) release fd for shutdown tablets [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #34003: URL: https://github.com/apache/doris/pull/34003#issuecomment-2071470526 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [chore](config) Add config to control BufferedReader and S3FileWriter's thread pool's min max nums [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #33974: URL: https://github.com/apache/doris/pull/33974#issuecomment-2071471197 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Feature](top-n) support topn filter on vscan node [doris]

2024-04-22 Thread via GitHub
HappenLee commented on code in PR #33496: URL: https://github.com/apache/doris/pull/33496#discussion_r1575682167 ## be/src/vec/exprs/vtopn_pred.h: ## @@ -0,0 +1,115 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See

Re: [PR] [Feature](top-n) support topn filter on vscan node [doris]

2024-04-22 Thread via GitHub
HappenLee commented on code in PR #33496: URL: https://github.com/apache/doris/pull/33496#discussion_r1575682167 ## be/src/vec/exprs/vtopn_pred.h: ## @@ -0,0 +1,115 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See

Re: [PR] [fix](fd) release fd for shutdown tablets [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #34003: URL: https://github.com/apache/doris/pull/34003#issuecomment-2071472161 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Feature](top-n) support topn filter on vscan node [doris]

2024-04-22 Thread via GitHub
HappenLee commented on code in PR #33496: URL: https://github.com/apache/doris/pull/33496#discussion_r1575684545 ## be/src/vec/exprs/vtopn_pred.h: ## @@ -0,0 +1,115 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See

[PR] [fix](fd) remove fd from cache when tablet is deleted [doris]

2024-04-22 Thread via GitHub
dataroaring opened a new pull request, #34004: URL: https://github.com/apache/doris/pull/34004 When tablet is set shutdown, a compaction on it may be running. So we should remove fds from cache when tablet's dir is deleted. ## Proposed changes Issue Number: close #xxx

Re: [PR] [fix](fd) remove fd from cache when tablet is deleted [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #34004: URL: https://github.com/apache/doris/pull/34004#issuecomment-2071479658 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [fix](fd) remove fd from cache when tablet is deleted [doris]

2024-04-22 Thread via GitHub
dataroaring commented on PR #34004: URL: https://github.com/apache/doris/pull/34004#issuecomment-2071480421 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](inverted index) the rowset may be deleted and become nullptr. [doris]

2024-04-22 Thread via GitHub
airborne12 commented on PR #33878: URL: https://github.com/apache/doris/pull/33878#issuecomment-2071483639 need some testcases -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [fix](inverted index) the rowset may be deleted and become nullptr. [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #33878: URL: https://github.com/apache/doris/pull/33878#issuecomment-2071484354 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](fd) release fd for shutdown tablets [doris]

2024-04-22 Thread via GitHub
dataroaring commented on PR #34003: URL: https://github.com/apache/doris/pull/34003#issuecomment-2071485963 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](fd) release fd for shutdown tablets [doris]

2024-04-22 Thread via GitHub
dataroaring commented on PR #34003: URL: https://github.com/apache/doris/pull/34003#issuecomment-2071487502 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](fd) remove fd from cache when tablet is deleted [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #34004: URL: https://github.com/apache/doris/pull/34004#issuecomment-2071487647 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](compile) fix two compile errors on MacOS (#33834) [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #34005: URL: https://github.com/apache/doris/pull/34005#issuecomment-2071488716 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [fix](compile) fix two compile errors on MacOS (#33834) [doris]

2024-04-22 Thread via GitHub
cambyzju commented on PR #34005: URL: https://github.com/apache/doris/pull/34005#issuecomment-2071489106 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[PR] [fix](compile) fix two compile errors on MacOS (#33834) [doris]

2024-04-22 Thread via GitHub
cambyzju opened a new pull request, #34005: URL: https://github.com/apache/doris/pull/34005 size_t is not UInt64 on MacOS this compile error intro by PR #33265 ## Proposed changes Issue Number: close #xxx cherry-pick #33834 to branch 2.1 ## Further comments

Re: [PR] [fix](fd) release fd for shutdown tablets [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #34003: URL: https://github.com/apache/doris/pull/34003#issuecomment-2071492429 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](fd) release fd for shutdown tablets [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #34003: URL: https://github.com/apache/doris/pull/34003#issuecomment-2071494117 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](gc) remove useless code due to #25921 [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #33999: URL: https://github.com/apache/doris/pull/33999#issuecomment-2071490072 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [bug](random distribution) fix data loss and incorrect in random distribution table [doris]

2024-04-22 Thread via GitHub
xy720 commented on PR #33962: URL: https://github.com/apache/doris/pull/33962#issuecomment-2071490296 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

<    1   2   3   4   5   6   7   >