Re: [PR] [opt](nereids)project sub expression in other condition for nested loop join [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #32697: URL: https://github.com/apache/doris/pull/32697#issuecomment-2068631487 ClickBench: Total hot run time: 30.11 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [opt](plugin) improve logstash doris output plugin [doris]

2024-04-22 Thread via GitHub
qidaye merged PR #33135: URL: https://github.com/apache/doris/pull/33135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apach

Re: [PR] [Fix](nereids) fix rule merge_aggregate when has project [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33892: URL: https://github.com/apache/doris/pull/33892#issuecomment-2068631669 ClickBench: Total hot run time: 29.96 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

(doris) branch master updated: improve logstash doris output plugin (#33135)

2024-04-22 Thread jianliangqi
This is an automated email from the ASF dual-hosted git repository. jianliangqi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 32804430d70 improve logstash doris output pl

Re: [PR] [bug](branch-2.0) fix data loss and incorrect in random distribution table in 2.0 [doris]

2024-04-22 Thread via GitHub
xy720 commented on code in PR #33920: URL: https://github.com/apache/doris/pull/33920#discussion_r1574224535 ## be/src/vec/sink/vtablet_sink.cpp: ## @@ -605,6 +605,21 @@ Status VNodeChannel::add_block(vectorized::Block* block, const Payload* payload, SCOPED_RAW_TIMER(&_s

Re: [PR] [fix](routine-load) fix routine load lag is negative [doris]

2024-04-22 Thread via GitHub
HHoflittlefish777 commented on PR #33846: URL: https://github.com/apache/doris/pull/33846#issuecomment-2068644263 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [bug](branch-2.0) fix data loss and incorrect in random distribution table in 2.0 [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33920: URL: https://github.com/apache/doris/pull/33920#issuecomment-2068655472 TeamCity be ut coverage result: Function Coverage: 37.80% (8067/21344) Line Coverage: 29.46% (65910/223693) Region Coverage: 28.93% (33917/117222) Branch Coverage: 24.8

Re: [PR] [bug](random distribution) fix data loss and incorrect in random distribution table [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33962: URL: https://github.com/apache/doris/pull/33962#issuecomment-2068653735 TPC-H: Total hot run time: 38966 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [feature](fe) Advance the next id before transfering to master [doris]

2024-04-22 Thread via GitHub
w41ter commented on code in PR #33817: URL: https://github.com/apache/doris/pull/33817#discussion_r1574240196 ## fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java: ## @@ -1601,6 +1605,23 @@ private void transferToMaster() { } } +/* + * Advance th

Re: [PR] [bug](branch-2.0) fix data loss and incorrect in random distribution table in 2.0 [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33920: URL: https://github.com/apache/doris/pull/33920#issuecomment-2068659984 TPC-H: Total hot run time: 49902 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [bug](random distribution) fix data loss and incorrect in random distribution table [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33962: URL: https://github.com/apache/doris/pull/33962#issuecomment-2068664376 TeamCity be ut coverage result: Function Coverage: 35.36% (8915/25210) Line Coverage: 27.09% (73314/270621) Region Coverage: 26.23% (37872/144391) Branch Coverage: 23.0

Re: [PR] [Fix](hdfs-writer) Fix hdfs file writer core with `check failed: _ref_cnt == 0` in dtor of `HdfsFileWriter`. [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33959: URL: https://github.com/apache/doris/pull/33959#issuecomment-2068664869 TeamCity be ut coverage result: Function Coverage: 35.37% (8916/25210) Line Coverage: 27.10% (73320/270591) Region Coverage: 26.24% (37877/144368) Branch Coverage: 23.0

Re: [PR] [fix](schema change) reduce memory usage of alter multi-column statement [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33073: URL: https://github.com/apache/doris/pull/33073#issuecomment-2068665638 TPC-H: Total hot run time: 38368 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Fix](hdfs-writer) Fix hdfs file writer core with `check failed: _ref_cnt == 0` in dtor of `HdfsFileWriter`. [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33959: URL: https://github.com/apache/doris/pull/33959#issuecomment-2068666342 TPC-H: Total hot run time: 38297 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [bug](random distribution) fix data loss and incorrect in random distribution table [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33962: URL: https://github.com/apache/doris/pull/33962#issuecomment-2068672952 TPC-DS: Total hot run time: 184443 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](routine-load) fix routine load lag is negative [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33846: URL: https://github.com/apache/doris/pull/33846#issuecomment-2068674445 TPC-H: Total hot run time: 39008 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

[PR] [Fix](Jdbc-Hive) fix the order of partition keys [doris]

2024-04-22 Thread via GitHub
BePPPower opened a new pull request, #33963: URL: https://github.com/apache/doris/pull/33963 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailt

Re: [PR] [Fix](Jdbc-Hive) fix the order of partition keys [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33963: URL: https://github.com/apache/doris/pull/33963#issuecomment-2068676538 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [Fix](Jdbc-Hive) fix the order of partition keys [doris]

2024-04-22 Thread via GitHub
BePPPower commented on PR #33963: URL: https://github.com/apache/doris/pull/33963#issuecomment-2068676603 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Bug](json) fix heap use after free when json parse failed [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #33955: URL: https://github.com/apache/doris/pull/33955#issuecomment-2068677328 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](HDFS) Correctly set hdfs cache allocator's offset [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33960: URL: https://github.com/apache/doris/pull/33960#issuecomment-2068681057 TeamCity be ut coverage result: Function Coverage: 35.37% (8916/25210) Line Coverage: 27.10% (73326/270601) Region Coverage: 26.23% (37869/144371) Branch Coverage: 23.0

Re: [PR] [func](jsonb)support json_depth function [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #24801: URL: https://github.com/apache/doris/pull/24801#issuecomment-2068680839 TPC-H: Total hot run time: 38574 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](HDFS) Correctly set hdfs cache allocator's offset [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33960: URL: https://github.com/apache/doris/pull/33960#issuecomment-2068681274 TPC-H: Total hot run time: 40503 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [bug](branch-2.0) fix data loss and incorrect in random distribution table in 2.0 [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33920: URL: https://github.com/apache/doris/pull/33920#issuecomment-2068681967 TPC-DS: Total hot run time: 203667 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [bug](random distribution) fix data loss and incorrect in random distribution table [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33962: URL: https://github.com/apache/doris/pull/33962#issuecomment-2068682892 ClickBench: Total hot run time: 30.28 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](schema change) reduce memory usage of alter multi-column statement [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33073: URL: https://github.com/apache/doris/pull/33073#issuecomment-2068686254 TPC-DS: Total hot run time: 184977 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Fix](hdfs-writer) Fix hdfs file writer core with `check failed: _ref_cnt == 0` in dtor of `HdfsFileWriter`. [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33959: URL: https://github.com/apache/doris/pull/33959#issuecomment-2068687359 TPC-DS: Total hot run time: 185925 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [refactor](cleanup) Clean up pipeline engine (PART I) [doris]

2024-04-22 Thread via GitHub
Gabriel39 commented on PR #33945: URL: https://github.com/apache/doris/pull/33945#issuecomment-2068690721 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [bug](branch-2.0) fix data loss and incorrect in random distribution table in 2.0 [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33920: URL: https://github.com/apache/doris/pull/33920#issuecomment-2068692861 ClickBench: Total hot run time: 31.04 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](schema change) reduce memory usage of alter multi-column statement [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33073: URL: https://github.com/apache/doris/pull/33073#issuecomment-2068697754 ClickBench: Total hot run time: 29.68 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](routine-load) fix routine load lag is negative [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33846: URL: https://github.com/apache/doris/pull/33846#issuecomment-2068697029 TPC-DS: Total hot run time: 184905 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

[PR] [chore](ci) adjust conf of external pipepline [doris]

2024-04-22 Thread via GitHub
hello-stephen opened a new pull request, #33964: URL: https://github.com/apache/doris/pull/33964 Right now, the external pipeline also uses conf in regression-test/pipeline/p0/conf/, it is better to use conf in regression-test/pipeline/external/conf/. this pr prepare the conf first, then I

Re: [PR] [func](jsonb)support json_depth function [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #24801: URL: https://github.com/apache/doris/pull/24801#issuecomment-2068698569 TeamCity be ut coverage result: Function Coverage: 35.36% (8917/25216) Line Coverage: 27.09% (73330/270679) Region Coverage: 26.23% (37881/144417) Branch Coverage: 23.0

Re: [PR] [bug](branch-2.0) fix data loss and incorrect in random distribution table in 2.0 [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33920: URL: https://github.com/apache/doris/pull/33920#issuecomment-2068699214 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 412a33ea27d24a77984a063d9b3a7332517543ce with default session variables Stream

Re: [I] [Bug] select with round function leads to BE crash [doris]

2024-04-22 Thread via GitHub
Mryange commented on issue #33895: URL: https://github.com/apache/doris/issues/33895#issuecomment-2068699832 The problem still exists on the master branch. Can we connect on WeChat for further discussion? WeChatID : ygg_0721_114514 -- This is an automated message from the Apache Git S

Re: [PR] [chore](ci) adjust conf of external pipepline [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33964: URL: https://github.com/apache/doris/pull/33964#issuecomment-2068698306 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [chore](ci) adjust conf of external pipepline [doris]

2024-04-22 Thread via GitHub
hello-stephen commented on PR #33964: URL: https://github.com/apache/doris/pull/33964#issuecomment-2068698525 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [Fix](hdfs-writer) Fix hdfs file writer core with `check failed: _ref_cnt == 0` in dtor of `HdfsFileWriter`. [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33959: URL: https://github.com/apache/doris/pull/33959#issuecomment-2068698779 ClickBench: Total hot run time: 30.02 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [enhancement](testutil) add new function for function test in be-ut [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on code in PR #33741: URL: https://github.com/apache/doris/pull/33741#discussion_r1574274271 ## be/test/vec/function/function_test_util.h: ## @@ -17,11 +17,17 @@ #include Review Comment: warning: 'gtest/gtest-message.h' file not found [clang

Re: [PR] [func](jsonb)support json_depth function [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #24801: URL: https://github.com/apache/doris/pull/24801#issuecomment-2068703992 TPC-DS: Total hot run time: 185648 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](routine-load) fix routine load lag is negative [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33846: URL: https://github.com/apache/doris/pull/33846#issuecomment-2068707044 ClickBench: Total hot run time: 30.72 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [feature](pipelineX) Add type check between upstream and downstream operators. [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #33643: URL: https://github.com/apache/doris/pull/33643#issuecomment-2068708724 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [refactor](cleanup) Clean up pipeline engine (PART I) [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on code in PR #33945: URL: https://github.com/apache/doris/pull/33945#discussion_r1574278960 ## be/src/pipeline/pipeline_fragment_context.cpp: ## @@ -231,36 +236,33 @@ PipelinePtr PipelineFragmentContext::add_pipeline(PipelinePtr parent, int idx) {

Re: [PR] [feature](pipelineX) Add type check between upstream and downstream operators. [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #33643: URL: https://github.com/apache/doris/pull/33643#issuecomment-2068708652 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Fix](Jdbc-Hive) fix the order of partition keys [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33963: URL: https://github.com/apache/doris/pull/33963#issuecomment-2068711740 TPC-H: Total hot run time: 38855 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [bug](random distribution) fix data loss and incorrect in random distribution table [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #33962: URL: https://github.com/apache/doris/pull/33962#issuecomment-2068714327 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [bug](random distribution) fix data loss and incorrect in random distribution table [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #33962: URL: https://github.com/apache/doris/pull/33962#issuecomment-2068714415 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [func](jsonb)support json_depth function [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #24801: URL: https://github.com/apache/doris/pull/24801#issuecomment-2068715028 ClickBench: Total hot run time: 29.97 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [I] [Bug] select with round function leads to BE crash [doris]

2024-04-22 Thread via GitHub
panyanye commented on issue #33895: URL: https://github.com/apache/doris/issues/33895#issuecomment-2068717249 > The problem still exists on the master branch. Can we connect on WeChat for further discussion? WeChatID : ygg_0721_114514 OK,I have sent the application. -- This is an a

Re: [PR] [bug](branch-2.0) fix data loss and incorrect in random distribution table in 2.0 [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #33920: URL: https://github.com/apache/doris/pull/33920#issuecomment-2068718735 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [bug](branch-2.0) fix data loss and incorrect in random distribution table in 2.0 [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #33920: URL: https://github.com/apache/doris/pull/33920#issuecomment-2068718784 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [refactor](cleanup) Clean up pipeline engine (PART I) [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on code in PR #33945: URL: https://github.com/apache/doris/pull/33945#discussion_r1574287414 ## be/src/pipeline/pipeline_fragment_context.cpp: ## @@ -231,36 +236,33 @@ PipelinePtr PipelineFragmentContext::add_pipeline(PipelinePtr parent, int idx) {

Re: [PR] [refactor](cleanup) Clean up pipeline engine (PART I) [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33945: URL: https://github.com/apache/doris/pull/33945#issuecomment-2068723415 TeamCity be ut coverage result: Function Coverage: 35.72% (8914/24957) Line Coverage: 27.26% (73310/268943) Region Coverage: 26.40% (37864/143403) Branch Coverage: 23.1

Re: [PR] [refactor](cleanup) Clean up pipeline engine (PART I) [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33945: URL: https://github.com/apache/doris/pull/33945#issuecomment-2068727152 TPC-H: Total hot run time: 38274 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

(doris) branch master updated (32804430d70 -> 4c4c272808a)

2024-04-22 Thread eldenmoon
This is an automated email from the ASF dual-hosted git repository. eldenmoon pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 32804430d70 improve logstash doris output plugin (#33135) add 4c4c272808a [Refator](point query) change LookupC

Re: [PR] [Refator](point query) change LookupConnectionCache policy to number [doris]

2024-04-22 Thread via GitHub
eldenmoon merged PR #33950: URL: https://github.com/apache/doris/pull/33950 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

Re: [PR] [Fix](Jdbc-Hive) fix the order of partition keys [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33963: URL: https://github.com/apache/doris/pull/33963#issuecomment-2068737870 TPC-DS: Total hot run time: 186711 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [enhancement](testutil) add new function for function test in be-ut [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on code in PR #33741: URL: https://github.com/apache/doris/pull/33741#discussion_r1574300503 ## be/test/vec/function/function_test_util.h: ## @@ -17,11 +17,17 @@ #include #include +#include Review Comment: warning: inclusion of deprecated

Re: [PR] [fix](regression test) fix test_decommission_with_replica_num_fail due to set force_olap_table_replication_num [doris]

2024-04-22 Thread via GitHub
yujun777 commented on PR #33941: URL: https://github.com/apache/doris/pull/33941#issuecomment-2068738498 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[PR] [profile](scanner) Fix wrong metrics [doris]

2024-04-22 Thread via GitHub
Gabriel39 opened a new pull request, #33965: URL: https://github.com/apache/doris/pull/33965 ## Proposed changes Now projections are done in parallel scanners. Timer for projections are cumulated to scan operator's exec time which is not correct. ## Further comments

Re: [PR] [profile](scanner) Fix wrong metrics [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33965: URL: https://github.com/apache/doris/pull/33965#issuecomment-2068739597 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [profile](scanner) Fix wrong metrics [doris]

2024-04-22 Thread via GitHub
Gabriel39 commented on PR #33965: URL: https://github.com/apache/doris/pull/33965#issuecomment-2068739717 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] (cloud-merge) Fix the cast failed when RollupJobV2 convert to CloudRollupJobV2 [doris]

2024-04-22 Thread via GitHub
gavinchou commented on code in PR #33847: URL: https://github.com/apache/doris/pull/33847#discussion_r1574303955 ## fe/fe-core/src/main/java/org/apache/doris/alter/CloudRollupJobV2.java: ## @@ -41,29 +41,35 @@ import org.apache.doris.thrift.TTaskType; import com.google.commo

Re: [PR] [Feature](top-n) support topn filter on vscan node [doris]

2024-04-22 Thread via GitHub
BiteThet commented on PR #33496: URL: https://github.com/apache/doris/pull/33496#issuecomment-2068746236 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Fix](hdfs-writer) Fix hdfs file writer core with `check failed: _ref_cnt == 0` in dtor of `HdfsFileWriter`. [doris]

2024-04-22 Thread via GitHub
gavinchou commented on code in PR #33959: URL: https://github.com/apache/doris/pull/33959#discussion_r1574306753 ## be/src/io/hdfs_util.cpp: ## @@ -103,16 +103,16 @@ void HdfsHandlerCache::_clean_oldest() { } Status HdfsHandlerCache::get_connection(const THdfsParams& hdfs_pa

Re: [PR] [Fix](Jdbc-Hive) fix the order of partition keys [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33963: URL: https://github.com/apache/doris/pull/33963#issuecomment-2068747973 ClickBench: Total hot run time: 30 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools Cli

Re: [PR] [profile](scanner) Fix wrong metrics [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #33965: URL: https://github.com/apache/doris/pull/33965#issuecomment-2068749081 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Fix](hdfs-writer) Fix hdfs file writer core with `check failed: _ref_cnt == 0` in dtor of `HdfsFileWriter`. [doris]

2024-04-22 Thread via GitHub
kaka11chen commented on code in PR #33959: URL: https://github.com/apache/doris/pull/33959#discussion_r1574310604 ## be/src/io/hdfs_util.cpp: ## @@ -103,16 +103,16 @@ void HdfsHandlerCache::_clean_oldest() { } Status HdfsHandlerCache::get_connection(const THdfsParams& hdfs_p

[I] Query with JDBC catalog with too many rows or taking too long will throw error :jdbc get block address: CAUSED BY: IndexOutOfBoundsException: Index: 0, Size: 0 [doris]

2024-04-22 Thread via GitHub
windylcx opened a new issue, #33966: URL: https://github.com/apache/doris/issues/33966 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version 2.1.1 ### What's

Re: [PR] (cloud-merge) Support more multi case strategies about cache [doris]

2024-04-22 Thread via GitHub
gavinchou commented on code in PR #32804: URL: https://github.com/apache/doris/pull/32804#discussion_r1574317098 ## be/src/cloud/config.h: ## @@ -88,4 +88,6 @@ DECLARE_mInt32(schedule_sync_tablets_interval_s); // Cloud mow DECLARE_mInt32(mow_stream_load_commit_retry_times);

[PR] [fix](bdb) Write OP_TIMESTAMP operation until it successed [doris]

2024-04-22 Thread via GitHub
w41ter opened a new pull request, #33967: URL: https://github.com/apache/doris/pull/33967 ## Proposed changes Issue Number: close #xxx For now, it will reset the next journal id and return if the OP_TIMESTAMP operation writes failed. Because BDBJE will replicate the com

Re: [PR] [fix](bdb) Write OP_TIMESTAMP operation until it successed [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33967: URL: https://github.com/apache/doris/pull/33967#issuecomment-2068765962 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [FIX]fix cidr func with const param [doris]

2024-04-22 Thread via GitHub
amorynan commented on PR #33968: URL: https://github.com/apache/doris/pull/33968#issuecomment-2068767998 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](bdb) Write OP_TIMESTAMP operation until it successed [doris]

2024-04-22 Thread via GitHub
w41ter commented on PR #33967: URL: https://github.com/apache/doris/pull/33967#issuecomment-2068766048 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[PR] [FIX]fix cidr func with const param [doris]

2024-04-22 Thread via GitHub
amorynan opened a new pull request, #33968: URL: https://github.com/apache/doris/pull/33968 ## Proposed changes in function_ipxx_cidr, if we use const param, here will make core in execute_impl with check_and_get_column Issue Number: close #xxx ## Further comments

Re: [PR] [FIX]fix cidr func with const param [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33968: URL: https://github.com/apache/doris/pull/33968#issuecomment-2068767815 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [fix](profile) Should set is done when reporting profile [doris]

2024-04-22 Thread via GitHub
zhiqiang- commented on PR #33810: URL: https://github.com/apache/doris/pull/33810#issuecomment-2068775892 p0 failed has nothin to do with this PR https://github.com/apache/doris/assets/42906151/acf5c904-4de8-410f-96b3-28c5a0d535ce";> -- This is an automated message from the Apac

Re: [PR] (cloud-merge) Support more multi case strategies about cache [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #32804: URL: https://github.com/apache/doris/pull/32804#issuecomment-2068777997 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [FIX]fix cidr func with const param [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #33968: URL: https://github.com/apache/doris/pull/33968#issuecomment-2068778671 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] [fix](profile) Fix content missing of brokerload profile [doris]

2024-04-22 Thread via GitHub
zhiqiang- opened a new pull request, #33969: URL: https://github.com/apache/doris/pull/33969 Broker load does not set enable_profile for its load task, makes profile empty. before: ![image](https://github.com/apache/doris/assets/42906151/1dd3f8d4-3b4e-4ba2-a5ad-e212ec535463)

Re: [PR] [fix](profile) Fix content missing of brokerload profile [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33969: URL: https://github.com/apache/doris/pull/33969#issuecomment-2068783782 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [profile](scanner) Fix wrong metrics [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33965: URL: https://github.com/apache/doris/pull/33965#issuecomment-2068782363 TeamCity be ut coverage result: Function Coverage: 35.36% (8913/25209) Line Coverage: 27.09% (73294/270592) Region Coverage: 26.22% (37852/144361) Branch Coverage: 23.0

Re: [PR] [profile](scanner) Fix wrong metrics [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33965: URL: https://github.com/apache/doris/pull/33965#issuecomment-2068793008 TPC-H: Total hot run time: 38692 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](profile) Fix content missing of brokerload profile [doris]

2024-04-22 Thread via GitHub
zhiqiang- commented on PR #33969: URL: https://github.com/apache/doris/pull/33969#issuecomment-2068794546 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] (cloud-merge) Fix the cast failed when RollupJobV2 convert to CloudRollupJobV2 [doris]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #33847: URL: https://github.com/apache/doris/pull/33847#issuecomment-2068796958 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [feature](fe) Advance the next id before transfering to master [doris]

2024-04-22 Thread via GitHub
w41ter commented on PR #33817: URL: https://github.com/apache/doris/pull/33817#issuecomment-2068804760 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [Enhencement](Nereids) string compare with empty string convert to length greater than zero [doris]

2024-04-22 Thread via GitHub
LiBinfeng-01 commented on PR #33837: URL: https://github.com/apache/doris/pull/33837#issuecomment-2068814599 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [feature](shuffle) enable strict consistency dml by default [doris]

2024-04-22 Thread via GitHub
kaijchen commented on PR #32958: URL: https://github.com/apache/doris/pull/32958#issuecomment-2068817335 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [profile](scanner) Fix wrong metrics [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33965: URL: https://github.com/apache/doris/pull/33965#issuecomment-2068817391 TPC-DS: Total hot run time: 184520 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [improve](txn insert) txn insert support write to one table many times [doris]

2024-04-22 Thread via GitHub
mymeiyi commented on PR #32980: URL: https://github.com/apache/doris/pull/32980#issuecomment-2068821993 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [FIX]fix cidr func with const param [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33968: URL: https://github.com/apache/doris/pull/33968#issuecomment-2068824285 TeamCity be ut coverage result: Function Coverage: 35.36% (8913/25209) Line Coverage: 27.09% (73299/270598) Region Coverage: 26.23% (37863/144376) Branch Coverage: 23.0

Re: [PR] [enhancement] (plsql) support show procedure status filters [doris]

2024-04-22 Thread via GitHub
Vallishp commented on PR #33264: URL: https://github.com/apache/doris/pull/33264#issuecomment-2068826963 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

(doris) 01/03: [Enhancement](ranger) Disable some permission operations when Ranger or LDAP are enabled (#32538) (#33957)

2024-04-22 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git commit 71314595be1848ebfa60f19b5a67859a995a9956 Author: Mingyu Chen AuthorDate: Mon Apr 22 14:34:18 2024 +0800 [Enhan

(doris) branch branch-2.1 updated (b87674630e9 -> f6b6c13fb39)

2024-04-22 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a change to branch branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git discard b87674630e9 [enhance](auth)Abstract authentication interface (#33668) (#33961) omit b74a79b78c1 [refactor](M

(doris) 02/03: [refactor](Mysql) Refactoring the process of using external components to authenticate in MySQL connections (#32875) (#33958)

2024-04-22 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git commit 88b3d61ecab44d854b54993e4dc4e72ad7a0b885 Author: Mingyu Chen AuthorDate: Mon Apr 22 14:40:52 2024 +0800 [refac

(doris) 03/03: [enhance](auth)Abstract authentication interface (#33668) (#33961)

2024-04-22 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git commit f6b6c13fb39562ed8a9d4e0300a4713e50aa9917 Author: Mingyu Chen AuthorDate: Mon Apr 22 14:47:59 2024 +0800 [enhan

Re: [PR] [profile](scanner) Fix wrong metrics [doris]

2024-04-22 Thread via GitHub
doris-robot commented on PR #33965: URL: https://github.com/apache/doris/pull/33965#issuecomment-2068828363 ClickBench: Total hot run time: 30.44 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [feature](pipelineX) Add type check between upstream and downstream operators. [doris]

2024-04-22 Thread via GitHub
Mryange commented on PR #33643: URL: https://github.com/apache/doris/pull/33643#issuecomment-2068828741 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [fix](bdb) Write OP_TIMESTAMP operation until it successed [doris]

2024-04-22 Thread via GitHub
w41ter commented on PR #33967: URL: https://github.com/apache/doris/pull/33967#issuecomment-2068833098 > If write occure InsufficientExeption or RollbackException , Is unlimted loop suitable? It will exit by transferring to a follower. -- This is an automated message from the Apach

Re: [PR] [FIX]fix cidr func with const param [doris]

2024-04-22 Thread via GitHub
zhiqiang- commented on code in PR #33968: URL: https://github.com/apache/doris/pull/33968#discussion_r1574378047 ## be/src/vec/functions/function_ip.h: ## @@ -771,7 +771,7 @@ class FunctionIPv4CIDRToRange : public IFunction { ColumnWithTypeAndName& cidr_column = bl

  1   2   3   4   5   6   7   >