[GitHub] [doris] dataroaring commented on a diff in pull request #19621: [Enhancement](drop) drop multi tables in one drop stmt

2023-06-03 Thread via GitHub
dataroaring commented on code in PR #19621: URL: https://github.com/apache/doris/pull/19621#discussion_r1216058163 ## fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java: ## @@ -807,67 +807,70 @@ public void replayRenameDatabase(String dbName, String newDb

[GitHub] [doris] dataroaring commented on pull request #19382: [Enhancement-19322]add a session variable enable_pp_fuzzy

2023-06-03 Thread via GitHub
dataroaring commented on PR #19382: URL: https://github.com/apache/doris/pull/19382#issuecomment-1575335593 dry_run_fe is a better name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [doris] dataroaring opened a new issue, #20403: [Feature] investigation for supporting embeddings and vector similarity on doris

2023-06-03 Thread via GitHub
dataroaring opened a new issue, #20403: URL: https://github.com/apache/doris/issues/20403 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Description Embeddings and v

[GitHub] [doris] github-actions[bot] commented on pull request #19917: [feature-wip](auto-inc) add AutoIncrementIdGenerator and FrontService for BE coordinator

2023-06-03 Thread via GitHub
github-actions[bot] commented on PR #19917: URL: https://github.com/apache/doris/pull/19917#issuecomment-1575340603 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[doris] branch branch-2.0-beta created (now 5b026df60d)

2023-06-03 Thread kxiao
This is an automated email from the ASF dual-hosted git repository. kxiao pushed a change to branch branch-2.0-beta in repository https://gitbox.apache.org/repos/asf/doris.git at 5b026df60d [typo](doc) Fixed typos in hive.md (#19457) No new revisions were added by this update. -

[GitHub] [doris] cambyzju commented on pull request #20239: [fix](dynamic partition) partition create failed after modify column comment

2023-06-03 Thread via GitHub
cambyzju commented on PR #20239: URL: https://github.com/apache/doris/pull/20239#issuecomment-1575354342 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] GoGoWen commented on pull request #20386: [Fix](Grammar) Fix some grammar mistakes

2023-06-03 Thread via GitHub
GoGoWen commented on PR #20386: URL: https://github.com/apache/doris/pull/20386#issuecomment-1575359465 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] github-actions[bot] commented on pull request #19917: [feature-wip](auto-inc) add AutoIncrementIdGenerator and FrontService for BE coordinator

2023-06-03 Thread via GitHub
github-actions[bot] commented on PR #19917: URL: https://github.com/apache/doris/pull/19917#issuecomment-1575363859 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] HappenLee merged pull request #20399: [pipeline](opt) Opt fragment instance prepare performance by thread pool

2023-06-03 Thread via GitHub
HappenLee merged PR #20399: URL: https://github.com/apache/doris/pull/20399 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

[doris] branch master updated: [pipeline](opt) Opt fragment instance prepare performance by thread pool (#20399)

2023-06-03 Thread lihaopeng
This is an automated email from the ASF dual-hosted git repository. lihaopeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new e1dbee5e90 [pipeline](opt) Opt fragment instan

[GitHub] [doris] kaijchen commented on pull request #20392: [wip] improve memtable sort performance

2023-06-03 Thread via GitHub
kaijchen commented on PR #20392: URL: https://github.com/apache/doris/pull/20392#issuecomment-1575372247 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] github-actions[bot] commented on pull request #20392: [wip] improve memtable sort performance

2023-06-03 Thread via GitHub
github-actions[bot] commented on PR #20392: URL: https://github.com/apache/doris/pull/20392#issuecomment-1575372369 `sh-checker report` To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/5167166132";) output. shellcheck err

[GitHub] [doris] github-actions[bot] commented on pull request #20392: [wip] improve memtable sort performance

2023-06-03 Thread via GitHub
github-actions[bot] commented on PR #20392: URL: https://github.com/apache/doris/pull/20392#issuecomment-1575373987 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #20392: [wip] improve memtable sort performance

2023-06-03 Thread via GitHub
github-actions[bot] commented on PR #20392: URL: https://github.com/apache/doris/pull/20392#issuecomment-1575374981 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] HappenLee commented on a diff in pull request #20391: [refactor](profile) refactor the join profile when its shared hash table

2023-06-03 Thread via GitHub
HappenLee commented on code in PR #20391: URL: https://github.com/apache/doris/pull/20391#discussion_r1216153361 ## be/src/exec/exec_node.h: ## @@ -289,6 +290,13 @@ class ExecNode { // OpentelemetrySpan _span; +//NOTICE: now add a faker profile, because sometimes

[GitHub] [doris] kaijchen commented on pull request #20392: [wip] improve memtable sort performance

2023-06-03 Thread via GitHub
kaijchen commented on PR #20392: URL: https://github.com/apache/doris/pull/20392#issuecomment-1575375080 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] HappenLee commented on pull request #20391: [refactor](profile) refactor the join profile when its shared hash table

2023-06-03 Thread via GitHub
HappenLee commented on PR #20391: URL: https://github.com/apache/doris/pull/20391#issuecomment-1575376178 Add picture before and after change ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [doris] HappenLee commented on a diff in pull request #20298: [Enchancement](Agg State) storage function name and result is nullable in agg state type

2023-06-03 Thread via GitHub
HappenLee commented on code in PR #20298: URL: https://github.com/apache/doris/pull/20298#discussion_r1216163047 ## gensrc/thrift/Descriptors.thrift: ## @@ -38,6 +38,7 @@ struct TColumn { 14: optional i32 gram_size 15: optional i32 gram_bf_size 16: optional string

[GitHub] [doris] kaijchen commented on pull request #20392: [performance](load) improve memtable sort performance

2023-06-03 Thread via GitHub
kaijchen commented on PR #20392: URL: https://github.com/apache/doris/pull/20392#issuecomment-1575381225 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] github-actions[bot] commented on pull request #20392: [performance](load) improve memtable sort performance

2023-06-03 Thread via GitHub
github-actions[bot] commented on PR #20392: URL: https://github.com/apache/doris/pull/20392#issuecomment-1575381893 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] HHoflittlefish777 opened a new pull request, #20404: [Fix]fix lazy open commit info lose

2023-06-03 Thread via GitHub
HHoflittlefish777 opened a new pull request, #20404: URL: https://github.com/apache/doris/pull/20404 ## Proposed changes **problem** when open enable_lazy_open_partition config, there is a possibility that the open partition rpc will perform the open operation after the txn commit

[GitHub] [doris] HHoflittlefish777 commented on pull request #20404: [Fix]fix lazy open commit info lose

2023-06-03 Thread via GitHub
HHoflittlefish777 commented on PR #20404: URL: https://github.com/apache/doris/pull/20404#issuecomment-1575383335 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [doris] github-actions[bot] commented on pull request #20404: [Fix]fix lazy open commit info lose

2023-06-03 Thread via GitHub
github-actions[bot] commented on PR #20404: URL: https://github.com/apache/doris/pull/20404#issuecomment-1575383911 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] freemandealer commented on a diff in pull request #20404: [Fix]fix lazy open commit info lose

2023-06-03 Thread via GitHub
freemandealer commented on code in PR #20404: URL: https://github.com/apache/doris/pull/20404#discussion_r1216191454 ## regression-test/suites/rollup_p0/test_materialized_view_lazy_open.groovy: ## @@ -70,6 +75,58 @@ suite("test_materialized_view_lazy_open", "rollup") {

[GitHub] [doris] cambyzju commented on pull request #20239: [fix](dynamic partition) partition create failed after modify column comment

2023-06-03 Thread via GitHub
cambyzju commented on PR #20239: URL: https://github.com/apache/doris/pull/20239#issuecomment-1575392801 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] github-actions[bot] commented on pull request #20298: [Enchancement](Agg State) storage function name and result is nullable in agg state type

2023-06-03 Thread via GitHub
github-actions[bot] commented on PR #20298: URL: https://github.com/apache/doris/pull/20298#issuecomment-1575393091 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #20392: [performance](load) improve memtable sort performance

2023-06-03 Thread via GitHub
github-actions[bot] commented on PR #20392: URL: https://github.com/apache/doris/pull/20392#issuecomment-1575405601 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #20392: [performance](load) improve memtable sort performance

2023-06-03 Thread via GitHub
github-actions[bot] commented on PR #20392: URL: https://github.com/apache/doris/pull/20392#issuecomment-1575405604 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] caoliang-web commented on pull request #18743: [BUG](es_catalog)Solve the problem of querying es catalog Unexpected exception: Index:…

2023-06-03 Thread via GitHub
caoliang-web commented on PR #18743: URL: https://github.com/apache/doris/pull/18743#issuecomment-1575415139 run build all -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [doris] freemandealer commented on a diff in pull request #20404: [Fix]fix lazy open commit info lose

2023-06-03 Thread via GitHub
freemandealer commented on code in PR #20404: URL: https://github.com/apache/doris/pull/20404#discussion_r1216277572 ## be/src/vec/sink/vtablet_sink.cpp: ## @@ -320,6 +320,9 @@ Status VNodeChannel::init(RuntimeState* state) { _rpc_timeout_ms = state->execution_timeout() *

[GitHub] [doris] freemandealer commented on a diff in pull request #20404: [Fix]fix lazy open commit info lose

2023-06-03 Thread via GitHub
freemandealer commented on code in PR #20404: URL: https://github.com/apache/doris/pull/20404#discussion_r1216277793 ## be/src/vec/sink/vtablet_sink.cpp: ## @@ -516,7 +519,7 @@ Status VNodeChannel::open_wait() { } void VNodeChannel::open_partition(int64_t partition_id) { -

[GitHub] [doris] freemandealer commented on a diff in pull request #20404: [Fix]fix lazy open commit info lose

2023-06-03 Thread via GitHub
freemandealer commented on code in PR #20404: URL: https://github.com/apache/doris/pull/20404#discussion_r1216280175 ## be/src/vec/sink/vtablet_sink.h: ## @@ -302,6 +304,7 @@ class VNodeChannel { int _rpc_timeout_ms = 6; int64_t _next_packet_seq = 0; Monotonic

[GitHub] [doris] kaijchen commented on pull request #20392: [performance](load) improve memtable sort performance

2023-06-03 Thread via GitHub
kaijchen commented on PR #20392: URL: https://github.com/apache/doris/pull/20392#issuecomment-1575428477 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #20392: [performance](load) improve memtable sort performance

2023-06-03 Thread via GitHub
github-actions[bot] commented on code in PR #20392: URL: https://github.com/apache/doris/pull/20392#discussion_r1216300223 ## be/test/olap/memtable_sort_test.cpp: ## @@ -0,0 +1,48 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license a

<    1   2