[GitHub] [doris] ByteYue commented on pull request #19947: [enhance](PrefetchReader) abort load task when data size returned by S3 is smaller than requested

2023-05-22 Thread via GitHub
ByteYue commented on PR #19947: URL: https://github.com/apache/doris/pull/19947#issuecomment-1558469112 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] ByteYue commented on pull request #19944: [enhance](S3FileWriter) abort when s3 file writer abnormally quite and optimize s3 buffer pool

2023-05-22 Thread via GitHub
ByteYue commented on PR #19944: URL: https://github.com/apache/doris/pull/19944#issuecomment-1558469484 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] hello-stephen commented on pull request #19933: [fix](s3)fix s3 resource check

2023-05-22 Thread via GitHub
hello-stephen commented on PR #19933: URL: https://github.com/apache/doris/pull/19933#issuecomment-1558469679 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.41 seconds stream load tsv: 445 seconds loaded 74807831229 Bytes, about 160 MB/s

[GitHub] [doris] github-actions[bot] commented on pull request #19928: [Improve](complex-type)add switch for array/struct/map nesting complex type

2023-05-22 Thread via GitHub
github-actions[bot] commented on PR #19928: URL: https://github.com/apache/doris/pull/19928#issuecomment-1558470659 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #19928: [Improve](complex-type)add switch for array/struct/map nesting complex type

2023-05-22 Thread via GitHub
github-actions[bot] commented on PR #19928: URL: https://github.com/apache/doris/pull/19928#issuecomment-1558470709 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] xy720 commented on a diff in pull request #19928: [Improve](complex-type)add switch for array/struct/map nesting complex type

2023-05-22 Thread via GitHub
xy720 commented on code in PR #19928: URL: https://github.com/apache/doris/pull/19928#discussion_r1201486463 ## regression-test/suites/query_p0/show/test_nesting_complex_switch.groovy: ## @@ -0,0 +1,245 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or mor

[GitHub] [doris] zclllyybb opened a new pull request, #19949: [fix](testcase) fix unstable case test_query_sys_tables

2023-05-22 Thread via GitHub
zclllyybb opened a new pull request, #19949: URL: https://github.com/apache/doris/pull/19949 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has

[GitHub] [doris] zclllyybb commented on pull request #19949: [fix](testcase) fix unstable case test_query_sys_tables

2023-05-22 Thread via GitHub
zclllyybb commented on PR #19949: URL: https://github.com/apache/doris/pull/19949#issuecomment-1558482092 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] sohardforaname commented on pull request #18869: [Feature](Nereids)support insert into select.

2023-05-22 Thread via GitHub
sohardforaname commented on PR #18869: URL: https://github.com/apache/doris/pull/18869#issuecomment-1558485868 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [doris] hello-stephen commented on pull request #19913: [regression](nereids) tpcds sf100 plan shape regression cases

2023-05-22 Thread via GitHub
hello-stephen commented on PR #19913: URL: https://github.com/apache/doris/pull/19913#issuecomment-1558487218 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 33.98 seconds stream load tsv: 441 seconds loaded 74807831229 Bytes, about 161 MB/s

[GitHub] [doris] github-actions[bot] commented on pull request #19072: [optimization](be)eliminate virtual calls when write mysql results

2023-05-22 Thread via GitHub
github-actions[bot] commented on PR #19072: URL: https://github.com/apache/doris/pull/19072#issuecomment-1558489365 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] hello-stephen commented on pull request #19947: [enhance](PrefetchReader) abort load task when data size returned by S3 is smaller than requested

2023-05-22 Thread via GitHub
hello-stephen commented on PR #19947: URL: https://github.com/apache/doris/pull/19947#issuecomment-1558492524 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 35.21 seconds stream load tsv: 448 seconds loaded 74807831229 Bytes, about 159 MB/s

[GitHub] [doris] zhengshiJ commented on pull request #19650: [Feature](Nereids) support advance mv

2023-05-22 Thread via GitHub
zhengshiJ commented on PR #19650: URL: https://github.com/apache/doris/pull/19650#issuecomment-1558492700 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] HappenLee commented on a diff in pull request #19708: [vectorized](feature) support partition sort node

2023-05-22 Thread via GitHub
HappenLee commented on code in PR #19708: URL: https://github.com/apache/doris/pull/19708#discussion_r1201493692 ## be/src/vec/common/sort/partition_sorter.h: ## @@ -0,0 +1,108 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agre

[GitHub] [doris] HappenLee commented on a diff in pull request #19708: [vectorized](feature) support partition sort node

2023-05-22 Thread via GitHub
HappenLee commented on code in PR #19708: URL: https://github.com/apache/doris/pull/19708#discussion_r1201497859 ## be/src/vec/exec/vpartition_sort_node.cpp: ## @@ -0,0 +1,451 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agree

[GitHub] [doris] hello-stephen commented on pull request #18869: [Feature](Nereids)support insert into select.

2023-05-22 Thread via GitHub
hello-stephen commented on PR #18869: URL: https://github.com/apache/doris/pull/18869#issuecomment-1558503663 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.68 seconds stream load tsv: 418 seconds loaded 74807831229 Bytes, about 170 MB/s

[GitHub] [doris] morrySnow commented on a diff in pull request #18784: [feature](Nereids): pushdown filter through window

2023-05-22 Thread via GitHub
morrySnow commented on code in PR #18784: URL: https://github.com/apache/doris/pull/18784#discussion_r1201464942 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/implementation/LogicalPartitionTopNToPhysicalPartitionTopN.java: ## @@ -0,0 +1,56 @@ +// Licensed to the Ap

[GitHub] [doris] zy-kkk opened a new pull request, #19950: [Enhencement](JDBC Catalog) refactor jdbc catalog insert logic

2023-05-22 Thread via GitHub
zy-kkk opened a new pull request, #19950: URL: https://github.com/apache/doris/pull/19950 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has uni

[GitHub] [doris] github-actions[bot] commented on pull request #19950: [Enhencement](JDBC Catalog) refactor jdbc catalog insert logic

2023-05-22 Thread via GitHub
github-actions[bot] commented on PR #19950: URL: https://github.com/apache/doris/pull/19950#issuecomment-1558507978 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] kingbabingge commented on issue #18660: Set statement does't support computing expr:concat('', ',STRICT_TRANS_TABLES')

2023-05-22 Thread via GitHub
kingbabingge commented on issue #18660: URL: https://github.com/apache/doris/issues/18660#issuecomment-1558522362 ```java // metabase l链接doris 执行一个设置语句, set sql_mode = concat(@@sql_mode,',STRICT_TRANS_TABLES'); /** * -FE 异常 2023-05-22 08:37:40,443 WARN (mysql-nio-

[GitHub] [doris] kingbabingge commented on issue #18660: Set statement does't support computing expr:concat('', ',STRICT_TRANS_TABLES')

2023-05-22 Thread via GitHub
kingbabingge commented on issue #18660: URL: https://github.com/apache/doris/issues/18660#issuecomment-1558524327 concat 函数在启动FE时注册。VARCHAR 类型len =-1 ,什么会情况下会导致修改 len的值? ```java private void registerFEFunction(ImmutableMultimap.Builder mapBuilder,

[GitHub] [doris] zddr opened a new pull request, #19951: [improvement](k8s)when the IP of be is different from the IP specified by the master, obey it

2023-05-22 Thread via GitHub
zddr opened a new pull request, #19951: URL: https://github.com/apache/doris/pull/19951 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. When FE is deployed on a virtual machine and CN is deployed on k8s, FE needs to use a prox

[GitHub] [doris] englefly commented on pull request #19913: [regression](nereids) tpcds sf100 plan shape regression cases

2023-05-22 Thread via GitHub
englefly commented on PR #19913: URL: https://github.com/apache/doris/pull/19913#issuecomment-1558555417 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] xy720 opened a new pull request, #19952: [Bug](schema-change) fix varchar can not change to datev2

2023-05-22 Thread via GitHub
xy720 opened a new pull request, #19952: URL: https://github.com/apache/doris/pull/19952 # Proposed changes How to reproduce: ``` CREATE TABLE `test_tbl` ( `k1` int(11) NOT NULL, `k2` varchar(4096) NOT NULL, `k3` varchar(4096) NOT NULL, `v1` float SUM NOT

[GitHub] [doris] github-actions[bot] commented on pull request #19951: [improvement](k8s)when the IP of be is different from the IP specified by the master, obey it

2023-05-22 Thread via GitHub
github-actions[bot] commented on PR #19951: URL: https://github.com/apache/doris/pull/19951#issuecomment-1558558774 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] xy720 commented on pull request #19952: [Bug](schema-change) fix varchar can not change to datev2

2023-05-22 Thread via GitHub
xy720 commented on PR #19952: URL: https://github.com/apache/doris/pull/19952#issuecomment-1558560058 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [doris] github-actions[bot] commented on pull request #19896: [test]add lazy open test

2023-05-22 Thread via GitHub
github-actions[bot] commented on PR #19896: URL: https://github.com/apache/doris/pull/19896#issuecomment-1558577898 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] hello-stephen commented on pull request #19913: [regression](nereids) tpcds sf100 plan shape regression cases

2023-05-22 Thread via GitHub
hello-stephen commented on PR #19913: URL: https://github.com/apache/doris/pull/19913#issuecomment-1558578185 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 35.05 seconds stream load tsv: 442 seconds loaded 74807831229 Bytes, about 161 MB/s

[GitHub] [doris] zhannngchen merged pull request #19864: [enhancement](page cache) use separate pk index cache

2023-05-22 Thread via GitHub
zhannngchen merged PR #19864: URL: https://github.com/apache/doris/pull/19864 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

[doris] branch master updated (da66a64e09 -> c0ad588801)

2023-05-22 Thread zhangchen
This is an automated email from the ASF dual-hosted git repository. zhangchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from da66a64e09 [fix](merge-on-write) return error st if check_pk_in_pre_segments failed (#19736) add c0ad588801 [e

[GitHub] [doris] dataroaring merged pull request #19896: [test]add lazy open test

2023-05-22 Thread via GitHub
dataroaring merged PR #19896: URL: https://github.com/apache/doris/pull/19896 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

[doris] branch master updated: [test](lazy open) add lazy open test (#19896)

2023-05-22 Thread dataroaring
This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new cae8161dd8 [test](lazy open) add lazy open t

[GitHub] [doris] github-actions[bot] commented on pull request #19945: [test](Nereids) enable all query in tpcds empty table test

2023-05-22 Thread via GitHub
github-actions[bot] commented on PR #19945: URL: https://github.com/apache/doris/pull/19945#issuecomment-1558582115 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #19945: [test](Nereids) enable all query in tpcds empty table test

2023-05-22 Thread via GitHub
github-actions[bot] commented on PR #19945: URL: https://github.com/apache/doris/pull/19945#issuecomment-1558582158 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] morningman merged pull request #19834: [refactor](routineload)Refactored routineload to improve scalability

2023-05-22 Thread via GitHub
morningman merged PR #19834: URL: https://github.com/apache/doris/pull/19834 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.a

[doris] branch master updated (cae8161dd8 -> ebe3f6ec42)

2023-05-22 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from cae8161dd8 [test](lazy open) add lazy open test (#19896) add ebe3f6ec42 [refactor](routineload)Refactored rout

[GitHub] [doris] zddr commented on pull request #19951: [improvement](k8s)when the IP of be is different from the IP specified by the master, obey it

2023-05-22 Thread via GitHub
zddr commented on PR #19951: URL: https://github.com/apache/doris/pull/19951#issuecomment-1558585114 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [doris] Yulei-Yang commented on pull request #19540: [Improvement](planner) expand sql-block-rule to make it can be used on all kinds of sql stmt

2023-05-22 Thread via GitHub
Yulei-Yang commented on PR #19540: URL: https://github.com/apache/doris/pull/19540#issuecomment-1558589366 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [doris] starocean999 commented on a diff in pull request #19926: [fix](DECIMALV3) Fix the error in DECIMALV3 when explicitly casting.

2023-05-22 Thread via GitHub
starocean999 commented on code in PR #19926: URL: https://github.com/apache/doris/pull/19926#discussion_r1201578847 ## fe/fe-core/src/main/java/org/apache/doris/analysis/ArithmeticExpr.java: ## @@ -536,7 +536,7 @@ private void analyzeDecimalV3Op(Type t1, Type t2) throws Analysi

[GitHub] [doris] sohardforaname commented on pull request #18869: [Feature](Nereids)support insert into select.

2023-05-22 Thread via GitHub
sohardforaname commented on PR #18869: URL: https://github.com/apache/doris/pull/18869#issuecomment-1558596069 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] github-actions[bot] commented on pull request #19654: [chore](compile) Using chain-PCH based on .o instead of cmake’s PCH

2023-05-22 Thread via GitHub
github-actions[bot] commented on PR #19654: URL: https://github.com/apache/doris/pull/19654#issuecomment-1558605647 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #19946: [bug](compile) fix fe compile error

2023-05-22 Thread via GitHub
github-actions[bot] commented on PR #19946: URL: https://github.com/apache/doris/pull/19946#issuecomment-1558612543 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] deadlinefen commented on pull request #19654: [chore](compile) Using chain-PCH based on .o instead of cmake’s PCH

2023-05-22 Thread via GitHub
deadlinefen commented on PR #19654: URL: https://github.com/apache/doris/pull/19654#issuecomment-1558612193 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] github-actions[bot] commented on pull request #19946: [bug](compile) fix fe compile error

2023-05-22 Thread via GitHub
github-actions[bot] commented on PR #19946: URL: https://github.com/apache/doris/pull/19946#issuecomment-1558612578 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] kaijchen commented on a diff in pull request #19099: [performance](load) use vector instead of skiplist when insert agg keys

2023-05-22 Thread via GitHub
kaijchen commented on code in PR #19099: URL: https://github.com/apache/doris/pull/19099#discussion_r1201597555 ## be/src/olap/memtable.cpp: ## @@ -425,6 +443,7 @@ Status MemTable::flush() { // and use the ids to load segment data file for calc delete bitmap. int64_t a

[GitHub] [doris] Mryange commented on a diff in pull request #19926: [fix](DECIMALV3) Fix the error in DECIMALV3 when explicitly casting.

2023-05-22 Thread via GitHub
Mryange commented on code in PR #19926: URL: https://github.com/apache/doris/pull/19926#discussion_r1201600387 ## fe/fe-core/src/main/java/org/apache/doris/analysis/ArithmeticExpr.java: ## @@ -536,7 +536,7 @@ private void analyzeDecimalV3Op(Type t1, Type t2) throws AnalysisExce

[GitHub] [doris] Kikyou1997 closed pull request #19651: [Draft](CTE) Support CTE materialization

2023-05-22 Thread via GitHub
Kikyou1997 closed pull request #19651: [Draft](CTE) Support CTE materialization URL: https://github.com/apache/doris/pull/19651 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [doris] hello-stephen commented on pull request #19951: [improvement](k8s)when the IP of be is different from the IP specified by the master, obey it

2023-05-22 Thread via GitHub
hello-stephen commented on PR #19951: URL: https://github.com/apache/doris/pull/19951#issuecomment-1558614080 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.13 seconds stream load tsv: 444 seconds loaded 74807831229 Bytes, about 160 MB/s

[GitHub] [doris] CalvinKirs opened a new pull request, #19953: [Chore](docs)Remove empty pages to avoid ambiguity

2023-05-22 Thread via GitHub
CalvinKirs opened a new pull request, #19953: URL: https://github.com/apache/doris/pull/19953 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has

[GitHub] [doris] CalvinKirs commented on pull request #19953: [Chore](docs)Remove empty pages to avoid ambiguity

2023-05-22 Thread via GitHub
CalvinKirs commented on PR #19953: URL: https://github.com/apache/doris/pull/19953#issuecomment-1558614867 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [doris] kaijchen commented on a diff in pull request #19099: [performance](load) use vector instead of skiplist when insert agg keys

2023-05-22 Thread via GitHub
kaijchen commented on code in PR #19099: URL: https://github.com/apache/doris/pull/19099#discussion_r1201597555 ## be/src/olap/memtable.cpp: ## @@ -425,6 +443,7 @@ Status MemTable::flush() { // and use the ids to load segment data file for calc delete bitmap. int64_t a

[GitHub] [doris] kaijchen commented on a diff in pull request #19099: [performance](load) use vector instead of skiplist when insert agg keys

2023-05-22 Thread via GitHub
kaijchen commented on code in PR #19099: URL: https://github.com/apache/doris/pull/19099#discussion_r1201597555 ## be/src/olap/memtable.cpp: ## @@ -425,6 +443,7 @@ Status MemTable::flush() { // and use the ids to load segment data file for calc delete bitmap. int64_t a

[GitHub] [doris] adonis0147 commented on pull request #19301: [Inprovement](consts): Use inline variable

2023-05-22 Thread via GitHub
adonis0147 commented on PR #19301: URL: https://github.com/apache/doris/pull/19301#issuecomment-1558616944 Hi @happysnaker , please re-format the changes due to the check failed. See [https://github.com/apache/doris/actions/runs/4890195881/jobs/8749820436?pr=19301](https://github.com/apache/

[GitHub] [doris] github-actions[bot] commented on pull request #19414: [typo](doc) fix some typo

2023-05-22 Thread via GitHub
github-actions[bot] commented on PR #19414: URL: https://github.com/apache/doris/pull/19414#issuecomment-1558619101 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #19571: [feature](load-refactor) Unfied mysql load use InsertStmt

2023-05-22 Thread via GitHub
github-actions[bot] commented on PR #19571: URL: https://github.com/apache/doris/pull/19571#issuecomment-1558625096 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] morrySnow merged pull request #19945: [test](Nereids) enable all query in tpcds empty table test

2023-05-22 Thread via GitHub
morrySnow merged PR #19945: URL: https://github.com/apache/doris/pull/19945 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

[doris] branch master updated (ebe3f6ec42 -> 14de2a5c0e)

2023-05-22 Thread morrysnow
This is an automated email from the ASF dual-hosted git repository. morrysnow pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from ebe3f6ec42 [refactor](routineload)Refactored routineload to improve scalability (#19834) add 14de2a5c0e [test]

[GitHub] [doris-website] jeffreys-cat opened a new pull request, #232: (app) use cdnd.selectdb.com

2023-05-22 Thread via GitHub
jeffreys-cat opened a new pull request, #232: URL: https://github.com/apache/doris-website/pull/232 - (app) use cdnd.selectdb.com -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [doris] CalvinKirs commented on a diff in pull request #19571: [feature](load-refactor) Unfied mysql load use InsertStmt

2023-05-22 Thread via GitHub
CalvinKirs commented on code in PR #19571: URL: https://github.com/apache/doris/pull/19571#discussion_r1201615009 ## fe/fe-core/src/main/java/org/apache/doris/analysis/UnifiedLoadStmt.java: ## @@ -55,6 +42,31 @@ public void init() { proxyStmt.setUserInfo(getUserInfo());

[GitHub] [doris] kaijchen commented on a diff in pull request #19099: [performance](load) use vector instead of skiplist when insert agg keys

2023-05-22 Thread via GitHub
kaijchen commented on code in PR #19099: URL: https://github.com/apache/doris/pull/19099#discussion_r1201615144 ## be/src/olap/memtable.cpp: ## @@ -425,6 +443,7 @@ Status MemTable::flush() { // and use the ids to load segment data file for calc delete bitmap. int64_t a

[GitHub] [doris] deadlinefen closed pull request #19798: [test](client-cache) Reopen dcheck

2023-05-22 Thread via GitHub
deadlinefen closed pull request #19798: [test](client-cache) Reopen dcheck URL: https://github.com/apache/doris/pull/19798 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] zddr opened a new issue, #19954: [Enhancement] FQDN pr summary

2023-05-22 Thread via GitHub
zddr opened a new issue, #19954: URL: https://github.com/apache/doris/issues/19954 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Description https://github.com/apac

[GitHub] [doris] Tanya-W commented on pull request #19889: [fix](function) fix result column is nullable type when fast execute

2023-05-22 Thread via GitHub
Tanya-W commented on PR #19889: URL: https://github.com/apache/doris/pull/19889#issuecomment-1558634172 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [doris] CalvinKirs commented on a diff in pull request #19655: [Refactor](load) Unify streamload properties

2023-05-22 Thread via GitHub
CalvinKirs commented on code in PR #19655: URL: https://github.com/apache/doris/pull/19655#discussion_r1201625528 ## fe/fe-core/src/main/java/org/apache/doris/analysis/StreamLoadStmt.java: ## @@ -147,12 +141,10 @@ public Separator getLineDelimiter() { return lineDelimit

[GitHub] [doris] CalvinKirs commented on a diff in pull request #19655: [Refactor](load) Unify streamload properties

2023-05-22 Thread via GitHub
CalvinKirs commented on code in PR #19655: URL: https://github.com/apache/doris/pull/19655#discussion_r1201628463 ## fe/fe-core/src/main/java/org/apache/doris/analysis/StreamLoadStmt.java: ## @@ -452,14 +434,26 @@ private void setLineDelimiter(String oriLineDelimiter) throws An

<    1   2   3   4