[GitHub] [doris] adonis0147 commented on a diff in pull request #18819: [Refact](type system)refact interconversion for jsonb with column

2023-04-21 Thread via GitHub
adonis0147 commented on code in PR #18819: URL: https://github.com/apache/doris/pull/18819#discussion_r1173612233 ## be/src/vec/data_types/serde/data_type_hll_serde.cpp: ## @@ -17,16 +17,8 @@ #include "data_type_hll_serde.h" -#include -#include -#include - -#include - -

[GitHub] [doris] hello-stephen commented on pull request #18883: [bugfix](memoryleak) inlist is memory leak if the type is int

2023-04-21 Thread via GitHub
hello-stephen commented on PR #18883: URL: https://github.com/apache/doris/pull/18883#issuecomment-1517624580 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.45 seconds stream load tsv: 435 seconds loaded 74807831229 Bytes, about 164 MB/s

[GitHub] [doris] adonis0147 commented on a diff in pull request #18819: [Refact](type system)refact interconversion for jsonb with column

2023-04-21 Thread via GitHub
adonis0147 commented on code in PR #18819: URL: https://github.com/apache/doris/pull/18819#discussion_r1173614138 ## be/src/vec/jsonb/serialize.cpp: ## @@ -17,291 +17,13 @@ #include "vec/jsonb/serialize.h" -#include -#include -#include - -#include -#include -#include

[GitHub] [doris] adonis0147 commented on a diff in pull request #18819: [Refact](type system)refact interconversion for jsonb with column

2023-04-21 Thread via GitHub
adonis0147 commented on code in PR #18819: URL: https://github.com/apache/doris/pull/18819#discussion_r1173614138 ## be/src/vec/jsonb/serialize.cpp: ## @@ -17,291 +17,13 @@ #include "vec/jsonb/serialize.h" -#include -#include -#include - -#include -#include -#include

[GitHub] [doris] github-actions[bot] commented on pull request #18883: [bugfix](memoryleak) inlist is memory leak if the type is int

2023-04-21 Thread via GitHub
github-actions[bot] commented on PR #18883: URL: https://github.com/apache/doris/pull/18883#issuecomment-1517633874 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #18883: [bugfix](memoryleak) inlist is memory leak if the type is int

2023-04-21 Thread via GitHub
github-actions[bot] commented on PR #18883: URL: https://github.com/apache/doris/pull/18883#issuecomment-1517633918 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] hello-stephen commented on pull request #18903: [refactor](vectorized) fix some undefined behaviors in BE under ubsan

2023-04-21 Thread via GitHub
hello-stephen commented on PR #18903: URL: https://github.com/apache/doris/pull/18903#issuecomment-1517638740 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 33.51 seconds stream load tsv: 426 seconds loaded 74807831229 Bytes, about 167 MB/s

[GitHub] [doris] jackwener merged pull request #18887: [feat](Nereids): Simplify Agg GroupBy

2023-04-21 Thread via GitHub
jackwener merged PR #18887: URL: https://github.com/apache/doris/pull/18887 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

[doris] branch master updated (af20b2c95e -> 317d9ee152)

2023-04-21 Thread jakevin
This is an automated email from the ASF dual-hosted git repository. jakevin pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from af20b2c95e [Bug](topn opt) Fix be crash when enable topn opt with larger thresho… (#18858) add 317d9ee152 [feat]

[GitHub] [doris] levy5307 commented on pull request #18873: [Feature](resource-group) Support drop resource group

2023-04-21 Thread via GitHub
levy5307 commented on PR #18873: URL: https://github.com/apache/doris/pull/18873#issuecomment-1517649802 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] liaoxin01 opened a new issue, #18911: [Bug] 指定sequence_col的类型为时间的默认值是CURRENT_TIMESTAMP,insert 失败

2023-04-21 Thread via GitHub
liaoxin01 opened a new issue, #18911: URL: https://github.com/apache/doris/issues/18911 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version 1.2/master ###

[GitHub] [doris] BiteTheDDDDt commented on pull request #18541: [Feature](aggregate) support generic aggregate functions on pre-aggregate model

2023-04-21 Thread via GitHub
BiteThet commented on PR #18541: URL: https://github.com/apache/doris/pull/18541#issuecomment-151782 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] luozenglin opened a new pull request, #18912: [fix](thirdparty) fix opentelemetry error message compiling with ubsan

2023-04-21 Thread via GitHub
luozenglin opened a new pull request, #18912: URL: https://github.com/apache/doris/pull/18912 # Proposed changes Issue Number: close #18907 related: https://github.com/open-telemetry/opentelemetry-cpp/pull/1815 ## Problem summary Describe your changes. ## Checkl

[GitHub] [doris] luozenglin commented on pull request #18912: [fix](thirdparty) fix opentelemetry error message compiling with ubsan

2023-04-21 Thread via GitHub
luozenglin commented on PR #18912: URL: https://github.com/apache/doris/pull/18912#issuecomment-1517669091 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [doris] hello-stephen commented on pull request #18873: [Feature](resource-group) Support drop resource group

2023-04-21 Thread via GitHub
hello-stephen commented on PR #18873: URL: https://github.com/apache/doris/pull/18873#issuecomment-1517675733 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 33.96 seconds stream load tsv: 423 seconds loaded 74807831229 Bytes, about 168 MB/s

[GitHub] [doris] github-actions[bot] commented on pull request #18541: [Feature](aggregate) support generic aggregate functions on pre-aggregate model

2023-04-21 Thread via GitHub
github-actions[bot] commented on PR #18541: URL: https://github.com/apache/doris/pull/18541#issuecomment-1517676030 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] yiguolei opened a new pull request, #18913: [bugfix](memleak) UserFunctionCache may have memory leak during close

2023-04-21 Thread via GitHub
yiguolei opened a new pull request, #18913: URL: https://github.com/apache/doris/pull/18913 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has u

[GitHub] [doris] yiguolei commented on pull request #18913: [bugfix](memleak) UserFunctionCache may have memory leak during close

2023-04-21 Thread via GitHub
yiguolei commented on PR #18913: URL: https://github.com/apache/doris/pull/18913#issuecomment-1517676344 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] lvshaokang commented on issue #18911: [Bug] 指定sequence_col的类型为时间的默认值是CURRENT_TIMESTAMP,insert 失败

2023-04-21 Thread via GitHub
lvshaokang commented on issue #18911: URL: https://github.com/apache/doris/issues/18911#issuecomment-1517677904 I will take this task,please assign me,thk! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [doris] github-actions[bot] commented on pull request #18899: [doc](update-key)add update key doc

2023-04-21 Thread via GitHub
github-actions[bot] commented on PR #18899: URL: https://github.com/apache/doris/pull/18899#issuecomment-1517679402 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #18899: [doc](update-key)add update key doc

2023-04-21 Thread via GitHub
github-actions[bot] commented on PR #18899: URL: https://github.com/apache/doris/pull/18899#issuecomment-1517679463 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #18913: [bugfix](memleak) UserFunctionCache may have memory leak during close

2023-04-21 Thread via GitHub
github-actions[bot] commented on PR #18913: URL: https://github.com/apache/doris/pull/18913#issuecomment-1517679766 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] chenlinzhong commented on pull request #18799: [feature](graph)Support querying data from the Nebula graph database

2023-04-21 Thread via GitHub
chenlinzhong commented on PR #18799: URL: https://github.com/apache/doris/pull/18799#issuecomment-1517684812 run p1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [doris] dataroaring commented on a diff in pull request #18899: [doc](update-key)add update key doc

2023-04-21 Thread via GitHub
dataroaring commented on code in PR #18899: URL: https://github.com/apache/doris/pull/18899#discussion_r1173663776 ## docs/en/docs/data-operate/update-delete/update.md: ## @@ -123,6 +123,9 @@ Since the table order is a UNIQUE model, the rows with the same Key, after which |-

[GitHub] [doris] airborne12 opened a new pull request, #18914: [Fix](inverted index) fix memory leak when create bkd reader

2023-04-21 Thread via GitHub
airborne12 opened a new pull request, #18914: URL: https://github.com/apache/doris/pull/18914 # Proposed changes Issue Number: close #xxx ## Problem summary The function compoundReader->openInput is called three times, and if any of these calls fail, an error is logged,

[GitHub] [doris] airborne12 commented on pull request #18914: [Fix](inverted index) fix memory leak when create bkd reader

2023-04-21 Thread via GitHub
airborne12 commented on PR #18914: URL: https://github.com/apache/doris/pull/18914#issuecomment-1517688537 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #18914: [Fix](inverted index) fix memory leak when create bkd reader

2023-04-21 Thread via GitHub
github-actions[bot] commented on code in PR #18914: URL: https://github.com/apache/doris/pull/18914#discussion_r1173667228 ## be/src/olap/rowset/segment_v2/inverted_index_compound_reader.cpp: ## @@ -244,6 +244,17 @@ int64_t DorisCompoundReader::fileLength(const char* name) cons

[GitHub] [doris] jackwener commented on pull request #18902: [fix](Nereids): dead loop in FillUpMissingSlots

2023-04-21 Thread via GitHub
jackwener commented on PR #18902: URL: https://github.com/apache/doris/pull/18902#issuecomment-1517696787 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [doris] dutyu commented on pull request #18815: [Feature](multi-catalog) support query hive views.

2023-04-21 Thread via GitHub
dutyu commented on PR #18815: URL: https://github.com/apache/doris/pull/18815#issuecomment-1517698017 > Please add some test case. You can refer to `https://doris.apache.org/zh-CN/community/developer-guide/regression-testing#%E5%A4%96%E9%83%A8%E6%95%B0%E6%8D%AE%E6%BA%90-e2e-%E6%B5%8B%E8%AF%9

[GitHub] [doris] hello-stephen commented on pull request #18913: [bugfix](memleak) UserFunctionCache may have memory leak during close

2023-04-21 Thread via GitHub
hello-stephen commented on PR #18913: URL: https://github.com/apache/doris/pull/18913#issuecomment-1517698521 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 33.71 seconds stream load tsv: 425 seconds loaded 74807831229 Bytes, about 167 MB/s

[GitHub] [doris] TimChen44 closed issue #18677: [Bug] 当处理一个非常大的数据时,发生内存溢出,并且be掉线

2023-04-21 Thread via GitHub
TimChen44 closed issue #18677: [Bug] 当处理一个非常大的数据时,发生内存溢出,并且be掉线 URL: https://github.com/apache/doris/issues/18677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[GitHub] [doris] airborne12 commented on pull request #18914: [Fix](inverted index) fix memory leak when create bkd reader

2023-04-21 Thread via GitHub
airborne12 commented on PR #18914: URL: https://github.com/apache/doris/pull/18914#issuecomment-1517710815 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [doris] github-actions[bot] commented on pull request #18914: [Fix](inverted index) fix memory leak when create bkd reader

2023-04-21 Thread via GitHub
github-actions[bot] commented on PR #18914: URL: https://github.com/apache/doris/pull/18914#issuecomment-1517711265 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] airborne12 commented on pull request #18876: [Chore](thirdparty) update clucene from 2.4.9 to 2.4.10

2023-04-21 Thread via GitHub
airborne12 commented on PR #18876: URL: https://github.com/apache/doris/pull/18876#issuecomment-1517714417 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [doris] dataroaring commented on a diff in pull request #18891: [Improve](be)check swap

2023-04-21 Thread via GitHub
dataroaring commented on code in PR #18891: URL: https://github.com/apache/doris/pull/18891#discussion_r1173686227 ## bin/start_be.sh: ## @@ -71,6 +71,10 @@ if [[ "$(uname -s)" != 'Darwin' ]]; then fi fi +if [[ "$(swapon -s | wc -l)" -gt 1 ]]; then +echo "Please disa

[GitHub] [doris] gitccl opened a new pull request, #18915: [fix](compaction) fix potential null pointer dereference

2023-04-21 Thread via GitHub
gitccl opened a new pull request, #18915: URL: https://github.com/apache/doris/pull/18915 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has uni

[GitHub] [doris] gitccl commented on pull request #18915: [fix](compaction) fix potential null pointer dereference

2023-04-21 Thread via GitHub
gitccl commented on PR #18915: URL: https://github.com/apache/doris/pull/18915#issuecomment-1517717020 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [doris] github-actions[bot] commented on pull request #18915: [fix](compaction) fix potential null pointer dereference

2023-04-21 Thread via GitHub
github-actions[bot] commented on PR #18915: URL: https://github.com/apache/doris/pull/18915#issuecomment-1517718441 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #18915: [fix](compaction) fix potential null pointer dereference

2023-04-21 Thread via GitHub
github-actions[bot] commented on PR #18915: URL: https://github.com/apache/doris/pull/18915#issuecomment-1517718488 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #18915: [fix](compaction) fix potential null pointer dereference

2023-04-21 Thread via GitHub
github-actions[bot] commented on PR #18915: URL: https://github.com/apache/doris/pull/18915#issuecomment-1517720611 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #18906: [opt](FileCache) use modification time to determine whether the file is changed

2023-04-21 Thread via GitHub
github-actions[bot] commented on PR #18906: URL: https://github.com/apache/doris/pull/18906#issuecomment-1517724670 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL

2023-04-21 Thread via GitHub
github-actions[bot] commented on PR #18565: URL: https://github.com/apache/doris/pull/18565#issuecomment-1517733474 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] yongjinhou opened a new pull request, #18916: [enhencement](http) Fe config action supports specified item

2023-04-21 Thread via GitHub
yongjinhou opened a new pull request, #18916: URL: https://github.com/apache/doris/pull/18916 # Proposed changes Issue Number: close #xxx ## Problem summary Fe config action supports specified item. Support “GET /rest/v1/config/fe/” and “GET /rest/v1/config/fe?conf_ite

[GitHub] [doris] yongjinhou commented on pull request #18916: [enhencement](http) Fe config action supports specified item

2023-04-21 Thread via GitHub
yongjinhou commented on PR #18916: URL: https://github.com/apache/doris/pull/18916#issuecomment-1517745436 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [doris] hello-stephen commented on pull request #18915: [fix](compaction) fix potential null pointer dereference

2023-04-21 Thread via GitHub
hello-stephen commented on PR #18915: URL: https://github.com/apache/doris/pull/18915#issuecomment-1517753768 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.03 seconds stream load tsv: 424 seconds loaded 74807831229 Bytes, about 168 MB/s

[GitHub] [doris] Wilson-BT commented on issue #18854: [Bug] Flink-Doris-Connector Data losing happens while CDC job running . 同步cdc数据丢失。

2023-04-21 Thread via GitHub
Wilson-BT commented on issue #18854: URL: https://github.com/apache/doris/issues/18854#issuecomment-1517767536 > > 更改字段操作,是实时进行的,但是update 数据,是有时间间隔的 或者buffer的,是不是因为测试时间间隔问题导致的? > > 大概率是的。看了flink-doris-connector源码,它实际上是按批接收数据,一个checkpoint攒了一批数据,猜测是如果这批数据里面有ddl,就直接跳过数据写入的步骤。 可能你看

[GitHub] [doris] TangSiyang2001 commented on pull request #18691: [enhancement](agent-task/schema-change) make agent batch tasks cancelable in BE

2023-04-21 Thread via GitHub
TangSiyang2001 commented on PR #18691: URL: https://github.com/apache/doris/pull/18691#issuecomment-1517769709 run arm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] TangSiyang2001 commented on pull request #18691: [enhancement](agent-task/schema-change) make agent batch tasks cancelable in BE

2023-04-21 Thread via GitHub
TangSiyang2001 commented on PR #18691: URL: https://github.com/apache/doris/pull/18691#issuecomment-1517770887 run p1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] hust-hhb opened a new issue, #18917: [Enhancement] reduce stream load time on three replica table

2023-04-21 Thread via GitHub
hust-hhb opened a new issue, #18917: URL: https://github.com/apache/doris/issues/18917 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Description In my test on tpch

[GitHub] [doris] zzzzzzzs commented on a diff in pull request #18891: [Improve](be)check swap

2023-04-21 Thread via GitHub
zzzs commented on code in PR #18891: URL: https://github.com/apache/doris/pull/18891#discussion_r1173721667 ## bin/start_be.sh: ## @@ -71,6 +71,10 @@ if [[ "$(uname -s)" != 'Darwin' ]]; then fi fi +if [[ "$(swapon -s | wc -l)" -gt 1 ]]; then +echo "Please disable

[GitHub] [doris] jackwener opened a new pull request, #18918: [fix](Nereids): move SimplifyAggGroupBy before NormalizeAggregate.

2023-04-21 Thread via GitHub
jackwener opened a new pull request, #18918: URL: https://github.com/apache/doris/pull/18918 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has

[GitHub] [doris] yiguolei merged pull request #18905: [FIX](map-type)fix map regression test

2023-04-21 Thread via GitHub
yiguolei merged PR #18905: URL: https://github.com/apache/doris/pull/18905 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[doris] branch branch-2.0-alpha updated: fix map delete enable (#18905)

2023-04-21 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch branch-2.0-alpha in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/branch-2.0-alpha by this push: new 623b927e11 fix map delete e

[GitHub] [doris] yiguolei merged pull request #18777: [bug](bdbje) Add retry for reSetupBdbEnvironment() `restore.execute()`

2023-04-21 Thread via GitHub
yiguolei merged PR #18777: URL: https://github.com/apache/doris/pull/18777 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[doris] branch master updated: [bug](bdbje) Add retry for reSetupBdbEnvironment() `restore.execute()` (#18777)

2023-04-21 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 0ae3a6df7e [bug](bdbje) Add retry for reSetupBd

[GitHub] [doris] yiguolei closed issue #18766: [Bug] [fe] fe can't start with InsufficientLogException

2023-04-21 Thread via GitHub
yiguolei closed issue #18766: [Bug] [fe] fe can't start with InsufficientLogException URL: https://github.com/apache/doris/issues/18766 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [doris] BePPPower opened a new pull request, #18919: [fix](jdbc catalog) Use default value if the user does not set the pool parameter in be.conf

2023-04-21 Thread via GitHub
BePPPower opened a new pull request, #18919: URL: https://github.com/apache/doris/pull/18919 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has

[GitHub] [doris] BePPPower commented on pull request #18919: [fix](jdbc catalog) Use default value if the user does not set the pool parameter in be.conf

2023-04-21 Thread via GitHub
BePPPower commented on PR #18919: URL: https://github.com/apache/doris/pull/18919#issuecomment-1517805469 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] JNSimba commented on pull request #18899: [doc](update-key)add update key doc

2023-04-21 Thread via GitHub
JNSimba commented on PR #18899: URL: https://github.com/apache/doris/pull/18899#issuecomment-1517811106 Thanks for the review, it has been modified. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [doris] HappenLee commented on a diff in pull request #18903: [refactor](vectorized) fix some undefined behaviors in BE under ubsan

2023-04-21 Thread via GitHub
HappenLee commented on code in PR #18903: URL: https://github.com/apache/doris/pull/18903#discussion_r1173752840 ## be/src/olap/types.h: ## @@ -899,7 +899,15 @@ struct FieldTypeTraits uint128_t abs_value = value; if (value < 0) { *(curr

[GitHub] [doris] HappenLee commented on a diff in pull request #18903: [refactor](vectorized) fix some undefined behaviors in BE under ubsan

2023-04-21 Thread via GitHub
HappenLee commented on code in PR #18903: URL: https://github.com/apache/doris/pull/18903#discussion_r1173755028 ## be/src/vec/columns/column_nullable.h: ## @@ -385,7 +385,7 @@ class ColumnNullable final : public COWHelper { WrappedPtr null_map; bool _need_update_has

[GitHub] [doris] HappenLee commented on a diff in pull request #18903: [refactor](vectorized) fix some undefined behaviors in BE under ubsan

2023-04-21 Thread via GitHub
HappenLee commented on code in PR #18903: URL: https://github.com/apache/doris/pull/18903#discussion_r1173755989 ## be/src/vec/aggregate_functions/aggregate_function_collect.h: ## @@ -208,15 +208,19 @@ struct AggregateFunctionCollectListData { void write(BufferWritable& buf

[GitHub] [doris] github-actions[bot] commented on pull request #18892: [chore](doc) fix mv doc typo and cold heat separation

2023-04-21 Thread via GitHub
github-actions[bot] commented on PR #18892: URL: https://github.com/apache/doris/pull/18892#issuecomment-1517830019 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #18892: [chore](doc) fix mv doc typo and cold heat separation

2023-04-21 Thread via GitHub
github-actions[bot] commented on PR #18892: URL: https://github.com/apache/doris/pull/18892#issuecomment-1517830076 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] jackwener commented on pull request #18918: [fix](Nereids): move SimplifyAggGroupBy before NormalizeAggregate.

2023-04-21 Thread via GitHub
jackwener commented on PR #18918: URL: https://github.com/apache/doris/pull/18918#issuecomment-1517831795 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] hello-stephen commented on pull request #18919: [fix](jdbc catalog) Use default value if the user does not set the pool parameter in be.conf

2023-04-21 Thread via GitHub
hello-stephen commented on PR #18919: URL: https://github.com/apache/doris/pull/18919#issuecomment-1517832094 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 33.82 seconds stream load tsv: 427 seconds loaded 74807831229 Bytes, about 167 MB/s

[GitHub] [doris] amorynan commented on pull request #18819: [Refact](type system)refact interconversion for jsonb with column

2023-04-21 Thread via GitHub
amorynan commented on PR #18819: URL: https://github.com/apache/doris/pull/18819#issuecomment-1517836512 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[GitHub] [doris] dataroaring commented on pull request #18899: [doc](update-key)add update key doc

2023-04-21 Thread via GitHub
dataroaring commented on PR #18899: URL: https://github.com/apache/doris/pull/18899#issuecomment-1517839334 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] nextdreamblue commented on pull request #18895: [fix](schema) fix show create table get wrong random distribution info

2023-04-21 Thread via GitHub
nextdreamblue commented on PR #18895: URL: https://github.com/apache/doris/pull/18895#issuecomment-1517858455 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [doris] nextdreamblue commented on pull request #18895: [fix](schema) fix show create table get wrong random distribution info

2023-04-21 Thread via GitHub
nextdreamblue commented on PR #18895: URL: https://github.com/apache/doris/pull/18895#issuecomment-1517858634 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [doris] nextdreamblue commented on pull request #18758: [feature-wip](duplicate_no_keys) add create duplicate table without keys

2023-04-21 Thread via GitHub
nextdreamblue commented on PR #18758: URL: https://github.com/apache/doris/pull/18758#issuecomment-1517861176 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] nextdreamblue commented on pull request #18895: [fix](schema) fix show create table get wrong random distribution info

2023-04-21 Thread via GitHub
nextdreamblue commented on PR #18895: URL: https://github.com/apache/doris/pull/18895#issuecomment-1517862502 run feut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] eldenmoon commented on pull request #18231: [feature](array_cum_sum) Support array_cum_sum function

2023-04-21 Thread via GitHub
eldenmoon commented on PR #18231: URL: https://github.com/apache/doris/pull/18231#issuecomment-1517863191 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] yiguolei merged pull request #18731: (fix)[olap] not support in_memory=true now

2023-04-21 Thread via GitHub
yiguolei merged PR #18731: URL: https://github.com/apache/doris/pull/18731 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[GitHub] [doris] jackwener commented on pull request #18902: [fix](Nereids): dead loop in FillUpMissingSlots

2023-04-21 Thread via GitHub
jackwener commented on PR #18902: URL: https://github.com/apache/doris/pull/18902#issuecomment-1517882368 run buildp0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] WinkerDu commented on a diff in pull request #18834: [feature](multi-catalog) Rename multi-catalog config 'specified_database_list' to 'include_database_list', and introduce new multi

2023-04-21 Thread via GitHub
WinkerDu commented on code in PR #18834: URL: https://github.com/apache/doris/pull/18834#discussion_r1173807309 ## docs/en/docs/lakehouse/multi-catalog/hive.md: ## @@ -56,10 +56,13 @@ CREATE CATALOG hive PROPERTIES ( In addition to `type` and `hive.metastore.uris` , which a

[GitHub] [doris] morningman merged pull request #18513: [refactor] intro pthread pool for brpc and hadoop libhdfs

2023-04-21 Thread via GitHub
morningman merged PR #18513: URL: https://github.com/apache/doris/pull/18513 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.a

[doris] branch branch-1.2-lts updated: [refactor] intro pthread pool for brpc and hadoop libhdfs (#18513)

2023-04-21 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch branch-1.2-lts in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/branch-1.2-lts by this push: new 890a8bb098 [refactor] intro p

[GitHub] [doris] starocean999 commented on pull request #18920: [fix](nereids)remove unnecessary project above scan node

2023-04-21 Thread via GitHub
starocean999 commented on PR #18920: URL: https://github.com/apache/doris/pull/18920#issuecomment-1517892768 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] starocean999 opened a new pull request, #18920: [fix](nereids)remove unnecessary project above scan node

2023-04-21 Thread via GitHub
starocean999 opened a new pull request, #18920: URL: https://github.com/apache/doris/pull/18920 # Proposed changes 1. remove unnecessary project node above scan node. 2. fix in subquery may be recognized as scalar subquery bug 3. fix some Quantile related functions' return type b

[GitHub] [doris] morningman merged pull request #18893: [fix](test)Move broker test to p2. Move test data to cos in Beijing region.

2023-04-21 Thread via GitHub
morningman merged PR #18893: URL: https://github.com/apache/doris/pull/18893 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.a

[GitHub] [doris] github-actions[bot] commented on pull request #18920: [fix](nereids)remove unnecessary project above scan node

2023-04-21 Thread via GitHub
github-actions[bot] commented on PR #18920: URL: https://github.com/apache/doris/pull/18920#issuecomment-1517903347 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #18920: [fix](nereids)remove unnecessary project above scan node

2023-04-21 Thread via GitHub
github-actions[bot] commented on PR #18920: URL: https://github.com/apache/doris/pull/18920#issuecomment-1517903302 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[doris] branch master updated: [fix](test)Move broker test to p2. Move test data to cos in Beijing region (#18893)

2023-04-21 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 425101bf53 [fix](test)Move broker test to p2.

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #17585: [feature](io) enable s3 file writer with multi part uploading concurrently

2023-04-21 Thread via GitHub
github-actions[bot] commented on code in PR #17585: URL: https://github.com/apache/doris/pull/17585#discussion_r1173823759 ## be/test/io/fs/remote_file_system_test.cpp: ## @@ -392,6 +394,12 @@ TEST_F(RemoteFileSystemTest, TestHdfsFileSystem) { } TEST_F(RemoteFileSystemTest,

[GitHub] [doris] yiguolei merged pull request #18884: [fix](mtmv) fix mtmv thread interruption issue

2023-04-21 Thread via GitHub
yiguolei merged PR #18884: URL: https://github.com/apache/doris/pull/18884 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[doris] branch master updated: [fix](mtmv) fix mtmv thread interruption issue (#18884)

2023-04-21 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 313fab0802 [fix](mtmv) fix mtmv thread interrup

[GitHub] [doris] ByteYue commented on pull request #17585: [feature](io) enable s3 file writer with multi part uploading concurrently

2023-04-21 Thread via GitHub
ByteYue commented on PR #17585: URL: https://github.com/apache/doris/pull/17585#issuecomment-1517922995 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] dataroaring merged pull request #18892: [chore](doc) fix mv doc typo and cold heat separation

2023-04-21 Thread via GitHub
dataroaring merged PR #18892: URL: https://github.com/apache/doris/pull/18892 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

[doris] branch master updated: [chore](doc) fix mv doc typo and cold heat separation (#18892)

2023-04-21 Thread dataroaring
This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new d56fed345e [chore](doc) fix mv doc typo and

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #17585: [feature](io) enable s3 file writer with multi part uploading concurrently

2023-04-21 Thread via GitHub
github-actions[bot] commented on code in PR #17585: URL: https://github.com/apache/doris/pull/17585#discussion_r1173847482 ## be/test/io/fs/remote_file_system_test.cpp: ## @@ -392,6 +394,12 @@ TEST_F(RemoteFileSystemTest, TestHdfsFileSystem) { } TEST_F(RemoteFileSystemTest,

[GitHub] [doris] WinkerDu commented on pull request #18834: [feature](multi-catalog) Rename multi-catalog config 'specified_database_list' to 'include_database_list', and introduce new multi-catalog c

2023-04-21 Thread via GitHub
WinkerDu commented on PR #18834: URL: https://github.com/apache/doris/pull/18834#issuecomment-1517928019 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] WinkerDu commented on a diff in pull request #18834: [feature](multi-catalog) Rename multi-catalog config 'specified_database_list' to 'include_database_list', and introduce new multi

2023-04-21 Thread via GitHub
WinkerDu commented on code in PR #18834: URL: https://github.com/apache/doris/pull/18834#discussion_r1173850716 ## fe/fe-core/src/main/java/org/apache/doris/datasource/HMSExternalCatalog.java: ## @@ -130,10 +130,15 @@ protected void init() { initCatalogLog.setCatalogId(

[GitHub] [doris] github-actions[bot] commented on pull request #18834: [feature](multi-catalog) Rename multi-catalog config 'specified_database_list' to 'include_database_list', and introduce new mult

2023-04-21 Thread via GitHub
github-actions[bot] commented on PR #18834: URL: https://github.com/apache/doris/pull/18834#issuecomment-1517937011 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #18834: [feature](multi-catalog) Rename multi-catalog config 'specified_database_list' to 'include_database_list', and introduce new mult

2023-04-21 Thread via GitHub
github-actions[bot] commented on PR #18834: URL: https://github.com/apache/doris/pull/18834#issuecomment-1517937066 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #18919: [fix](jdbc catalog) Use default value if the user does not set the pool parameter in be.conf

2023-04-21 Thread via GitHub
github-actions[bot] commented on PR #18919: URL: https://github.com/apache/doris/pull/18919#issuecomment-1517940944 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #18919: [fix](jdbc catalog) Use default value if the user does not set the pool parameter in be.conf

2023-04-21 Thread via GitHub
github-actions[bot] commented on PR #18919: URL: https://github.com/apache/doris/pull/18919#issuecomment-1517940995 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #18902: [fix](Nereids): dead loop in FillUpMissingSlots

2023-04-21 Thread via GitHub
github-actions[bot] commented on PR #18902: URL: https://github.com/apache/doris/pull/18902#issuecomment-1517943285 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #18902: [fix](Nereids): dead loop in FillUpMissingSlots

2023-04-21 Thread via GitHub
github-actions[bot] commented on PR #18902: URL: https://github.com/apache/doris/pull/18902#issuecomment-1517943414 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] morrySnow commented on a diff in pull request #18800: [feat](stats) Return job id for async analyze stmt

2023-04-21 Thread via GitHub
morrySnow commented on code in PR #18800: URL: https://github.com/apache/doris/pull/18800#discussion_r1173862100 ## regression-test/suites/statistics/analyze_test.groovy: ## @@ -232,4 +232,66 @@ suite("analyze_test") { //exception """errCode = 2, detailMessage = Unexpec

<    1   2   3   >