[GitHub] [doris] zhannngchen commented on a diff in pull request #17639: [enhancement](planner) support update from syntax

2023-03-12 Thread via GitHub
zhannngchen commented on code in PR #17639: URL: https://github.com/apache/doris/pull/17639#discussion_r1133415876 ## fe/fe-core/src/main/java/org/apache/doris/analysis/UpdateStmt.java: ## @@ -17,101 +17,123 @@ package org.apache.doris.analysis; +import org.apache.doris.cat

[GitHub] [doris] yiguolei opened a new pull request, #17715: [refactor](functioncontext) remove function context impl class

2023-03-12 Thread via GitHub
yiguolei opened a new pull request, #17715: URL: https://github.com/apache/doris/pull/17715 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has u

[GitHub] [doris] zhannngchen commented on a diff in pull request #17639: [enhancement](planner) support update from syntax

2023-03-12 Thread via GitHub
zhannngchen commented on code in PR #17639: URL: https://github.com/apache/doris/pull/17639#discussion_r1133416203 ## docs/zh-CN/docs/sql-manual/sql-reference/Data-Manipulation-Statements/Manipulation/UPDATE.md: ## @@ -76,9 +102,69 @@ UPDATE test SET v1 = 1 WHERE k1=1 and k2=2;

[GitHub] [doris] morrySnow commented on a diff in pull request #17089: [Feature] Support CREATE DB COMMENT (#16678)

2023-03-12 Thread via GitHub
morrySnow commented on code in PR #17089: URL: https://github.com/apache/doris/pull/17089#discussion_r1133416008 ## fe/fe-core/src/main/java/org/apache/doris/catalog/Database.java: ## @@ -605,6 +628,7 @@ public void readFields(DataInput in) throws IOException { clusterN

[GitHub] [doris] yuxuan-luo commented on a diff in pull request #17694: [Bug](catalog) Fix fetching information_schema table timed out(#17692)

2023-03-12 Thread via GitHub
yuxuan-luo commented on code in PR #17694: URL: https://github.com/apache/doris/pull/17694#discussion_r1133416894 ## fe/fe-core/src/main/java/org/apache/doris/datasource/ExternalCatalog.java: ## @@ -240,6 +240,20 @@ public List getDbNames() { return listDatabaseNames(nu

[GitHub] [doris] yiguolei commented on pull request #17704: [feature-wip](table-metadata) support altering the property "light_schema_change" for the tables which created before 1.2

2023-03-12 Thread via GitHub
yiguolei commented on PR #17704: URL: https://github.com/apache/doris/pull/17704#issuecomment-1465465024 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] github-actions[bot] commented on pull request #17534: [Feature](materialized-view) support where clause on create materialized view

2023-03-12 Thread via GitHub
github-actions[bot] commented on PR #17534: URL: https://github.com/apache/doris/pull/17534#issuecomment-1465465512 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] starocean999 opened a new pull request, #17716: [fix](fe)project should be done inside subquery

2023-03-12 Thread via GitHub
starocean999 opened a new pull request, #17716: URL: https://github.com/apache/doris/pull/17716 # Proposed changes pick from master https://github.com/apache/doris/pull/17630 ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affe

[GitHub] [doris] morningman commented on a diff in pull request #17622: [Improvement](dynamic partition) Support bigint unix timestamp as par…

2023-03-12 Thread via GitHub
morningman commented on code in PR #17622: URL: https://github.com/apache/doris/pull/17622#discussion_r1133418498 ## fe/fe-core/src/main/java/org/apache/doris/common/ErrorCode.java: ## @@ -22,1006 +22,1016 @@ // Error code used to indicate what error happened. public enum Erro

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #17715: [refactor](functioncontext) remove function context impl class

2023-03-12 Thread via GitHub
github-actions[bot] commented on code in PR #17715: URL: https://github.com/apache/doris/pull/17715#discussion_r1133418782 ## be/src/udf/udf.h: ## @@ -132,16 +145,39 @@ class FunctionContext { ~FunctionContext() = default; private: -friend class doris::FunctionContex

[GitHub] [doris] morningman merged pull request #17716: [fix](fe)project should be done inside subquery

2023-03-12 Thread via GitHub
morningman merged PR #17716: URL: https://github.com/apache/doris/pull/17716 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.a

[doris] branch branch-1.2-lts updated: [fix](fe)project should be done inside subquery (#17716)

2023-03-12 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch branch-1.2-lts in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/branch-1.2-lts by this push: new db32b251e6 [fix](fe)project s

[GitHub] [doris] github-actions[bot] commented on pull request #17716: [fix](fe)project should be done inside subquery

2023-03-12 Thread via GitHub
github-actions[bot] commented on PR #17716: URL: https://github.com/apache/doris/pull/17716#issuecomment-1465467336 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #17716: [fix](fe)project should be done inside subquery

2023-03-12 Thread via GitHub
github-actions[bot] commented on PR #17716: URL: https://github.com/apache/doris/pull/17716#issuecomment-1465467362 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] JNSimba opened a new pull request, #17717: [api](schema) schema api compatible array type

2023-03-12 Thread via GitHub
JNSimba opened a new pull request, #17717: URL: https://github.com/apache/doris/pull/17717 # Problem summary Http API `/api///_schema` will return table structure information. **Array type, currently cannot return subtype** For example, the table structure is as follows: ```sql

[GitHub] [doris] ZhangYu0123 closed pull request #17703: [Enhence](array function) support array_remove function process NULL element

2023-03-12 Thread via GitHub
ZhangYu0123 closed pull request #17703: [Enhence](array function) support array_remove function process NULL element URL: https://github.com/apache/doris/pull/17703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] BBB-source commented on pull request #17204: [test](mv) Add mv case from fe ut

2023-03-12 Thread via GitHub
BBB-source commented on PR #17204: URL: https://github.com/apache/doris/pull/17204#issuecomment-1465481453 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [doris] hello-stephen commented on pull request #17711: [enhance](nereids) broadcast cost calculate

2023-03-12 Thread via GitHub
hello-stephen commented on PR #17711: URL: https://github.com/apache/doris/pull/17711#issuecomment-1465487464 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 36.24 seconds stream load tsv: 468 seconds loaded 74807831229 Bytes, about 152 MB/s

[GitHub] [doris] HappenLee commented on a diff in pull request #17594: [Feature](parquet-reader) Implements dict filter functionality parquet reader.

2023-03-12 Thread via GitHub
HappenLee commented on code in PR #17594: URL: https://github.com/apache/doris/pull/17594#discussion_r1133428175 ## be/src/vec/exec/format/parquet/vparquet_group_reader.cpp: ## @@ -71,11 +97,136 @@ Status RowGroupReader::init(const FieldDescriptor& schema, std::vector

[GitHub] [doris] zhengshiJ commented on pull request #17661: [fix](Nereids) type coercion for subquery

2023-03-12 Thread via GitHub
zhengshiJ commented on PR #17661: URL: https://github.com/apache/doris/pull/17661#issuecomment-1465493891 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] mrhhsg opened a new pull request, #17718: [fix](agg) Incorrect aggregation result caused by wrong rows_returned from VExchangeNode

2023-03-12 Thread via GitHub
mrhhsg opened a new pull request, #17718: URL: https://github.com/apache/doris/pull/17718 # Proposed changes In aggregation node, `rows_returned` will be used to determine whether the aggregate result is null or not: ```cpp ColumnPtr ptr = std::move(columns[i]);

[GitHub] [doris] HappenLee commented on a diff in pull request #17594: [Feature](parquet-reader) Implements dict filter functionality parquet reader.

2023-03-12 Thread via GitHub
HappenLee commented on code in PR #17594: URL: https://github.com/apache/doris/pull/17594#discussion_r1133435376 ## be/src/vec/exec/format/parquet/vparquet_group_reader.cpp: ## @@ -599,6 +668,236 @@ Status RowGroupReader::_filter_block_internal(Block* block, return Status:

[GitHub] [doris] Kikyou1997 commented on a diff in pull request #17637: [ehancemnet](nereids) Refactor statistics

2023-03-12 Thread via GitHub
Kikyou1997 commented on code in PR #17637: URL: https://github.com/apache/doris/pull/17637#discussion_r1133439538 ## fe/fe-core/src/main/java/org/apache/doris/nereids/cost/CostModelV1.java: ## @@ -221,12 +221,7 @@ public Cost visitPhysicalHashJoin( pattern2: (L join1 Ag

[GitHub] [doris] github-actions[bot] commented on pull request #15588: [Feature](add bitmap udaf) add the bitmap intersection and difference set for mixed calculation of udaf

2023-03-12 Thread via GitHub
github-actions[bot] commented on PR #15588: URL: https://github.com/apache/doris/pull/15588#issuecomment-1465505654 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] 924060929 commented on pull request #17579: [refactor](Nereids) refactor column pruning

2023-03-12 Thread via GitHub
924060929 commented on PR #17579: URL: https://github.com/apache/doris/pull/17579#issuecomment-1465506221 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] yiguolei commented on pull request #17715: [refactor](functioncontext) remove function context impl class

2023-03-12 Thread via GitHub
yiguolei commented on PR #17715: URL: https://github.com/apache/doris/pull/17715#issuecomment-1465507053 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] brody715 opened a new issue, #17719: [Feature](array-function) Support array_cum_sum function

2023-03-12 Thread via GitHub
brody715 opened a new issue, #17719: URL: https://github.com/apache/doris/issues/17719 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Description _No response_

[GitHub] [doris] github-actions[bot] commented on pull request #17715: [refactor](functioncontext) remove function context impl class

2023-03-12 Thread via GitHub
github-actions[bot] commented on PR #17715: URL: https://github.com/apache/doris/pull/17715#issuecomment-1465512704 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] Kikyou1997 opened a new pull request, #17720: [ehancement](profile) Disable profiling for the internal query

2023-03-12 Thread via GitHub
Kikyou1997 opened a new pull request, #17720: URL: https://github.com/apache/doris/pull/17720 # Proposed changes Once user set `enable_profile` globally, the internal queries's profile would be cached and display on the web page,such like for sqls for statistics collection which wou

[GitHub] [doris] Kikyou1997 commented on pull request #17637: [ehancemnet](nereids) Refactor statistics

2023-03-12 Thread via GitHub
Kikyou1997 commented on PR #17637: URL: https://github.com/apache/doris/pull/17637#issuecomment-1465528739 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [doris] Kikyou1997 commented on a diff in pull request #17637: [ehancemnet](nereids) Refactor statistics

2023-03-12 Thread via GitHub
Kikyou1997 commented on code in PR #17637: URL: https://github.com/apache/doris/pull/17637#discussion_r1133452798 ## fe/fe-core/src/main/java/org/apache/doris/nereids/cost/CostModelV1.java: ## @@ -221,12 +221,7 @@ public Cost visitPhysicalHashJoin( pattern2: (L join1 Ag

[GitHub] [doris] lexluo09 opened a new issue, #17721: [Enhancement] (DOE) Support table names with line-through

2023-03-12 Thread via GitHub
lexluo09 opened a new issue, #17721: URL: https://github.com/apache/doris/issues/17721 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Description When the table name

[GitHub] [doris] lexluo09 opened a new issue, #17722: [Enhancement] (DOE) hosts protocol access exception

2023-03-12 Thread via GitHub
lexluo09 opened a new issue, #17722: URL: https://github.com/apache/doris/issues/17722 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Description 1、create catalog

[GitHub] [doris] lexluo09 opened a new issue, #17723: [Enhancement] (DOE) Supports alias field queries

2023-03-12 Thread via GitHub
lexluo09 opened a new issue, #17723: URL: https://github.com/apache/doris/issues/17723 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Description When creating a fie

[GitHub] [doris] hello-stephen commented on pull request #17671: [refactor](Nereids) expression translate no longer rely on legacy planner code

2023-03-12 Thread via GitHub
hello-stephen commented on PR #17671: URL: https://github.com/apache/doris/pull/17671#issuecomment-1465544264 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.47 seconds stream load tsv: 460 seconds loaded 74807831229 Bytes, about 155 MB/s

[GitHub] [doris] zhangstar333 commented on pull request #17581: [vectorized](function) support array_map function

2023-03-12 Thread via GitHub
zhangstar333 commented on PR #17581: URL: https://github.com/apache/doris/pull/17581#issuecomment-1465551855 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] 1330571 commented on pull request #17551: [fix](insert) Session varaiables dont work for transaction insert

2023-03-12 Thread via GitHub
1330571 commented on PR #17551: URL: https://github.com/apache/doris/pull/17551#issuecomment-1465552721 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] bobhan1 opened a new pull request, #17724: [Enhance](array function) add support for DecimalV3 for array_enumerate_uniq()

2023-03-12 Thread via GitHub
bobhan1 opened a new pull request, #17724: URL: https://github.com/apache/doris/pull/17724 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has un

[GitHub] [doris] github-actions[bot] commented on pull request #17581: [vectorized](function) support array_map function

2023-03-12 Thread via GitHub
github-actions[bot] commented on PR #17581: URL: https://github.com/apache/doris/pull/17581#issuecomment-1465556366 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #17724: [Enhance](array function) add support for DecimalV3 for array_enumerate_uniq()

2023-03-12 Thread via GitHub
github-actions[bot] commented on PR #17724: URL: https://github.com/apache/doris/pull/17724#issuecomment-1465556394 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] yuxuan-luo commented on pull request #17694: [Bug](catalog) Fix fetching information_schema table timed out(#17692)

2023-03-12 Thread via GitHub
yuxuan-luo commented on PR #17694: URL: https://github.com/apache/doris/pull/17694#issuecomment-1465562149 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [doris] lexluo09 opened a new issue, #17725: [Enhancement] (DOE) Support for querying data by doc Id

2023-03-12 Thread via GitHub
lexluo09 opened a new issue, #17725: URL: https://github.com/apache/doris/issues/17725 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Description Set the parameter "

[GitHub] [doris] yiguolei merged pull request #17718: [fix](agg) Incorrect aggregation result caused by wrong rows_returned from VExchangeNode

2023-03-12 Thread via GitHub
yiguolei merged PR #17718: URL: https://github.com/apache/doris/pull/17718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[doris] branch branch-1.2-lts updated: [fix](agg) Incorrect aggregation result caused by wrong rows_returned from VExchangeNode (#17718)

2023-03-12 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch branch-1.2-lts in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/branch-1.2-lts by this push: new 0b39084562 [fix](agg) Incorrect

[GitHub] [doris] eldenmoon opened a new pull request, #17726: [Feature](PreparedStatement) implement general server side prepared

2023-03-12 Thread via GitHub
eldenmoon opened a new pull request, #17726: URL: https://github.com/apache/doris/pull/17726 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has

[GitHub] [doris] pengxiangyu closed issue #17712: [Bug](cooldown)Fix bug for storage policy in dynamic partition

2023-03-12 Thread via GitHub
pengxiangyu closed issue #17712: [Bug](cooldown)Fix bug for storage policy in dynamic partition URL: https://github.com/apache/doris/issues/17712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [doris] pengxiangyu merged pull request #17665: [fix](cooldown)Fix bug for storage policy in dynamic partition

2023-03-12 Thread via GitHub
pengxiangyu merged PR #17665: URL: https://github.com/apache/doris/pull/17665 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

[doris] branch master updated (be5147c32e -> ac944e2ac1)

2023-03-12 Thread pengxiangyu
This is an automated email from the ASF dual-hosted git repository. pengxiangyu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from be5147c32e [enhancement](feservice) catch throwable and print log for frontend service (#17708) add ac944e2a

[GitHub] [doris] github-actions[bot] commented on pull request #17726: [Feature](PreparedStatement) implement general server side prepared

2023-03-12 Thread via GitHub
github-actions[bot] commented on PR #17726: URL: https://github.com/apache/doris/pull/17726#issuecomment-1465573828 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] zclllyybb opened a new pull request, #17727: [optimize-WIP](functions)

2023-03-12 Thread via GitHub
zclllyybb opened a new pull request, #17727: URL: https://github.com/apache/doris/pull/17727 # Proposed changes ## Problem summary make functions with only one argument to be automatically transformed when it's a constant column. ## Checklist(Required) * [ ] Does

[GitHub] [doris] yiguolei commented on a diff in pull request #17720: [ehancement](profile) Disable profiling for the internal query

2023-03-12 Thread via GitHub
yiguolei commented on code in PR #17720: URL: https://github.com/apache/doris/pull/17720#discussion_r1133482931 ## fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java: ## @@ -702,6 +702,10 @@ private void forwardToMaster() throws Exception { @Override publ

[GitHub] [doris] dataroaring merged pull request #17584: [Feature](array-function) Support array_pushfront function

2023-03-12 Thread via GitHub
dataroaring merged PR #17584: URL: https://github.com/apache/doris/pull/17584 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

[doris] branch master updated: [Feature](array-function) Support array_pushfront function (#17584)

2023-03-12 Thread dataroaring
This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new c302fa2564 [Feature](array-function) Support

[GitHub] [doris] dataroaring closed issue #17538: [Feature](array function) Support `array_pushfront` function

2023-03-12 Thread via GitHub
dataroaring closed issue #17538: [Feature](array function) Support `array_pushfront` function URL: https://github.com/apache/doris/issues/17538 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [doris] Lchangliang commented on pull request #17710: [Improve](FileCahe) Support the file cache profile iin olap scan node and Update the profile

2023-03-12 Thread via GitHub
Lchangliang commented on PR #17710: URL: https://github.com/apache/doris/pull/17710#issuecomment-1465583935 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [doris] Tanya-W commented on a diff in pull request #17629: [Feature-WIP](inverted index) support range predicate push down to inverted index

2023-03-12 Thread via GitHub
Tanya-W commented on code in PR #17629: URL: https://github.com/apache/doris/pull/17629#discussion_r1133411199 ## be/src/olap/rowset/segment_v2/segment_iterator.cpp: ## @@ -826,11 +824,12 @@ Status SegmentIterator::_apply_inverted_index_on_block_column_predicate(

[GitHub] [doris] github-actions[bot] commented on pull request #17727: [optimize-WIP](functions)

2023-03-12 Thread via GitHub
github-actions[bot] commented on PR #17727: URL: https://github.com/apache/doris/pull/17727#issuecomment-1465584035 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] Kikyou1997 commented on a diff in pull request #17720: [ehancement](profile) Disable profiling for the internal query

2023-03-12 Thread via GitHub
Kikyou1997 commented on code in PR #17720: URL: https://github.com/apache/doris/pull/17720#discussion_r1133487691 ## fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java: ## @@ -702,6 +702,10 @@ private void forwardToMaster() throws Exception { @Override pu

[GitHub] [doris] github-actions[bot] commented on pull request #17710: [Improve](FileCahe) Support the file cache profile iin olap scan node and Update the profile

2023-03-12 Thread via GitHub
github-actions[bot] commented on PR #17710: URL: https://github.com/apache/doris/pull/17710#issuecomment-1465586163 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[doris] branch fix_bug created (now c302fa2564)

2023-03-12 Thread pengxiangyu
This is an automated email from the ASF dual-hosted git repository. pengxiangyu pushed a change to branch fix_bug in repository https://gitbox.apache.org/repos/asf/doris.git at c302fa2564 [Feature](array-function) Support array_pushfront function (#17584) No new revisions were added by t

[GitHub] [doris] HappenLee commented on a diff in pull request #17727: [optimize-WIP](functions)

2023-03-12 Thread via GitHub
HappenLee commented on code in PR #17727: URL: https://github.com/apache/doris/pull/17727#discussion_r1133491701 ## be/src/vec/functions/function_bitmap.cpp: ## @@ -272,8 +272,7 @@ class FunctionBitmapAlwaysNull : public IFunction { auto& null_map = res_null_map->get_da

[GitHub] [doris] stalary commented on issue #17721: [Enhancement] (DOE) Support table names with line-through

2023-03-12 Thread via GitHub
stalary commented on issue #17721: URL: https://github.com/apache/doris/issues/17721#issuecomment-1465591845 Doris not support `-`, you can use \`tag-track-pro\` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] HappenLee commented on a diff in pull request #17727: [optimize-WIP](functions)

2023-03-12 Thread via GitHub
HappenLee commented on code in PR #17727: URL: https://github.com/apache/doris/pull/17727#discussion_r1133492904 ## be/src/vec/functions/functions_comparison.h: ## @@ -112,9 +112,9 @@ struct GenericComparisonImpl { static void NO_INLINE vector_constant(const IColumn& a, c

[GitHub] [doris] zhangguoqiang666 opened a new pull request, #17728: change only doc test

2023-03-12 Thread via GitHub
zhangguoqiang666 opened a new pull request, #17728: URL: https://github.com/apache/doris/pull/17728 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [

[GitHub] [doris] zhangguoqiang666 commented on pull request #17728: change only doc test

2023-03-12 Thread via GitHub
zhangguoqiang666 commented on PR #17728: URL: https://github.com/apache/doris/pull/17728#issuecomment-1465592280 run just_for_test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [doris] Tanya-W commented on a diff in pull request #17629: [Feature-WIP](inverted index) support range predicate push down to inverted index

2023-03-12 Thread via GitHub
Tanya-W commented on code in PR #17629: URL: https://github.com/apache/doris/pull/17629#discussion_r1133492815 ## be/src/olap/rowset/segment_v2/inverted_index_reader.cpp: ## @@ -191,36 +186,73 @@ Status FullTextIndexReader::query(OlapReaderStatistics* stats, const std::string

[GitHub] [doris] yiguolei opened a new pull request, #17729: [fix](agg) Incorrect aggregation result caused by wrong rows_returned from VExchangeNode (#17718)

2023-03-12 Thread via GitHub
yiguolei opened a new pull request, #17729: URL: https://github.com/apache/doris/pull/17729 In aggregation node, rows_returned will be used to determine whether the aggregate result is null or not: ColumnPtr ptr = std::move(columns[i]); // unless `co

[GitHub] [doris] yiguolei commented on pull request #17729: [fix](agg) Incorrect aggregation result caused by wrong rows_returned from VExchangeNode (#17718)

2023-03-12 Thread via GitHub
yiguolei commented on PR #17729: URL: https://github.com/apache/doris/pull/17729#issuecomment-1465592799 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] eldenmoon commented on pull request #17726: [Feature](PreparedStatement) implement general server side prepared

2023-03-12 Thread via GitHub
eldenmoon commented on PR #17726: URL: https://github.com/apache/doris/pull/17726#issuecomment-1465594014 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] yiguolei commented on pull request #17720: [ehancement](profile) Disable profiling for the internal query

2023-03-12 Thread via GitHub
yiguolei commented on PR #17720: URL: https://github.com/apache/doris/pull/17720#issuecomment-1465595215 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] github-actions[bot] commented on pull request #17720: [ehancement](profile) Disable profiling for the internal query

2023-03-12 Thread via GitHub
github-actions[bot] commented on PR #17720: URL: https://github.com/apache/doris/pull/17720#issuecomment-1465595683 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #17720: [ehancement](profile) Disable profiling for the internal query

2023-03-12 Thread via GitHub
github-actions[bot] commented on PR #17720: URL: https://github.com/apache/doris/pull/17720#issuecomment-1465595729 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] Tanya-W commented on a diff in pull request #17629: [Feature-WIP](inverted index) support range predicate push down to inverted index

2023-03-12 Thread via GitHub
Tanya-W commented on code in PR #17629: URL: https://github.com/apache/doris/pull/17629#discussion_r1133496118 ## be/src/olap/rowset/segment_v2/inverted_index_query.cpp: ## @@ -0,0 +1,284 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor l

[GitHub] [doris] Tanya-W commented on a diff in pull request #17629: [Feature-WIP](inverted index) support range predicate push down to inverted index

2023-03-12 Thread via GitHub
Tanya-W commented on code in PR #17629: URL: https://github.com/apache/doris/pull/17629#discussion_r1133492815 ## be/src/olap/rowset/segment_v2/inverted_index_reader.cpp: ## @@ -191,36 +186,73 @@ Status FullTextIndexReader::query(OlapReaderStatistics* stats, const std::string

[doris] branch opt_dict_perf updated (f2407030fb -> b8616a6cb2)

2023-03-12 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a change to branch opt_dict_perf in repository https://gitbox.apache.org/repos/asf/doris.git omit f2407030fb f omit 0ba1797a59 f omit 2004fa3c4b f omit f9446dedf4 f omit 6b5052e4bd try tofix p

[doris] 01/01: [improvement](dict) cache the value of find code (#17674)

2023-03-12 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch opt_dict_perf in repository https://gitbox.apache.org/repos/asf/doris.git commit b8616a6cb291a820fc2dac4a9d58082253794889 Author: Jerry Hu AuthorDate: Fri Mar 10 18:35:07 2023 +0800 [impro

[GitHub] [doris] 1330571 commented on pull request #17551: [fix](insert) Session varaiables dont work for transaction insert

2023-03-12 Thread via GitHub
1330571 commented on PR #17551: URL: https://github.com/apache/doris/pull/17551#issuecomment-1465602199 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] mymeiyi opened a new pull request, #17730: [fix](load) fix cancel load failed because Job could not be cancelled…

2023-03-12 Thread via GitHub
mymeiyi opened a new pull request, #17730: URL: https://github.com/apache/doris/pull/17730 … when job is finished or cancelled # Proposed changes Issue Number: close #xxx ## Problem summary Label can be reused if the previous load is failed. But when cancel a retry

[GitHub] [doris] mymeiyi commented on pull request #17730: [fix](load) fix cancel load failed because Job could not be cancelled…

2023-03-12 Thread via GitHub
mymeiyi commented on PR #17730: URL: https://github.com/apache/doris/pull/17730#issuecomment-1465604093 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] Kikyou1997 commented on a diff in pull request #17637: [ehancemnet](nereids) Refactor statistics

2023-03-12 Thread via GitHub
Kikyou1997 commented on code in PR #17637: URL: https://github.com/apache/doris/pull/17637#discussion_r1133452798 ## fe/fe-core/src/main/java/org/apache/doris/nereids/cost/CostModelV1.java: ## @@ -221,12 +221,7 @@ public Cost visitPhysicalHashJoin( pattern2: (L join1 Ag

[GitHub] [doris] Kikyou1997 commented on pull request #17637: [ehancemnet](nereids) Refactor statistics

2023-03-12 Thread via GitHub
Kikyou1997 commented on PR #17637: URL: https://github.com/apache/doris/pull/17637#issuecomment-1465604805 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [doris] Kikyou1997 commented on a diff in pull request #17637: [ehancemnet](nereids) Refactor statistics

2023-03-12 Thread via GitHub
Kikyou1997 commented on code in PR #17637: URL: https://github.com/apache/doris/pull/17637#discussion_r1133507357 ## fe/fe-core/src/main/java/org/apache/doris/nereids/cost/CostModelV1.java: ## @@ -221,12 +221,7 @@ public Cost visitPhysicalHashJoin( pattern2: (L join1 Ag

<    1   2   3