[GitHub] [doris] github-actions[bot] commented on pull request #16952: [improve](inverted index) not apply inverted index on 'in' or 'not_in' predicate which is produced by runtime_filter

2023-02-20 Thread via GitHub
github-actions[bot] commented on PR #16952: URL: https://github.com/apache/doris/pull/16952#issuecomment-1436952496 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] Tanya-W commented on pull request #16952: [improve](inverted index) not apply inverted index on 'in' or 'not_in' predicate which is produced by runtime_filter

2023-02-20 Thread via GitHub
Tanya-W commented on PR #16952: URL: https://github.com/apache/doris/pull/16952#issuecomment-1436953081 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] github-actions[bot] commented on pull request #16952: [improve](inverted index) not apply inverted index on 'in' or 'not_in' predicate which is produced by runtime_filter

2023-02-20 Thread via GitHub
github-actions[bot] commented on PR #16952: URL: https://github.com/apache/doris/pull/16952#issuecomment-1436953979 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #16952: [improve](inverted index) not apply inverted index on 'in' or 'not_in' predicate which is produced by runtime_filter

2023-02-20 Thread via GitHub
github-actions[bot] commented on PR #16952: URL: https://github.com/apache/doris/pull/16952#issuecomment-1436954435 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] xy720 commented on a diff in pull request #16948: [Improve](map-type) Add contains_null for map

2023-02-20 Thread via GitHub
xy720 commented on code in PR #16948: URL: https://github.com/apache/doris/pull/16948#discussion_r890046 ## fe/fe-core/src/main/java/org/apache/doris/analysis/MapLiteral.java: ## @@ -47,30 +47,18 @@ public MapLiteral(LiteralExpr... exprs) throws AnalysisException {

[GitHub] [doris] xy720 commented on a diff in pull request #16948: [Improve](map-type) Add contains_null for map

2023-02-20 Thread via GitHub
xy720 commented on code in PR #16948: URL: https://github.com/apache/doris/pull/16948#discussion_r821110 ## fe/fe-core/src/main/java/org/apache/doris/analysis/MapLiteral.java: ## @@ -47,30 +47,18 @@ public MapLiteral(LiteralExpr... exprs) throws AnalysisException {

[GitHub] [doris] xy720 commented on a diff in pull request #16948: [Improve](map-type) Add contains_null for map

2023-02-20 Thread via GitHub
xy720 commented on code in PR #16948: URL: https://github.com/apache/doris/pull/16948#discussion_r821110 ## fe/fe-core/src/main/java/org/apache/doris/analysis/MapLiteral.java: ## @@ -47,30 +47,18 @@ public MapLiteral(LiteralExpr... exprs) throws AnalysisException {

[GitHub] [doris] github-actions[bot] commented on pull request #16564: [feature](merge-on-write) add DCHECK in compaction to detect data inconsistency

2023-02-20 Thread via GitHub
github-actions[bot] commented on PR #16564: URL: https://github.com/apache/doris/pull/16564#issuecomment-1436984938 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] HappenLee opened a new pull request, #16953: [Function](vec) use const column to opt function current_time()

2023-02-20 Thread via GitHub
HappenLee opened a new pull request, #16953: URL: https://github.com/apache/doris/pull/16953 # Proposed changes Before: ``` mysql> select count(current_time()) from hits; +---+ | count(current_time()) | +---+ |

[GitHub] [doris] github-actions[bot] commented on pull request #16953: [Function](vec) use const column to opt function current_time()

2023-02-20 Thread via GitHub
github-actions[bot] commented on PR #16953: URL: https://github.com/apache/doris/pull/16953#issuecomment-1436998931 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #16953: [Function](vec) use const column to opt function current_time()

2023-02-20 Thread via GitHub
github-actions[bot] commented on PR #16953: URL: https://github.com/apache/doris/pull/16953#issuecomment-1437005544 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] xy720 closed issue #9302: [Feature] Support protobuf format for routine load

2023-02-20 Thread via GitHub
xy720 closed issue #9302: [Feature] Support protobuf format for routine load URL: https://github.com/apache/doris/issues/9302 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] sohardforaname commented on pull request #16824: [regression-test](Nereids) add agg function, tvf, generator, window function test cases

2023-02-20 Thread via GitHub
sohardforaname commented on PR #16824: URL: https://github.com/apache/doris/pull/16824#issuecomment-1437015994 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] sohardforaname commented on pull request #16824: [regression-test](Nereids) add agg function, tvf, generator, window function test cases

2023-02-20 Thread via GitHub
sohardforaname commented on PR #16824: URL: https://github.com/apache/doris/pull/16824#issuecomment-1437016465 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [doris] github-actions[bot] commented on pull request #16941: (feature)[DOE]Support array for Doris on ES

2023-02-20 Thread via GitHub
github-actions[bot] commented on PR #16941: URL: https://github.com/apache/doris/pull/16941#issuecomment-1437021424 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] freemandealer commented on pull request #16950: [fix](log) fix and clarify error msg for tablet writer write failure …

2023-02-20 Thread via GitHub
freemandealer commented on PR #16950: URL: https://github.com/apache/doris/pull/16950#issuecomment-1437022897 After apply this pr, the error output would be like: ``` "Message": "[INTERNAL_ERROR]cancelled: [INTERNAL_ERROR]tablet error: tablet writer write failed, tablet_id=10083, txn_i

[GitHub] [doris] sohardforaname commented on pull request #16824: [regression-test](Nereids) add agg function, tvf, generator, window function test cases

2023-02-20 Thread via GitHub
sohardforaname commented on PR #16824: URL: https://github.com/apache/doris/pull/16824#issuecomment-1437023157 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] github-actions[bot] commented on pull request #16941: (feature)[DOE]Support array for Doris on ES

2023-02-20 Thread via GitHub
github-actions[bot] commented on PR #16941: URL: https://github.com/apache/doris/pull/16941#issuecomment-1437027164 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] hello-stephen commented on pull request #16931: [Fix](multi-catalog) Fix switch-case fall-through issue in multi-catalog module.

2023-02-20 Thread via GitHub
hello-stephen commented on PR #16931: URL: https://github.com/apache/doris/pull/16931#issuecomment-1437030622 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.95 seconds stream load tsv: 469 seconds loaded 74807831229 Bytes, about 152 MB/s

[GitHub] [doris] freemandealer opened a new issue, #16954: [Bug] useless error message when tablet write failed

2023-02-20 Thread via GitHub
freemandealer opened a new issue, #16954: URL: https://github.com/apache/doris/issues/16954 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version newest upstream

[GitHub] [doris] BiteTheDDDDt merged pull request #16931: [Fix](multi-catalog) Fix switch-case fall-through issue in multi-catalog module.

2023-02-20 Thread via GitHub
BiteThet merged PR #16931: URL: https://github.com/apache/doris/pull/16931 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris

[doris] branch master updated: [Fix](multi-catalog) Fix switch-case fall-through issue in multi-catalog module. (#16931)

2023-02-20 Thread panxiaolei
This is an automated email from the ASF dual-hosted git repository. panxiaolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new a46941c684 [Fix](multi-catalog) Fix switch-ca

[GitHub] [doris] BiteTheDDDDt opened a new pull request, #16955: [Enchancement](function) refact and optimize some function register

2023-02-20 Thread via GitHub
BiteThet opened a new pull request, #16955: URL: https://github.com/apache/doris/pull/16955 # Proposed changes 1. refact function create helper 2. use AggregateFunctionNullUnaryInline to optimize group_by_or/and/xor and distinct combinator. 3.42 sec -> 3.27 sec ## Proble

[GitHub] [doris] github-actions[bot] commented on pull request #16955: [Enchancement](function) refact and optimize some function register

2023-02-20 Thread via GitHub
github-actions[bot] commented on PR #16955: URL: https://github.com/apache/doris/pull/16955#issuecomment-1437047271 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc

2023-02-20 Thread via GitHub
TangSiyang2001 commented on PR #16123: URL: https://github.com/apache/doris/pull/16123#issuecomment-1437052296 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc

2023-02-20 Thread via GitHub
TangSiyang2001 commented on PR #16123: URL: https://github.com/apache/doris/pull/16123#issuecomment-1437052447 run p1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] BiteTheDDDDt commented on pull request #16955: [Enchancement](function) refact and optimize some function register

2023-02-20 Thread via GitHub
BiteThet commented on PR #16955: URL: https://github.com/apache/doris/pull/16955#issuecomment-1437055466 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] Tanya-W commented on pull request #16952: [improve](inverted index) not apply inverted index on 'in' or 'not_in' predicate which is produced by runtime_filter

2023-02-20 Thread via GitHub
Tanya-W commented on PR #16952: URL: https://github.com/apache/doris/pull/16952#issuecomment-1437057948 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] github-actions[bot] commented on pull request #16952: [improve](inverted index) not apply inverted index on 'in' or 'not_in' predicate which is produced by runtime_filter

2023-02-20 Thread via GitHub
github-actions[bot] commented on PR #16952: URL: https://github.com/apache/doris/pull/16952#issuecomment-1437060541 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #16889: [fix](replica) Fix inconsistent replica id between BE and FE in corner case of tablet rebalance

2023-02-20 Thread via GitHub
github-actions[bot] commented on PR #16889: URL: https://github.com/apache/doris/pull/16889#issuecomment-1437062027 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #16803: [fix](cooldown) Use `pending_remote_rowsets` to avoid deleting rowset files being uploaded

2023-02-20 Thread via GitHub
github-actions[bot] commented on PR #16803: URL: https://github.com/apache/doris/pull/16803#issuecomment-1437063933 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc

2023-02-20 Thread via GitHub
TangSiyang2001 commented on PR #16123: URL: https://github.com/apache/doris/pull/16123#issuecomment-1437065821 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc

2023-02-20 Thread via GitHub
TangSiyang2001 commented on PR #16123: URL: https://github.com/apache/doris/pull/16123#issuecomment-1437066021 run p1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc

2023-02-20 Thread via GitHub
TangSiyang2001 commented on PR #16123: URL: https://github.com/apache/doris/pull/16123#issuecomment-1437066287 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [doris] github-actions[bot] commented on pull request #16938: [fix](union iterator) fix bug that result data order of VUnionIterator is different

2023-02-20 Thread via GitHub
github-actions[bot] commented on PR #16938: URL: https://github.com/apache/doris/pull/16938#issuecomment-1437068284 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc

2023-02-20 Thread via GitHub
github-actions[bot] commented on PR #16123: URL: https://github.com/apache/doris/pull/16123#issuecomment-1437069243 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] hello-stephen commented on pull request #16955: [Enchancement](function) refact and optimize some function register

2023-02-20 Thread via GitHub
hello-stephen commented on PR #16955: URL: https://github.com/apache/doris/pull/16955#issuecomment-1437082077 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 35.77 seconds stream load tsv: 471 seconds loaded 74807831229 Bytes, about 151 MB/s

[GitHub] [doris] github-actions[bot] commented on pull request #16953: [Function](vec) use const column to opt function current_time()

2023-02-20 Thread via GitHub
github-actions[bot] commented on PR #16953: URL: https://github.com/apache/doris/pull/16953#issuecomment-1437085365 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc

2023-02-20 Thread via GitHub
github-actions[bot] commented on PR #16123: URL: https://github.com/apache/doris/pull/16123#issuecomment-1437094418 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #16850: [improvement](vec) avoid creating a new column while filtering mutable columns

2023-02-20 Thread via GitHub
github-actions[bot] commented on PR #16850: URL: https://github.com/apache/doris/pull/16850#issuecomment-1437105520 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] platoneko opened a new pull request, #16956: [fix](cooldown) Forbid re-add replica with cooldowned rowsets

2023-02-20 Thread via GitHub
platoneko opened a new pull request, #16956: URL: https://github.com/apache/doris/pull/16956 # Proposed changes Issue Number: close #xxx ## Problem summary Forbid re-add replica with cooldowned rowsets, because these cooldowned rowsets may already been confirmed as unuse

[GitHub] [doris] morningman opened a new pull request, #16957: [fix](auth) fix losing global priv bug and refactor default role name

2023-02-20 Thread via GitHub
morningman opened a new pull request, #16957: URL: https://github.com/apache/doris/pull/16957 # Proposed changes Issue Number: close #xxx ## Problem summary This PR mainly changes: 1. When upgrading from old version to master, the ADMIN_PRIV for normal user may be

[doris] 02/03: 3

2023-02-20 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch auth_replay_bg in repository https://gitbox.apache.org/repos/asf/doris.git commit c6f30fadc2aaedbfd164f96874f525325eb66d5f Author: morningman AuthorDate: Mon Feb 20 22:06:08 2023 +0800 3

[doris] branch auth_replay_bg created (now 0b574c532d)

2023-02-20 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch auth_replay_bg in repository https://gitbox.apache.org/repos/asf/doris.git at 0b574c532d add doc This branch includes the following new commits: new c17eceaad4 1 new c6f30fa

[doris] 03/03: add doc

2023-02-20 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch auth_replay_bg in repository https://gitbox.apache.org/repos/asf/doris.git commit 0b574c532d8aa6954859404d3baa5b2e63c96c34 Author: morningman AuthorDate: Mon Feb 20 22:17:32 2023 +0800 a

[doris] 01/03: 1

2023-02-20 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch auth_replay_bg in repository https://gitbox.apache.org/repos/asf/doris.git commit c17eceaad4533d628662de19f97e334e0b083ac6 Author: morningman AuthorDate: Mon Feb 20 18:41:55 2023 +0800 1

[GitHub] [doris] dataroaring commented on a diff in pull request #16472: [improvement](meta) Enhance Doris's fault tolerance to disk error

2023-02-20 Thread via GitHub
dataroaring commented on code in PR #16472: URL: https://github.com/apache/doris/pull/16472#discussion_r1112009136 ## be/src/olap/tablet.h: ## @@ -391,6 +391,14 @@ class Tablet : public BaseTablet { } } +inline void increase_io_error_times() { ++_io_error_tim

[GitHub] [doris] github-actions[bot] commented on pull request #16472: [improvement](meta) Enhance Doris's fault tolerance to disk error

2023-02-20 Thread via GitHub
github-actions[bot] commented on PR #16472: URL: https://github.com/apache/doris/pull/16472#issuecomment-1437135172 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #16472: [improvement](meta) Enhance Doris's fault tolerance to disk error

2023-02-20 Thread via GitHub
github-actions[bot] commented on PR #16472: URL: https://github.com/apache/doris/pull/16472#issuecomment-1437135104 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris-website] wangyf0555 closed pull request #192: website optimization

2023-02-20 Thread via GitHub
wangyf0555 closed pull request #192: website optimization URL: https://github.com/apache/doris-website/pull/192 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [doris] morningman commented on pull request #16928: [fix](tvf) fix bug that failed to get schema of tvf when file is empty

2023-02-20 Thread via GitHub
morningman commented on PR #16928: URL: https://github.com/apache/doris/pull/16928#issuecomment-1437146050 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [doris] amorynan commented on a diff in pull request #16948: [Improve](map-type) Add contains_null for map

2023-02-20 Thread via GitHub
amorynan commented on code in PR #16948: URL: https://github.com/apache/doris/pull/16948#discussion_r1112054418 ## fe/fe-core/src/main/java/org/apache/doris/analysis/MapLiteral.java: ## @@ -47,30 +47,18 @@ public MapLiteral(LiteralExpr... exprs) throws AnalysisException {

[GitHub] [doris] morningman commented on pull request #16891: [improvement](scan) separate scanner into local and remote scanner pool

2023-02-20 Thread via GitHub
morningman commented on PR #16891: URL: https://github.com/apache/doris/pull/16891#issuecomment-1437150551 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [doris] morningman commented on a diff in pull request #16891: [improvement](scan) separate scanner into local and remote scanner pool

2023-02-20 Thread via GitHub
morningman commented on code in PR #16891: URL: https://github.com/apache/doris/pull/16891#discussion_r1112056687 ## be/src/vec/exec/scan/new_olap_scanner.cpp: ## @@ -385,6 +385,23 @@ Status NewOlapScanner::_init_return_columns() { return Status::OK(); } +doris::TabletSt

[GitHub] [doris] github-actions[bot] commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc

2023-02-20 Thread via GitHub
github-actions[bot] commented on PR #16123: URL: https://github.com/apache/doris/pull/16123#issuecomment-1437151221 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #16928: [fix](tvf) fix bug that failed to get schema of tvf when file is empty

2023-02-20 Thread via GitHub
github-actions[bot] commented on PR #16928: URL: https://github.com/apache/doris/pull/16928#issuecomment-1437154080 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] morningman merged pull request #16771: [enhancement](exception safe) make function state exception safe

2023-02-20 Thread via GitHub
morningman merged PR #16771: URL: https://github.com/apache/doris/pull/16771 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.a

[doris] branch master updated: [enhancement](exception safe) make function state exception safe (#16771)

2023-02-20 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new e04c13b7a6 [enhancement](exception safe) make

[GitHub] [doris] github-actions[bot] commented on pull request #16891: [improvement](scan) separate scanner into local and remote scanner pool

2023-02-20 Thread via GitHub
github-actions[bot] commented on PR #16891: URL: https://github.com/apache/doris/pull/16891#issuecomment-1437157720 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc

2023-02-20 Thread via GitHub
TangSiyang2001 commented on PR #16123: URL: https://github.com/apache/doris/pull/16123#issuecomment-1437169917 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc

2023-02-20 Thread via GitHub
TangSiyang2001 commented on PR #16123: URL: https://github.com/apache/doris/pull/16123#issuecomment-1437170358 run p1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc

2023-02-20 Thread via GitHub
TangSiyang2001 commented on PR #16123: URL: https://github.com/apache/doris/pull/16123#issuecomment-1437170109 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] BePPPower opened a new pull request, #16958: [BugFix](Jdbc Catalog) Fix null pointer exception in JdbcExecutor

2023-02-20 Thread via GitHub
BePPPower opened a new pull request, #16958: URL: https://github.com/apache/doris/pull/16958 # Proposed changes Issue Number: close #xxx This pr do two things: 1. fix: It use `column[0]` to judge class type in JdbcExecutor, but column[0] may be null ! 3. enhen

[GitHub] [doris] hello-stephen commented on pull request #16889: [fix](replica) Fix inconsistent replica id between BE and FE in corner case of tablet rebalance

2023-02-20 Thread via GitHub
hello-stephen commented on PR #16889: URL: https://github.com/apache/doris/pull/16889#issuecomment-1437174813 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 35.56 seconds stream load tsv: 469 seconds loaded 74807831229 Bytes, about 152 MB/s

[GitHub] [doris] TangSiyang2001 opened a new issue, #16959: [Enhancement](regression-test) complete the regression-test of BE brpc-http api

2023-02-20 Thread via GitHub
TangSiyang2001 opened a new issue, #16959: URL: https://github.com/apache/doris/issues/16959 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Description When implemen

[GitHub] [doris] ZhangGuoqiang666 commented on pull request #16944: [improvement](test)Set compile required and add clickbench,arm to buildall

2023-02-20 Thread via GitHub
ZhangGuoqiang666 commented on PR #16944: URL: https://github.com/apache/doris/pull/16944#issuecomment-1437196914 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [doris] mrhhsg commented on pull request #16850: [improvement](vec) avoid creating a new column while filtering mutable columns

2023-02-20 Thread via GitHub
mrhhsg commented on PR #16850: URL: https://github.com/apache/doris/pull/16850#issuecomment-1437211532 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [doris] hello-stephen commented on pull request #16953: [Function](vec) use const column to opt function current_time()

2023-02-20 Thread via GitHub
hello-stephen commented on PR #16953: URL: https://github.com/apache/doris/pull/16953#issuecomment-1437214414 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 35 seconds stream load tsv: 468 seconds loaded 74807831229 Bytes, about 152 MB/s

[GitHub] [doris] TangSiyang2001 commented on a diff in pull request #15339: [enhancement](aggregate-function) enhance aggregate funtion collect and add group_array aliases

2023-02-20 Thread via GitHub
TangSiyang2001 commented on code in PR #15339: URL: https://github.com/apache/doris/pull/15339#discussion_r1112107754 ## be/src/vec/aggregate_functions/aggregate_function_collect.h: ## @@ -31,122 +33,180 @@ namespace doris::vectorized { -template +template struct Aggrega

[GitHub] [doris] TangSiyang2001 commented on a diff in pull request #15339: [enhancement](aggregate-function) enhance aggregate funtion collect and add group_array aliases

2023-02-20 Thread via GitHub
TangSiyang2001 commented on code in PR #15339: URL: https://github.com/apache/doris/pull/15339#discussion_r1112109843 ## be/src/vec/aggregate_functions/aggregate_function_collect.h: ## @@ -202,27 +266,36 @@ class AggregateFunctionCollect final } DataTypePtr get_retur

[GitHub] [doris] jackwener commented on pull request #16910: [feature](Nereids): Eliminate duplicate join condition.

2023-02-20 Thread via GitHub
jackwener commented on PR #16910: URL: https://github.com/apache/doris/pull/16910#issuecomment-1437219935 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] TangSiyang2001 commented on a diff in pull request #15339: [enhancement](aggregate-function) enhance aggregate funtion collect and add group_array aliases

2023-02-20 Thread via GitHub
TangSiyang2001 commented on code in PR #15339: URL: https://github.com/apache/doris/pull/15339#discussion_r1112110316 ## be/src/vec/aggregate_functions/aggregate_function_collect.h: ## @@ -31,122 +33,180 @@ namespace doris::vectorized { -template +template struct Aggrega

[GitHub] [doris] TangSiyang2001 commented on a diff in pull request #15339: [enhancement](aggregate-function) enhance aggregate funtion collect and add group_array aliases

2023-02-20 Thread via GitHub
TangSiyang2001 commented on code in PR #15339: URL: https://github.com/apache/doris/pull/15339#discussion_r1112116359 ## be/src/vec/aggregate_functions/aggregate_function_collect.h: ## @@ -202,27 +266,36 @@ class AggregateFunctionCollect final } DataTypePtr get_retur

[GitHub] [doris] TangSiyang2001 commented on a diff in pull request #15339: [enhancement](aggregate-function) enhance aggregate funtion collect and add group_array aliases

2023-02-20 Thread via GitHub
TangSiyang2001 commented on code in PR #15339: URL: https://github.com/apache/doris/pull/15339#discussion_r1112109843 ## be/src/vec/aggregate_functions/aggregate_function_collect.h: ## @@ -202,27 +266,36 @@ class AggregateFunctionCollect final } DataTypePtr get_retur

[GitHub] [doris] zclllyybb commented on pull request #16935: [Fix](function)fix datatime-diff function's overflow

2023-02-20 Thread via GitHub
zclllyybb commented on PR #16935: URL: https://github.com/apache/doris/pull/16935#issuecomment-1437229100 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] github-actions[bot] commented on pull request #16935: [Fix](function)fix datatime-diff function's overflow

2023-02-20 Thread via GitHub
github-actions[bot] commented on PR #16935: URL: https://github.com/apache/doris/pull/16935#issuecomment-1437230112 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #16935: [Fix](function)fix datatime-diff function's overflow

2023-02-20 Thread via GitHub
github-actions[bot] commented on PR #16935: URL: https://github.com/apache/doris/pull/16935#issuecomment-1437231788 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris-website] wangyf0555 closed pull request #194: website optimization

2023-02-20 Thread via GitHub
wangyf0555 closed pull request #194: website optimization URL: https://github.com/apache/doris-website/pull/194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [doris] jacktengg commented on pull request #16384: [regression-test](fuzzy) fuzzy session variable batch_size

2023-02-20 Thread via GitHub
jacktengg commented on PR #16384: URL: https://github.com/apache/doris/pull/16384#issuecomment-1437237916 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [doris] jacktengg commented on pull request #16384: [regression-test](fuzzy) fuzzy session variable batch_size

2023-02-20 Thread via GitHub
jacktengg commented on PR #16384: URL: https://github.com/apache/doris/pull/16384#issuecomment-1437239157 run beut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [doris] hello-stephen commented on pull request #16957: [fix](auth) fix losing global priv bug and refactor default role name

2023-02-20 Thread via GitHub
hello-stephen commented on PR #16957: URL: https://github.com/apache/doris/pull/16957#issuecomment-1437238704 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.91 seconds stream load tsv: 472 seconds loaded 74807831229 Bytes, about 151 MB/s

[GitHub] [doris] jacktengg commented on pull request #16384: [regression-test](fuzzy) fuzzy session variable batch_size

2023-02-20 Thread via GitHub
jacktengg commented on PR #16384: URL: https://github.com/apache/doris/pull/16384#issuecomment-1437238820 run feut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [doris] jacktengg commented on pull request #16938: [fix](union iterator) fix bug that result data order of VUnionIterator is different

2023-02-20 Thread via GitHub
jacktengg commented on PR #16938: URL: https://github.com/apache/doris/pull/16938#issuecomment-1437240354 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [doris] github-actions[bot] commented on pull request #16935: [Fix](function)fix datatime-diff function's overflow

2023-02-20 Thread via GitHub
github-actions[bot] commented on PR #16935: URL: https://github.com/apache/doris/pull/16935#issuecomment-1437240412 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] jacktengg commented on pull request #16938: [fix](union iterator) fix bug that result data order of VUnionIterator is different

2023-02-20 Thread via GitHub
jacktengg commented on PR #16938: URL: https://github.com/apache/doris/pull/16938#issuecomment-1437240573 run beut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [doris] TangSiyang2001 commented on pull request #15339: [enhancement](aggregate-function) enhance aggregate funtion collect and add group_array aliases

2023-02-20 Thread via GitHub
TangSiyang2001 commented on PR #15339: URL: https://github.com/apache/doris/pull/15339#issuecomment-1437242528 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [doris] freemandealer commented on pull request #16950: [fix](log) fix and clarify error msg for tablet writer write failure …

2023-02-20 Thread via GitHub
freemandealer commented on PR #16950: URL: https://github.com/apache/doris/pull/16950#issuecomment-1437244329 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [doris] github-actions[bot] commented on pull request #16950: [fix](log) fix and clarify error msg for tablet writer write failure …

2023-02-20 Thread via GitHub
github-actions[bot] commented on PR #16950: URL: https://github.com/apache/doris/pull/16950#issuecomment-1437246918 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #15339: [enhancement](aggregate-function) enhance aggregate funtion collect and add group_array aliases

2023-02-20 Thread via GitHub
github-actions[bot] commented on PR #15339: URL: https://github.com/apache/doris/pull/15339#issuecomment-1437247396 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] TangSiyang2001 commented on pull request #15339: [enhancement](aggregate-function) enhance aggregate funtion collect and add group_array aliases

2023-02-20 Thread via GitHub
TangSiyang2001 commented on PR #15339: URL: https://github.com/apache/doris/pull/15339#issuecomment-1437266720 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] TangSiyang2001 commented on pull request #15339: [enhancement](aggregate-function) enhance aggregate funtion collect and add group_array aliases

2023-02-20 Thread via GitHub
TangSiyang2001 commented on PR #15339: URL: https://github.com/apache/doris/pull/15339#issuecomment-1437266948 run p1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] platoneko commented on pull request #16889: [fix](replica) Fix inconsistent replica id between BE and FE in corner case of tablet rebalance

2023-02-20 Thread via GitHub
platoneko commented on PR #16889: URL: https://github.com/apache/doris/pull/16889#issuecomment-1437328855 run feut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [doris] platoneko commented on pull request #16889: [fix](replica) Fix inconsistent replica id between BE and FE in corner case of tablet rebalance

2023-02-20 Thread via GitHub
platoneko commented on PR #16889: URL: https://github.com/apache/doris/pull/16889#issuecomment-1437330260 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] platoneko commented on pull request #16956: [fix](cooldown) Forbid re-add replica with cooldowned rowsets

2023-02-20 Thread via GitHub
platoneko commented on PR #16956: URL: https://github.com/apache/doris/pull/16956#issuecomment-1437332691 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] platoneko commented on pull request #16803: [fix](cooldown) Use `pending_remote_rowsets` to avoid deleting rowset files being uploaded

2023-02-20 Thread via GitHub
platoneko commented on PR #16803: URL: https://github.com/apache/doris/pull/16803#issuecomment-1437332001 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] Yukang-Lian commented on pull request #16340: [feature](mysql) Support secure MySQL connection to FE

2023-02-20 Thread via GitHub
Yukang-Lian commented on PR #16340: URL: https://github.com/apache/doris/pull/16340#issuecomment-1437352057 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] platoneko commented on pull request #16803: [fix](cooldown) Use `pending_remote_rowsets` to avoid deleting rowset files being uploaded

2023-02-20 Thread via GitHub
platoneko commented on PR #16803: URL: https://github.com/apache/doris/pull/16803#issuecomment-1437391303 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [doris] platoneko commented on pull request #16889: [fix](replica) Fix inconsistent replica id between BE and FE in corner case of tablet rebalance

2023-02-20 Thread via GitHub
platoneko commented on PR #16889: URL: https://github.com/apache/doris/pull/16889#issuecomment-1437392582 build p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [doris] platoneko commented on pull request #16889: [fix](replica) Fix inconsistent replica id between BE and FE in corner case of tablet rebalance

2023-02-20 Thread via GitHub
platoneko commented on PR #16889: URL: https://github.com/apache/doris/pull/16889#issuecomment-1437392701 build feut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] WinkerDu commented on issue #16561: [Enhancement] Support function `microseconds_add` and `microseconds_sub`

2023-02-20 Thread via GitHub
WinkerDu commented on issue #16561: URL: https://github.com/apache/doris/issues/16561#issuecomment-1437421552 @Gabriel39 I have finished datatimev2 `microseconds_add` support, will push a commit soon. -- This is an automated message from the Apache Git Service. To respond to the messa

  1   2   3   4   5   >