[GitHub] [incubator-doris] jacktengg commented on a diff in pull request #9736: [bugfix] fix memleaks reported by ASAN

2022-05-23 Thread GitBox
jacktengg commented on code in PR #9736: URL: https://github.com/apache/incubator-doris/pull/9736#discussion_r879085624 ## be/src/vec/exprs/vexpr.h: ## @@ -108,7 +108,13 @@ class VExpr { VExpr* parent, int* node_idx, VExpr** root_expr,

[incubator-doris] branch master updated (fdd5bc07a9 -> 5039ec4570)

2022-05-23 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git from fdd5bc07a9 [doc]Add SQL Select usage help documentation (#9729) add 5039ec4570 [vec][opt] opt hash joi

[GitHub] [incubator-doris] yiguolei merged pull request #9735: [vec][opt] opt hash join build resize hash table before insert data

2022-05-23 Thread GitBox
yiguolei merged PR #9735: URL: https://github.com/apache/incubator-doris/pull/9735 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@d

[GitHub] [incubator-doris] yiguolei closed pull request #9069: resize hash table before building

2022-05-23 Thread GitBox
yiguolei closed pull request #9069: resize hash table before building URL: https://github.com/apache/incubator-doris/pull/9069 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [incubator-doris] yiguolei commented on pull request #9732: [optimize] init join hash table size by rows before hash table building

2022-05-23 Thread GitBox
yiguolei commented on PR #9732: URL: https://github.com/apache/incubator-doris/pull/9732#issuecomment-1134273470 Duplicate with #9735 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] yiguolei closed pull request #9732: [optimize] init join hash table size by rows before hash table building

2022-05-23 Thread GitBox
yiguolei closed pull request #9732: [optimize] init join hash table size by rows before hash table building URL: https://github.com/apache/incubator-doris/pull/9732 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9708: [refactor][be] Optimize headers

2022-05-23 Thread GitBox
github-actions[bot] commented on PR #9708: URL: https://github.com/apache/incubator-doris/pull/9708#issuecomment-1134284011 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9708: [refactor][be] Optimize headers

2022-05-23 Thread GitBox
github-actions[bot] commented on PR #9708: URL: https://github.com/apache/incubator-doris/pull/9708#issuecomment-1134284053 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [incubator-doris] luozenglin opened a new issue, #9737: [Bug] InPredicate child expressions type conversion related exceptions

2022-05-23 Thread GitBox
luozenglin opened a new issue, #9737: URL: https://github.com/apache/incubator-doris/issues/9737 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version 1.0

[GitHub] [incubator-doris] luozenglin opened a new issue, #9738: [Bug] InPredicate child expressions type conversion related exceptions

2022-05-23 Thread GitBox
luozenglin opened a new issue, #9738: URL: https://github.com/apache/incubator-doris/issues/9738 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version 1.0

[GitHub] [incubator-doris] luozenglin opened a new pull request, #9739: [Enhancement][fix] Add a rewrite rule to optimize InPredicate.

2022-05-23 Thread GitBox
luozenglin opened a new pull request, #9739: URL: https://github.com/apache/incubator-doris/pull/9739 1. Convert child expressions in InPredicate to column type and discard child expressions in them that cannot be converted exactly. 2. Fix the bug of ColumnRange exception caused by InPred

[GitHub] [incubator-doris] HappenLee commented on a diff in pull request #9541: [feature-wip](parquet-orc) Support orc scanner in vectorized engine

2022-05-23 Thread GitBox
HappenLee commented on code in PR #9541: URL: https://github.com/apache/incubator-doris/pull/9541#discussion_r879094893 ## be/src/vec/data_types/data_type_factory.cpp: ## @@ -310,10 +310,10 @@ DataTypePtr DataTypeFactory::create_data_type(const arrow::Type::type& type, boo

[GitHub] [incubator-doris] yinzhijian commented on a diff in pull request #9541: [feature-wip](parquet-orc) Support orc scanner in vectorized engine

2022-05-23 Thread GitBox
yinzhijian commented on code in PR #9541: URL: https://github.com/apache/incubator-doris/pull/9541#discussion_r879138403 ## be/src/vec/data_types/data_type_factory.cpp: ## @@ -310,10 +310,10 @@ DataTypePtr DataTypeFactory::create_data_type(const arrow::Type::type& type, boo

[GitHub] [incubator-doris] qidaye commented on a diff in pull request #9658: Refactor part of Iceberg code to support more Iceberg Catalogs

2022-05-23 Thread GitBox
qidaye commented on code in PR #9658: URL: https://github.com/apache/incubator-doris/pull/9658#discussion_r879153705 ## docs/en/ecosystem/external-table/iceberg-of-doris.md: ## @@ -135,10 +167,15 @@ You can also create an Iceberg table by explicitly specifying the column defini

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9686: push predicate to subquery

2022-05-23 Thread GitBox
github-actions[bot] commented on PR #9686: URL: https://github.com/apache/incubator-doris/pull/9686#issuecomment-1134387189 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [incubator-doris] morrySnow opened a new issue, #9740: [Enhancement] change Doris's query organization syntax to standard sql

2022-05-23 Thread GitBox
morrySnow opened a new issue, #9740: URL: https://github.com/apache/incubator-doris/issues/9740 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Description

[GitHub] [incubator-doris] jackwener commented on a diff in pull request #9739: [Enhancement][fix] Add a rewrite rule to optimize InPredicate.

2022-05-23 Thread GitBox
jackwener commented on code in PR #9739: URL: https://github.com/apache/incubator-doris/pull/9739#discussion_r879216788 ## fe/fe-core/src/main/java/org/apache/doris/rewrite/RewriteInPredicateRule.java: ## @@ -0,0 +1,114 @@ +// Licensed to the Apache Software Foundation (ASF) und

[GitHub] [incubator-doris] xiaokang opened a new pull request, #9741: fix column reader compress codec unsafe problem

2022-05-23 Thread GitBox
xiaokang opened a new pull request, #9741: URL: https://github.com/apache/incubator-doris/pull/9741 fix column reader compress codec unsafe problem by moving codec from shared reader to unshared iterator # Proposed changes Issue Number: close #9706, which was introduced by htt

[GitHub] [incubator-doris] SaintBacchus commented on a diff in pull request #9485: [Tiny-fix] Add show user stmt impl.

2022-05-23 Thread GitBox
SaintBacchus commented on code in PR #9485: URL: https://github.com/apache/incubator-doris/pull/9485#discussion_r879301924 ## docs/zh-CN/sql-manual/sql-reference/Show-Statements/SHOW-USER.md: ## @@ -31,9 +31,19 @@ under the License. SHOW USER ### Description +该语句用于展示当前登录用户的用

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9741: fix column reader compress codec unsafe problem

2022-05-23 Thread GitBox
github-actions[bot] commented on PR #9741: URL: https://github.com/apache/incubator-doris/pull/9741#issuecomment-1134514706 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [incubator-doris] stalary commented on pull request #9694: [Bug] Fix create table like when having hidden columns

2022-05-23 Thread GitBox
stalary commented on PR #9694: URL: https://github.com/apache/incubator-doris/pull/9694#issuecomment-1134538937 LGTM,But you need to rebase first. You can refer to the documentation below. https://doris.apache.org/zh-CN/community/how-to-contribute/pull-request.html -- This is an automat

[GitHub] [incubator-doris] JNSimba opened a new pull request, #9742: [Doc] Add SQL Mode Doc

2022-05-23 Thread GitBox
JNSimba opened a new pull request, #9742: URL: https://github.com/apache/incubator-doris/pull/9742 # Proposed changes Issue Number: close #xxx ## Problem Summary: Add SQL Mode Doc ## Checklist(Required) 1. Does it affect the original behavior: (Yes/No/I Don'

[GitHub] [incubator-doris] stalary commented on pull request #9725: [Enhancement][Step1] Add a ProfileStorage interface to support record all the querylog in persist storage.

2022-05-23 Thread GitBox
stalary commented on PR #9725: URL: https://github.com/apache/incubator-doris/pull/9725#issuecomment-1134551330 Can you supplement the unit tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [incubator-doris] jackwener commented on a diff in pull request #8789: [fix] update RewriteBinaryPredicatesRule and consider special decimalLiteral (0.0 is equal to 0)

2022-05-23 Thread GitBox
jackwener commented on code in PR #8789: URL: https://github.com/apache/incubator-doris/pull/8789#discussion_r879352863 ## fe/fe-core/src/test/java/org/apache/doris/rewrite/RewriteBinaryPredicatesRuleTest.java: ## @@ -0,0 +1,59 @@ +// Licensed to the Apache Software Foundation (

[GitHub] [incubator-doris] jackwener commented on pull request #8789: [fix] update RewriteBinaryPredicatesRule and consider special decimalLiteral (0.0 is equal to 0)

2022-05-23 Thread GitBox
jackwener commented on PR #8789: URL: https://github.com/apache/incubator-doris/pull/8789#issuecomment-1134562657 You can rebase the `master` to - pass the all CI - fix the conflict -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] jackwener commented on pull request #4000: [Planner]Apply inner join condition reorganization rule

2022-05-23 Thread GitBox
jackwener commented on PR #4000: URL: https://github.com/apache/incubator-doris/pull/4000#issuecomment-1134603084 Please rebase the `master` and add an UT for this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [incubator-doris] Gabriel39 opened a new pull request, #9743: [Improvement] fix typo

2022-05-23 Thread GitBox
Gabriel39 opened a new pull request, #9743: URL: https://github.com/apache/incubator-doris/pull/9743 # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behav

[GitHub] [incubator-doris] yiguolei merged pull request #9741: fix column reader compress codec unsafe problem

2022-05-23 Thread GitBox
yiguolei merged PR #9741: URL: https://github.com/apache/incubator-doris/pull/9741 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@d

[GitHub] [incubator-doris] yiguolei closed issue #9706: [Bug] double free on lz4

2022-05-23 Thread GitBox
yiguolei closed issue #9706: [Bug] double free on lz4 URL: https://github.com/apache/incubator-doris/issues/9706 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[incubator-doris] branch master updated: [bugfix]fix column reader compress codec unsafe problem (#9741)

2022-05-23 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 8b7bb2d07c [bugfix]fix column reader

[GitHub] [incubator-doris] ConeyLiu commented on a diff in pull request #9658: Refactor part of Iceberg code to support more Iceberg Catalogs

2022-05-23 Thread GitBox
ConeyLiu commented on code in PR #9658: URL: https://github.com/apache/incubator-doris/pull/9658#discussion_r879433707 ## docs/en/ecosystem/external-table/iceberg-of-doris.md: ## @@ -135,10 +167,15 @@ You can also create an Iceberg table by explicitly specifying the column defi

[GitHub] [incubator-doris] ConeyLiu commented on a diff in pull request #9658: Refactor part of Iceberg code to support more Iceberg Catalogs

2022-05-23 Thread GitBox
ConeyLiu commented on code in PR #9658: URL: https://github.com/apache/incubator-doris/pull/9658#discussion_r879433250 ## docs/en/ecosystem/external-table/iceberg-of-doris.md: ## @@ -135,10 +167,15 @@ You can also create an Iceberg table by explicitly specifying the column defi

[GitHub] [incubator-doris] stalary opened a new issue, #9744: [Enhancement] group_concat support order by

2022-05-23 Thread GitBox
stalary opened a new issue, #9744: URL: https://github.com/apache/incubator-doris/issues/9744 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Description gr

[GitHub] [incubator-doris] stalary commented on pull request #9725: [Enhancement][Step1] Add a ProfileStorage interface to support record all the querylog in persist storage.

2022-05-23 Thread GitBox
stalary commented on PR #9725: URL: https://github.com/apache/incubator-doris/pull/9725#issuecomment-1134778896 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [incubator-doris] morrySnow opened a new pull request, #9745: [enhancement] (planner) change Doris's query organization syntax to standard sql

2022-05-23 Thread GitBox
morrySnow opened a new pull request, #9745: URL: https://github.com/apache/incubator-doris/pull/9745 # Proposed changes Issue Number: close #9740 ## Problem Summary: Current, we process `order by` and `limit` in Doris only way: https://github.com/apache/incubator-dor

[GitHub] [incubator-doris] xinyiZzz commented on a diff in pull request #9727: [opt] avoid memcpy when building page

2022-05-23 Thread GitBox
xinyiZzz commented on code in PR #9727: URL: https://github.com/apache/incubator-doris/pull/9727#discussion_r879936473 ## be/src/util/faststring.cc: ## @@ -37,18 +37,20 @@ void faststring::GrowToAtLeast(size_t newcapacity) { void faststring::GrowArray(size_t newcapacity) {

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9742: [Doc] Add SQL Mode Doc

2022-05-23 Thread GitBox
github-actions[bot] commented on PR #9742: URL: https://github.com/apache/incubator-doris/pull/9742#issuecomment-1135241249 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9742: [Doc] Add SQL Mode Doc

2022-05-23 Thread GitBox
github-actions[bot] commented on PR #9742: URL: https://github.com/apache/incubator-doris/pull/9742#issuecomment-1135241269 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [incubator-doris] xinyiZzz commented on a diff in pull request #9720: [improvement] Optimize send fragment logic to reduce send fragment timeout error

2022-05-23 Thread GitBox
xinyiZzz commented on code in PR #9720: URL: https://github.com/apache/incubator-doris/pull/9720#discussion_r879949182 ## gensrc/thrift/PaloInternalService.thrift: ## @@ -346,6 +346,10 @@ struct TExecPlanFragmentParams { 19: optional TGlobalDict global_dict // scan node coul

[GitHub] [incubator-doris] xinyiZzz commented on pull request #9720: [improvement] Optimize send fragment logic to reduce send fragment timeout error

2022-05-23 Thread GitBox
xinyiZzz commented on PR #9720: URL: https://github.com/apache/incubator-doris/pull/9720#issuecomment-1135256585 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [incubator-doris] yiguolei opened a new pull request, #9746: disable bloomfilter is pass rate is very high

2022-05-23 Thread GitBox
yiguolei opened a new pull request, #9746: URL: https://github.com/apache/incubator-doris/pull/9746 # Proposed changes Issue Number: close #xxx ## Problem Summary: disable bloomfilter is pass rate is very high ## Checklist(Required) 1. Does it affect the ori

[GitHub] [incubator-doris] xinyiZzz commented on a diff in pull request #9581: [Enhancement] [Memory] [Vectorized] Stress test and optimize memory allocation

2022-05-23 Thread GitBox
xinyiZzz commented on code in PR #9581: URL: https://github.com/apache/incubator-doris/pull/9581#discussion_r879952021 ## build.sh: ## @@ -212,6 +212,9 @@ fi if [[ -z ${STRIP_DEBUG_INFO} ]]; then STRIP_DEBUG_INFO=OFF fi +if [[ -z ${NO_MEM_TRACKER} ]]; then +NO_MEM_TRA

[GitHub] [incubator-doris] xinyiZzz commented on pull request #9746: disable bloomfilter is pass rate is very high

2022-05-23 Thread GitBox
xinyiZzz commented on PR #9746: URL: https://github.com/apache/incubator-doris/pull/9746#issuecomment-1135293628 Nice job, this optimization is also a TODO of the runtime filter: https://github.com/apache/incubator-doris/issues/6116 This helps reduce the performance penalty of the run

[GitHub] [incubator-doris] xinyiZzz commented on pull request #9714: Fix lz4f optimization thread unsafe

2022-05-23 Thread GitBox
xinyiZzz commented on PR #9714: URL: https://github.com/apache/incubator-doris/pull/9714#issuecomment-1135296561 > The thread_local approach is learned from #7911 by @xinyiZzz . It will be very appreciated if you have a look and check whether the usage of thread_local in this pr is right, @

[GitHub] [incubator-doris] xiaokang opened a new pull request, #9747: add zstd compression codec

2022-05-23 Thread GitBox
xiaokang opened a new pull request, #9747: URL: https://github.com/apache/incubator-doris/pull/9747 # Proposed changes ZSTD compression is fast with high compression ratio. It can be used to archive higher compression ratio than default Lz4f codec for storing cost sensitive data such

[GitHub] [incubator-doris] xiaokang commented on pull request #9747: add zstd compression codec

2022-05-23 Thread GitBox
xiaokang commented on PR #9747: URL: https://github.com/apache/incubator-doris/pull/9747#issuecomment-1135310442 Compared to Lz4f codec, we see zstd codec get 35% compressed size off, 30% faster at first time read without OS page cache, 40% slower at second time read with OS page cache in t

[GitHub] [incubator-doris] xiaokang commented on pull request #9747: add zstd compression codec

2022-05-23 Thread GitBox
xiaokang commented on PR #9747: URL: https://github.com/apache/incubator-doris/pull/9747#issuecomment-1135312848 https://github.com/apache/incubator-doris/pull/8923 need to be merged before users can enable zstd or other codec, since current Lz4f codec is hardcoded and not configurable.

[GitHub] [incubator-doris] xiaokang commented on pull request #9714: Fix lz4f optimization thread unsafe

2022-05-23 Thread GitBox
xiaokang commented on PR #9714: URL: https://github.com/apache/incubator-doris/pull/9714#issuecomment-1135320964 @xinyiZzz , thank you for your suggestion and it's valuable. Yes, a better solution #9741, so this one will be closed. -- This is an automated message from the Apache Git Servi

[GitHub] [incubator-doris] xiaokang closed pull request #9714: Fix lz4f optimization thread unsafe

2022-05-23 Thread GitBox
xiaokang closed pull request #9714: Fix lz4f optimization thread unsafe URL: https://github.com/apache/incubator-doris/pull/9714 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [incubator-doris] yiguolei closed issue #9606: [Bug] "insert into TABLE select ..." failed when enable_vectorized_engine=true

2022-05-23 Thread GitBox
yiguolei closed issue #9606: [Bug] "insert into TABLE select ..." failed when enable_vectorized_engine=true URL: https://github.com/apache/incubator-doris/issues/9606 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [incubator-doris] yiguolei commented on issue #9606: [Bug] "insert into TABLE select ..." failed when enable_vectorized_engine=true

2022-05-23 Thread GitBox
yiguolei commented on issue #9606: URL: https://github.com/apache/incubator-doris/issues/9606#issuecomment-1135325551 https://github.com/apache/incubator-doris/pull/9518 Fixed by this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] yiguolei merged pull request #9722: [fix] teach BufferedBlockMgr2 track memory right

2022-05-23 Thread GitBox
yiguolei merged PR #9722: URL: https://github.com/apache/incubator-doris/pull/9722 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@d

[incubator-doris] branch master updated: [bugfix]teach BufferedBlockMgr2 track memory right (#9722)

2022-05-23 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 6353539ef7 [bugfix]teach BufferedBloc

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9722: [fix] teach BufferedBlockMgr2 track memory right

2022-05-23 Thread GitBox
github-actions[bot] commented on PR #9722: URL: https://github.com/apache/incubator-doris/pull/9722#issuecomment-1135326301 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9722: [fix] teach BufferedBlockMgr2 track memory right

2022-05-23 Thread GitBox
github-actions[bot] commented on PR #9722: URL: https://github.com/apache/incubator-doris/pull/9722#issuecomment-1135326319 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9736: [bugfix] fix memleaks reported by ASAN

2022-05-23 Thread GitBox
github-actions[bot] commented on PR #9736: URL: https://github.com/apache/incubator-doris/pull/9736#issuecomment-1135326929 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9736: [bugfix] fix memleaks reported by ASAN

2022-05-23 Thread GitBox
github-actions[bot] commented on PR #9736: URL: https://github.com/apache/incubator-doris/pull/9736#issuecomment-1135326915 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] HappenLee commented on a diff in pull request #9746: disable bloomfilter is pass rate is very high

2022-05-23 Thread GitBox
HappenLee commented on code in PR #9746: URL: https://github.com/apache/incubator-doris/pull/9746#discussion_r88234 ## be/src/olap/bloom_filter_predicate.h: ## @@ -157,6 +160,14 @@ void BloomFilterColumnPredicate::evaluate(vectorized::IColumn& column, uint16 ne

[incubator-doris] branch master updated: [Enhancement](Vectorized)build hash table with new thread, as non-vec… (#9290)

2022-05-23 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 90e8cda5f2 [Enhancement](Vectorized)b

[GitHub] [incubator-doris] yiguolei merged pull request #9290: [Enhancement](Vectorized)build hash table with new thread, as non-vec…

2022-05-23 Thread GitBox
yiguolei merged PR #9290: URL: https://github.com/apache/incubator-doris/pull/9290 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@d

[GitHub] [incubator-doris] yinzhijian opened a new pull request, #9748: [feature-wip](parquet-orc) Support orc scanner in vectorized engine

2022-05-23 Thread GitBox
yinzhijian opened a new pull request, #9748: URL: https://github.com/apache/incubator-doris/pull/9748 # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original beha

[GitHub] [incubator-doris] HappenLee commented on a diff in pull request #9734: [Bug] [Vectorized] add padding when load char type data

2022-05-23 Thread GitBox
HappenLee commented on code in PR #9734: URL: https://github.com/apache/incubator-doris/pull/9734#discussion_r880003279 ## be/src/vec/olap/olap_data_convertor.h: ## @@ -99,8 +102,41 @@ class OlapBlockDataConvertor { Status convert_to_olap() override; private: +

[GitHub] [incubator-doris] qidaye commented on a diff in pull request #9658: Refactor part of Iceberg code to support more Iceberg Catalogs

2022-05-23 Thread GitBox
qidaye commented on code in PR #9658: URL: https://github.com/apache/incubator-doris/pull/9658#discussion_r880003376 ## docs/en/ecosystem/external-table/iceberg-of-doris.md: ## @@ -135,10 +167,15 @@ You can also create an Iceberg table by explicitly specifying the column defini

[GitHub] [incubator-doris] HappenLee commented on a diff in pull request #9734: [Bug] [Vectorized] add padding when load char type data

2022-05-23 Thread GitBox
HappenLee commented on code in PR #9734: URL: https://github.com/apache/incubator-doris/pull/9734#discussion_r880003627 ## be/src/vec/olap/olap_data_convertor.h: ## @@ -99,8 +102,41 @@ class OlapBlockDataConvertor { Status convert_to_olap() override; private: +

[GitHub] [incubator-doris] yinzhijian closed pull request #9748: [feature-wip](parquet-orc) Support orc scanner in vectorized engine

2022-05-23 Thread GitBox
yinzhijian closed pull request #9748: [feature-wip](parquet-orc) Support orc scanner in vectorized engine URL: https://github.com/apache/incubator-doris/pull/9748 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [incubator-doris] xiaokang commented on a diff in pull request #8923: [Feature] Support compression prop

2022-05-23 Thread GitBox
xiaokang commented on code in PR #8923: URL: https://github.com/apache/incubator-doris/pull/8923#discussion_r880008300 ## fe/fe-core/src/main/java/org/apache/doris/common/util/PropertyAnalyzer.java: ## @@ -434,6 +436,31 @@ public static long analyzeTimeout(Map properties, long

[GitHub] [incubator-doris] luozenglin commented on a diff in pull request #9739: [Enhancement][fix] Add a rewrite rule to optimize InPredicate.

2022-05-23 Thread GitBox
luozenglin commented on code in PR #9739: URL: https://github.com/apache/incubator-doris/pull/9739#discussion_r880017193 ## fe/fe-core/src/main/java/org/apache/doris/rewrite/RewriteInPredicateRule.java: ## @@ -0,0 +1,114 @@ +// Licensed to the Apache Software Foundation (ASF) un

[GitHub] [incubator-doris] xiaokang commented on pull request #8923: [Feature] Support compression prop

2022-05-23 Thread GitBox
xiaokang commented on PR #8923: URL: https://github.com/apache/incubator-doris/pull/8923#issuecomment-1135352894 There are still some hardcoded LZ4F in the following files. be/src/olap/rowset/segment_v2/column_writer.cpp: length_options.meta->set_compression(LZ4F); be/sr

[incubator-doris] 04/04: [bugfix]fix column reader compress codec unsafe problem (#9741)

2022-05-23 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.0.1 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit 3d5829e3f0058913a265bf710a8f58f8da81ecdd Author: Kang AuthorDate: Mon May 23 20:25:49 2022 +0800 [b

[incubator-doris] 01/04: [BUG] fix bug for vectorized compaction and some storage vectorization bug (#9610)

2022-05-23 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.0.1 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit f1e9dd513fd2c7a121fc35673c6069662b3caeb2 Author: Gabriel AuthorDate: Thu May 19 16:35:15 2022 +0800

[incubator-doris] 03/04: [vec][opt] opt hash join build resize hash table before insert data (#9735)

2022-05-23 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.0.1 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit 2265374d28c2411079e1b3a844b86e5859e41de1 Author: HappenLee AuthorDate: Mon May 23 15:13:57 2022 +0800

[incubator-doris] branch dev-1.0.1 updated (25ee329f52 -> 3d5829e3f0)

2022-05-23 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch dev-1.0.1 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git from 25ee329f52 [improvement](planner) Backfill the original predicate pushdown code (#9703) new f1e9

[incubator-doris] 02/04: [Bug-Fix][Vectorized] Full join return error result (#9690)

2022-05-23 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.0.1 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit e763465ec3be14fb89a84f5006c9e6d7b1ae6503 Author: HappenLee AuthorDate: Mon May 23 13:29:37 2022 +0800

[GitHub] [incubator-doris] HappenLee commented on a diff in pull request #9541: [feature-wip](parquet-orc) Support orc scanner in vectorized engine

2022-05-23 Thread GitBox
HappenLee commented on code in PR #9541: URL: https://github.com/apache/incubator-doris/pull/9541#discussion_r88000 ## be/src/exec/arrow/arrow_reader.cpp: ## @@ -0,0 +1,156 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agre

[GitHub] [incubator-doris] stalary opened a new issue, #9749: [Bug] SqlBlockRule NPE Exception

2022-05-23 Thread GitBox
stalary opened a new issue, #9749: URL: https://github.com/apache/incubator-doris/issues/9749 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version 0.15

[incubator-doris] branch dev-1.0.1 updated: [hotfix] fix load with close wait failed error

2022-05-23 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.0.1 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/dev-1.0.1 by this push: new d752946faa [hotfix] fix load

[GitHub] [incubator-doris] BePPPower opened a new issue, #9750: [Bug] core dump when insert into values with default value.

2022-05-23 Thread GitBox
BePPPower opened a new issue, #9750: URL: https://github.com/apache/incubator-doris/issues/9750 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version trun

[GitHub] [incubator-doris] stalary commented on a diff in pull request #7403: [feature] sql-block-rule: add partition_num, tablet_num, cardinality in SqlBlockRule to block big/slow sql

2022-05-23 Thread GitBox
stalary commented on code in PR #7403: URL: https://github.com/apache/incubator-doris/pull/7403#discussion_r880043644 ## fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java: ## @@ -357,8 +359,17 @@ public void execute(TUniqueId queryId) throws Exception {

[GitHub] [incubator-doris] sumtumn commented on pull request #9726: [feature](function) Add nvl function

2022-05-23 Thread GitBox
sumtumn commented on PR #9726: URL: https://github.com/apache/incubator-doris/pull/9726#issuecomment-1135391364 @hf200012 @yiguolei doc and regression test were added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-doris] stalary commented on issue #9749: [Bug] SqlBlockRule NPE Exception

2022-05-23 Thread GitBox
stalary commented on issue #9749: URL: https://github.com/apache/incubator-doris/issues/9749#issuecomment-1135391955 In this pr, I will refactor some null value handling, checkstyle, and ut. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-doris] spaces-X opened a new issue, #9751: [Feature] Supports vectorization of spark load in BE load stage

2022-05-23 Thread GitBox
spaces-X opened a new issue, #9751: URL: https://github.com/apache/incubator-doris/issues/9751 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Description S

[GitHub] [incubator-doris] BiteTheDDDDt commented on pull request #9712: [Bug] fix bug in time_round function

2022-05-23 Thread GitBox
BiteThet commented on PR #9712: URL: https://github.com/apache/incubator-doris/pull/9712#issuecomment-1135459276 Hi, you can add a test to `regression-test` or `be-unit-test` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-doris] carlvinhust2012 commented on a diff in pull request #9747: add zstd compression codec

2022-05-23 Thread GitBox
carlvinhust2012 commented on code in PR #9747: URL: https://github.com/apache/incubator-doris/pull/9747#discussion_r880097962 ## be/src/util/block_compression.cpp: ## @@ -22,6 +22,8 @@ #include #include #include +#include Review Comment: no need to add some documentat

[GitHub] [incubator-doris] dujl opened a new pull request, #9752: support query hudi external table

2022-05-23 Thread GitBox
dujl opened a new pull request, #9752: URL: https://github.com/apache/incubator-doris/pull/9752 # Proposed changes Issue Number: https://github.com/apache/incubator-doris/issues/9557 Support query hudi external table in Doris. This pr support query cow and mor hudi table.

[GitHub] [incubator-doris] EmmyMiao87 commented on issue #6483: New Optimizer

2022-05-23 Thread GitBox
EmmyMiao87 commented on issue #6483: URL: https://github.com/apache/incubator-doris/issues/6483#issuecomment-1135475396 The Nereids design document is following: https://docs.google.com/document/d/1jmYaj1yUDirKfT-UEZWQe5_z1q473DCuKKPGTa1qblE/edit#heading=h.2i99bgu6sk3 -- This is an autom

[GitHub] [incubator-doris] EmmyMiao87 commented on issue #6483: New Optimizer

2022-05-23 Thread GitBox
EmmyMiao87 commented on issue #6483: URL: https://github.com/apache/incubator-doris/issues/6483#issuecomment-1135478709 Early POC document from Meituan: https://docs.google.com/document/d/1bKulayCpK3ioASXUR8pFcKqE0_jfVQzJh1Qk82liMv0/edit#heading=h.qcbzgp9acb -- This is an automated messa

[GitHub] [incubator-doris] dujl commented on a diff in pull request #9559: [feature-wip](hudi) Step1: Support create hudi external table

2022-05-23 Thread GitBox
dujl commented on code in PR #9559: URL: https://github.com/apache/incubator-doris/pull/9559#discussion_r880124516 ## fe/fe-core/src/main/java/org/apache/doris/catalog/Catalog.java: ## @@ -4105,6 +4111,44 @@ private void createHiveTable(Database db, CreateTableStmt stmt) throws