[GitHub] [incubator-doris] Gabriel39 commented on pull request #9582: [refactor](decimalv3) optimize decimal performance and precision

2022-05-19 Thread GitBox
Gabriel39 commented on PR #9582: URL: https://github.com/apache/incubator-doris/pull/9582#issuecomment-1131311445 We should support schema change on decimal column between different precision and scale which is not done in this PR. -- This is an automated message from the Apache Git Servi

[GitHub] [incubator-doris] adonis0147 commented on a diff in pull request #9683: [fix]Set the memory size used when FE starts according to the user's available memory at startup

2022-05-19 Thread GitBox
adonis0147 commented on code in PR #9683: URL: https://github.com/apache/incubator-doris/pull/9683#discussion_r876687681 ## bin/start_fe.sh: ## @@ -132,13 +132,21 @@ fi # check java version and choose correct JAVA_OPTS java_version=$(jdk_version) -final_java_opt=$JAVA_OPTS +

[GitHub] [incubator-doris] HappenLee commented on a diff in pull request #9666: [Refactor][Bug-Fix][Load Vec] Refactor code of basescanner and vjson/vparquet/vbroker scanner

2022-05-19 Thread GitBox
HappenLee commented on code in PR #9666: URL: https://github.com/apache/incubator-doris/pull/9666#discussion_r876702627 ## be/src/exec/base_scanner.cpp: ## @@ -71,6 +77,21 @@ Status BaseScanner::open() { _rows_read_counter = ADD_COUNTER(_profile, "RowsRead", TUnit::UNIT);

[GitHub] [incubator-doris] HappenLee commented on a diff in pull request #9666: [Refactor][Bug-Fix][Load Vec] Refactor code of basescanner and vjson/vparquet/vbroker scanner

2022-05-19 Thread GitBox
HappenLee commented on code in PR #9666: URL: https://github.com/apache/incubator-doris/pull/9666#discussion_r876704180 ## be/src/vec/core/block.cpp: ## @@ -402,6 +402,20 @@ std::string Block::dump_data(size_t begin, size_t row_limit) const { return out.str(); } +std::s

[GitHub] [incubator-doris] gtchaos commented on a diff in pull request #9524: [Feature] libhdfs3 built enable kerberos support

2022-05-19 Thread GitBox
gtchaos commented on code in PR #9524: URL: https://github.com/apache/incubator-doris/pull/9524#discussion_r876709031 ## thirdparty/build-thirdparty.sh: ## @@ -904,16 +904,46 @@ build_gsasl() { make -j $PARALLEL && make install } +# build_gsasl2 just for libgsasl1.8.0 +b

[GitHub] [incubator-doris] HappenLee commented on a diff in pull request #9666: [Refactor][Bug-Fix][Load Vec] Refactor code of basescanner and vjson/vparquet/vbroker scanner

2022-05-19 Thread GitBox
HappenLee commented on code in PR #9666: URL: https://github.com/apache/incubator-doris/pull/9666#discussion_r876727851 ## be/src/vec/exec/vbroker_scanner.cpp: ## @@ -44,18 +44,14 @@ VBrokerScanner::VBrokerScanner(RuntimeState* state, RuntimeProfile* profile, _text_convert

[GitHub] [incubator-doris] yangzhg opened a new pull request, #9685: [fix] fix Code Quality Analysis failed

2022-05-19 Thread GitBox
yangzhg opened a new pull request, #9685: URL: https://github.com/apache/incubator-doris/pull/9685 # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behavio

[GitHub] [incubator-doris] HappenLee commented on a diff in pull request #9459: [stream-load-vec]: memtable flush only if necessary after aggregated

2022-05-19 Thread GitBox
HappenLee commented on code in PR #9459: URL: https://github.com/apache/incubator-doris/pull/9459#discussion_r876733240 ## be/src/olap/memtable.cpp: ## @@ -263,11 +266,43 @@ vectorized::Block MemTable::_collect_vskiplist_results() { auto function = _agg_function

[GitHub] [incubator-doris] yangzhg commented on a diff in pull request #9678: add tablet erros when close_wait return error

2022-05-19 Thread GitBox
yangzhg commented on code in PR #9678: URL: https://github.com/apache/incubator-doris/pull/9678#discussion_r876753281 ## be/src/olap/delta_writer.h: ## @@ -70,6 +70,7 @@ class DeltaWriter { Status close_wait(google::protobuf::RepeatedPtrField* tablet_vec,

[GitHub] [incubator-doris] starocean999 opened a new pull request, #9686: push predicate to subquery

2022-05-19 Thread GitBox
starocean999 opened a new pull request, #9686: URL: https://github.com/apache/incubator-doris/pull/9686 # Proposed changes Issue Number: close https://github.com/apache/incubator-doris/issues/8894 ## Problem Summary: In some cases, pushing the predicate to subquery can ge

[GitHub] [incubator-doris] starocean999 commented on pull request #8897: push predicate to subquery

2022-05-19 Thread GitBox
starocean999 commented on PR #8897: URL: https://github.com/apache/incubator-doris/pull/8897#issuecomment-1131393833 rebase error, create a new pr https://github.com/apache/incubator-doris/pull/9686 instead -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [incubator-doris] starocean999 closed pull request #8897: push predicate to subquery

2022-05-19 Thread GitBox
starocean999 closed pull request #8897: push predicate to subquery URL: https://github.com/apache/incubator-doris/pull/8897 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [incubator-doris] yangzhg commented on a diff in pull request #9678: add tablet erros when close_wait return error

2022-05-19 Thread GitBox
yangzhg commented on code in PR #9678: URL: https://github.com/apache/incubator-doris/pull/9678#discussion_r876758703 ## be/src/runtime/tablets_channel.cpp: ## @@ -137,6 +137,23 @@ Status TabletsChannel::close(int sender_id, int64_t backend_id, bool* finished, return Statu

[GitHub] [incubator-doris] HappenLee opened a new issue, #9687: [Bug] [Vectorized] Full join get error result

2022-05-19 Thread GitBox
HappenLee opened a new issue, #9687: URL: https://github.com/apache/incubator-doris/issues/9687 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version mast

[GitHub] [incubator-doris] yiguolei merged pull request #9610: [BUG] fix bug for vectorized compaction

2022-05-19 Thread GitBox
yiguolei merged PR #9610: URL: https://github.com/apache/incubator-doris/pull/9610 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@d

[incubator-doris] branch master updated: [BUG] fix bug for vectorized compaction and some storage vectorization bug (#9610)

2022-05-19 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 7c2db79b73 [BUG] fix bug for vectoriz

[GitHub] [incubator-doris] yiguolei closed issue #9604: [Bug] vectorized compaction failed

2022-05-19 Thread GitBox
yiguolei closed issue #9604: [Bug] vectorized compaction failed URL: https://github.com/apache/incubator-doris/issues/9604 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [incubator-doris] yiguolei closed issue #9404: [Enhancement] (FE Code Style) step2: turn on name and error-prone way of writing check

2022-05-19 Thread GitBox
yiguolei closed issue #9404: [Enhancement] (FE Code Style) step2: turn on name and error-prone way of writing check URL: https://github.com/apache/incubator-doris/issues/9404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [incubator-doris] yiguolei merged pull request #9670: [style](fe) code correct rules and name rules

2022-05-19 Thread GitBox
yiguolei merged PR #9670: URL: https://github.com/apache/incubator-doris/pull/9670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@d

[GitHub] [incubator-doris] yiguolei closed issue #9676: [Enhancement][be] Improve debugging experience

2022-05-19 Thread GitBox
yiguolei closed issue #9676: [Enhancement][be] Improve debugging experience URL: https://github.com/apache/incubator-doris/issues/9676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [incubator-doris] yiguolei merged pull request #9677: [enhancement][be] Improve debugging experience

2022-05-19 Thread GitBox
yiguolei merged PR #9677: URL: https://github.com/apache/incubator-doris/pull/9677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@d

[incubator-doris] branch master updated: [enhancement] Improve debugging experience. (#9677)

2022-05-19 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 119ff2c02d [enhancement] Improve debu

[GitHub] [incubator-doris] yiguolei merged pull request #9537: [Feature] cancel load support state

2022-05-19 Thread GitBox
yiguolei merged PR #9537: URL: https://github.com/apache/incubator-doris/pull/9537 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@d

[incubator-doris] branch master updated: [Feature] cancel load support state (#9537)

2022-05-19 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new cbc7b167b1 [Feature] cancel load supp

[GitHub] [incubator-doris] ConeyLiu commented on a diff in pull request #9658: Refactor part of Iceberg code to support more Iceberg Catalogs

2022-05-19 Thread GitBox
ConeyLiu commented on code in PR #9658: URL: https://github.com/apache/incubator-doris/pull/9658#discussion_r876779129 ## fe/fe-core/src/main/java/org/apache/doris/external/iceberg/IcebergCatalogMgr.java: ## @@ -50,83 +49,62 @@ public class IcebergCatalogMgr { // hive met

[GitHub] [incubator-doris] ConeyLiu commented on a diff in pull request #9658: Refactor part of Iceberg code to support more Iceberg Catalogs

2022-05-19 Thread GitBox
ConeyLiu commented on code in PR #9658: URL: https://github.com/apache/incubator-doris/pull/9658#discussion_r876780913 ## fe/fe-core/src/main/java/org/apache/doris/external/iceberg/IcebergCatalogImpl.java: ## @@ -14,54 +14,48 @@ // KIND, either express or implied. See the Lice

[GitHub] [incubator-doris] ConeyLiu commented on pull request #9658: Refactor part of Iceberg code to support more Iceberg Catalogs

2022-05-19 Thread GitBox
ConeyLiu commented on PR #9658: URL: https://github.com/apache/incubator-doris/pull/9658#issuecomment-1131411701 @qidaye, thanks for the review. Comments have been addressed. Please take another look when you are free. Thanks again. -- This is an automated message from the Apache Git Serv

[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #9521: [improvement][performance] improve lru cache resize performance and memory usage

2022-05-19 Thread GitBox
yiguolei commented on code in PR #9521: URL: https://github.com/apache/incubator-doris/pull/9521#discussion_r876790065 ## be/src/olap/lru_cache.cpp: ## @@ -73,9 +73,6 @@ uint32_t CacheKey::hash(const char* data, size_t n, uint32_t seed) const { Cache::~Cache() {} HandleTabl

[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #9521: [improvement][performance] improve lru cache resize performance and memory usage

2022-05-19 Thread GitBox
yiguolei commented on code in PR #9521: URL: https://github.com/apache/incubator-doris/pull/9521#discussion_r876813350 ## be/src/olap/lru_cache.cpp: ## @@ -148,29 +143,22 @@ void HandleTable::_resize() { LRUHandle** new_list = new (std::nothrow) LRUHandle*[new_length];

[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #9521: [improvement][performance] improve lru cache resize performance and memory usage

2022-05-19 Thread GitBox
yiguolei commented on code in PR #9521: URL: https://github.com/apache/incubator-doris/pull/9521#discussion_r876820043 ## be/src/olap/lru_cache.cpp: ## @@ -148,29 +143,22 @@ void HandleTable::_resize() { LRUHandle** new_list = new (std::nothrow) LRUHandle*[new_length];

[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #9521: [improvement][performance] improve lru cache resize performance and memory usage

2022-05-19 Thread GitBox
yiguolei commented on code in PR #9521: URL: https://github.com/apache/incubator-doris/pull/9521#discussion_r876820856 ## be/src/olap/lru_cache.cpp: ## @@ -148,29 +143,22 @@ void HandleTable::_resize() { LRUHandle** new_list = new (std::nothrow) LRUHandle*[new_length];

[GitHub] [incubator-doris] spaces-X commented on a diff in pull request #9459: [stream-load-vec]: memtable flush only if necessary after aggregated

2022-05-19 Thread GitBox
spaces-X commented on code in PR #9459: URL: https://github.com/apache/incubator-doris/pull/9459#discussion_r876825011 ## be/src/olap/memtable.cpp: ## @@ -263,11 +266,43 @@ vectorized::Block MemTable::_collect_vskiplist_results() { auto function = _agg_functions

[GitHub] [incubator-doris] spaces-X commented on a diff in pull request #9459: [stream-load-vec]: memtable flush only if necessary after aggregated

2022-05-19 Thread GitBox
spaces-X commented on code in PR #9459: URL: https://github.com/apache/incubator-doris/pull/9459#discussion_r876825481 ## be/src/olap/delta_writer.cpp: ## @@ -222,9 +222,12 @@ Status DeltaWriter::write(const vectorized::Block* block, const std::vector } } -i

[GitHub] [incubator-doris] morrySnow commented on issue #9671: [Feature] Separate sql parser to a independent module

2022-05-19 Thread GitBox
morrySnow commented on issue #9671: URL: https://github.com/apache/incubator-doris/issues/9671#issuecomment-1131458343 Hi, separated sql parser model is not a good idea to do that. A better way to do that is a common framework for getting query plans and making changes to them. Under this

[GitHub] [incubator-doris] gaodayue commented on a diff in pull request #9521: [improvement][performance] improve lru cache resize performance and memory usage

2022-05-19 Thread GitBox
gaodayue commented on code in PR #9521: URL: https://github.com/apache/incubator-doris/pull/9521#discussion_r876832379 ## be/src/olap/lru_cache.cpp: ## @@ -73,9 +73,6 @@ uint32_t CacheKey::hash(const char* data, size_t n, uint32_t seed) const { Cache::~Cache() {} HandleTabl

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9524: [Feature] libhdfs3 built enable kerberos support

2022-05-19 Thread GitBox
github-actions[bot] commented on PR #9524: URL: https://github.com/apache/incubator-doris/pull/9524#issuecomment-1131465851 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] gaodayue commented on a diff in pull request #9521: [improvement][performance] improve lru cache resize performance and memory usage

2022-05-19 Thread GitBox
gaodayue commented on code in PR #9521: URL: https://github.com/apache/incubator-doris/pull/9521#discussion_r876839145 ## be/src/olap/lru_cache.cpp: ## @@ -148,29 +143,22 @@ void HandleTable::_resize() { LRUHandle** new_list = new (std::nothrow) LRUHandle*[new_length];

[GitHub] [incubator-doris] cambyzju opened a new pull request, #9688: [bug] null value serialize to same key

2022-05-19 Thread GitBox
cambyzju opened a new pull request, #9688: URL: https://github.com/apache/incubator-doris/pull/9688 # Proposed changes Issue Number: close #9544 ## Problem Summary: Describe the overview of changes. The reason in the issue is: In vec engine, if value is appended

[GitHub] [incubator-doris] pengxiangyu commented on a diff in pull request #9678: add tablet erros when close_wait return error

2022-05-19 Thread GitBox
pengxiangyu commented on code in PR #9678: URL: https://github.com/apache/incubator-doris/pull/9678#discussion_r876872380 ## be/src/olap/delta_writer.h: ## @@ -70,6 +70,7 @@ class DeltaWriter { Status close_wait(google::protobuf::RepeatedPtrField* tablet_vec,

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9521: [improvement][performance] improve lru cache resize performance and memory usage

2022-05-19 Thread GitBox
github-actions[bot] commented on PR #9521: URL: https://github.com/apache/incubator-doris/pull/9521#issuecomment-1131516256 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #9688: [fix] group by with two NULL rows after left join

2022-05-19 Thread GitBox
yiguolei commented on code in PR #9688: URL: https://github.com/apache/incubator-doris/pull/9688#discussion_r876891641 ## be/src/vec/columns/column_nullable.cpp: ## @@ -102,7 +102,10 @@ StringRef ColumnNullable::serialize_value_into_arena(size_t n, Arena& arena, static con

[GitHub] [incubator-doris] hf200012 commented on a diff in pull request #9683: [fix]Set the memory size used when FE starts according to the user's available memory at startup

2022-05-19 Thread GitBox
hf200012 commented on code in PR #9683: URL: https://github.com/apache/incubator-doris/pull/9683#discussion_r876907925 ## bin/start_fe.sh: ## @@ -132,13 +132,21 @@ fi # check java version and choose correct JAVA_OPTS java_version=$(jdk_version) -final_java_opt=$JAVA_OPTS +fi

[GitHub] [incubator-doris] hf200012 closed issue #9668: [Bug] fe start faild (version:1.0.0-preview2)

2022-05-19 Thread GitBox
hf200012 closed issue #9668: [Bug] fe start faild (version:1.0.0-preview2) URL: https://github.com/apache/incubator-doris/issues/9668 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [incubator-doris] caiconghui commented on pull request #9683: [fix]Set the memory size used when FE starts according to the user's available memory at startup

2022-05-19 Thread GitBox
caiconghui commented on PR #9683: URL: https://github.com/apache/incubator-doris/pull/9683#issuecomment-1131565834 will it work if I have set fe jvm config? what if user need memory for 36G ? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-doris] dataroaring opened a new pull request, #9689: [fix] NullPredicate should implement evaluate_vec

2022-05-19 Thread GitBox
dataroaring opened a new pull request, #9689: URL: https://github.com/apache/incubator-doris/pull/9689 select column from table where column is null # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklis

[GitHub] [incubator-doris] hf200012 commented on pull request #9683: [fix]Set the memory size used when FE starts according to the user's available memory at startup

2022-05-19 Thread GitBox
hf200012 commented on PR #9683: URL: https://github.com/apache/incubator-doris/pull/9683#issuecomment-1131570860 > will it work if I have set fe jvm config? what if user need memory for 36G ? Modify the JAVA_OPTS_8G or JAVA_OPTS_FOR_JDK_9_8G parameter in fe.conf This is just to avo

[GitHub] [incubator-doris] zhaomin1423 commented on issue #9671: [Feature] Separate sql parser to a independent module

2022-05-19 Thread GitBox
zhaomin1423 commented on issue #9671: URL: https://github.com/apache/incubator-doris/issues/9671#issuecomment-1131575526 yeah, a new framework is a good idea, but, its goal is to have a single package in maven for users to use. -- This is an automated message from the Apache Git Service

[GitHub] [incubator-doris] jackwener commented on a diff in pull request #9686: push predicate to subquery

2022-05-19 Thread GitBox
jackwener commented on code in PR #9686: URL: https://github.com/apache/incubator-doris/pull/9686#discussion_r876916819 ## fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java: ## @@ -655,6 +666,224 @@ private void parse() throws AnalysisException, DdlException {

[GitHub] [incubator-doris] GoGoWen closed pull request #7515: optimization reading for single rowset

2022-05-19 Thread GitBox
GoGoWen closed pull request #7515: optimization reading for single rowset URL: https://github.com/apache/incubator-doris/pull/7515 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [incubator-doris] GoGoWen commented on pull request #9560: fix memory leak

2022-05-19 Thread GitBox
GoGoWen commented on PR #9560: URL: https://github.com/apache/incubator-doris/pull/9560#issuecomment-1131621624 as we use v1.0, after verify with master branch. the memory leak should be fixed. so close this pr. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-doris] GoGoWen closed pull request #9560: fix memory leak

2022-05-19 Thread GitBox
GoGoWen closed pull request #9560: fix memory leak URL: https://github.com/apache/incubator-doris/pull/9560 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

[GitHub] [incubator-doris] HappenLee opened a new pull request, #9690: [Bug-Fix][Vectorized] Full join return error result

2022-05-19 Thread GitBox
HappenLee opened a new pull request, #9690: URL: https://github.com/apache/incubator-doris/pull/9690 # Proposed changes Issue Number: close #9687 ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original beha

[GitHub] [incubator-doris] cambyzju commented on a diff in pull request #9688: [fix] group by with two NULL rows after left join

2022-05-19 Thread GitBox
cambyzju commented on code in PR #9688: URL: https://github.com/apache/incubator-doris/pull/9688#discussion_r876996911 ## be/src/vec/columns/column_nullable.cpp: ## @@ -102,7 +102,10 @@ StringRef ColumnNullable::serialize_value_into_arena(size_t n, Arena& arena, static con

[GitHub] [incubator-doris] dataroaring opened a new issue, #9691: [Bug] vectorized stream load use after free on bitmap

2022-05-19 Thread GitBox
dataroaring opened a new issue, #9691: URL: https://github.com/apache/incubator-doris/issues/9691 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version ma

[GitHub] [incubator-doris] yiguolei merged pull request #9680: Fix some typos for docs.

2022-05-19 Thread GitBox
yiguolei merged PR #9680: URL: https://github.com/apache/incubator-doris/pull/9680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@d

[incubator-doris] branch master updated: Fix some typos for docs. (#9680)

2022-05-19 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 87e3904cc6 Fix some typos for docs. (

[GitHub] [incubator-doris] yiguolei merged pull request #9681: Fix some typos in be/.

2022-05-19 Thread GitBox
yiguolei merged PR #9681: URL: https://github.com/apache/incubator-doris/pull/9681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@d

[incubator-doris] branch master updated: Fix some typos in be/. (#9681)

2022-05-19 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 73c4ec7167 Fix some typos in be/. (#9

[GitHub] [incubator-doris] zxealous opened a new pull request, #9692: [Docs]Fix typos in documentation

2022-05-19 Thread GitBox
zxealous opened a new pull request, #9692: URL: https://github.com/apache/incubator-doris/pull/9692 # Proposed changes This pr aims to fix typos in documentation ## Problem Summary: This pr aims to fix typos in documentation ## Checklist(Required) 1. Does it

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9690: [Bug-Fix][Vectorized] Full join return error result

2022-05-19 Thread GitBox
github-actions[bot] commented on PR #9690: URL: https://github.com/apache/incubator-doris/pull/9690#issuecomment-1131657855 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #9574: [Bug] Fix timestamp_diff issue when timeunit is year and month

2022-05-19 Thread GitBox
yiguolei commented on code in PR #9574: URL: https://github.com/apache/incubator-doris/pull/9574#discussion_r877049071 ## be/src/vec/runtime/vdatetime_value.h: ## @@ -288,21 +288,23 @@ class VecDateTimeValue { // Now this type is a temp solution with little changes cas

[GitHub] [incubator-doris] yiguolei closed issue #9296: [Bug] TIMESTAMPDIFF(unit,datetime_expr1,datetime_expr2) get wrong result

2022-05-19 Thread GitBox
yiguolei closed issue #9296: [Bug] TIMESTAMPDIFF(unit,datetime_expr1,datetime_expr2) get wrong result URL: https://github.com/apache/incubator-doris/issues/9296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-doris] yiguolei merged pull request #9574: [Bug] Fix timestamp_diff issue when timeunit is year and month

2022-05-19 Thread GitBox
yiguolei merged PR #9574: URL: https://github.com/apache/incubator-doris/pull/9574 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@d

[incubator-doris] branch master updated: [Bug] Fix timestamp_diff issue when timeunit is year and month (#9574)

2022-05-19 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 0f9ef26576 [Bug] Fix timestamp_diff i

[GitHub] [incubator-doris] jackwener opened a new pull request, #9693: [enhancement](community): enhance java style

2022-05-19 Thread GitBox
jackwener opened a new pull request, #9693: URL: https://github.com/apache/incubator-doris/pull/9693 # Proposed changes Issue Number: close #xxx ## Problem Summary: Enhance java style. ## Checklist(Required) 1. Does it affect the original behavior: (No) 2

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9598: [feature](nereids): add join rules base code

2022-05-19 Thread GitBox
github-actions[bot] commented on PR #9598: URL: https://github.com/apache/incubator-doris/pull/9598#issuecomment-1131840318 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9598: [feature](nereids): add join rules base code

2022-05-19 Thread GitBox
github-actions[bot] commented on PR #9598: URL: https://github.com/apache/incubator-doris/pull/9598#issuecomment-1131840377 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [incubator-doris] yiguolei merged pull request #9685: [fix] fix Code Quality Analysis failed

2022-05-19 Thread GitBox
yiguolei merged PR #9685: URL: https://github.com/apache/incubator-doris/pull/9685 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@d

[GitHub] [incubator-doris] nextdreamblue opened a new pull request, #9694: [Bug] Fix create table like when having hidden columns

2022-05-19 Thread GitBox
nextdreamblue opened a new pull request, #9694: URL: https://github.com/apache/incubator-doris/pull/9694 # Proposed changes Issue Number: close #9539 ## Problem Summary: Fix create table like when having hidden columns。 When fe set enable_batch_delete_by_default=tr

[GitHub] [incubator-doris] nextdreamblue commented on issue #9539: [Bug] CREATE TABLE LIKE Exception

2022-05-19 Thread GitBox
nextdreamblue commented on issue #9539: URL: https://github.com/apache/incubator-doris/issues/9539#issuecomment-1131874747 i meet some error like this issue. i reproduce it like this : MySQL [abc]> ADMIN SET FRONTEND CONFIG ("enable_batch_delete_by_default" = "true"); Query

[GitHub] [incubator-doris] nextdreamblue commented on issue #9539: [Bug] CREATE TABLE LIKE Exception

2022-05-19 Thread GitBox
nextdreamblue commented on issue #9539: URL: https://github.com/apache/incubator-doris/issues/9539#issuecomment-1131876063 i commit a pr for fix this bug . https://github.com/apache/incubator-doris/pull/9694 -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [incubator-doris] yiguolei merged pull request #9521: [improvement][performance] improve lru cache resize performance and memory usage

2022-05-19 Thread GitBox
yiguolei merged PR #9521: URL: https://github.com/apache/incubator-doris/pull/9521 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@d

[incubator-doris] branch master updated (939daa07f1 -> c09858671d)

2022-05-19 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git from 939daa07f1 [fix] fix Code Quality Analysis failed (#9685) add c09858671d [improvement][performance] im

[GitHub] [incubator-doris] yiguolei closed issue #9522: [Bug] [Vectorized] fix schema change add varchar type column default value get wrong result

2022-05-19 Thread GitBox
yiguolei closed issue #9522: [Bug] [Vectorized] fix schema change add varchar type column default value get wrong result URL: https://github.com/apache/incubator-doris/issues/9522 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [incubator-doris] yiguolei merged pull request #9523: [Bug][Vectorized] fix schema change add varchar type column default value get wrong result

2022-05-19 Thread GitBox
yiguolei merged PR #9523: URL: https://github.com/apache/incubator-doris/pull/9523 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@d

[GitHub] [incubator-doris] yiguolei merged pull request #9499: [Enhance] Add host info to heartbeat error msg

2022-05-19 Thread GitBox
yiguolei merged PR #9499: URL: https://github.com/apache/incubator-doris/pull/9499 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@d

[incubator-doris] branch master updated (6951c42d5c -> 1355bc162b)

2022-05-19 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git from 6951c42d5c [Bug][Vectorized] fix schema change add varchar type column default value get wrong result (#95

[GitHub] [incubator-doris] yiguolei merged pull request #9472: [Enhancement] improve parquet reader via arrow's prefetch and multi thread

2022-05-19 Thread GitBox
yiguolei merged PR #9472: URL: https://github.com/apache/incubator-doris/pull/9472 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@d

[incubator-doris] branch master updated: [Enhancement] improve parquet reader via arrow's prefetch and multi thread (#9472)

2022-05-19 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new ef65f484df [Enhancement] improve par

[GitHub] [incubator-doris] yiguolei merged pull request #9436: [Spark Load]fix min_value of GlobalDict will be negative number in spark load

2022-05-19 Thread GitBox
yiguolei merged PR #9436: URL: https://github.com/apache/incubator-doris/pull/9436 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@d

[incubator-doris] branch master updated: [fix](sparkload): fix min_value will be negative number when `maxGlobalDictValue` exceeds integer range (#9436)

2022-05-19 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new c048b1f0f9 [fix](sparkload): fix min_

[GitHub] [incubator-doris] yiguolei merged pull request #9368: [refactor][rowset]move rowset writer to a single place

2022-05-19 Thread GitBox
yiguolei merged PR #9368: URL: https://github.com/apache/incubator-doris/pull/9368 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@d

[incubator-doris] branch master updated: [refactor][rowset]move rowset writer to a single place (#9368)

2022-05-19 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 2c79d223e4 [refactor][rowset]move row

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9154: adjust read unit of http to optimize stream load

2022-05-19 Thread GitBox
github-actions[bot] commented on PR #9154: URL: https://github.com/apache/incubator-doris/pull/9154#issuecomment-1131906936 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] yiguolei merged pull request #9598: [feature](nereids): add join rules base code

2022-05-19 Thread GitBox
yiguolei merged PR #9598: URL: https://github.com/apache/incubator-doris/pull/9598 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@d

[GitHub] [incubator-doris] stalary commented on issue #9662: [Bug] Query data date format output is incorrect

2022-05-19 Thread GitBox
stalary commented on issue #9662: URL: https://github.com/apache/incubator-doris/issues/9662#issuecomment-1132321591 `If` has a problem with two different types of inference, and I'll fix it soon. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [incubator-doris] yiguolei merged pull request #9590: [Docs] Fix error command of meta tool docs

2022-05-19 Thread GitBox
yiguolei merged PR #9590: URL: https://github.com/apache/incubator-doris/pull/9590 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@d

[incubator-doris] branch master updated: [docs] Fix error command of meta tool docs (#9590)

2022-05-19 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 1e940f28b0 [docs] Fix error command o

[GitHub] [incubator-doris] morningman closed issue #8196: [Bug] 修改分区参数时没有校验存储介质

2022-05-19 Thread GitBox
morningman closed issue #8196: [Bug] 修改分区参数时没有校验存储介质 URL: https://github.com/apache/incubator-doris/issues/8196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [incubator-doris] morningman commented on issue #8196: [Bug] 修改分区参数时没有校验存储介质

2022-05-19 Thread GitBox
morningman commented on issue #8196: URL: https://github.com/apache/incubator-doris/issues/8196#issuecomment-1132364044 Actually this is not a bug. Because when creating table, Doris will do the real "create tablet" task on BE, so that it MUST find enough backends with specified stora

[GitHub] [incubator-doris] morningman merged pull request #9154: adjust read unit of http to optimize stream load

2022-05-19 Thread GitBox
morningman merged PR #9154: URL: https://github.com/apache/incubator-doris/pull/9154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[incubator-doris] branch master updated: [improvement](stream-load) adjust read unit of http to optimize stream load (#9154)

2022-05-19 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new defdae1e7d [improvement](stream-loa

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9190: [Fix] Remove trailing spaces in broker_scanner. Make it consistent with hive and trino behavior.

2022-05-19 Thread GitBox
github-actions[bot] commented on PR #9190: URL: https://github.com/apache/incubator-doris/pull/9190#issuecomment-1132365389 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9190: [Fix] Remove trailing spaces in broker_scanner. Make it consistent with hive and trino behavior.

2022-05-19 Thread GitBox
github-actions[bot] commented on PR #9190: URL: https://github.com/apache/incubator-doris/pull/9190#issuecomment-1132365371 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] morningman merged pull request #9190: [Fix] Remove trailing spaces in broker_scanner. Make it consistent with hive and trino behavior.

2022-05-19 Thread GitBox
morningman merged PR #9190: URL: https://github.com/apache/incubator-doris/pull/9190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[GitHub] [incubator-doris] morningman closed issue #9257: [Bug] Doesn't trim the trailing spaces while querying hive external table

2022-05-19 Thread GitBox
morningman closed issue #9257: [Bug] Doesn't trim the trailing spaces while querying hive external table URL: https://github.com/apache/incubator-doris/issues/9257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-doris] branch master updated: [fix](broker-scan-node) Remove trailing spaces in broker_scanner. Make it consistent with hive and trino behavior. (#9190)

2022-05-19 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 5fa6e892be [fix](broker-scan-node)

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9692: [Docs]Fix typos in documentation

2022-05-19 Thread GitBox
github-actions[bot] commented on PR #9692: URL: https://github.com/apache/incubator-doris/pull/9692#issuecomment-1132373266 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [incubator-doris] Kikyou1997 commented on issue #9621: [Enhancement](Nereids)Add physical plan nodes that needed by SSB

2022-05-19 Thread GitBox
Kikyou1997 commented on issue #9621: URL: https://github.com/apache/incubator-doris/issues/9621#issuecomment-1132373379 I will do it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] Kikyou1997 commented on issue #9622: [Enhancement](Nereids)Fragment translator rules

2022-05-19 Thread GitBox
Kikyou1997 commented on issue #9622: URL: https://github.com/apache/incubator-doris/issues/9622#issuecomment-1132373627 I could do it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

  1   2   >