[GitHub] [incubator-doris] jackwener commented on issue #8697: [Bug] About full join and cross join

2022-03-29 Thread GitBox
jackwener commented on issue #8697: URL: https://github.com/apache/incubator-doris/issues/8697#issuecomment-1081487873 A little hint, we can use markdown syntax \`\`\`sql your sql statement \`\`\` -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-doris] jackwener commented on issue #8715: [Enhancement] Support DROP USER [IF EXISTS]

2022-03-29 Thread GitBox
jackwener commented on issue #8715: URL: https://github.com/apache/incubator-doris/issues/8715#issuecomment-1081491683 > I'm kind of busy these days, but I'm willing to walk through the code and submit PR once I'm free. It's great, If you have some problem, you can contact maintaine

[GitHub] [incubator-doris] ritikBhandari commented on issue #8721: [Enhancement] Remove some unused include

2022-03-29 Thread GitBox
ritikBhandari commented on issue #8721: URL: https://github.com/apache/incubator-doris/issues/8721#issuecomment-1081492453 Hi, Can I solve this issue if you dont mind? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [incubator-doris] jackwener commented on issue #8721: [Enhancement] Remove some unused include

2022-03-29 Thread GitBox
jackwener commented on issue #8721: URL: https://github.com/apache/incubator-doris/issues/8721#issuecomment-1081495419 Yes, you can take it up.❤ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [incubator-doris] jackwener edited a comment on issue #8721: [Enhancement] Remove some unused include

2022-03-29 Thread GitBox
jackwener edited a comment on issue #8721: URL: https://github.com/apache/incubator-doris/issues/8721#issuecomment-1081495419 Yes, you can take it up.❤ If you have any question, you can contact me by @jackwener -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-doris] ritikBhandari commented on issue #8721: [Enhancement] Remove some unused include

2022-03-29 Thread GitBox
ritikBhandari commented on issue #8721: URL: https://github.com/apache/incubator-doris/issues/8721#issuecomment-1081498980 So is this issue present in the whole repository or some of the files? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-doris] HappenLee opened a new pull request #8722: [Join] Support join project in query engine

2022-03-29 Thread GitBox
HappenLee opened a new pull request #8722: URL: https://github.com/apache/incubator-doris/pull/8722 # Proposed changes Issue Number: close #7901 ## Problem Summary: link pr :#8618 ## Checklist(Required) 1. Does it affect the original behavior: (Yes/No/I Do

[GitHub] [incubator-doris-manager] liruixl opened a new pull request #24: [fix] check if user is empty when deleting palo user

2022-03-29 Thread GitBox
liruixl opened a new pull request #24: URL: https://github.com/apache/incubator-doris-manager/pull/24 ## Checklist(Required) 1. Does it affect the original behavior: Yes 2. Has unit tests been added: No 3. Has document been added or modified: No Need 4. Does it need to update

[GitHub] [incubator-doris] caiconghui merged pull request #8694: [refactor]Remove mem tablet from be

2022-03-29 Thread GitBox
caiconghui merged pull request #8694: URL: https://github.com/apache/incubator-doris/pull/8694 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: com

[GitHub] [incubator-doris] kevinjmh opened a new pull request #8723: [doc] update doc of get-load-state

2022-03-29 Thread GitBox
kevinjmh opened a new pull request #8723: URL: https://github.com/apache/incubator-doris/pull/8723 # Proposed changes Add return values details; Add curl example; Remove misplaced doc; ## Problem Summary: Describe the overview of changes. ## Checklist(Requir

[GitHub] [incubator-doris] jackwener commented on issue #8721: [Enhancement] Remove some unused include

2022-03-29 Thread GitBox
jackwener commented on issue #8721: URL: https://github.com/apache/incubator-doris/issues/8721#issuecomment-1081510407 > So is this issue present in the whole repository or some of the files? Let me give a example. In the `be/src/env`, other `.h` file include `.env.h` . `.cpp`

[GitHub] [incubator-doris] jackwener edited a comment on issue #8721: [Enhancement] Remove some unused include

2022-03-29 Thread GitBox
jackwener edited a comment on issue #8721: URL: https://github.com/apache/incubator-doris/issues/8721#issuecomment-1081510407 > So is this issue present in the whole repository or some of the files? Let me give a example. In the `be/src/env`, other `.h` file include `.env.h` .

[GitHub] [incubator-doris] ritikBhandari commented on issue #8721: [Enhancement] Remove some unused include

2022-03-29 Thread GitBox
ritikBhandari commented on issue #8721: URL: https://github.com/apache/incubator-doris/issues/8721#issuecomment-1081514612 Sure. Thank you :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [incubator-doris] yangzhg opened a new pull request #8724: [fix] Fix a typo caused by a refactoring

2022-03-29 Thread GitBox
yangzhg opened a new pull request #8724: URL: https://github.com/apache/incubator-doris/pull/8724 # Proposed changes Fix a typo caused by a refactoring ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the origin

[GitHub] [incubator-doris-manager] hf200012 merged pull request #24: [fix] check if user is empty when deleting palo user

2022-03-29 Thread GitBox
hf200012 merged pull request #24: URL: https://github.com/apache/incubator-doris-manager/pull/24 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: c

[GitHub] [incubator-doris] huangyuansheng commented on issue #8697: [Bug] About full join and cross join

2022-03-29 Thread GitBox
huangyuansheng commented on issue #8697: URL: https://github.com/apache/incubator-doris/issues/8697#issuecomment-1081533968 ``` yeah I get it thx ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [incubator-doris] huangyuansheng commented on issue #8698: [Bug] About grouping sets

2022-03-29 Thread GitBox
huangyuansheng commented on issue #8698: URL: https://github.com/apache/incubator-doris/issues/8698#issuecomment-1081537765 ``` yeah again I get it again thx again ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-doris] huangyuansheng edited a comment on issue #8698: [Bug] About grouping sets

2022-03-29 Thread GitBox
huangyuansheng edited a comment on issue #8698: URL: https://github.com/apache/incubator-doris/issues/8698#issuecomment-1081537765 ``` yeah again I get it again thx again ``` -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8724: [fix] Fix a typo caused by a refactoring

2022-03-29 Thread GitBox
github-actions[bot] commented on pull request #8724: URL: https://github.com/apache/incubator-doris/pull/8724#issuecomment-1081543125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] HappenLee commented on issue #8697: [Bug] About full join and cross join

2022-03-29 Thread GitBox
HappenLee commented on issue #8697: URL: https://github.com/apache/incubator-doris/issues/8697#issuecomment-1081552612 This bug is cause by old join reorder, you can temp fix by the way: ``` set enable_cost_based_join_reorder=true; set disable_join_reorder=true; ``` -- This i

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #8618: Enable hash join project

2022-03-29 Thread GitBox
EmmyMiao87 commented on a change in pull request #8618: URL: https://github.com/apache/incubator-doris/pull/8618#discussion_r837182344 ## File path: fe/fe-core/src/main/java/org/apache/doris/planner/HashJoinNode.java ## @@ -165,6 +170,54 @@ public void setColocate(boolean coloc

[GitHub] [incubator-doris] dataroaring opened a new issue #8725: [Bug] be core dump at NodeChannel::try_send_batch

2022-03-29 Thread GitBox
dataroaring opened a new issue #8725: URL: https://github.com/apache/incubator-doris/issues/8725 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version de

[GitHub] [incubator-doris] dataroaring opened a new issue #8726: [Bug] DCHECK failed at VExprContext::close

2022-03-29 Thread GitBox
dataroaring opened a new issue #8726: URL: https://github.com/apache/incubator-doris/issues/8726 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version de

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8720: [Bug] Fix DCHECK failed in runtime filter and mutable block

2022-03-29 Thread GitBox
github-actions[bot] commented on pull request #8720: URL: https://github.com/apache/incubator-doris/pull/8720#issuecomment-1081589231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] yangzhg merged pull request #8724: [fix] Fix a typo caused by a refactoring

2022-03-29 Thread GitBox
yangzhg merged pull request #8724: URL: https://github.com/apache/incubator-doris/pull/8724 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commit

[GitHub] [incubator-doris] yangzhg commented on pull request #8724: [fix] Fix a typo caused by a refactoring

2022-03-29 Thread GitBox
yangzhg commented on pull request #8724: URL: https://github.com/apache/incubator-doris/pull/8724#issuecomment-1081590473 merge for fix bug -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [incubator-doris] dataroaring opened a new pull request #8727: Sinks call DataSink::close instead of operating _closed directly

2022-03-29 Thread GitBox
dataroaring opened a new pull request #8727: URL: https://github.com/apache/incubator-doris/pull/8727 TabletSink::_is_closed is duplicated with DataSink::_closed and all sinks should call DataSink::close rather than set _closed directly. Fix for https://github.com/apache/incubat

[GitHub] [incubator-doris] dataroaring opened a new pull request #8728: fix concurrent synchorinzation problem in NodeChannel::try_send_batch

2022-03-29 Thread GitBox
dataroaring opened a new pull request #8728: URL: https://github.com/apache/incubator-doris/pull/8728 The detailed message is put in tablet_sink.cpp as comment. Fix for https://github.com/apache/incubator-doris/issues/8725. # Proposed changes Issue Number: close #8725

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #8722: [Join] Support join project in query engine

2022-03-29 Thread GitBox
EmmyMiao87 commented on a change in pull request #8722: URL: https://github.com/apache/incubator-doris/pull/8722#discussion_r837226563 ## File path: be/src/vec/exec/join/vhash_join_node.h ## @@ -232,6 +232,10 @@ class HashJoinNode : public ::doris::ExecNode { std::vector _

[GitHub] [incubator-doris] DarvenDuan closed pull request #8634: [bug] (sql_block_rule) Fix sql block rule bug

2022-03-29 Thread GitBox
DarvenDuan closed pull request #8634: URL: https://github.com/apache/incubator-doris/pull/8634 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: com

[GitHub] [incubator-doris] BiteTheDDDDt opened a new issue #8729: [Enhancement] enhancement for regression-test framework

2022-03-29 Thread GitBox
BiteThet opened a new issue #8729: URL: https://github.com/apache/incubator-doris/issues/8729 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Description

[GitHub] [incubator-doris] BiteTheDDDDt opened a new pull request #8730: [Enhancement] enhancement for regression-test framework

2022-03-29 Thread GitBox
BiteThet opened a new pull request #8730: URL: https://github.com/apache/incubator-doris/pull/8730 # Proposed changes Issue Number: close #8729 ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original b

[GitHub] [incubator-doris] morningman opened a new issue #8731: [Bug] FE failed to start with java.lang.NoSuchFieldError

2022-03-29 Thread GitBox
morningman opened a new issue #8731: URL: https://github.com/apache/incubator-doris/issues/8731 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version tru

[GitHub] [incubator-doris] morningman opened a new pull request #8732: [chore] Modify build.sh and refactor dependency of FE submodules

2022-03-29 Thread GitBox
morningman opened a new pull request #8732: URL: https://github.com/apache/incubator-doris/pull/8732 # Proposed changes Issue Number: close #8731 ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original be

[GitHub] [incubator-doris] marising closed issue #4592: [Bug]Sqlcache has the problem of cross-border access index, and BE will crash

2022-03-29 Thread GitBox
marising closed issue #4592: URL: https://github.com/apache/incubator-doris/issues/4592 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-un

[GitHub] [incubator-doris] marising closed issue #2581: [Feature][Cache] Doris caches query results based on partition

2022-03-29 Thread GitBox
marising closed issue #2581: URL: https://github.com/apache/incubator-doris/issues/2581 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-un

[GitHub] [incubator-doris] marising closed issue #3735: [Bug]If the key column of the table is a double / float type, it will crash when checksum

2022-03-29 Thread GitBox
marising closed issue #3735: URL: https://github.com/apache/incubator-doris/issues/3735 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-un

[GitHub] [incubator-doris] marising closed issue #4076: [MetaData]Add VisibleVersionTime for Partition metadata

2022-03-29 Thread GitBox
marising closed issue #4076: URL: https://github.com/apache/incubator-doris/issues/4076 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-un

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8732: [chore] Modify build.sh and refactor dependency of FE submodules

2022-03-29 Thread GitBox
github-actions[bot] commented on pull request #8732: URL: https://github.com/apache/incubator-doris/pull/8732#issuecomment-1081665732 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] hf200012 merged pull request #8642: [Enhancement] add clang-tidy config && add C++ Code Diagnostic document

2022-03-29 Thread GitBox
hf200012 merged pull request #8642: URL: https://github.com/apache/incubator-doris/pull/8642 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commi

[GitHub] [incubator-doris] hf200012 merged pull request #8660: [Vectorized][refactor] refactor stddev/variance agg functions

2022-03-29 Thread GitBox
hf200012 merged pull request #8660: URL: https://github.com/apache/incubator-doris/pull/8660 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commi

[GitHub] [incubator-doris] hf200012 closed issue #8659: [Vectorized]refactor stddev/variance agg functions

2022-03-29 Thread GitBox
hf200012 closed issue #8659: URL: https://github.com/apache/incubator-doris/issues/8659 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-un

[GitHub] [incubator-doris] hf200012 merged pull request #8683: optimize create tpch table statments to achieve higher performance

2022-03-29 Thread GitBox
hf200012 merged pull request #8683: URL: https://github.com/apache/incubator-doris/pull/8683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commi

[GitHub] [incubator-doris] hf200012 merged pull request #8696: [doc] Update flink-doris-connector.md

2022-03-29 Thread GitBox
hf200012 merged pull request #8696: URL: https://github.com/apache/incubator-doris/pull/8696 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commi

[GitHub] [incubator-doris] hf200012 merged pull request #8702: [typo] Fix runtime filter docs

2022-03-29 Thread GitBox
hf200012 merged pull request #8702: URL: https://github.com/apache/incubator-doris/pull/8702 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commi

[GitHub] [incubator-doris] hf200012 merged pull request #8703: [doc] Update VARCHAR.md

2022-03-29 Thread GitBox
hf200012 merged pull request #8703: URL: https://github.com/apache/incubator-doris/pull/8703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commi

[GitHub] [incubator-doris] hf200012 merged pull request #8714: [Improvement] fix typo

2022-03-29 Thread GitBox
hf200012 merged pull request #8714: URL: https://github.com/apache/incubator-doris/pull/8714 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commi

[GitHub] [incubator-doris] hf200012 closed issue #8717: [Enhancement] Broker load with HDFS doesn't support wildcard

2022-03-29 Thread GitBox
hf200012 closed issue #8717: URL: https://github.com/apache/incubator-doris/issues/8717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-un

[GitHub] [incubator-doris] hf200012 merged pull request #8718: [Improvement] broker load with hdfs support wildcard

2022-03-29 Thread GitBox
hf200012 merged pull request #8718: URL: https://github.com/apache/incubator-doris/pull/8718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commi

[incubator-doris] branch master updated (f3659c8 -> 0d43f8e)

2022-03-29 Thread yangzhg
This is an automated email from the ASF dual-hosted git repository. yangzhg pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from f3659c8 [fix][chore](repository)(fe) check reponame when creating repository and modify build.sh (#8671)

[GitHub] [incubator-doris-spark-connector] lijun816 opened a new issue #16: [Bug]

2022-03-29 Thread GitBox
lijun816 opened a new issue #16: URL: https://github.com/apache/incubator-doris-spark-connector/issues/16 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version

[GitHub] [incubator-doris] dataroaring opened a new pull request #8733: [ubsan] fix some ubsan complains on vector and pointer

2022-03-29 Thread GitBox
dataroaring opened a new pull request #8733: URL: https://github.com/apache/incubator-doris/pull/8733 # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original beh

[GitHub] [incubator-doris] englefly commented on a change in pull request #8695: [enhancement] update broadcast join cost algorithm

2022-03-29 Thread GitBox
englefly commented on a change in pull request #8695: URL: https://github.com/apache/incubator-doris/pull/8695#discussion_r837314863 ## File path: fe/fe-core/src/main/java/org/apache/doris/planner/JoinCostEvaluation.java ## @@ -147,7 +149,7 @@ public long constructHashTableSpa

[GitHub] [incubator-doris] adonis0147 commented on pull request #8680: [Refactor](type_info) use template and single instance to refactor get type info logic

2022-03-29 Thread GitBox
adonis0147 commented on pull request #8680: URL: https://github.com/apache/incubator-doris/pull/8680#issuecomment-1081708279 I think this pr should be discussed sufficiently before merge it in. -- This is an automated message from the Apache Git Service. To respond to the message, please

[incubator-doris-manager] branch master updated: check if user is empty when delete palo user (#24)

2022-03-29 Thread jiafengzheng
This is an automated email from the ASF dual-hosted git repository. jiafengzheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris-manager.git The following commit(s) were added to refs/heads/master by this push: new b2c3c77 check if user is

[incubator-doris] branch master updated (d82c138 -> f3659c8)

2022-03-29 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from d82c138 [fix](user-property) Fix bug that can not set exec_mem_limit at user level (#8710) add f3

[incubator-doris-manager] branch master updated (4ef5f46 -> 00e96af)

2022-03-29 Thread jiafengzheng
This is an automated email from the ASF dual-hosted git repository. jiafengzheng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris-manager.git. from 4ef5f46 Optimize compilation scripts (#22) add 00e96af [fix] fix the custom config cann

[incubator-doris] branch master updated (ba933d1 -> 8d2d889)

2022-03-29 Thread yangzhg
This is an automated email from the ASF dual-hosted git repository. yangzhg pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from ba933d1 [refactor](storage_engine) Remove mem tablet from be (#8694) add 8d2d889 [fix] Fix a typo ca

[GitHub] [incubator-doris] morningman commented on a change in pull request #8728: fix concurrent synchorinzation problem in NodeChannel::try_send_batch

2022-03-29 Thread GitBox
morningman commented on a change in pull request #8728: URL: https://github.com/apache/incubator-doris/pull/8728#discussion_r837332798 ## File path: be/src/exec/tablet_sink.cpp ## @@ -458,8 +458,37 @@ int NodeChannel::try_send_and_fetch_status(RuntimeState* state, ret

[incubator-doris] branch master updated (23b3484 -> 66a3c57)

2022-03-29 Thread lihaopeng
This is an automated email from the ASF dual-hosted git repository. lihaopeng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 23b3484 [Bug] Read bitmap/hll column failed for storage layer vectorization (#8560) add 66a3c57 [

[GitHub] [incubator-doris] morningman commented on a change in pull request #8728: fix concurrent synchorinzation problem in NodeChannel::try_send_batch

2022-03-29 Thread GitBox
morningman commented on a change in pull request #8728: URL: https://github.com/apache/incubator-doris/pull/8728#discussion_r837333782 ## File path: be/src/exec/tablet_sink.cpp ## @@ -458,8 +458,37 @@ int NodeChannel::try_send_and_fetch_status(RuntimeState* state, ret

[GitHub] [incubator-doris] morningman commented on a change in pull request #8733: [ubsan] fix some ubsan complains on vector and pointer

2022-03-29 Thread GitBox
morningman commented on a change in pull request #8733: URL: https://github.com/apache/incubator-doris/pull/8733#discussion_r837337104 ## File path: be/src/exprs/expr_context.cpp ## @@ -116,7 +116,8 @@ Status ExprContext::clone(RuntimeState* state, ExprContext** new_ctx) {

[GitHub] [incubator-doris] morningman commented on a change in pull request #8727: Sinks call DataSink::close instead of operating _closed directly

2022-03-29 Thread GitBox
morningman commented on a change in pull request #8727: URL: https://github.com/apache/incubator-doris/pull/8727#discussion_r837340672 ## File path: be/src/vec/sink/result_sink.cpp ## @@ -125,7 +125,7 @@ Status VResultSink::close(RuntimeState* state, Status exec_status) {

[incubator-doris] branch master updated (0d43f8e -> 23b3484)

2022-03-29 Thread wangbo
This is an automated email from the ASF dual-hosted git repository. wangbo pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 0d43f8e [refactor] remove atomic.h/cpp use std::atomic instead (#8693) add 23b3484 [Bug] Read bitmap/

[GitHub] [incubator-doris] wangbo opened a new issue #8734: [Bug] Vectorization decimal avg inconsistent

2022-03-29 Thread GitBox
wangbo opened a new issue #8734: URL: https://github.com/apache/incubator-doris/issues/8734 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version master

[GitHub] [incubator-doris] wangbo merged pull request #8627: [refactor][optimize] Code optimization and refactoring for low-cardinality columns in storage layer

2022-03-29 Thread GitBox
wangbo merged pull request #8627: URL: https://github.com/apache/incubator-doris/pull/8627 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[incubator-doris] branch master updated (b20af5f -> da87e0c)

2022-03-29 Thread jiafengzheng
This is an automated email from the ASF dual-hosted git repository. jiafengzheng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from b20af5f [Vectorized][refactor] refactor stddev/variance agg functions (#8660) add da87e0c opti

[GitHub] [incubator-doris] platoneko opened a new issue #8735: [Bug] be ut TestBitField failed

2022-03-29 Thread GitBox
platoneko opened a new issue #8735: URL: https://github.com/apache/incubator-doris/issues/8735 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version mast

[incubator-doris] branch master updated (1ddfe20 -> 3f5bc52)

2022-03-29 Thread jiafengzheng
This is an automated email from the ASF dual-hosted git repository. jiafengzheng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 1ddfe20 fix typo (#8714) add 3f5bc52 [Improvement] broker load with hdfs support wildcard (#871

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #8348: [Feature](Statistics) generate the statistics tasks based on input statement

2022-03-29 Thread GitBox
EmmyMiao87 commented on a change in pull request #8348: URL: https://github.com/apache/incubator-doris/pull/8348#discussion_r837346292 ## File path: fe/fe-core/src/test/java/org/apache/doris/statistics/StatisticsJobTest.java ## @@ -0,0 +1,159 @@ +package org.apache.doris.stati

[GitHub] [incubator-doris] morningman opened a new issue #8736: [Bug] Multi plan fragment even if there is only one BE

2022-03-29 Thread GitBox
morningman opened a new issue #8736: URL: https://github.com/apache/incubator-doris/issues/8736 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version tru

[incubator-doris] branch master updated (da87e0c -> c7bdf3e)

2022-03-29 Thread jiafengzheng
This is an automated email from the ASF dual-hosted git repository. jiafengzheng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from da87e0c optimize create tpch table statments to achieve higher performance (#8683) add c7bdf3e

[incubator-doris] branch master updated (8d2d889 -> a9d185f)

2022-03-29 Thread jiafengzheng
This is an automated email from the ASF dual-hosted git repository. jiafengzheng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 8d2d889 [fix] Fix a typo caused by a refactoring (#8724) add a9d185f [Enhancement] add clang-ti

[incubator-doris] branch master updated (3f5bc52 -> 3724f94)

2022-03-29 Thread wangbo
This is an automated email from the ASF dual-hosted git repository. wangbo pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 3f5bc52 [Improvement] broker load with hdfs support wildcard (#8718) add 3724f94 [refactor][optimize]

[incubator-doris] branch master updated (92b95e1 -> 1ddfe20)

2022-03-29 Thread jiafengzheng
This is an automated email from the ASF dual-hosted git repository. jiafengzheng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 92b95e1 [doc] Update VARCHAR.md (#8703) add 1ddfe20 fix typo (#8714) No new revisions were add

[incubator-doris] branch master updated (a9d185f -> b20af5f)

2022-03-29 Thread jiafengzheng
This is an automated email from the ASF dual-hosted git repository. jiafengzheng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from a9d185f [Enhancement] add clang-tidy config && add C++ Code Diagnostic document (#8642) add b20

[GitHub] [incubator-doris] platoneko commented on issue #8735: [Bug] be ut TestBitField failed

2022-03-29 Thread GitBox
platoneko commented on issue #8735: URL: https://github.com/apache/incubator-doris/issues/8735#issuecomment-1081749871 Do we still need `TestBitField`? @morningman @yiguolei -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[incubator-doris] branch master updated (23155e0 -> 92b95e1)

2022-03-29 Thread jiafengzheng
This is an automated email from the ASF dual-hosted git repository. jiafengzheng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 23155e0 [typo] Fix runtime filter docs (#8702) add 92b95e1 [doc] Update VARCHAR.md (#8703) No

[incubator-doris] branch master updated (c7bdf3e -> 23155e0)

2022-03-29 Thread jiafengzheng
This is an automated email from the ASF dual-hosted git repository. jiafengzheng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from c7bdf3e [doc] Update flink-doris-connector.md (#8696) add 23155e0 [typo] Fix runtime filter doc

[GitHub] [incubator-doris] adonis0147 edited a comment on pull request #8680: [Refactor](type_info) use template and single instance to refactor get type info logic

2022-03-29 Thread GitBox
adonis0147 edited a comment on pull request #8680: URL: https://github.com/apache/incubator-doris/pull/8680#issuecomment-1081708279 I think this pr should be discussed sufficiently before we merge it in. Unlike the scalar type, the type info of dynamic types (such as Array, Map and e

[GitHub] [incubator-doris] dataroaring commented on a change in pull request #8728: fix concurrent synchorinzation problem in NodeChannel::try_send_batch

2022-03-29 Thread GitBox
dataroaring commented on a change in pull request #8728: URL: https://github.com/apache/incubator-doris/pull/8728#discussion_r837372719 ## File path: be/src/exec/tablet_sink.cpp ## @@ -458,8 +458,37 @@ int NodeChannel::try_send_and_fetch_status(RuntimeState* state, re

[incubator-doris] branch master updated (365eba0 -> d82c138)

2022-03-29 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 365eba0 [fix] fix core dump when avg on not null decimal in empty table (#8681) add d82c138 [fix

[incubator-doris] branch master updated (66a3c57 -> ba933d1)

2022-03-29 Thread caiconghui
This is an automated email from the ASF dual-hosted git repository. caiconghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 66a3c57 [Vectorized][Bug] fix percentile_approx function to return always nullable (#8572) add ba

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #8348: [Feature](Statistics) generate the statistics tasks based on input statement

2022-03-29 Thread GitBox
EmmyMiao87 commented on a change in pull request #8348: URL: https://github.com/apache/incubator-doris/pull/8348#discussion_r837389102 ## File path: fe/fe-core/src/main/java/org/apache/doris/statistics/StatisticsJobManager.java ## @@ -18,56 +18,128 @@ package org.apache.doris

[GitHub] [incubator-doris] dataroaring commented on pull request #8728: fix concurrent synchorinzation problem in NodeChannel::try_send_batch

2022-03-29 Thread GitBox
dataroaring commented on pull request #8728: URL: https://github.com/apache/incubator-doris/pull/8728#issuecomment-1081802909 please do not merge this patch, the patch brings other problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-doris] zbtzbtzbt commented on a change in pull request #8733: [ubsan] fix some ubsan complains on vector and pointer

2022-03-29 Thread GitBox
zbtzbtzbt commented on a change in pull request #8733: URL: https://github.com/apache/incubator-doris/pull/8733#discussion_r837417647 ## File path: be/src/exprs/expr_context.h ## @@ -165,11 +165,6 @@ class ExprContext { /// and owned by this ExprContext. std::vector _

[GitHub] [incubator-doris] xlwh commented on pull request #8679: [Typo] Optimize some code comments style for 'be/src/common/*'

2022-03-29 Thread GitBox
xlwh commented on pull request #8679: URL: https://github.com/apache/incubator-doris/pull/8679#issuecomment-1081818334 > Was the code formatted using the method here? http://doris.incubator.apache.org/zh-CN/developer-guide/cpp-format-code.html#%E4%BB%A3%E7%A0%81%E9%A3%8E%E6%A0%BC%E5%AE%9A%E

[GitHub] [incubator-doris] zenoyang opened a new pull request #8737: [optimize](storage) Use column dictionary only when all pages are dict encoding

2022-03-29 Thread GitBox
zenoyang opened a new pull request #8737: URL: https://github.com/apache/incubator-doris/pull/8737 # Proposed changes Issue Number: close #8315 Use column dictionary only when all pages are dict encoding. ## Problem Summary: The current storage layer creates a `Colum

[GitHub] [incubator-doris] zenoyang commented on pull request #8737: [optimize](storage) Use column dictionary only when all pages are dict encoding

2022-03-29 Thread GitBox
zenoyang commented on pull request #8737: URL: https://github.com/apache/incubator-doris/pull/8737#issuecomment-1081844297 I have tested and verified the correctness, and will provide a performance comparison before and after optimization soon. -- This is an automated message from the Ap

[GitHub] [incubator-doris] DarvenDuan opened a new pull request #8738: [bug] (sql_block_rule) Fix sql block rule bug

2022-03-29 Thread GitBox
DarvenDuan opened a new pull request #8738: URL: https://github.com/apache/incubator-doris/pull/8738 # Proposed changes Issue Number: close #8629 & #8621 ## Problem Summary: 1. Check properties' effectiveness of a sql_block_rule, can't set limitations of sql_block_rule

[GitHub] [incubator-doris-flink-connector] madongz opened a new pull request #23: json load by line

2022-03-29 Thread GitBox
madongz opened a new pull request #23: URL: https://github.com/apache/incubator-doris-flink-connector/pull/23 # Proposed changes 1. For stream load with json format,support read_json_by_line instead of strip_outer_array 2. Remove non empty check for dorisReadOptions ## Che

[GitHub] [incubator-doris] caiconghui commented on pull request #8680: [Refactor](type_info) use template and single instance to refactor get type info logic

2022-03-29 Thread GitBox
caiconghui commented on pull request #8680: URL: https://github.com/apache/incubator-doris/pull/8680#issuecomment-1081889227 > I think this pr should be discussed sufficiently before we merge it in. > > Unlike the scalar type, the type info of dynamic types (such as Array, Map and et

[GitHub] [incubator-doris] platoneko opened a new pull request #8739: [bug] fix be ut in olap

2022-03-29 Thread GitBox
platoneko opened a new pull request #8739: URL: https://github.com/apache/incubator-doris/pull/8739 # Proposed changes Issue Number: close #8735 ## Problem Summary: Create necessary files before run the tests. ## Checklist(Required) 1. Does it affect the o

svn commit: r53437 - /dev/incubator/doris/1.0/1.0.0-rc02/

2022-03-29 Thread morningman
Author: morningman Date: Tue Mar 29 14:21:12 2022 New Revision: 53437 Log: update doris 1.0.0-rc02 jdk version Modified: dev/incubator/doris/1.0/1.0.0-rc02/apache-doris-be-1.0.0-incubating-bin.tar.gz dev/incubator/doris/1.0/1.0.0-rc02/apache-doris-be-1.0.0-incubating-bin.tar.gz.asc

[GitHub] [incubator-doris] dataalive opened a new pull request #8740: [typo] fix show tablets command

2022-03-29 Thread GitBox
dataalive opened a new pull request #8740: URL: https://github.com/apache/incubator-doris/pull/8740 # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behav

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8740: [fix](doc) fix show tablets command

2022-03-29 Thread GitBox
github-actions[bot] commented on pull request #8740: URL: https://github.com/apache/incubator-doris/pull/8740#issuecomment-1082025828 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [incubator-doris] morningman commented on issue #8659: [Vectorized]refactor stddev/variance agg functions

2022-03-29 Thread GitBox
morningman commented on issue #8659: URL: https://github.com/apache/incubator-doris/issues/8659#issuecomment-1082043255 This kind issue is meaningless... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-doris] morningman commented on pull request #8627: [refactor][optimize] Code optimization and refactoring for low-cardinality columns in storage layer

2022-03-29 Thread GitBox
morningman commented on pull request #8627: URL: https://github.com/apache/incubator-doris/pull/8627#issuecomment-1082052588 hi @wangbo , the label `dev/merged-1.0.1` means this PR has been merged to branch `dev-1.0.1`. if not, it should be marked as `dev/1.0.1` -- This is an automate

[GitHub] [incubator-doris] morningman edited a comment on pull request #8627: [refactor][optimize] Code optimization and refactoring for low-cardinality columns in storage layer

2022-03-29 Thread GitBox
morningman edited a comment on pull request #8627: URL: https://github.com/apache/incubator-doris/pull/8627#issuecomment-1082052588 hi @wangbo , the label `dev/merged-1.0.1` means this PR has been merged to branch `dev-1.0.1`. if not, it should be marked as `dev/1.0.1` I will merg

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8739: [bug] fix be ut in olap

2022-03-29 Thread GitBox
github-actions[bot] commented on pull request #8739: URL: https://github.com/apache/incubator-doris/pull/8739#issuecomment-1082073795 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

  1   2   >