[GitHub] [incubator-doris] xiaokang commented on pull request #8451: [improvement](memory) fix olap table scan and sink memory usage problem

2022-03-13 Thread GitBox
xiaokang commented on pull request #8451: URL: https://github.com/apache/incubator-doris/pull/8451#issuecomment-1066054539 @morningman volap_scan_node.cpp is done. The test result is almost the same as non-vectorized version. -- This is an automated message from the Apache Git Service. T

[GitHub] [incubator-doris] zhannngchen opened a new pull request #8458: [UT] add unit tests for min/max function, and cleaned up some unused …

2022-03-13 Thread GitBox
zhannngchen opened a new pull request #8458: URL: https://github.com/apache/incubator-doris/pull/8458 # Proposed changes Add unit tests for min/max function, with some code cleanup. ## Problem Summary: Describe the overview of changes. ## Checklist(Required)

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8458: [UT] add unit tests for min/max function, and cleaned up some unused …

2022-03-13 Thread GitBox
github-actions[bot] commented on pull request #8458: URL: https://github.com/apache/incubator-doris/pull/8458#issuecomment-1066080355 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [incubator-doris] dataroaring commented on issue #8382: [Bug] variance is different with trino

2022-03-13 Thread GitBox
dataroaring commented on issue #8382: URL: https://github.com/apache/incubator-doris/issues/8382#issuecomment-1066080832 https://github.com/apache/incubator-doris/blob/master/regression-test/suites/aggregate/aggregate.groovy can reproduce. -- This is an automated message from the Apach

[GitHub] [incubator-doris] zbtzbtzbt commented on issue #8435: [Enhancement] The bitmap_hash function can be implemented using murmur_hash3_128

2022-03-13 Thread GitBox
zbtzbtzbt commented on issue #8435: URL: https://github.com/apache/incubator-doris/issues/8435#issuecomment-1066083773 I think this modification will be incompatible with old data @syb853553110 https://doris.apache.org/zh-CN/sql-reference/sql-functions/bitmap-functions/bitmap_hash.html

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8457: [fix][routine-load] fix bug that routine load cannot cancel task when append_data return error

2022-03-13 Thread GitBox
github-actions[bot] commented on pull request #8457: URL: https://github.com/apache/incubator-doris/pull/8457#issuecomment-1066084147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8451: [improvement](memory) fix olap table scan and sink memory usage problem

2022-03-13 Thread GitBox
github-actions[bot] commented on pull request #8451: URL: https://github.com/apache/incubator-doris/pull/8451#issuecomment-1066084713 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] morningman merged pull request #8369: [docs] Update documentation configuration parameter `sink.batch.bytes…

2022-03-13 Thread GitBox
morningman merged pull request #8369: URL: https://github.com/apache/incubator-doris/pull/8369 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: com

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8369: [docs] Update documentation configuration parameter `sink.batch.bytes…

2022-03-13 Thread GitBox
github-actions[bot] commented on pull request #8369: URL: https://github.com/apache/incubator-doris/pull/8369#issuecomment-1066095170 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[incubator-doris] branch master updated: [doc] Update documentation configuration parameter `sink.batch.bytes` in flink-doris-connector (#8369)

2022-03-13 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 392a977 [doc] Update documentation

[incubator-doris] branch master updated: [improvement](VHashJoin) add probe timer (#8233)

2022-03-13 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 705989d [improvement](VHashJoin) a

[GitHub] [incubator-doris] morningman merged pull request #8233: [Vectorized][HashJoin] add probe timer

2022-03-13 Thread GitBox
morningman merged pull request #8233: URL: https://github.com/apache/incubator-doris/pull/8233 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: com

[GitHub] [incubator-doris] morningman opened a new issue #8459: [Bug] BE crash when doing left outer join with vec engine

2022-03-13 Thread GitBox
morningman opened a new issue #8459: URL: https://github.com/apache/incubator-doris/issues/8459 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version dev

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8458: [UT] add unit tests for min/max function, and cleaned up some unused …

2022-03-13 Thread GitBox
github-actions[bot] commented on pull request #8458: URL: https://github.com/apache/incubator-doris/pull/8458#issuecomment-1066110440 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8456: [chore](dependency) fix build thirdparty errors

2022-03-13 Thread GitBox
github-actions[bot] commented on pull request #8456: URL: https://github.com/apache/incubator-doris/pull/8456#issuecomment-1066110771 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [incubator-doris] morningman merged pull request #8456: [chore](dependency) fix build thirdparty errors

2022-03-13 Thread GitBox
morningman merged pull request #8456: URL: https://github.com/apache/incubator-doris/pull/8456 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: com

[incubator-doris] branch master updated (705989d -> a4b710c)

2022-03-13 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 705989d [improvement](VHashJoin) add probe timer (#8233) add a4b710c [chore](dependency) fix buil

[GitHub] [incubator-doris] morningman merged pull request #8451: [improvement](memory) fix olap table scan and sink memory usage problem

2022-03-13 Thread GitBox
morningman merged pull request #8451: URL: https://github.com/apache/incubator-doris/pull/8451 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: com

[incubator-doris] branch master updated (a4b710c -> e807e8b)

2022-03-13 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from a4b710c [chore](dependency) fix build thirdparty errors (#8456) add e807e8b [improvement](memory)

[GitHub] [incubator-doris] dataroaring closed pull request #8433: add loggger to Suite to log in cases

2022-03-13 Thread GitBox
dataroaring closed pull request #8433: URL: https://github.com/apache/incubator-doris/pull/8433 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: co

[GitHub] [incubator-doris] dataroaring opened a new pull request #8460: let framework support sql cases

2022-03-13 Thread GitBox
dataroaring opened a new pull request #8460: URL: https://github.com/apache/incubator-doris/pull/8460 We generate groovy files from sql cases and run the generated groovy file. This way, we can just put sql cases, then framework handles left work. # Proposed changes Issue

[incubator-doris] branch dev-1.0.0 updated (32da525 -> 701fd4f)

2022-03-13 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch dev-1.0.0 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 32da525 [fix] BE crash when reporting tablet (#8453) new eb322f5 [improvement](vectorized) Sup

[incubator-doris] 01/03: [improvement](vectorized) Support BetweenPredicate enable fold const expr (#8450)

2022-03-13 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.0.0 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit eb322f542cb37fa49d264b887bfe45fe7499046e Author: HappenLee AuthorDate: Sun Mar 13 09:36:24 2022 +0800

[incubator-doris] 02/03: [improvement](memory) fix olap table scan and sink memory usage problem (#8451)

2022-03-13 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.0.0 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit ca058465f861f1df95e25d1a3b009e71c5bdf2ea Author: Kang AuthorDate: Sun Mar 13 22:12:15 2022 +0800 [i

[incubator-doris] 03/03: [chore](dependency) fix build thirdparty errors (#8456)

2022-03-13 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.0.0 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit 701fd4f7f5bbf422f817be6a917e3ca19f294ae0 Author: Mingyu Chen AuthorDate: Sun Mar 13 22:11:24 2022 +0800

[incubator-doris] annotated tag 1.0.0-preview updated (e6478e8 -> 014414a)

2022-03-13 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to annotated tag 1.0.0-preview in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. *** WARNING: tag 1.0.0-preview was modified! *** from e6478e8 (commit) to 014414a (tag

[GitHub] [incubator-doris] HappenLee opened a new pull request #8461: [Bug][Vectorized] Agg/Unique not null column outer join coredump

2022-03-13 Thread GitBox
HappenLee opened a new pull request #8461: URL: https://github.com/apache/incubator-doris/pull/8461 # Proposed changes Issue Number: close #8459 ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original beha

[GitHub] [incubator-doris] xiaokang commented on pull request #8322: [refactor] Impl of MemTracker, and related use

2022-03-13 Thread GitBox
xiaokang commented on pull request #8322: URL: https://github.com/apache/incubator-doris/pull/8322#issuecomment-1066228733 @xinyiZzz When I test for #8451 , I encounter a memory limit problem. The problem is that, after the long query, as specified in the test steps of #8451 , is fi

[GitHub] [incubator-doris-flink-connector] zhqu1148980644 opened a new pull request #19: Update README.md

2022-03-13 Thread GitBox
zhqu1148980644 opened a new pull request #19: URL: https://github.com/apache/incubator-doris-flink-connector/pull/19 # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect t

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #8439: [refactor] use c++ 14 deprecated instead of comment, this detect usage of deprecated var or func at compile time

2022-03-13 Thread GitBox
yangzhg commented on a change in pull request #8439: URL: https://github.com/apache/incubator-doris/pull/8439#discussion_r825546528 ## File path: be/src/agent/task_worker_pool.h ## @@ -51,12 +51,12 @@ class TaskWorkerPool { REALTIME_PUSH, PUBLISH_VERSION,

[GitHub] [incubator-doris] anjia0532 commented on issue #7587: [Roadmap] Doris on K8S

2022-03-13 Thread GitBox
anjia0532 commented on issue #7587: URL: https://github.com/apache/incubator-doris/issues/7587#issuecomment-1066263940 @liangyongz [Kubernetes应用Pod固定IP之kruise](https://segmentfault.com/a/119040707667) -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-doris] caiconghui merged pull request #8457: [fix][routine-load] fix bug that routine load cannot cancel task when append_data return error

2022-03-13 Thread GitBox
caiconghui merged pull request #8457: URL: https://github.com/apache/incubator-doris/pull/8457 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: com

[incubator-doris] branch master updated: [fix][routine-load] fix bug that routine load cannot cancel task when append_data return error (#8457)

2022-03-13 Thread caiconghui
This is an automated email from the ASF dual-hosted git repository. caiconghui pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 991dc7f [fix][routine-load] fix bu

[GitHub] [incubator-doris-flink-connector] bridgeDream commented on pull request #18: [improvement] (before 1.13)Support set max bytes in each batch to avoid congestion

2022-03-13 Thread GitBox
bridgeDream commented on pull request #18: URL: https://github.com/apache/incubator-doris-flink-connector/pull/18#issuecomment-1066275553 > I will close #13 @bridgeDream Ok, can you approval this pr for branch before 1.13 @hf200012 -- This is an automated message from the Apach

[GitHub] [incubator-doris] hf200012 commented on issue #7587: [Roadmap] Doris on K8S

2022-03-13 Thread GitBox
hf200012 commented on issue #7587: URL: https://github.com/apache/incubator-doris/issues/7587#issuecomment-1066280183 > https://github.com/liangyongz/doris-on-k8s The temporary solution I am currently using is hostNetwork,This approach is limited. > > Will you solve this problem,Use

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8461: [fix](vectorized) Agg/Unique not null column outer join coredump

2022-03-13 Thread GitBox
github-actions[bot] commented on pull request #8461: URL: https://github.com/apache/incubator-doris/pull/8461#issuecomment-1066284455 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] morningman commented on pull request #8461: [fix](vectorized) Agg/Unique not null column outer join coredump

2022-03-13 Thread GitBox
morningman commented on pull request #8461: URL: https://github.com/apache/incubator-doris/pull/8461#issuecomment-1066286993 merge it for quick test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [incubator-doris] morningman merged pull request #8461: [fix](vectorized) Agg/Unique not null column outer join coredump

2022-03-13 Thread GitBox
morningman merged pull request #8461: URL: https://github.com/apache/incubator-doris/pull/8461 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: com

[incubator-doris] branch master updated (991dc7f -> 41a15cc)

2022-03-13 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 991dc7f [fix][routine-load] fix bug that routine load cannot cancel task when append_data return error

[GitHub] [incubator-doris] morningman closed issue #8459: [Bug] BE crash when doing left outer join with vec engine

2022-03-13 Thread GitBox
morningman closed issue #8459: URL: https://github.com/apache/incubator-doris/issues/8459 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-

[GitHub] [incubator-doris] BiteTheDDDDt commented on a change in pull request #8448: [Feature][Vectorized] support lateral view

2022-03-13 Thread GitBox
BiteThet commented on a change in pull request #8448: URL: https://github.com/apache/incubator-doris/pull/8448#discussion_r825562764 ## File path: be/src/vec/exec/vrepeat_node.cpp ## @@ -181,13 +187,9 @@ Status VRepeatNode::get_next(RuntimeState* state, Block* block, bool*

[incubator-doris] branch array-type updated: [feature-wip](array-type) Add codes and UT for array_contains and array_position functions (#8401)

2022-03-13 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch array-type in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/array-type by this push: new 706f7ff [feature-wip](arra

[GitHub] [incubator-doris] morningman merged pull request #8401: [feature][array-type]add array_contains and array_position functions

2022-03-13 Thread GitBox
morningman merged pull request #8401: URL: https://github.com/apache/incubator-doris/pull/8401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: com

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #8408: [Benchmark] Add TPC-H benchmark tools

2022-03-13 Thread GitBox
EmmyMiao87 commented on a change in pull request #8408: URL: https://github.com/apache/incubator-doris/pull/8408#discussion_r825566731 ## File path: tools/tpch-tools/README.md ## @@ -0,0 +1,34 @@ + + +## Usage + +These scripts are used to make tpc-h test. +follow the steps belo

[GitHub] [incubator-doris] zenoyang commented on a change in pull request #8318: [improvement](storage) Low cardinality string optimization in storage layer

2022-03-13 Thread GitBox
zenoyang commented on a change in pull request #8318: URL: https://github.com/apache/incubator-doris/pull/8318#discussion_r825582068 ## File path: be/src/vec/columns/column_dictionary.h ## @@ -0,0 +1,381 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or m

[GitHub] [incubator-doris] zenoyang commented on a change in pull request #8318: [improvement](storage) Low cardinality string optimization in storage layer

2022-03-13 Thread GitBox
zenoyang commented on a change in pull request #8318: URL: https://github.com/apache/incubator-doris/pull/8318#discussion_r825586828 ## File path: be/src/olap/comparison_predicate.cpp ## @@ -145,28 +146,68 @@ COMPARISON_PRED_COLUMN_BLOCK_EVALUATE(LessEqualPredicate, <=) COMPA

[GitHub] [incubator-doris] zenoyang commented on a change in pull request #8318: [improvement](storage) Low cardinality string optimization in storage layer

2022-03-13 Thread GitBox
zenoyang commented on a change in pull request #8318: URL: https://github.com/apache/incubator-doris/pull/8318#discussion_r825587115 ## File path: be/src/vec/columns/column_dictionary.h ## @@ -0,0 +1,381 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or m

[GitHub] [incubator-doris] wangbo commented on a change in pull request #8318: [improvement](storage) Low cardinality string optimization in storage layer

2022-03-13 Thread GitBox
wangbo commented on a change in pull request #8318: URL: https://github.com/apache/incubator-doris/pull/8318#discussion_r825596165 ## File path: be/src/vec/columns/column_dictionary.h ## @@ -0,0 +1,381 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or mor

[GitHub] [incubator-doris] wangbo commented on a change in pull request #8318: [improvement](storage) Low cardinality string optimization in storage layer

2022-03-13 Thread GitBox
wangbo commented on a change in pull request #8318: URL: https://github.com/apache/incubator-doris/pull/8318#discussion_r825596739 ## File path: be/src/vec/columns/column_dictionary.h ## @@ -0,0 +1,381 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or mor

[GitHub] [incubator-doris] wangbo commented on a change in pull request #8318: [improvement](storage) Low cardinality string optimization in storage layer

2022-03-13 Thread GitBox
wangbo commented on a change in pull request #8318: URL: https://github.com/apache/incubator-doris/pull/8318#discussion_r825598921 ## File path: be/src/vec/columns/column_dictionary.h ## @@ -0,0 +1,381 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or mor

[GitHub] [incubator-doris] wangbo commented on a change in pull request #8318: [improvement](storage) Low cardinality string optimization in storage layer

2022-03-13 Thread GitBox
wangbo commented on a change in pull request #8318: URL: https://github.com/apache/incubator-doris/pull/8318#discussion_r825601591 ## File path: be/src/runtime/string_value.h ## @@ -22,9 +22,53 @@ #include "udf/udf.h" #include "util/hash_util.hpp" +#include "util/cpu_info.h

[GitHub] [incubator-doris] wangbo commented on a change in pull request #8318: [improvement](storage) Low cardinality string optimization in storage layer

2022-03-13 Thread GitBox
wangbo commented on a change in pull request #8318: URL: https://github.com/apache/incubator-doris/pull/8318#discussion_r825602217 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp ## @@ -856,6 +857,18 @@ void SegmentIterator::_evaluate_short_circuit_predicate(u

[GitHub] [incubator-doris] wangbo commented on a change in pull request #8318: [improvement](storage) Low cardinality string optimization in storage layer

2022-03-13 Thread GitBox
wangbo commented on a change in pull request #8318: URL: https://github.com/apache/incubator-doris/pull/8318#discussion_r825604376 ## File path: be/src/olap/in_list_predicate.cpp ## @@ -122,21 +123,56 @@ IN_LIST_PRED_COLUMN_BLOCK_EVALUATE(NotInListPredicate, ==) void CLASS

[GitHub] [incubator-doris] syb853553110 commented on issue #8435: [Enhancement] The bitmap_hash function can be implemented using murmur_hash3_128

2022-03-13 Thread GitBox
syb853553110 commented on issue #8435: URL: https://github.com/apache/incubator-doris/issues/8435#issuecomment-1066405091 > I think this modification will be incompatible with old data @syb853553110 https://doris.apache.org/zh-CN/sql-reference/sql-functions/bitmap-functions/bitmap_hash.htm

[GitHub] [incubator-doris] wangbo commented on a change in pull request #8318: [improvement](storage) Low cardinality string optimization in storage layer

2022-03-13 Thread GitBox
wangbo commented on a change in pull request #8318: URL: https://github.com/apache/incubator-doris/pull/8318#discussion_r825609607 ## File path: be/src/olap/comparison_predicate.cpp ## @@ -145,28 +146,68 @@ COMPARISON_PRED_COLUMN_BLOCK_EVALUATE(LessEqualPredicate, <=) COMPARI

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8202: [improvment] show export support label like

2022-03-13 Thread GitBox
github-actions[bot] commented on pull request #8202: URL: https://github.com/apache/incubator-doris/pull/8202#issuecomment-1066426017 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[incubator-doris] branch dev-1.0.1 created (now 9f6dabf)

2022-03-13 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch dev-1.0.1 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. at 9f6dabf [fix][cherry-pick] fix compilation bug with cherry-pick This branch includes the following