[GitHub] [incubator-doris] morningman closed issue #8294: [Feature] StarRocks都有可视化部署了,我们能不能搞一下

2022-03-02 Thread GitBox
morningman closed issue #8294: URL: https://github.com/apache/incubator-doris/issues/8294 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-

[GitHub] [incubator-doris] morningman commented on issue #8294: [Feature] StarRocks都有可视化部署了,我们能不能搞一下

2022-03-02 Thread GitBox
morningman commented on issue #8294: URL: https://github.com/apache/incubator-doris/issues/8294#issuecomment-1056529945 Refer to: https://github.com/apache/incubator-doris/issues/7986 BTW, this is not a good way to ask questions or seek support. I will close and lock this conversati

[GitHub] [incubator-doris] wangbo commented on issue #7334: [Bug] show frontends cause FE oom

2022-03-02 Thread GitBox
wangbo commented on issue #7334: URL: https://github.com/apache/incubator-doris/issues/7334#issuecomment-1056550092 This patch can also be applied for 0.14 too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8282: [Bug] fix string type length limit error && add runtime filter decimal support

2022-03-02 Thread GitBox
github-actions[bot] commented on pull request #8282: URL: https://github.com/apache/incubator-doris/pull/8282#issuecomment-1056562074 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] HappenLee opened a new issue #8295: [Feature] Support update query in vec query engine

2022-03-02 Thread GitBox
HappenLee opened a new issue #8295: URL: https://github.com/apache/incubator-doris/issues/8295 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Description

[GitHub] [incubator-doris] HappenLee opened a new pull request #8296: [Feature] Support update stmt in vec query engine

2022-03-02 Thread GitBox
HappenLee opened a new pull request #8296: URL: https://github.com/apache/incubator-doris/pull/8296 # Proposed changes Issue Number: close #8295 ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original beh

[GitHub] [incubator-doris] yangzhg closed issue #8276: [Bug] encryption functions with iv may return wrong result

2022-03-02 Thread GitBox
yangzhg closed issue #8276: URL: https://github.com/apache/incubator-doris/issues/8276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[incubator-doris] branch master updated: [fix] fix a bug of encryption function with iv may return wrong result (#8277)

2022-03-02 Thread yangzhg
This is an automated email from the ASF dual-hosted git repository. yangzhg pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 246ac4e [fix] fix a bug of encryption

[GitHub] [incubator-doris] yangzhg merged pull request #8277: [fix] fix a bug of encryption function with iv may return wrong result

2022-03-02 Thread GitBox
yangzhg merged pull request #8277: URL: https://github.com/apache/incubator-doris/pull/8277 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commit

[GitHub] [incubator-doris] levy5307 commented on a change in pull request #8292: (improving) refactor column::insert_many_dict_data

2022-03-02 Thread GitBox
levy5307 commented on a change in pull request #8292: URL: https://github.com/apache/incubator-doris/pull/8292#discussion_r817516069 ## File path: be/src/vec/columns/column_string.h ## @@ -165,10 +167,33 @@ class ColumnString final : public COWHelper { } }; -

[GitHub] [incubator-doris] levy5307 commented on a change in pull request #8292: (improving) refactor column::insert_many_dict_data

2022-03-02 Thread GitBox
levy5307 commented on a change in pull request #8292: URL: https://github.com/apache/incubator-doris/pull/8292#discussion_r817516579 ## File path: be/src/vec/columns/column_string.h ## @@ -165,10 +167,33 @@ class ColumnString final : public COWHelper { } }; -

[GitHub] [incubator-doris] wangshuo128 opened a new pull request #8297: [build](fe) Support building an individual maven module.

2022-03-02 Thread GitBox
wangshuo128 opened a new pull request #8297: URL: https://github.com/apache/incubator-doris/pull/8297 # Proposed changes Current, if we build an individual FE maven module, e.g., build `fe-core` moudle via `mvn clean package -pl fe-core`, the below error would occur ``` [ERROR]

[GitHub] [incubator-doris] kangshisen opened a new issue #8298: help broker load 文档错误

2022-03-02 Thread GitBox
kangshisen opened a new issue #8298: URL: https://github.com/apache/incubator-doris/issues/8298 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version 0.1

[GitHub] [incubator-doris] dataroaring opened a new pull request #8299: Window funnel

2022-03-02 Thread GitBox
dataroaring opened a new pull request #8299: URL: https://github.com/apache/incubator-doris/pull/8299 # Proposed changes Implement window_funnel aggregate function. Issue Number: close #xxx ## Problem Summary: It can be used like window_funnel(window)(timestamp, e

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #8248: [fix] (rpc-udf) Fixed the problem that the query could not be interrupted if an error occurred in the rpc server during

2022-03-02 Thread GitBox
yangzhg commented on a change in pull request #8248: URL: https://github.com/apache/incubator-doris/pull/8248#discussion_r817559297 ## File path: be/src/service/function_service.h ## @@ -0,0 +1,125 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more co

[GitHub] [incubator-doris] wangbo opened a new issue #8300: [Bug] GroupingSet return error result with mismatch partition type

2022-03-02 Thread GitBox
wangbo opened a new issue #8300: URL: https://github.com/apache/incubator-doris/issues/8300 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version 0.13

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #8248: [fix] (rpc-udf) Fixed the problem that the query could not be interrupted if an error occurred in the rpc server during

2022-03-02 Thread GitBox
yangzhg commented on a change in pull request #8248: URL: https://github.com/apache/incubator-doris/pull/8248#discussion_r817567354 ## File path: be/src/runtime/fragment_mgr.cpp ## @@ -250,15 +247,18 @@ Status FragmentExecState::cancel_before_execute() { return Status::OK(

[GitHub] [incubator-doris-spark-connector] zhaomin1423 opened a new pull request #10: Fix null value

2022-03-02 Thread GitBox
zhaomin1423 opened a new pull request #10: URL: https://github.com/apache/incubator-doris-spark-connector/pull/10 # Proposed changes Issue Number: close #xxx ## Problem Summary: When the value of source column is NULL, the value of doris column is "null". ## Check

[GitHub] [incubator-doris-spark-connector] zhaomin1423 closed pull request #10: Fix null value

2022-03-02 Thread GitBox
zhaomin1423 closed pull request #10: URL: https://github.com/apache/incubator-doris-spark-connector/pull/10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[GitHub] [incubator-doris] zuochunwei commented on a change in pull request #8292: (improving) refactor column::insert_many_dict_data

2022-03-02 Thread GitBox
zuochunwei commented on a change in pull request #8292: URL: https://github.com/apache/incubator-doris/pull/8292#discussion_r817593579 ## File path: be/src/vec/columns/column_string.h ## @@ -165,10 +167,33 @@ class ColumnString final : public COWHelper { } }; -

[GitHub] [incubator-doris] zuochunwei commented on a change in pull request #8292: (improving) refactor column::insert_many_dict_data

2022-03-02 Thread GitBox
zuochunwei commented on a change in pull request #8292: URL: https://github.com/apache/incubator-doris/pull/8292#discussion_r817593797 ## File path: be/src/vec/columns/column_string.h ## @@ -165,10 +167,33 @@ class ColumnString final : public COWHelper { } }; -

[GitHub] [incubator-doris] EmmyMiao87 commented on issue #7901: [Feature] [Vectorized] Some Join opt in vec exec engine

2022-03-02 Thread GitBox
EmmyMiao87 commented on issue #7901: URL: https://github.com/apache/incubator-doris/issues/7901#issuecomment-1056815743 # Join opt ## Reduce unnecessary memory copy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-doris] zuochunwei commented on a change in pull request #8292: (improving) refactor column::insert_many_dict_data

2022-03-02 Thread GitBox
zuochunwei commented on a change in pull request #8292: URL: https://github.com/apache/incubator-doris/pull/8292#discussion_r817593579 ## File path: be/src/vec/columns/column_string.h ## @@ -165,10 +167,33 @@ class ColumnString final : public COWHelper { } }; -

[GitHub] [incubator-doris] wangbo commented on pull request #8292: (improving) refactor column::insert_many_dict_data

2022-03-02 Thread GitBox
wangbo commented on pull request #8292: URL: https://github.com/apache/incubator-doris/pull/8292#issuecomment-1056832065 I will try to test this pr to confirm the performance improvement, it will take some time -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #8289: [refactor] remove types_test

2022-03-02 Thread GitBox
yangzhg commented on a change in pull request #8289: URL: https://github.com/apache/incubator-doris/pull/8289#discussion_r817610939 ## File path: fe/fe-core/src/main/java/org/apache/doris/catalog/ScalarType.java ## @@ -69,6 +66,12 @@ // Keep consistent with backend ColumnT

[GitHub] [incubator-doris] BiteTheDDDDt commented on a change in pull request #8299: Window funnel

2022-03-02 Thread GitBox
BiteThet commented on a change in pull request #8299: URL: https://github.com/apache/incubator-doris/pull/8299#discussion_r817612721 ## File path: be/src/exprs/aggregate_functions.cpp ## @@ -2265,6 +2265,206 @@ void AggregateFunctions::offset_fn_update(FunctionContext* ctx

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #8289: [refactor] remove types_test

2022-03-02 Thread GitBox
yangzhg commented on a change in pull request #8289: URL: https://github.com/apache/incubator-doris/pull/8289#discussion_r817610939 ## File path: fe/fe-core/src/main/java/org/apache/doris/catalog/ScalarType.java ## @@ -69,6 +66,12 @@ // Keep consistent with backend ColumnT

[GitHub] [incubator-doris] JusticeGong commented on issue #7986: Apache Doris Manager 2022 Roadmap

2022-03-02 Thread GitBox
JusticeGong commented on issue #7986: URL: https://github.com/apache/incubator-doris/issues/7986#issuecomment-1056844715 > Is there any progress on this Doris visualization management tool? Recently we've done a lot progress on Doris Manager. The first version Doris Manager 1.0 is a

[GitHub] [incubator-doris] HappenLee opened a new issue #8301: [Bug] [Vectorized] const column coredump in exchange node

2022-03-02 Thread GitBox
HappenLee opened a new issue #8301: URL: https://github.com/apache/incubator-doris/issues/8301 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version vect

[GitHub] [incubator-doris] EmmyMiao87 edited a comment on issue #7901: [Feature] [Vectorized] Some Join opt in vec exec engine

2022-03-02 Thread GitBox
EmmyMiao87 edited a comment on issue #7901: URL: https://github.com/apache/incubator-doris/issues/7901#issuecomment-1056815743 # Join 性能优化 ## 减少不必要的内存拷贝 Join Node 的输出 schema 与 Join Node 的输入 schema 不同。但当前 Doris 的 Join Node 算子在构造结果行时,直接将左右孩子的 tuple 进行拼接。 而实际上结果行的列可能是输入行中列的子集

[GitHub] [incubator-doris] HappenLee opened a new pull request #8302: [Bug][Vectorized] coredump const compare in exchange node

2022-03-02 Thread GitBox
HappenLee opened a new pull request #8302: URL: https://github.com/apache/incubator-doris/pull/8302 # Proposed changes Issue Number: close #8301 ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original beha

[GitHub] [incubator-doris] HappenLee commented on a change in pull request #8267: [fix](vectorization)Some small fix for SegmentIter Vectorization

2022-03-02 Thread GitBox
HappenLee commented on a change in pull request #8267: URL: https://github.com/apache/incubator-doris/pull/8267#discussion_r817639363 ## File path: be/src/vec/columns/column_complex.h ## @@ -67,6 +67,7 @@ class ColumnComplexType final : public COWHelper> for (size_

[GitHub] [incubator-doris] qidaye opened a new pull request #8303: [fix](ut) query stmt test error

2022-03-02 Thread GitBox
qidaye opened a new pull request #8303: URL: https://github.com/apache/incubator-doris/pull/8303 # Proposed changes introduced by #8268 1. fix `collectExprs` ut error 2. fix constant-folding in `SetOperationStmt` ordery clause and update ut. ## Problem Summary:

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8303: [fix](ut) query stmt test error

2022-03-02 Thread GitBox
github-actions[bot] commented on pull request #8303: URL: https://github.com/apache/incubator-doris/pull/8303#issuecomment-1056875712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8248: [fix] (rpc-udf) Fixed the problem that the query could not be interrupted if an error occurred in the rpc server during

2022-03-02 Thread GitBox
github-actions[bot] commented on pull request #8248: URL: https://github.com/apache/incubator-doris/pull/8248#issuecomment-1056894212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8289: [refactor] remove types_test

2022-03-02 Thread GitBox
github-actions[bot] commented on pull request #8289: URL: https://github.com/apache/incubator-doris/pull/8289#issuecomment-1056898923 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8302: [Bug][Vectorized] coredump const compare in exchange node

2022-03-02 Thread GitBox
github-actions[bot] commented on pull request #8302: URL: https://github.com/apache/incubator-doris/pull/8302#issuecomment-1056910065 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8293: [fix](fe-ut) Fix FE unit test

2022-03-02 Thread GitBox
github-actions[bot] commented on pull request #8293: URL: https://github.com/apache/incubator-doris/pull/8293#issuecomment-1057029652 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] morningman merged pull request #8303: [fix](ut) query stmt test error

2022-03-02 Thread GitBox
morningman merged pull request #8303: URL: https://github.com/apache/incubator-doris/pull/8303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: com

[GitHub] [incubator-doris] yangzhg commented on pull request #8248: [fix] (rpc-udf) Fixed the problem that the query could not be interrupted if an error occurred in the rpc server during the executio

2022-03-02 Thread GitBox
yangzhg commented on pull request #8248: URL: https://github.com/apache/incubator-doris/pull/8248#issuecomment-1057569828 Merger it for working on UDAF -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[incubator-doris] branch master updated (246ac4e -> 114eb19)

2022-03-02 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 246ac4e [fix] fix a bug of encryption function with iv may return wrong result (#8277) add 114eb

[GitHub] [incubator-doris] yangzhg edited a comment on pull request #8248: [fix] (rpc-udf) Fixed the problem that the query could not be interrupted if an error occurred in the rpc server during the e

2022-03-02 Thread GitBox
yangzhg edited a comment on pull request #8248: URL: https://github.com/apache/incubator-doris/pull/8248#issuecomment-1057569828 Merge it for working on UDAF -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [incubator-doris] morningman merged pull request #8293: [fix](fe-ut) Fix FE unit test

2022-03-02 Thread GitBox
morningman merged pull request #8293: URL: https://github.com/apache/incubator-doris/pull/8293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: com

[GitHub] [incubator-doris] yangzhg merged pull request #8248: [fix] (rpc-udf) Fixed the problem that the query could not be interrupted if an error occurred in the rpc server during the execution of r

2022-03-02 Thread GitBox
yangzhg merged pull request #8248: URL: https://github.com/apache/incubator-doris/pull/8248 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commit

[incubator-doris] branch master updated (114eb19 -> 09bfb8b)

2022-03-02 Thread yangzhg
This is an automated email from the ASF dual-hosted git repository. yangzhg pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 114eb19 [fix](ut) query stmt test error (#8303) add 09bfb8b [fix] (rpc-udf) Fixed the problem that

[incubator-doris] branch master updated (09bfb8b -> 18098c5)

2022-03-02 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 09bfb8b [fix] (rpc-udf) Fixed the problem that the query could not be interrupted (#8248) add 180

[GitHub] [incubator-doris] morningman merged pull request #8288: [Refactor] remove pusher.cpp and related mock test code

2022-03-02 Thread GitBox
morningman merged pull request #8288: URL: https://github.com/apache/incubator-doris/pull/8288 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: com

[incubator-doris] branch master updated (18098c5 -> 8be71b6)

2022-03-02 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 18098c5 [fix](fe-ut) Fix FE unit test (#8293) add 8be71b6 [refactor] remove pusher.cpp and relate

[GitHub] [incubator-doris] yangzhg merged pull request #8289: [refactor] remove types_test

2022-03-02 Thread GitBox
yangzhg merged pull request #8289: URL: https://github.com/apache/incubator-doris/pull/8289 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commit

[incubator-doris] branch master updated (8be71b6 -> f622ce0)

2022-03-02 Thread yangzhg
This is an automated email from the ASF dual-hosted git repository. yangzhg pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 8be71b6 [refactor] remove pusher.cpp and related mock test code (#8288) add f622ce0 [refactor] remo

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8123: [improvement] optimize compaction too slow replica process, will set to ok if the replica compaction is done

2022-03-02 Thread GitBox
github-actions[bot] commented on pull request #8123: URL: https://github.com/apache/incubator-doris/pull/8123#issuecomment-1057579823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #8146: [Enhancement] Support Skipping compaction lower replica where select queryable replica for better scan performance

2022-03-02 Thread GitBox
yiguolei commented on a change in pull request #8146: URL: https://github.com/apache/incubator-doris/pull/8146#discussion_r818255966 ## File path: fe/fe-core/src/main/java/org/apache/doris/catalog/Tablet.java ## @@ -227,10 +228,25 @@ public void getQueryableReplicas(List allQu

[GitHub] [incubator-doris] levy5307 commented on a change in pull request #8146: [Enhancement] Support Skipping compaction lower replica where select queryable replica for better scan performance

2022-03-02 Thread GitBox
levy5307 commented on a change in pull request #8146: URL: https://github.com/apache/incubator-doris/pull/8146#discussion_r818262489 ## File path: be/src/olap/tablet_manager.cpp ## @@ -888,19 +880,18 @@ OLAPStatus TabletManager::build_all_report_tablets_info( DorisMetric

[GitHub] [incubator-doris] caiconghui commented on pull request #8256: [Enhancement](routine-load) Support routine load task succeed with empty data consumed

2022-03-02 Thread GitBox
caiconghui commented on pull request #8256: URL: https://github.com/apache/incubator-doris/pull/8256#issuecomment-1057602906 > Does this affect the overall behavior of the job? Because I understand that "cancel" is only internal logic and does not affect the continuation of the routine loa

[GitHub] [incubator-doris] levy5307 commented on a change in pull request #8146: [Enhancement] Support Skipping compaction lower replica where select queryable replica for better scan performance

2022-03-02 Thread GitBox
levy5307 commented on a change in pull request #8146: URL: https://github.com/apache/incubator-doris/pull/8146#discussion_r818263335 ## File path: be/src/olap/tablet_manager.cpp ## @@ -616,19 +615,12 @@ bool TabletManager::get_rowset_id_from_path(const string& path, RowsetId*

[GitHub] [incubator-doris] levy5307 commented on a change in pull request #8146: [Enhancement] Support Skipping compaction lower replica where select queryable replica for better scan performance

2022-03-02 Thread GitBox
levy5307 commented on a change in pull request #8146: URL: https://github.com/apache/incubator-doris/pull/8146#discussion_r818263506 ## File path: be/src/olap/tablet_manager.cpp ## @@ -913,12 +904,22 @@ OLAPStatus TabletManager::build_all_report_tablets_info(

[GitHub] [incubator-doris] caiconghui commented on a change in pull request #8146: [Enhancement] Support Skipping compaction lower replica where select queryable replica for better scan performance

2022-03-02 Thread GitBox
caiconghui commented on a change in pull request #8146: URL: https://github.com/apache/incubator-doris/pull/8146#discussion_r818264486 ## File path: be/src/olap/tablet_manager.cpp ## @@ -616,19 +615,12 @@ bool TabletManager::get_rowset_id_from_path(const string& path, RowsetId

[GitHub] [incubator-doris] levy5307 commented on a change in pull request #8146: [Enhancement] Support Skipping compaction lower replica where select queryable replica for better scan performance

2022-03-02 Thread GitBox
levy5307 commented on a change in pull request #8146: URL: https://github.com/apache/incubator-doris/pull/8146#discussion_r818264836 ## File path: fe/fe-core/src/main/java/org/apache/doris/catalog/Replica.java ## @@ -239,12 +239,19 @@ public void setNeedFurtherRepair(boolean n

[GitHub] [incubator-doris] zbtzbtzbt commented on a change in pull request #8292: (improving) refactor column::insert_many_dict_data

2022-03-02 Thread GitBox
zbtzbtzbt commented on a change in pull request #8292: URL: https://github.com/apache/incubator-doris/pull/8292#discussion_r818267646 ## File path: be/src/vec/columns/column_string.h ## @@ -32,6 +32,8 @@ #include "vec/common/sip_hash.h" #include "vec/core/field.h" +#include

[GitHub] [incubator-doris] zbtzbtzbt commented on a change in pull request #8292: (improving) refactor column::insert_many_dict_data

2022-03-02 Thread GitBox
zbtzbtzbt commented on a change in pull request #8292: URL: https://github.com/apache/incubator-doris/pull/8292#discussion_r818268350 ## File path: be/src/vec/columns/column.h ## @@ -174,7 +174,7 @@ class IColumn : public COW { LOG(FATAL) << "Method insert_many_fix_len_d

[GitHub] [incubator-doris] zbtzbtzbt commented on a change in pull request #8292: (improving) refactor column::insert_many_dict_data

2022-03-02 Thread GitBox
zbtzbtzbt commented on a change in pull request #8292: URL: https://github.com/apache/incubator-doris/pull/8292#discussion_r818268350 ## File path: be/src/vec/columns/column.h ## @@ -174,7 +174,7 @@ class IColumn : public COW { LOG(FATAL) << "Method insert_many_fix_len_d

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8207: [fix] fix hash table insert() may be failed but not handle this error

2022-03-02 Thread GitBox
github-actions[bot] commented on pull request #8207: URL: https://github.com/apache/incubator-doris/pull/8207#issuecomment-1057613470 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] levy5307 commented on a change in pull request #8146: [Enhancement] Support Skipping compaction lower replica where select queryable replica for better scan performance

2022-03-02 Thread GitBox
levy5307 commented on a change in pull request #8146: URL: https://github.com/apache/incubator-doris/pull/8146#discussion_r818273532 ## File path: be/src/olap/tablet_manager.cpp ## @@ -913,12 +904,22 @@ OLAPStatus TabletManager::build_all_report_tablets_info(

[GitHub] [incubator-doris] levy5307 commented on a change in pull request #8146: [Enhancement] Support Skipping compaction lower replica where select queryable replica for better scan performance

2022-03-02 Thread GitBox
levy5307 commented on a change in pull request #8146: URL: https://github.com/apache/incubator-doris/pull/8146#discussion_r818273532 ## File path: be/src/olap/tablet_manager.cpp ## @@ -913,12 +904,22 @@ OLAPStatus TabletManager::build_all_report_tablets_info(

[GitHub] [incubator-doris] levy5307 commented on a change in pull request #8146: [Enhancement] Support Skipping compaction lower replica where select queryable replica for better scan performance

2022-03-02 Thread GitBox
levy5307 commented on a change in pull request #8146: URL: https://github.com/apache/incubator-doris/pull/8146#discussion_r818274107 ## File path: be/src/olap/tablet_manager.h ## @@ -228,12 +226,8 @@ class TabletManager { std::map> _partition_tablet_map; std::vector _

[GitHub] [incubator-doris] caiconghui commented on a change in pull request #8146: [Enhancement] Support Skipping compaction lower replica where select queryable replica for better scan performance

2022-03-02 Thread GitBox
caiconghui commented on a change in pull request #8146: URL: https://github.com/apache/incubator-doris/pull/8146#discussion_r818277002 ## File path: be/src/olap/tablet_manager.h ## @@ -228,12 +226,8 @@ class TabletManager { std::map> _partition_tablet_map; std::vector

[GitHub] [incubator-doris] adonis0147 opened a new issue #8304: [feature-wip][array-type] Support nested array insertion.

2022-03-02 Thread GitBox
adonis0147 opened a new issue #8304: URL: https://github.com/apache/incubator-doris/issues/8304 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Description

[GitHub] [incubator-doris] levy5307 commented on a change in pull request #8146: [Enhancement] Support Skipping compaction lower replica where select queryable replica for better scan performance

2022-03-02 Thread GitBox
levy5307 commented on a change in pull request #8146: URL: https://github.com/apache/incubator-doris/pull/8146#discussion_r818279779 ## File path: fe/fe-core/src/main/java/org/apache/doris/catalog/Tablet.java ## @@ -227,10 +228,25 @@ public void getQueryableReplicas(List allQu

[GitHub] [incubator-doris] adonis0147 opened a new pull request #8305: [feature-wip][array-type] Support nested array insertion.

2022-03-02 Thread GitBox
adonis0147 opened a new pull request #8305: URL: https://github.com/apache/incubator-doris/pull/8305 # Proposed changes Issue Number: close #8304 . ## Problem Summary: Please refer to #8304 . ## Checklist(Required) 1. Does it affect the original behavior: N

[GitHub] [incubator-doris] zhangstar333 opened a new issue #8306: [Vectorized][Feature] support regexp&&sm4&&aes function

2022-03-02 Thread GitBox
zhangstar333 opened a new issue #8306: URL: https://github.com/apache/incubator-doris/issues/8306 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Description

[GitHub] [incubator-doris] zhangstar333 opened a new pull request #8307: [Vectorized][Function] support regexp&&sm4&&aes functions

2022-03-02 Thread GitBox
zhangstar333 opened a new pull request #8307: URL: https://github.com/apache/incubator-doris/pull/8307 # Proposed changes Issue Number: close #8306 ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original

[GitHub] [incubator-doris] zbtzbtzbt commented on a change in pull request #8292: (improving) refactor column::insert_many_dict_data

2022-03-02 Thread GitBox
zbtzbtzbt commented on a change in pull request #8292: URL: https://github.com/apache/incubator-doris/pull/8292#discussion_r818284576 ## File path: be/src/vec/columns/column_string.h ## @@ -32,6 +32,8 @@ #include "vec/common/sip_hash.h" #include "vec/core/field.h" +#include

[GitHub] [incubator-doris] morningman edited a comment on issue #7502: Doris Roadmap 2022

2022-03-02 Thread GitBox
morningman edited a comment on issue #7502: URL: https://github.com/apache/incubator-doris/issues/7502#issuecomment-1001839293 The following is the Roadmap for the Doris community in 2022. The plan includes all aspects of code features, documentation, community building, etc. that are t

[GitHub] [incubator-doris] morningman edited a comment on issue #7502: Doris Roadmap 2022

2022-03-02 Thread GitBox
morningman edited a comment on issue #7502: URL: https://github.com/apache/incubator-doris/issues/7502#issuecomment-1001839293 The following is the Roadmap for the Doris community in 2022. The plan includes all aspects of code features, documentation, community building, etc. that are t

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8259: [Feature] Support Changing the bucketing mode of the table from Hash Distribution to Random Distribution

2022-03-02 Thread GitBox
github-actions[bot] commented on pull request #8259: URL: https://github.com/apache/incubator-doris/pull/8259#issuecomment-1057635535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] liaoxin01 opened a new pull request #8308:

2022-03-02 Thread GitBox
liaoxin01 opened a new pull request #8308: URL: https://github.com/apache/incubator-doris/pull/8308 # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behav

[GitHub] [incubator-doris] BiteTheDDDDt commented on a change in pull request #8299: [feature] Window funnel

2022-03-02 Thread GitBox
BiteThet commented on a change in pull request #8299: URL: https://github.com/apache/incubator-doris/pull/8299#discussion_r818294081 ## File path: be/src/vec/aggregate_functions/aggregate_function_window_funnel.h ## @@ -0,0 +1,210 @@ +// Licensed to the Apache Software Foun

[GitHub] [incubator-doris] yangzhg opened a new pull request #8309: [chore] remove some ut temp files and add some file to .gitignore

2022-03-02 Thread GitBox
yangzhg opened a new pull request #8309: URL: https://github.com/apache/incubator-doris/pull/8309 # Proposed changes I remove some ut temp files and add some file to .gitignore ## Checklist(Required) 1. Does it affect the original behavior: (No) 2. Has unit tests

[GitHub] [incubator-doris] BiteTheDDDDt commented on a change in pull request #8299: [feature] Window funnel

2022-03-02 Thread GitBox
BiteThet commented on a change in pull request #8299: URL: https://github.com/apache/incubator-doris/pull/8299#discussion_r818301213 ## File path: be/src/vec/aggregate_functions/aggregate_function_window_funnel.h ## @@ -0,0 +1,210 @@ +// Licensed to the Apache Software Foun

[GitHub] [incubator-doris] BiteTheDDDDt commented on a change in pull request #8299: [feature] Window funnel

2022-03-02 Thread GitBox
BiteThet commented on a change in pull request #8299: URL: https://github.com/apache/incubator-doris/pull/8299#discussion_r818302071 ## File path: be/src/vec/aggregate_functions/aggregate_function_window_funnel.h ## @@ -0,0 +1,210 @@ +// Licensed to the Apache Software Foun

[GitHub] [incubator-doris] BiteTheDDDDt commented on a change in pull request #8299: [feature] Window funnel

2022-03-02 Thread GitBox
BiteThet commented on a change in pull request #8299: URL: https://github.com/apache/incubator-doris/pull/8299#discussion_r818294081 ## File path: be/src/vec/aggregate_functions/aggregate_function_window_funnel.h ## @@ -0,0 +1,210 @@ +// Licensed to the Apache Software Foun

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8309: [chore] remove some ut temp files and add some file to .gitignore

2022-03-02 Thread GitBox
github-actions[bot] commented on pull request #8309: URL: https://github.com/apache/incubator-doris/pull/8309#issuecomment-1057655806 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #8259: [Feature] Support Changing the bucketing mode of the table from Hash Distribution to Random Distribution

2022-03-02 Thread GitBox
yiguolei commented on a change in pull request #8259: URL: https://github.com/apache/incubator-doris/pull/8259#discussion_r818235814 ## File path: fe/fe-core/src/main/java/org/apache/doris/analysis/ModifyTablePropertiesClause.java ## @@ -55,7 +55,10 @@ public void analyze(Anal

[GitHub] [incubator-doris] caiconghui commented on a change in pull request #8259: [Feature] Support Changing the bucketing mode of the table from Hash Distribution to Random Distribution

2022-03-02 Thread GitBox
caiconghui commented on a change in pull request #8259: URL: https://github.com/apache/incubator-doris/pull/8259#discussion_r818307658 ## File path: fe/fe-core/src/main/java/org/apache/doris/analysis/ModifyTablePropertiesClause.java ## @@ -55,7 +55,10 @@ public void analyze(An

[GitHub] [incubator-doris] yiguolei commented on pull request #8259: [Feature] Support Changing the bucketing mode of the table from Hash Distribution to Random Distribution

2022-03-02 Thread GitBox
yiguolei commented on pull request #8259: URL: https://github.com/apache/incubator-doris/pull/8259#issuecomment-1057660965 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8308: [refactor] Translate the code comments of gensrc

2022-03-02 Thread GitBox
github-actions[bot] commented on pull request #8308: URL: https://github.com/apache/incubator-doris/pull/8308#issuecomment-1057661465 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #8307: [Vectorized][Function] support regexp&&sm4&&aes functions

2022-03-02 Thread GitBox
yangzhg commented on a change in pull request #8307: URL: https://github.com/apache/incubator-doris/pull/8307#discussion_r818309614 ## File path: be/src/vec/functions/function_bitmap.cpp ## @@ -474,4 +474,4 @@ void register_function_bitmap(SimpleFunctionFactory& factory) {

[GitHub] [incubator-doris] HappenLee opened a new issue #8310: [Bug] Core dump because of using mistake api of fmt

2022-03-02 Thread GitBox
HappenLee opened a new issue #8310: URL: https://github.com/apache/incubator-doris/issues/8310 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version mast

[GitHub] [incubator-doris] HappenLee opened a new pull request #8311: [Bug] Use fmt::to_string replace memory buffer::data()

2022-03-02 Thread GitBox
HappenLee opened a new pull request #8311: URL: https://github.com/apache/incubator-doris/pull/8311 # Proposed changes Issue Number: close #8310 ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original beha

[GitHub] [incubator-doris] yangzhg commented on pull request #8297: [build](fe) Support building an individual maven module.

2022-03-02 Thread GitBox
yangzhg commented on pull request #8297: URL: https://github.com/apache/incubator-doris/pull/8297#issuecomment-1057665124 I think this is not a good way, the purpose of using reversion is to unify version management, has added maven flatten plugin, in the release will play flat version, as

[GitHub] [incubator-doris] yangzhg edited a comment on pull request #8297: [build](fe) Support building an individual maven module.

2022-03-02 Thread GitBox
yangzhg edited a comment on pull request #8297: URL: https://github.com/apache/incubator-doris/pull/8297#issuecomment-1057665124 I think this is not a good way, the purpose of using reversion is to unify version management, has added maven flatten plugin, in the release will play flat vers

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8259: [Feature] Support Changing the bucketing mode of the table from Hash Distribution to Random Distribution

2022-03-02 Thread GitBox
github-actions[bot] commented on pull request #8259: URL: https://github.com/apache/incubator-doris/pull/8259#issuecomment-1057665512 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [incubator-doris] yangzhg edited a comment on pull request #8297: [build](fe) Support building an individual maven module.

2022-03-02 Thread GitBox
yangzhg edited a comment on pull request #8297: URL: https://github.com/apache/incubator-doris/pull/8297#issuecomment-1057665124 I think this is not a good way, the purpose of using reversion is to unify version management, has added maven flatten plugin, in the release will play flat vers

[GitHub] [incubator-doris] HappenLee commented on a change in pull request #8307: [Vectorized][Function] support regexp&&sm4&&aes functions

2022-03-02 Thread GitBox
HappenLee commented on a change in pull request #8307: URL: https://github.com/apache/incubator-doris/pull/8307#discussion_r818315672 ## File path: be/src/vec/functions/function_encryption.cpp ## @@ -0,0 +1,245 @@ +// Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [incubator-doris] yangzhg opened a new issue #8312: [Feature] Support UDAF in RPC framework

2022-03-02 Thread GitBox
yangzhg opened a new issue #8312: URL: https://github.com/apache/incubator-doris/issues/8312 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Description Fu

[GitHub] [incubator-doris] morningman edited a comment on issue #7502: Doris Roadmap 2022

2022-03-02 Thread GitBox
morningman edited a comment on issue #7502: URL: https://github.com/apache/incubator-doris/issues/7502#issuecomment-1001839293 The following is the Roadmap for the Doris community in 2022. The plan includes all aspects of code features, documentation, community building, etc. that are t

[GitHub] [incubator-doris] yangzhg merged pull request #8309: [chore] remove some ut temp files and add some file to .gitignore

2022-03-02 Thread GitBox
yangzhg merged pull request #8309: URL: https://github.com/apache/incubator-doris/pull/8309 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commit

[incubator-doris] branch master updated: [chore] remove some ut temp files and add some file to .gitignore (#8309)

2022-03-02 Thread yangzhg
This is an automated email from the ASF dual-hosted git repository. yangzhg pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new f5ab055 [chore] remove some ut temp f

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #8209: [fix](replica) handle replica version missing info to avoid -214 error

2022-03-02 Thread GitBox
yangzhg commented on a change in pull request #8209: URL: https://github.com/apache/incubator-doris/pull/8209#discussion_r818329859 ## File path: be/src/olap/tablet.cpp ## @@ -577,9 +578,9 @@ OLAPStatus Tablet::capture_consistent_versions(const Version& spec_version, retu

[GitHub] [incubator-doris] zhangyifan27 opened a new pull request #8313: [docs] Fix invalid links in docker-dev document

2022-03-02 Thread GitBox
zhangyifan27 opened a new pull request #8313: URL: https://github.com/apache/incubator-doris/pull/8313 # Proposed changes Issue Number: close #xxx ## Problem Summary: Fix invalid links in docker-dev document. ## Checklist(Required) 1. Does it affect the ori

  1   2   >