[GitHub] [incubator-doris] morningman commented on issue #3419: [Website] Some problem about the new website.

2022-02-06 Thread GitBox
morningman commented on issue #3419: URL: https://github.com/apache/incubator-doris/issues/3419#issuecomment-1030772806 Sorry I have no idea about this error... Have you try it again? And be sure that you have subscribed the dev@doris mail list, or you may not be able to receive

[GitHub] [incubator-doris] dongweizhao commented on pull request #7915: Add substr function description document

2022-02-06 Thread GitBox
dongweizhao commented on pull request #7915: URL: https://github.com/apache/incubator-doris/pull/7915#issuecomment-1030775885 > `substr` have overload `substr(str,pos)`, could you please add this to document? Yes, I will add it after I verify it @BiteThet -- This is an au

[GitHub] [incubator-doris] morningman commented on a change in pull request #6650: [Bug] Fix bug that The MetaObject lock design of fe would cause some problems with consistent meta when catalog do re

2022-02-06 Thread GitBox
morningman commented on a change in pull request #6650: URL: https://github.com/apache/incubator-doris/pull/6650#discussion_r800152957 ## File path: fe/fe-core/src/main/java/org/apache/doris/alter/Alter.java ## @@ -490,6 +496,7 @@ private void replaceTableInternal(Database db,

[GitHub] [incubator-doris] morningman commented on a change in pull request #7936: [improvement](query) Improve fe high concurrent query performance

2022-02-06 Thread GitBox
morningman commented on a change in pull request #7936: URL: https://github.com/apache/incubator-doris/pull/7936#discussion_r800157381 ## File path: fe/fe-core/src/main/java/org/apache/doris/qe/ConnectScheduler.java ## @@ -96,50 +94,50 @@ public boolean submit(ConnectContext co

[GitHub] [incubator-doris] caiconghui commented on a change in pull request #7936: [improvement](query) Improve fe high concurrent query performance

2022-02-06 Thread GitBox
caiconghui commented on a change in pull request #7936: URL: https://github.com/apache/incubator-doris/pull/7936#discussion_r800158119 ## File path: fe/fe-core/src/main/java/org/apache/doris/qe/ConnectScheduler.java ## @@ -96,50 +94,50 @@ public boolean submit(ConnectContext co

[GitHub] [incubator-doris] morningman commented on a change in pull request #7940: [Feature] Add table function framework and add numbers table function

2022-02-06 Thread GitBox
morningman commented on a change in pull request #7940: URL: https://github.com/apache/incubator-doris/pull/7940#discussion_r800158250 ## File path: fe/fe-core/src/main/java/org/apache/doris/tablefunction/TableFunction.java ## @@ -0,0 +1,50 @@ +// Licensed to the Apache Softwa

[GitHub] [incubator-doris] caiconghui commented on a change in pull request #7936: [improvement](query) Improve fe high concurrent query performance

2022-02-06 Thread GitBox
caiconghui commented on a change in pull request #7936: URL: https://github.com/apache/incubator-doris/pull/7936#discussion_r800158642 ## File path: fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java ## @@ -471,8 +471,9 @@ public void exec() throws Exception {

[GitHub] [incubator-doris] caiconghui commented on a change in pull request #6650: [Bug] Fix bug that The MetaObject lock design of fe would cause some problems with consistent meta when catalog do re

2022-02-06 Thread GitBox
caiconghui commented on a change in pull request #6650: URL: https://github.com/apache/incubator-doris/pull/6650#discussion_r800160238 ## File path: fe/fe-core/src/main/java/org/apache/doris/catalog/Table.java ## @@ -54,6 +57,8 @@ // assume that the time a lock is held by

[GitHub] [incubator-doris] caiconghui commented on a change in pull request #6650: [Bug] Fix bug that The MetaObject lock design of fe would cause some problems with consistent meta when catalog do re

2022-02-06 Thread GitBox
caiconghui commented on a change in pull request #6650: URL: https://github.com/apache/incubator-doris/pull/6650#discussion_r800160997 ## File path: fe/fe-core/src/main/java/org/apache/doris/alter/Alter.java ## @@ -415,27 +417,31 @@ private void processReplaceTable(Database db,

[GitHub] [incubator-doris] caiconghui commented on a change in pull request #6650: [Bug] Fix bug that The MetaObject lock design of fe would cause some problems with consistent meta when catalog do re

2022-02-06 Thread GitBox
caiconghui commented on a change in pull request #6650: URL: https://github.com/apache/incubator-doris/pull/6650#discussion_r800161021 ## File path: fe/fe-core/src/main/java/org/apache/doris/backup/RestoreJob.java ## @@ -1576,7 +1592,9 @@ public void cancelInternal(boolean isRe

[GitHub] [incubator-doris] dataroaring opened a new pull request #7949: teach build.sh --clean work correctly

2022-02-06 Thread GitBox
dataroaring opened a new pull request #7949: URL: https://github.com/apache/incubator-doris/pull/7949 CMAKE_BUILD_DIR is set while building be. "build.sh --clean" just cleans and exits, however clean_be does not works without CMAKE_BUILD_DIR set. This patch set CMAKE_BUILD_DIR in clean

[GitHub] [incubator-doris] morningman commented on a change in pull request #6650: [Bug] Fix bug that The MetaObject lock design of fe would cause some problems with consistent meta when catalog do re

2022-02-06 Thread GitBox
morningman commented on a change in pull request #6650: URL: https://github.com/apache/incubator-doris/pull/6650#discussion_r800196812 ## File path: fe/fe-core/src/main/java/org/apache/doris/catalog/Table.java ## @@ -54,6 +57,8 @@ // assume that the time a lock is held by

[GitHub] [incubator-doris] morningman commented on issue #3419: [Website] Some problem about the new website.

2022-02-06 Thread GitBox
morningman commented on issue #3419: URL: https://github.com/apache/incubator-doris/issues/3419#issuecomment-1030861581 > Or do you use any other IM such as Slack or Telegram? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-doris] rinkydevi commented on issue #3419: [Website] Some problem about the new website.

2022-02-06 Thread GitBox
rinkydevi commented on issue #3419: URL: https://github.com/apache/incubator-doris/issues/3419#issuecomment-1030878672 @morningman yes sir! i have telegram:- https://t.me/rinky_s01 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #7939: [improvement][refactor](vec) Refactor serde of vec block and using brpc attachment

2022-02-06 Thread GitBox
yangzhg commented on a change in pull request #7939: URL: https://github.com/apache/incubator-doris/pull/7939#discussion_r800265696 ## File path: gensrc/proto/types.proto ## @@ -63,3 +63,36 @@ message PUniqueId { required int64 lo = 2; }; +message PDataType { +enum

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #7519: [feature] Support udf through RPC

2022-02-06 Thread GitBox
yangzhg commented on a change in pull request #7519: URL: https://github.com/apache/incubator-doris/pull/7519#discussion_r800267157 ## File path: gensrc/proto/types.proto ## @@ -63,3 +67,150 @@ message PUniqueId { required int64 lo = 2; }; +message PGenericType { Revie

[GitHub] [incubator-doris] caoliang-web opened a new pull request #7950: Modify the content of code comments

2022-02-06 Thread GitBox
caoliang-web opened a new pull request #7950: URL: https://github.com/apache/incubator-doris/pull/7950 # Proposed changes 1.Modify the content of the code comments in the file_helper.cpp file 2.Modify the content of the code comments in the file_helper.h file ## Problem Summ

[GitHub] [incubator-doris] morningman commented on a change in pull request #7936: [improvement](query) Improve fe high concurrent query performance

2022-02-06 Thread GitBox
morningman commented on a change in pull request #7936: URL: https://github.com/apache/incubator-doris/pull/7936#discussion_r800281317 ## File path: fe/fe-core/src/main/java/org/apache/doris/qe/ConnectScheduler.java ## @@ -96,50 +94,50 @@ public boolean submit(ConnectContext co

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7936: [improvement](query) Improve fe high concurrent query performance

2022-02-06 Thread GitBox
github-actions[bot] commented on pull request #7936: URL: https://github.com/apache/incubator-doris/pull/7936#issuecomment-1031017053 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #6650: [Bug] Fix bug that The MetaObject lock design of fe would cause some problems with consistent meta when catalog do repla

2022-02-06 Thread GitBox
github-actions[bot] commented on pull request #6650: URL: https://github.com/apache/incubator-doris/pull/6650#issuecomment-1031038197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] dataroaring opened a new pull request #7951: add performance test framework for ci/cd

2022-02-06 Thread GitBox
dataroaring opened a new pull request #7951: URL: https://github.com/apache/incubator-doris/pull/7951 This patch contributes a performance test framework to doris for ci/cd by learning from ClickHouse's. Performance results is computed by using clickhouse, maybe we should use doris ins

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7950: Modify the content of code comments

2022-02-06 Thread GitBox
github-actions[bot] commented on pull request #7950: URL: https://github.com/apache/incubator-doris/pull/7950#issuecomment-1031091591 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] dataroaring commented on pull request #7951: add performance test framework for ci/cd

2022-02-06 Thread GitBox
dataroaring commented on pull request #7951: URL: https://github.com/apache/incubator-doris/pull/7951#issuecomment-1031096853 Here is an example of result. https://doris-build.oss-cn-beijing.aliyuncs.com/doris-test-reports/1/192ec94f1541b1d0c053f3ba3f885ceca9a045a6/performance/output.7z -

[GitHub] [incubator-doris] morningman commented on pull request #7951: add performance test framework for ci/cd

2022-02-06 Thread GitBox
morningman commented on pull request #7951: URL: https://github.com/apache/incubator-doris/pull/7951#issuecomment-1031108305 Hi @dataroaring , thanks for you contribution. This is a huge PR, I think it is better to discuss about it, or at least add document to explain how it works and ho

[GitHub] [incubator-doris] qzsee opened a new pull request #7952: [Bug] fix using clause npe

2022-02-06 Thread GitBox
qzsee opened a new pull request #7952: URL: https://github.com/apache/incubator-doris/pull/7952 # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behavior:

[GitHub] [incubator-doris] qzsee opened a new issue #7953: [Bug]

2022-02-06 Thread GitBox
qzsee opened a new issue #7953: URL: https://github.com/apache/incubator-doris/issues/7953 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version master

[GitHub] [incubator-doris] smallhibiscus closed pull request #7847: [docs](config) Added http interface return example to obtain the specified table structure information.

2022-02-06 Thread GitBox
smallhibiscus closed pull request #7847: URL: https://github.com/apache/incubator-doris/pull/7847 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-doris] smallhibiscus opened a new pull request #7954: [docs] Added http interface return example to obtain the specified table structure information

2022-02-06 Thread GitBox
smallhibiscus opened a new pull request #7954: URL: https://github.com/apache/incubator-doris/pull/7954 # Proposed changes 1. Added http interface return example in table-schema-action.md. 2. Correct typos in the document in error.md. 3. Modify the content of the code comments i

[GitHub] [incubator-doris] smallhibiscus closed pull request #7954: [docs] Added http interface return example to obtain the specified table structure information

2022-02-06 Thread GitBox
smallhibiscus closed pull request #7954: URL: https://github.com/apache/incubator-doris/pull/7954 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #7940: [Feature] Add table function framework and add numbers table function

2022-02-06 Thread GitBox
yiguolei commented on a change in pull request #7940: URL: https://github.com/apache/incubator-doris/pull/7940#discussion_r800350506 ## File path: fe/fe-core/src/main/java/org/apache/doris/tablefunction/TableFunction.java ## @@ -0,0 +1,50 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] yiguolei commented on pull request #7949: teach build.sh --clean work correctly

2022-02-06 Thread GitBox
yiguolei commented on pull request #7949: URL: https://github.com/apache/incubator-doris/pull/7949#issuecomment-1031136714 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [incubator-doris] smallhibiscus opened a new pull request #7955: [docs]Added http interface return example to obtain the specified table str…

2022-02-06 Thread GitBox
smallhibiscus opened a new pull request #7955: URL: https://github.com/apache/incubator-doris/pull/7955 …ucture information # Proposed changes 1. Added http interface return example in table-schema-action.md. 2. Correct typos in the document in error.md. 3. Modify the con

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7519: [feature] Support udf through RPC

2022-02-06 Thread GitBox
github-actions[bot] commented on pull request #7519: URL: https://github.com/apache/incubator-doris/pull/7519#issuecomment-1031153214 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] morningman commented on pull request #7519: [feature] Support udf through RPC

2022-02-06 Thread GitBox
morningman commented on pull request #7519: URL: https://github.com/apache/incubator-doris/pull/7519#issuecomment-1031154316 Document need to be added later -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-doris] HappenLee opened a new issue #7956: [Feature] [Load][vec] Support vtablet sink to enable insert into in vec query engine

2022-02-06 Thread GitBox
HappenLee opened a new issue #7956: URL: https://github.com/apache/incubator-doris/issues/7956 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Description

[GitHub] [incubator-doris] HappenLee opened a new pull request #7957: [Load][vec] Support vtablet sink to enable insert into in vec query engine

2022-02-06 Thread GitBox
HappenLee opened a new pull request #7957: URL: https://github.com/apache/incubator-doris/pull/7957 # Proposed changes Issue Number: close #7956 ## Problem Summary: Support vtablet sink to enable `insert into query` in vec query engine ## Checklist(Required)

[GitHub] [incubator-doris] HappenLee opened a new issue #7958: [Bug] not align mem address cause core in distinct agg and pre stream agg

2022-02-06 Thread GitBox
HappenLee opened a new issue #7958: URL: https://github.com/apache/incubator-doris/issues/7958 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version vect