[GitHub] [incubator-doris] morningman commented on a change in pull request #7940: [Feature] Add table function framework and add numbers table function

2022-02-04 Thread GitBox
morningman commented on a change in pull request #7940: URL: https://github.com/apache/incubator-doris/pull/7940#discussion_r799246945 ## File path: be/src/vec/exec/tablefunction/vnumbers_tbf_scannode.h ## @@ -0,0 +1,78 @@ +// Licensed to the Apache Software Foundation (ASF) un

[GitHub] [incubator-doris] morningman closed pull request #7569: [Improvement] support build thirdparty and BE using clang

2022-02-04 Thread GitBox
morningman closed pull request #7569: URL: https://github.com/apache/incubator-doris/pull/7569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: com

[GitHub] [incubator-doris] morningman commented on a change in pull request #7939: [improvement][refactor](vec) Refactor serde of vec block and using brpc attachment

2022-02-04 Thread GitBox
morningman commented on a change in pull request #7939: URL: https://github.com/apache/incubator-doris/pull/7939#discussion_r799306497 ## File path: be/src/vec/data_types/data_type_nullable.cpp ## @@ -53,33 +53,52 @@ std::string DataTypeNullable::to_string(const IColumn& colum

[GitHub] [incubator-doris] morningman commented on a change in pull request #7939: [improvement][refactor](vec) Refactor serde of vec block and using brpc attachment

2022-02-04 Thread GitBox
morningman commented on a change in pull request #7939: URL: https://github.com/apache/incubator-doris/pull/7939#discussion_r799307185 ## File path: be/src/vec/data_types/data_type_number_base.cpp ## @@ -65,30 +65,40 @@ std::string DataTypeNumberBase::to_string(const IColumn&

[GitHub] [incubator-doris] Keysluomo opened a new pull request #7941: [style] Translate Chinese to English in PaloBrokerService.thrift

2022-02-04 Thread GitBox
Keysluomo opened a new pull request #7941: URL: https://github.com/apache/incubator-doris/pull/7941 Translate Chinese to English in PaloBrokerService.thrift -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #7940: [Feature] Add table function framework and add numbers table function

2022-02-04 Thread GitBox
yiguolei commented on a change in pull request #7940: URL: https://github.com/apache/incubator-doris/pull/7940#discussion_r799363885 ## File path: be/src/vec/exec/tablefunction/vnumbers_tbf_scannode.h ## @@ -0,0 +1,78 @@ +// Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #7940: [Feature] Add table function framework and add numbers table function

2022-02-04 Thread GitBox
yiguolei commented on a change in pull request #7940: URL: https://github.com/apache/incubator-doris/pull/7940#discussion_r799369231 ## File path: fe/fe-core/src/main/java/org/apache/doris/tablefunction/TableFunction.java ## @@ -0,0 +1,50 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #7940: [Feature] Add table function framework and add numbers table function

2022-02-04 Thread GitBox
yiguolei commented on a change in pull request #7940: URL: https://github.com/apache/incubator-doris/pull/7940#discussion_r799370200 ## File path: fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java ## @@ -446,7 +446,7 @@ public void execute(TUniqueId queryId) throws

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7941: [style] Translate Chinese to English in PaloBrokerService.thrift

2022-02-04 Thread GitBox
github-actions[bot] commented on pull request #7941: URL: https://github.com/apache/incubator-doris/pull/7941#issuecomment-1030008332 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] Keysluomo commented on pull request #7941: [style] Translate Chinese to English in PaloBrokerService.thrift

2022-02-04 Thread GitBox
Keysluomo commented on pull request #7941: URL: https://github.com/apache/incubator-doris/pull/7941#issuecomment-1030050446 > LGTM thanks,I will work harder to make greater contributions😁 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-doris] Keysluomo edited a comment on pull request #7941: [style] Translate Chinese to English in PaloBrokerService.thrift

2022-02-04 Thread GitBox
Keysluomo edited a comment on pull request #7941: URL: https://github.com/apache/incubator-doris/pull/7941#issuecomment-1030050446 thanks,I will work harder to make greater contributions😁 -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [incubator-doris] HappenLee opened a new issue #7942: [Vectorized][Bug] Agg table cause block data use after free

2022-02-04 Thread GitBox
HappenLee opened a new issue #7942: URL: https://github.com/apache/incubator-doris/issues/7942 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version Vect

[GitHub] [incubator-doris] zbtzbtzbt opened a new issue #7943: [Enhancement] Speed up data insert in skiplist

2022-02-04 Thread GitBox
zbtzbtzbt opened a new issue #7943: URL: https://github.com/apache/incubator-doris/issues/7943 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Description

[GitHub] [incubator-doris] HappenLee opened a new pull request #7944: [fix] (vec) block mem use after free in agg table read

2022-02-04 Thread GitBox
HappenLee opened a new pull request #7944: URL: https://github.com/apache/incubator-doris/pull/7944 # Proposed changes Issue Number: close #7942 ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original beh

[GitHub] [incubator-doris] morningman commented on a change in pull request #7473: [Feature][Transaction] Support two phase batch commit for stream load

2022-02-04 Thread GitBox
morningman commented on a change in pull request #7473: URL: https://github.com/apache/incubator-doris/pull/7473#discussion_r799920692 ## File path: docs/zh-CN/administrator-guide/load-data/stream-load-manual.md ## @@ -179,6 +179,22 @@ Stream load 由于使用的是 HTTP 协议,所以所有导入任务有关的

[GitHub] [incubator-doris] morningman commented on issue #7942: [Vectorized][Bug] Agg table cause block data use after free

2022-02-04 Thread GitBox
morningman commented on issue #7942: URL: https://github.com/apache/incubator-doris/issues/7942#issuecomment-1030571449 [error.txt](https://github.com/apache/incubator-doris/files/8007605/error.txt) -- This is an automated message from the Apache Git Service. To respond to the messa