[GitHub] [incubator-doris] zuochunwei commented on pull request #7906: (storage) add debug-timer for the purpose of testing

2022-01-27 Thread GitBox
zuochunwei commented on pull request #7906: URL: https://github.com/apache/incubator-doris/pull/7906#issuecomment-1022973342 > We'd better not add `Timer` in hot code path, especially in Page.next_batch, because the Timer itself may cost lots of time. i got, just for test this ver

[GitHub] [incubator-doris] adonis0147 closed pull request #7874: [Improvement] (fe-unit-test) Pass conf map to create Doris cluster.

2022-01-27 Thread GitBox
adonis0147 closed pull request #7874: URL: https://github.com/apache/incubator-doris/pull/7874 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: com

[GitHub] [incubator-doris] adonis0147 closed issue #7873: [Improvement] (fe-unit-test) Pass conf map to create Doris cluster.

2022-01-27 Thread GitBox
adonis0147 closed issue #7873: URL: https://github.com/apache/incubator-doris/issues/7873 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-

[GitHub] [incubator-doris] adonis0147 commented on issue #7873: [Improvement] (fe-unit-test) Pass conf map to create Doris cluster.

2022-01-27 Thread GitBox
adonis0147 commented on issue #7873: URL: https://github.com/apache/incubator-doris/issues/7873#issuecomment-1022976001 There are some alternatives which can achieve the same effect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-doris] zuochunwei commented on pull request #7906: (storage) add debug-timer for the purpose of testing

2022-01-27 Thread GitBox
zuochunwei commented on pull request #7906: URL: https://github.com/apache/incubator-doris/pull/7906#issuecomment-1022979072 i just want to provide this method for testing any code cost, so i marked as '//demo DEBUG timer ' to indicate that this codes will be deleted later -- This is

[GitHub] [incubator-doris] bingzxy opened a new pull request #7907: fix typo

2022-01-27 Thread GitBox
bingzxy opened a new pull request #7907: URL: https://github.com/apache/incubator-doris/pull/7907 - fix typo # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect th

[GitHub] [incubator-doris] adonis0147 opened a new issue #7908: [Enhancement] [Compilation] CMake may use wrong ninja to build the code.

2022-01-27 Thread GitBox
adonis0147 opened a new issue #7908: URL: https://github.com/apache/incubator-doris/issues/7908 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Description

[GitHub] [incubator-doris] adonis0147 opened a new pull request #7909: Set the full path of make program to CMake.

2022-01-27 Thread GitBox
adonis0147 opened a new pull request #7909: URL: https://github.com/apache/incubator-doris/pull/7909 # Proposed changes Issue Number: close #7908 ## Problem Summary: ## Checklist(Required) 1. Does it affect the original behavior: No. 2. Has unit tests

[GitHub] [incubator-doris] spaces-X opened a new issue #7910: [Bug] query analyze failed after change the default bucket num

2022-01-27 Thread GitBox
spaces-X opened a new issue #7910: URL: https://github.com/apache/incubator-doris/issues/7910 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version 0.15

[GitHub] [incubator-doris] xinyiZzz opened a new pull request #7911: [Help] gcc11 compiles `thread_local` variable, BE start: version `GLIBC_2.18' not found

2022-01-27 Thread GitBox
xinyiZzz opened a new pull request #7911: URL: https://github.com/apache/incubator-doris/pull/7911 ## Problem Summary: Error details in be.out: /home/disk3/zxy/baidu/bdg/doris/core/output/be/lib/palo_be: /lib64/libc.so.6: version `GLIBC_2.18' not found (required by /home/d

[GitHub] [incubator-doris] EmmyMiao87 commented on issue #7901: [Feature] [Vectorized] Some Join opt in vec exec engine

2022-01-27 Thread GitBox
EmmyMiao87 commented on issue #7901: URL: https://github.com/apache/incubator-doris/issues/7901#issuecomment-1023087786 I will resolve this issue together ~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [incubator-doris] htyoung opened a new pull request #7912: fix(ui):fix home page spin bug #7170

2022-01-27 Thread GitBox
htyoung opened a new pull request #7912: URL: https://github.com/apache/incubator-doris/pull/7912 1. The Spin(loading circle) will disappear after hardware info loaded # Proposed changes Issue Number: close #7170 ## Problem Summary: when I visit apache doris ui ho

[GitHub] [incubator-doris] caiconghui opened a new issue #7913: [Enhancement] Support that user can use show data skew statement instead of admin

2022-01-27 Thread GitBox
caiconghui opened a new issue #7913: URL: https://github.com/apache/incubator-doris/issues/7913 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Description

[GitHub] [incubator-doris] caiconghui opened a new pull request #7914: [improvement](show) Support that user can use show data skew statement instead of admin

2022-01-27 Thread GitBox
caiconghui opened a new pull request #7914: URL: https://github.com/apache/incubator-doris/pull/7914 # Proposed changes Issue Number: close #7913 ## Problem Summary: This PR mainly do two things: 1. Support that user can use show data skew statement instead of admin

[GitHub] [incubator-doris] caiconghui commented on pull request #7914: [improvement](show) Support that user can use show data skew statement instead of admin

2022-01-27 Thread GitBox
caiconghui commented on pull request #7914: URL: https://github.com/apache/incubator-doris/pull/7914#issuecomment-1023164720 ut failed cc @EmmyMiao87 show data skew cc @morningman -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [incubator-doris] dongweizhao opened a new pull request #7915: Add substr function description document

2022-01-27 Thread GitBox
dongweizhao opened a new pull request #7915: URL: https://github.com/apache/incubator-doris/pull/7915 # Proposed changes Issue Number: close #xxx ## Problem Summary: Add substr function description ## Checklist(Required) 1. Does it affect the origin

[GitHub] [incubator-doris] zenoyang opened a new issue #7916: [Enhancement](Vectorized) Optinmize dict page decoder init

2022-01-27 Thread GitBox
zenoyang opened a new issue #7916: URL: https://github.com/apache/incubator-doris/issues/7916 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Description T

[GitHub] [incubator-doris] zenoyang opened a new pull request #7917: [Enhancement](Vectorized) Optinmize dict page decoder init

2022-01-27 Thread GitBox
zenoyang opened a new pull request #7917: URL: https://github.com/apache/incubator-doris/pull/7917 # Proposed changes Issue Number: close #7916 Traverse the dict page once, and then call each time `dict_page_decoder->set_dict_decoder` reuses the result of `_dict_start_offset

[GitHub] [incubator-doris] caiconghui edited a comment on pull request #7914: [improvement](show) Support that user can use show data skew statement instead of admin

2022-01-27 Thread GitBox
caiconghui edited a comment on pull request #7914: URL: https://github.com/apache/incubator-doris/pull/7914#issuecomment-1023164720 ut failed cc @EmmyMiao87 show data skew cc @morningman cc @qidaye -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7907: [docs] fix typo

2022-01-27 Thread GitBox
github-actions[bot] commented on pull request #7907: URL: https://github.com/apache/incubator-doris/pull/7907#issuecomment-1023257876 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] adonis0147 opened a new issue #7918: [Bug] Fail to rerun build-thirdparty.sh.

2022-01-27 Thread GitBox
adonis0147 opened a new issue #7918: URL: https://github.com/apache/incubator-doris/issues/7918 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version mas

[GitHub] [incubator-doris] adonis0147 opened a new pull request #7919: [chore] Fix the return code of function download_func

2022-01-27 Thread GitBox
adonis0147 opened a new pull request #7919: URL: https://github.com/apache/incubator-doris/pull/7919 # Proposed changes Issue Number: close #7918 ## Problem Summary: Please refer to #7918 ## Checklist(Required) 1. Does it affect the original behavior: No.

[GitHub] [incubator-doris] morningman commented on pull request #7911: [Help] gcc11 compiles `thread_local` variable, BE start: version `GLIBC_2.18' not found

2022-01-27 Thread GitBox
morningman commented on pull request #7911: URL: https://github.com/apache/incubator-doris/pull/7911#issuecomment-1023367102 PTAL @amosbird , if you have time, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #7914: [improvement](show) Support that user can use show data skew statement instead of admin

2022-01-27 Thread GitBox
EmmyMiao87 commented on a change in pull request #7914: URL: https://github.com/apache/incubator-doris/pull/7914#discussion_r793757061 ## File path: fe/fe-core/src/main/java/org/apache/doris/catalog/MetadataViewer.java ## @@ -288,7 +287,7 @@ private static String graph(long num

[GitHub] [incubator-doris] EmmyMiao87 commented on pull request #7914: [improvement](show) Support that user can use show data skew statement instead of admin

2022-01-27 Thread GitBox
EmmyMiao87 commented on pull request #7914: URL: https://github.com/apache/incubator-doris/pull/7914#issuecomment-1023367991 The document could not be built correctly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [incubator-doris] amosbird commented on pull request #7911: [Help] gcc11 compiles `thread_local` variable, BE start: version `GLIBC_2.18' not found

2022-01-27 Thread GitBox
amosbird commented on pull request #7911: URL: https://github.com/apache/incubator-doris/pull/7911#issuecomment-1023369852 Is it for some future PRs with thread local? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [incubator-doris] morningman commented on pull request #7911: [Help] gcc11 compiles `thread_local` variable, BE start: version `GLIBC_2.18' not found

2022-01-27 Thread GitBox
morningman commented on pull request #7911: URL: https://github.com/apache/incubator-doris/pull/7911#issuecomment-1023372778 > Is it for some future PRs with thread local? Yes, @xinyiZzz is developing memory tracking and management based on thread local. -- This is an automated me

[GitHub] [incubator-doris] morningman edited a comment on pull request #7911: [Help] gcc11 compiles `thread_local` variable, BE start: version `GLIBC_2.18' not found

2022-01-27 Thread GitBox
morningman edited a comment on pull request #7911: URL: https://github.com/apache/incubator-doris/pull/7911#issuecomment-1023372778 > Is it for some future PRs with thread local? Yes, @xinyiZzz is developing memory tracking and management based on thread local. And this is just a

[GitHub] [incubator-doris] amosbird commented on pull request #7911: [Help] gcc11 compiles `thread_local` variable, BE start: version `GLIBC_2.18' not found

2022-01-27 Thread GitBox
amosbird commented on pull request #7911: URL: https://github.com/apache/incubator-doris/pull/7911#issuecomment-1023375876 > > Is it for some future PRs with thread local? > > Yes, @xinyiZzz is developing memory tracking and management based on thread local. And this is just a PR for

[GitHub] [incubator-doris] caiconghui commented on a change in pull request #7914: [improvement](show) Support that user can use show data skew statement instead of admin

2022-01-27 Thread GitBox
caiconghui commented on a change in pull request #7914: URL: https://github.com/apache/incubator-doris/pull/7914#discussion_r793765347 ## File path: fe/fe-core/src/main/java/org/apache/doris/catalog/MetadataViewer.java ## @@ -288,7 +287,7 @@ private static String graph(long num

[GitHub] [incubator-doris] morningman opened a new issue #7920: [Bug]

2022-01-27 Thread GitBox
morningman opened a new issue #7920: URL: https://github.com/apache/incubator-doris/issues/7920 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version tru

[GitHub] [incubator-doris] morningman opened a new pull request #7921: [fix](brpc-attachment) Fix bug that may cause BE crash when enable `transfer_data_by_brpc_attachment`

2022-01-27 Thread GitBox
morningman opened a new pull request #7921: URL: https://github.com/apache/incubator-doris/pull/7921 # Proposed changes Issue Number: close #7920 ## Problem Summary: In `data_stream_sender`, we will send a serialized PRowBatch data to multiple Channels. And if `tran

[GitHub] [incubator-doris] amosbird commented on pull request #7911: [Help] gcc11 compiles `thread_local` variable, BE start: version `GLIBC_2.18' not found

2022-01-27 Thread GitBox
amosbird commented on pull request #7911: URL: https://github.com/apache/incubator-doris/pull/7911#issuecomment-1023508528 I did some investigation. It's not easy to mask the symbol, which is from libc++abi https://libcxxabi.llvm.org/spec.html . It's also not safe to use the polyfill imple

[GitHub] [incubator-doris] amosbird edited a comment on pull request #7911: [Help] gcc11 compiles `thread_local` variable, BE start: version `GLIBC_2.18' not found

2022-01-27 Thread GitBox
amosbird edited a comment on pull request #7911: URL: https://github.com/apache/incubator-doris/pull/7911#issuecomment-1023508528 I did some investigation. It's not easy to mask this symbol, which is meant to be added to the libc++abi. It's also not safe to use the polyfill implementation

[GitHub] [incubator-doris] dataroaring opened a new pull request #7922: rename DDL Statements to SQL Statements in sidebars of docs in english

2022-01-27 Thread GitBox
dataroaring opened a new pull request #7922: URL: https://github.com/apache/incubator-doris/pull/7922 # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original beh

[GitHub] [incubator-doris] luzhijing commented on pull request #7915: Add substr function description document

2022-01-27 Thread GitBox
luzhijing commented on pull request #7915: URL: https://github.com/apache/incubator-doris/pull/7915#issuecomment-1023819319 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [incubator-doris] qidaye commented on a change in pull request #7915: Add substr function description document

2022-01-27 Thread GitBox
qidaye commented on a change in pull request #7915: URL: https://github.com/apache/incubator-doris/pull/7915#discussion_r794157060 ## File path: docs/en/sql-reference/sql-functions/string-functions/substr.md ## @@ -0,0 +1,55 @@ +--- +{ +"title": "substr", +"language": "

[GitHub] [incubator-doris] qidaye commented on pull request #7922: rename DDL Statements to SQL Statements in sidebars of docs in english

2022-01-27 Thread GitBox
qidaye commented on pull request #7922: URL: https://github.com/apache/incubator-doris/pull/7922#issuecomment-1023827810 LGTM. Please format your commit info according to the document [commit-format](https://doris.apache.org/zh-CN/community/commit-format-specification.html) -- This is

[GitHub] [incubator-doris] qidaye commented on pull request #7915: Add substr function description document

2022-01-27 Thread GitBox
qidaye commented on pull request #7915: URL: https://github.com/apache/incubator-doris/pull/7915#issuecomment-1023831431 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [incubator-doris] qidaye removed a comment on pull request #7915: Add substr function description document

2022-01-27 Thread GitBox
qidaye removed a comment on pull request #7915: URL: https://github.com/apache/incubator-doris/pull/7915#issuecomment-1023831431 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] dongweizhao commented on pull request #7915: Add substr function description document

2022-01-27 Thread GitBox
dongweizhao commented on pull request #7915: URL: https://github.com/apache/incubator-doris/pull/7915#issuecomment-1023833929 > Attention to the format. Please format your commit info according to the document [commit-format](https://doris.apache.org/zh-CN/community/commit-format-specifica

[GitHub] [incubator-doris] zuochunwei opened a new pull request #7923: [storage]add Generic debug timer for debugging or profiling

2022-01-27 Thread GitBox
zuochunwei opened a new pull request #7923: URL: https://github.com/apache/incubator-doris/pull/7923 # Proposed changes add a group of debug-timer for the purpose of profiling or testing you can use these timers for custom meaning purpose unlike the specific named timer i will

[GitHub] [incubator-doris] xinyiZzz commented on a change in pull request #7198: [Memory] Refactor MemTracker and new memory statistics framework based on TCMalloc Hook

2022-01-27 Thread GitBox
xinyiZzz commented on a change in pull request #7198: URL: https://github.com/apache/incubator-doris/pull/7198#discussion_r794177942 ## File path: be/src/common/config.h ## @@ -594,12 +594,28 @@ CONF_Int32(aws_log_level, "3"); // the buffer size when read data from remote stor

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7865: [fix](lateral-view) fix bugs of lateral view with CTE or where clause

2022-01-27 Thread GitBox
github-actions[bot] commented on pull request #7865: URL: https://github.com/apache/incubator-doris/pull/7865#issuecomment-1023853768 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7917: [typo](storage) Optinmize dict page decoder init

2022-01-27 Thread GitBox
github-actions[bot] commented on pull request #7917: URL: https://github.com/apache/incubator-doris/pull/7917#issuecomment-1023855007 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] zuochunwei opened a new pull request #7924: (documation) Update debug-tool.md for scan debug-timer group

2022-01-27 Thread GitBox
zuochunwei opened a new pull request #7924: URL: https://github.com/apache/incubator-doris/pull/7924 scan debug timer OlapScanNode中有一组调试定时器(_general_debug_timer)可供debugging和profiling之用,_general_debug_timer是一个定时器组,通过_general_debug_timer+下标非常方面的使用具体的某一个定时器。 _general_debug_time

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #7914: [improvement](show) Support that user can use show data skew statement instead of admin

2022-01-27 Thread GitBox
EmmyMiao87 commented on a change in pull request #7914: URL: https://github.com/apache/incubator-doris/pull/7914#discussion_r794181689 ## File path: docs/.vuepress/sidebar/en.js ## @@ -616,6 +615,7 @@ module.exports = [ "SHOW CREATE FUNCTION", "SHO

[GitHub] [incubator-doris] xinyiZzz commented on pull request #7911: [Help] gcc11 compiles `thread_local` variable, BE start: version `GLIBC_2.18' not found

2022-01-27 Thread GitBox
xinyiZzz commented on pull request #7911: URL: https://github.com/apache/incubator-doris/pull/7911#issuecomment-1023861894 > I did some investigation. It's not easy to mask this symbol, which is meant to be added to the libc++abi. It's also not safe to use the polyfill implementation from

[GitHub] [incubator-doris] caiconghui commented on a change in pull request #7914: [improvement](show) Support that user can use show data skew statement instead of admin

2022-01-27 Thread GitBox
caiconghui commented on a change in pull request #7914: URL: https://github.com/apache/incubator-doris/pull/7914#discussion_r794189411 ## File path: docs/.vuepress/sidebar/en.js ## @@ -616,6 +615,7 @@ module.exports = [ "SHOW CREATE FUNCTION", "SHO

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7914: [improvement](show) Support that user can use show data skew statement instead of admin

2022-01-27 Thread GitBox
github-actions[bot] commented on pull request #7914: URL: https://github.com/apache/incubator-doris/pull/7914#issuecomment-1023873830 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] hf200012 commented on pull request #7848: [Compatible]http v2 and v1 interface compatible

2022-01-27 Thread GitBox
hf200012 commented on pull request #7848: URL: https://github.com/apache/incubator-doris/pull/7848#issuecomment-1023880219 > Please config your IDEA to enable auto code format ok -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [incubator-doris] amosbird commented on pull request #7911: [Help] gcc11 compiles `thread_local` variable, BE start: version `GLIBC_2.18' not found

2022-01-27 Thread GitBox
amosbird commented on pull request #7911: URL: https://github.com/apache/incubator-doris/pull/7911#issuecomment-1023889347 > Regarding the second point, do you mean changing the thread_local variable to a member variable of the class? For example, abstract a parent class to save this varia

[GitHub] [incubator-doris] xinyiZzz commented on pull request #7911: [Help] gcc11 compiles `thread_local` variable, BE start: version `GLIBC_2.18' not found

2022-01-27 Thread GitBox
xinyiZzz commented on pull request #7911: URL: https://github.com/apache/incubator-doris/pull/7911#issuecomment-1023917862 > > Regarding the second point, do you mean changing the thread_local variable to a member variable of the class? For example, abstract a parent class to save this var

[GitHub] [incubator-doris] xinyiZzz edited a comment on pull request #7911: [Help] gcc11 compiles `thread_local` variable, BE start: version `GLIBC_2.18' not found

2022-01-27 Thread GitBox
xinyiZzz edited a comment on pull request #7911: URL: https://github.com/apache/incubator-doris/pull/7911#issuecomment-1023917862 > > Regarding the second point, do you mean changing the thread_local variable to a member variable of the class? For example, abstract a parent class to save t

[GitHub] [incubator-doris] hf200012 opened a new pull request #7925: [optimization]Remove the old http module and completely replace it with http v2

2022-01-27 Thread GitBox
hf200012 opened a new pull request #7925: URL: https://github.com/apache/incubator-doris/pull/7925 The http v2 version can completely replace the old http module. In order to avoid the problem of inconsistency between the two codes, the old http module will be removed. # Proposed ch

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7924: (documation) Update debug-tool.md for scan debug-timer group

2022-01-27 Thread GitBox
github-actions[bot] commented on pull request #7924: URL: https://github.com/apache/incubator-doris/pull/7924#issuecomment-1023971494 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific