[GitHub] [incubator-doris] xiedeyantu opened a new pull request #7470: add Dockerfile with clang11

2021-12-23 Thread GitBox
xiedeyantu opened a new pull request #7470: URL: https://github.com/apache/incubator-doris/pull/7470 ## Proposed changes add Dockerfile with clang11 ## Types of changes What types of changes does your code introduce to Doris? _Put an `x` in the boxes that apply_

[GitHub] [incubator-doris] wangshuo128 opened a new pull request #7471: [test]Fix NPE when start FE in unit test.

2021-12-23 Thread GitBox
wangshuo128 opened a new pull request #7471: URL: https://github.com/apache/incubator-doris/pull/7471 ## Proposed changes Before this PR, NPE would be thrown if start FE in a unit test. ## Types of changes What types of changes does your code introduce to Doris? _Put an `

[GitHub] [incubator-doris] weizuo93 opened a new pull request #7473: [Feature][Transaction] Support two phase batch commit for stream load

2021-12-23 Thread GitBox
weizuo93 opened a new pull request #7473: URL: https://github.com/apache/incubator-doris/pull/7473 ## Proposed changes The two phase batch commit means: During Stream load, after data is written, the message will be returned to the client, the data is invisible at this point and t

[GitHub] [incubator-doris] tianhui5 opened a new pull request #7474: [Feature] Limit cluster resource usage in user granularity #7129

2021-12-23 Thread GitBox
tianhui5 opened a new pull request #7474: URL: https://github.com/apache/incubator-doris/pull/7474 ## Proposed changes Fix #7129 ## Types of changes - [ ] Bugfix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionalit

[GitHub] [incubator-doris] xinyiZzz commented on pull request #7474: [Feature] Limit cluster resource usage in user granularity #7129

2021-12-23 Thread GitBox
xinyiZzz commented on pull request #7474: URL: https://github.com/apache/incubator-doris/pull/7474#issuecomment-1000325263 good idea, If FE can get the memory consumption of each query, we can limit the memory used by users, which is what I plan to do in the future. The actual Adm

[GitHub] [incubator-doris] xinyiZzz commented on issue #7129: [Feature] Limit cluster resource usage in user granularity

2021-12-23 Thread GitBox
xinyiZzz commented on issue #7129: URL: https://github.com/apache/incubator-doris/issues/7129#issuecomment-1000326390 > What if the request exceed the limit? return error or slow down? And is there any other system we can refer to? Impala’s AdmissionController does a similar thing,

[GitHub] [incubator-doris] xinyiZzz edited a comment on pull request #7474: [Feature] Limit cluster resource usage in user granularity #7129

2021-12-23 Thread GitBox
xinyiZzz edited a comment on pull request #7474: URL: https://github.com/apache/incubator-doris/pull/7474#issuecomment-1000325263 good idea, If FE can get the memory consumption of each query, we can limit the memory used by users, which is what I plan to do in the future. Impala’

[GitHub] [incubator-doris] xinyiZzz edited a comment on pull request #7474: [Feature] Limit cluster resource usage in user granularity #7129

2021-12-23 Thread GitBox
xinyiZzz edited a comment on pull request #7474: URL: https://github.com/apache/incubator-doris/pull/7474#issuecomment-1000325263 Good idea, If FE can get the memory consumption of each query, we can limit the memory used by users, which is what I plan to do in the future. Impala’

[GitHub] [incubator-doris] xinyiZzz edited a comment on pull request #7474: [Feature] Limit cluster resource usage in user granularity #7129

2021-12-23 Thread GitBox
xinyiZzz edited a comment on pull request #7474: URL: https://github.com/apache/incubator-doris/pull/7474#issuecomment-1000325263 Good idea, If FE can get the memory consumption of each query, we can limit the memory used by users, which is what I plan to do in the future. Impala’

[GitHub] [incubator-doris] xinyiZzz edited a comment on pull request #7474: [Feature] Limit cluster resource usage in user granularity #7129

2021-12-23 Thread GitBox
xinyiZzz edited a comment on pull request #7474: URL: https://github.com/apache/incubator-doris/pull/7474#issuecomment-1000325263 Good idea, If FE can get the memory consumption of each Query and Load, we can limit the memory used by users, which is what I plan to do in the future.

[GitHub] [incubator-doris] morningman merged pull request #7468: [fix](ut) fix testPartitionRebalancer ut

2021-12-23 Thread GitBox
morningman merged pull request #7468: URL: https://github.com/apache/incubator-doris/pull/7468 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: com

[incubator-doris] branch master updated: [fix](ut) fix testPartitionRebalancer ut (#7468)

2021-12-23 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 3128c7c [fix](ut) fix testPartitio

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7471: [fix](ut) Fix NPE when start FE in unit test.

2021-12-23 Thread GitBox
github-actions[bot] commented on pull request #7471: URL: https://github.com/apache/incubator-doris/pull/7471#issuecomment-1000378307 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7469: fix logic error for Tablet::capture_rs_readers

2021-12-23 Thread GitBox
github-actions[bot] commented on pull request #7469: URL: https://github.com/apache/incubator-doris/pull/7469#issuecomment-1000380159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7447: Add document of docker dev

2021-12-23 Thread GitBox
github-actions[bot] commented on pull request #7447: URL: https://github.com/apache/incubator-doris/pull/7447#issuecomment-1000380873 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7045: [Feature] make BinaryPredicate do not cast date to datetime/varchar

2021-12-23 Thread GitBox
github-actions[bot] commented on pull request #7045: URL: https://github.com/apache/incubator-doris/pull/7045#issuecomment-1000383207 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7430: [Bug] DCHECK fail at BitmapValue getSizeInBytes

2021-12-23 Thread GitBox
github-actions[bot] commented on pull request #7430: URL: https://github.com/apache/incubator-doris/pull/7430#issuecomment-1000384215 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7437: [Bug] fix aggregate function min() at type varchar

2021-12-23 Thread GitBox
github-actions[bot] commented on pull request #7437: URL: https://github.com/apache/incubator-doris/pull/7437#issuecomment-1000387080 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] morningman commented on pull request #7459: add iot-function to doris

2021-12-23 Thread GitBox
morningman commented on pull request #7459: URL: https://github.com/apache/incubator-doris/pull/7459#issuecomment-1000387649 > udaf_iot_first Sorry, I want to know the behavior of this udaf. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [incubator-doris] wangqiuhao0912 commented on pull request #7459: add iot-function to doris

2021-12-23 Thread GitBox
wangqiuhao0912 commented on pull request #7459: URL: https://github.com/apache/incubator-doris/pull/7459#issuecomment-1000392464 @morningman In fact, the meaning of this function is very simple, that is, to find the code1 corresponding to the smallest timestamp (ts) in this group, w

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7421: [BUG] fix round function for inaccuracy

2021-12-23 Thread GitBox
github-actions[bot] commented on pull request #7421: URL: https://github.com/apache/incubator-doris/pull/7421#issuecomment-1000401173 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7454: memory usage optimization for load job

2021-12-23 Thread GitBox
github-actions[bot] commented on pull request #7454: URL: https://github.com/apache/incubator-doris/pull/7454#issuecomment-1000401747 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] morningman commented on pull request #7473: [Feature][Transaction] Support two phase batch commit for stream load

2021-12-23 Thread GitBox
morningman commented on pull request #7473: URL: https://github.com/apache/incubator-doris/pull/7473#issuecomment-1000406768 Thanks for your contribution. Please rebase the master to pass the test first. -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [incubator-doris] morningman commented on pull request #7474: [Feature] Limit cluster resource usage in user granularity #7129

2021-12-23 Thread GitBox
morningman commented on pull request #7474: URL: https://github.com/apache/incubator-doris/pull/7474#issuecomment-1000408597 Hi @tianhui5 , thanks for your contribution. But better to add document to explain the usage or best practice. Otherwise, it is hard to review. -- This is an

[GitHub] [incubator-doris] xiedeyantu commented on pull request #7470: add Dockerfile with clang11

2021-12-23 Thread GitBox
xiedeyantu commented on pull request #7470: URL: https://github.com/apache/incubator-doris/pull/7470#issuecomment-1000602907 > Can it be merged with the origin Dockerfile? So that user can switch gcc or clang in same docker image? OK, I have merged it origin Dockerfile. -- This is

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7467: Readme

2021-12-23 Thread GitBox
github-actions[bot] commented on pull request #7467: URL: https://github.com/apache/incubator-doris/pull/7467#issuecomment-1000605093 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] morningman commented on pull request #7467: Readme

2021-12-23 Thread GitBox
morningman commented on pull request #7467: URL: https://github.com/apache/incubator-doris/pull/7467#issuecomment-1000606888 this pr need modify, do not merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [incubator-doris] yangzhg opened a new pull request #7477: [refactor] Standardize the pom files, prepare for deployment to maven

2021-12-23 Thread GitBox
yangzhg opened a new pull request #7477: URL: https://github.com/apache/incubator-doris/pull/7477 ## Proposed changes Standardize the pom files, prepare for deployment to maven ## Types of changes What types of changes does your code introduce to Doris? _Put an `x` in

[GitHub] [incubator-doris] steadyBoy opened a new issue #7478: [Bug] having 子句不支持 now(), current_date() 等常量函数

2021-12-23 Thread GitBox
steadyBoy opened a new issue #7478: URL: https://github.com/apache/incubator-doris/issues/7478 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version 0.15

[GitHub] [incubator-doris] spaces-X opened a new issue #7479: [Bug]

2021-12-23 Thread GitBox
spaces-X opened a new issue #7479: URL: https://github.com/apache/incubator-doris/issues/7479 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version 0.13

[GitHub] [incubator-doris] spaces-X opened a new pull request #7480: [Bug][SparkLoad] fix Roaring64Map big-endian read/write in de/seriali…

2021-12-23 Thread GitBox
spaces-X opened a new pull request #7480: URL: https://github.com/apache/incubator-doris/pull/7480 See #7479 This bug is triggered when the bitmap exceeds 32 bits. ## Proposed changes Close related #issue (replace it with issue number if it exists). De

[GitHub] [incubator-doris] spaces-X commented on a change in pull request #7180: [Bug] fix insert load should have the same behavior as stream load

2021-12-23 Thread GitBox
spaces-X commented on a change in pull request #7180: URL: https://github.com/apache/incubator-doris/pull/7180#discussion_r774874379 ## File path: fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java ## @@ -324,6 +326,9 @@ @VariableMgr.VarAttr(name = LOAD_MEM_

[GitHub] [incubator-doris] yiguolei commented on pull request #7470: add Dockerfile with clang11

2021-12-23 Thread GitBox
yiguolei commented on pull request #7470: URL: https://github.com/apache/incubator-doris/pull/7470#issuecomment-1000673236 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [incubator-doris] tinkerrrr opened a new pull request #7481: [Fix][UT] Fix UT `SelectStmtTest.testDeduplicateOrs`

2021-12-23 Thread GitBox
tinke opened a new pull request #7481: URL: https://github.com/apache/incubator-doris/pull/7481 ## Proposed changes Fix UT failure in `SelectStmtTest.testDeduplicateOrs` ## Types of changes What types of changes does your code introduce to Doris? _Put an `x` in th

[GitHub] [incubator-doris] JNSimba commented on a change in pull request #7457: [Feature][flink-connector] support flink delete option

2021-12-23 Thread GitBox
JNSimba commented on a change in pull request #7457: URL: https://github.com/apache/incubator-doris/pull/7457#discussion_r774899291 ## File path: extension/flink-doris-connector/src/main/java/org/apache/doris/flink/table/DorisDynamicOutputFormat.java ## @@ -113,24 +133,26 @@ p

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #7477: [refactor] Standardize the pom files, prepare for deployment to maven

2021-12-23 Thread GitBox
EmmyMiao87 commented on a change in pull request #7477: URL: https://github.com/apache/incubator-doris/pull/7477#discussion_r774901167 ## File path: fe/fe-common/pom.xml ## @@ -94,6 +94,11 @@ under the License. org.roaringbitmap RoaringBitmap

[GitHub] [incubator-doris] aihai commented on pull request #7457: [Feature][flink-connector] support flink delete option

2021-12-23 Thread GitBox
aihai commented on pull request #7457: URL: https://github.com/apache/incubator-doris/pull/7457#issuecomment-1000690559 I am worry about whether the key word `__DORIS_DELETE_SIGN__` is compatible in the later version. -- This is an automated message from the Apache Git Service. To respon