[GitHub] [incubator-doris] chovy-3012 commented on issue #7201: Spark Doris Connector : does not allow insertion

2021-11-24 Thread GitBox
chovy-3012 commented on issue #7201: URL: https://github.com/apache/incubator-doris/issues/7201#issuecomment-977622355 > Doris Version -- 0.14.13.1 Spark connector-- doris-spark-1.0.0-SNAPSHOT Version 0.15 of `spark-connector` support batch and stream write data to `Doris` , refere

[GitHub] [incubator-doris] morningman commented on a change in pull request #7183: [BUG] Fix `curdate()+0` to behave like mysql

2021-11-24 Thread GitBox
morningman commented on a change in pull request #7183: URL: https://github.com/apache/incubator-doris/pull/7183#discussion_r755799838 ## File path: fe/fe-core/src/main/java/org/apache/doris/analysis/DateLiteral.java ## @@ -361,8 +361,18 @@ public int compareLiteral(LiteralExpr

[GitHub] [incubator-doris] morningman commented on a change in pull request #7210: [feat](flink-connector) add BATCH DELETE support

2021-11-24 Thread GitBox
morningman commented on a change in pull request #7210: URL: https://github.com/apache/incubator-doris/pull/7210#discussion_r755802527 ## File path: extension/flink-doris-connector/src/main/java/org/apache/doris/flink/cfg/DorisExecutionOptions.java ## @@ -105,6 +111,25 @@ publ

[GitHub] [incubator-doris] hf200012 commented on pull request #7210: [feat](flink-connector) add BATCH DELETE support

2021-11-24 Thread GitBox
hf200012 commented on pull request #7210: URL: https://github.com/apache/incubator-doris/pull/7210#issuecomment-977650940 This is only for the table of the unique key model, you need to turn on Batch Delete for the table ``` ALTER TABLE db.tbl ENABLE FEATURE "BATCH_DELETE"; ```

[GitHub] [incubator-doris] aihai commented on pull request #7210: [feat](flink-connector) add BATCH DELETE support

2021-11-24 Thread GitBox
aihai commented on pull request #7210: URL: https://github.com/apache/incubator-doris/pull/7210#issuecomment-977669027 Thank you for your reply. @morningman @hf200012 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-doris] zuochunwei commented on a change in pull request #7131: Refactor olap scannode

2021-11-24 Thread GitBox
zuochunwei commented on a change in pull request #7131: URL: https://github.com/apache/incubator-doris/pull/7131#discussion_r755842952 ## File path: be/src/runtime/fragment_mgr.h ## @@ -58,7 +58,7 @@ class FragmentMgr : public RestMonitorIface { using FinishCallback = std:

[GitHub] [incubator-doris] morningman commented on a change in pull request #7155: [Config] Support disable query and load for backend to make Doris more robust and set default value to 1 for max_quer

2021-11-24 Thread GitBox
morningman commented on a change in pull request #7155: URL: https://github.com/apache/incubator-doris/pull/7155#discussion_r755805485 ## File path: fe/fe-core/src/main/java/org/apache/doris/analysis/ModifyBackendClause.java ## @@ -17,6 +17,7 @@ package org.apache.doris.ana

[GitHub] [incubator-doris] 924060929 opened a new issue #7212: [Feature] TPC-H Q17、Q18优化调研:semi-join改inner-join,物化公共子查询

2021-11-24 Thread GitBox
924060929 opened a new issue #7212: URL: https://github.com/apache/incubator-doris/issues/7212 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Description

[GitHub] [incubator-doris] EmmyMiao87 commented on issue #7212: [Observation] TPC-H Q17、Q18优化调研:semi-join改inner-join,物化公共子查询

2021-11-24 Thread GitBox
EmmyMiao87 commented on issue #7212: URL: https://github.com/apache/incubator-doris/issues/7212#issuecomment-977737394 可以看看orca 在这个 query 上的优化是咋做的嘛?他如果可以的话,主要是在优化器的哪个节点进行的调整呢? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-doris] dh-cloud opened a new pull request #7213: fix partition rebalance bug

2021-11-24 Thread GitBox
dh-cloud opened a new pull request #7213: URL: https://github.com/apache/incubator-doris/pull/7213 the number of replica on specified medium we get from getReplicaNumByBeIdAndStorageMedium() is defined by table properties,but in fact there may not has SSD/HDD disk on this backend. So i

[GitHub] [incubator-doris] dh-cloud commented on pull request #7213: fix partition rebalance bug

2021-11-24 Thread GitBox
dh-cloud commented on pull request #7213: URL: https://github.com/apache/incubator-doris/pull/7213#issuecomment-92253 we set be data path: storage_root_path = xx/storage,medium:ssd fe config: tablet_rebalancer_type = Partition create table, not set storage_medium, default is HD

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #7198: [Memory] Use TCMalloc Hook to count the real Process and Query MemTracker

2021-11-24 Thread GitBox
EmmyMiao87 commented on a change in pull request #7198: URL: https://github.com/apache/incubator-doris/pull/7198#discussion_r755969683 ## File path: be/src/runtime/thread_status.h ## @@ -0,0 +1,78 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more con

[GitHub] [incubator-doris] morningman commented on pull request #7210: [feat](flink-connector) add BATCH DELETE support

2021-11-24 Thread GitBox
morningman commented on pull request #7210: URL: https://github.com/apache/incubator-doris/pull/7210#issuecomment-977929092 > This is only for the table of the unique key model, you need to turn on Batch Delete for the table > > ``` > ALTER TABLE db.tbl ENABLE FEATURE "BATCH_DELET

[GitHub] [incubator-doris] littleeleventhwolf commented on a change in pull request #7183: [BUG] Fix `curdate()+0` to behave like mysql

2021-11-24 Thread GitBox
littleeleventhwolf commented on a change in pull request #7183: URL: https://github.com/apache/incubator-doris/pull/7183#discussion_r756215416 ## File path: fe/fe-core/src/main/java/org/apache/doris/analysis/DateLiteral.java ## @@ -361,8 +361,18 @@ public int compareLiteral(Lit

[GitHub] [incubator-doris] wuyunfeng commented on issue #5389: FE 和 BE 节点正常,使用 Doris on es ,不能正确链接至 ES 地址

2021-11-24 Thread GitBox
wuyunfeng commented on issue #5389: URL: https://github.com/apache/incubator-doris/issues/5389#issuecomment-978783591 @ddsr-ops datanode1/10.50.253.1:9200/test1/_doc/_search 确认下这个吧 地址不对 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] killxdcj opened a new issue #7214: [Feature] Improve DeltaWriter's performance

2021-11-24 Thread GitBox
killxdcj opened a new issue #7214: URL: https://github.com/apache/incubator-doris/issues/7214 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Description #

[GitHub] [incubator-doris] wangshuo128 opened a new pull request #7215: [docs] Refine documents for commit tags.

2021-11-24 Thread GitBox
wangshuo128 opened a new pull request #7215: URL: https://github.com/apache/incubator-doris/pull/7215 ## Proposed changes Refine some documents about tags in the commit message. Please refer to the discussion in https://lists.apache.org/thread/cq96jwomfrkybshlot3ylxdmrojyks32 for more d

[GitHub] [incubator-doris] aihai commented on pull request #7210: [feat](flink-connector) add BATCH DELETE support

2021-11-24 Thread GitBox
aihai commented on pull request #7210: URL: https://github.com/apache/incubator-doris/pull/7210#issuecomment-978794493 NewDorisTest (Incubator Doris) failed, but I can't visit the Details. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [incubator-doris] killxdcj opened a new pull request #7216: [Feature]. Improve DeltaWriter's performance.

2021-11-24 Thread GitBox
killxdcj opened a new pull request #7216: URL: https://github.com/apache/incubator-doris/pull/7216 ## Proposed changes Improve DeltaWriter's performance, detail in #7214 - Support batch write for DeltaWriter. - Use mutex instead of SpinLock. ## Types of changes

[GitHub] [incubator-doris] morningman commented on a change in pull request #7216: [Feature]. Improve DeltaWriter's performance.

2021-11-24 Thread GitBox
morningman commented on a change in pull request #7216: URL: https://github.com/apache/incubator-doris/pull/7216#discussion_r756552049 ## File path: be/src/olap/delta_writer.cpp ## @@ -179,6 +180,26 @@ OLAPStatus DeltaWriter::write(Tuple* tuple) { return OLAP_SUCCESS; }

[GitHub] [incubator-doris] killxdcj commented on a change in pull request #7216: [Feature]. Improve DeltaWriter's performance.

2021-11-24 Thread GitBox
killxdcj commented on a change in pull request #7216: URL: https://github.com/apache/incubator-doris/pull/7216#discussion_r756593707 ## File path: be/src/olap/delta_writer.cpp ## @@ -179,6 +180,26 @@ OLAPStatus DeltaWriter::write(Tuple* tuple) { return OLAP_SUCCESS; } +

[GitHub] [incubator-doris] xinyiZzz commented on a change in pull request #7164: [BRPC] Support transfer RowBatch in ProtoBuf Request to Controller Attachment

2021-11-24 Thread GitBox
xinyiZzz commented on a change in pull request #7164: URL: https://github.com/apache/incubator-doris/pull/7164#discussion_r756603945 ## File path: gensrc/proto/data.proto ## @@ -33,6 +33,7 @@ message PRowBatch { repeated int32 tuple_offsets = 3; required bytes tuple_d