[GitHub] [incubator-doris] morningman opened a new pull request #7173: [doc] add FAQ document

2021-11-22 Thread GitBox
morningman opened a new pull request #7173: URL: https://github.com/apache/incubator-doris/pull/7173 ## Proposed changes From Apache Doris wechat count, authorized. ## Types of changes What types of changes does your code introduce to Doris? _Put an `x` in the boxes t

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7025: Add tablets number limit to affend wrong usage

2021-11-22 Thread GitBox
github-actions[bot] commented on pull request #7025: URL: https://github.com/apache/incubator-doris/pull/7025#issuecomment-975297628 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [incubator-doris] Gabriel39 commented on a change in pull request #7131: Refactor olap scannode

2021-11-22 Thread GitBox
Gabriel39 commented on a change in pull request #7131: URL: https://github.com/apache/incubator-doris/pull/7131#discussion_r754122278 ## File path: be/src/exec/olap_scan_node.h ## @@ -81,8 +80,8 @@ class OlapScanNode : public ScanNode { }; typedef std::priority_queu

[GitHub] [incubator-doris] morningman opened a new pull request #7174: [doc] Add build-dev image 1.4.2 to compilation document

2021-11-22 Thread GitBox
morningman opened a new pull request #7174: URL: https://github.com/apache/incubator-doris/pull/7174 ## Proposed changes Add build-dev image 1.4.2 to compilation document ## Types of changes What types of changes does your code introduce to Doris? _Put an `x` in the b

[GitHub] [incubator-doris] morningman commented on a change in pull request #7098: Support remote storage, step1: use a struct instead of string for parameter path, add basic remote method

2021-11-22 Thread GitBox
morningman commented on a change in pull request #7098: URL: https://github.com/apache/incubator-doris/pull/7098#discussion_r754038577 ## File path: be/src/env/env_remote.cpp ## @@ -0,0 +1,333 @@ +// Copyright (c) 2011-present, Facebook, Inc. All rights reserved. Review comm

[GitHub] [incubator-doris] luzhijing closed pull request #7156: [docs]Created commit-format-specification.md

2021-11-22 Thread GitBox
luzhijing closed pull request #7156: URL: https://github.com/apache/incubator-doris/pull/7156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: comm

[GitHub] [incubator-doris] morningman commented on a change in pull request #7167: [optimize]Add Doris restart script, optimize doris start and stop commands

2021-11-22 Thread GitBox
morningman commented on a change in pull request #7167: URL: https://github.com/apache/incubator-doris/pull/7167#discussion_r754179070 ## File path: bin/doris_be.sh ## @@ -0,0 +1,61 @@ +#!/bin/bash Review comment: License header. ## File path: bin/doris_be.sh #

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7054: [Feature] Refactor predicate function creator

2021-11-22 Thread GitBox
github-actions[bot] commented on pull request #7054: URL: https://github.com/apache/incubator-doris/pull/7054#issuecomment-975433026 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7109: [Doc]Modify the wrong comment of the ScanTime

2021-11-22 Thread GitBox
github-actions[bot] commented on pull request #7109: URL: https://github.com/apache/incubator-doris/pull/7109#issuecomment-975433439 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [incubator-doris] spaces-X opened a new issue #7179: [Bug] insert load should have the same behavior with stream load

2021-11-22 Thread GitBox
spaces-X opened a new issue #7179: URL: https://github.com/apache/incubator-doris/issues/7179 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version versi

[GitHub] [incubator-doris] spaces-X opened a new pull request #7180: [Bug] fix insert load should have the same behavior as stream load

2021-11-22 Thread GitBox
spaces-X opened a new pull request #7180: URL: https://github.com/apache/incubator-doris/pull/7180 ## Proposed changes see #7179 ## Types of changes What types of changes does your code introduce to Doris? _Put an `x` in the boxes that apply_ - [x] Bugf

[GitHub] [incubator-doris] HappenLee opened a new pull request #7181: [Bug] Fix mem limit -1 in partition aggregate node

2021-11-22 Thread GitBox
HappenLee opened a new pull request #7181: URL: https://github.com/apache/incubator-doris/pull/7181 ## Proposed changes Fix mem limit -1 in partition aggregate node ## Types of changes What types of changes does your code introduce to Doris? _Put an `x` in the boxes t

[GitHub] [incubator-doris] morningman commented on a change in pull request #7181: [Bug] Fix mem limit -1 in partition aggregate node

2021-11-22 Thread GitBox
morningman commented on a change in pull request #7181: URL: https://github.com/apache/incubator-doris/pull/7181#discussion_r754758749 ## File path: be/src/exec/partitioned_aggregation_node.cc ## @@ -849,7 +849,7 @@ Status PartitionedAggregationNode::Partition::Spill(bool more

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7132: [Clang-Format] Add Clang Format/Syswalking eyes github action

2021-11-22 Thread GitBox
github-actions[bot] commented on pull request #7132: URL: https://github.com/apache/incubator-doris/pull/7132#issuecomment-976101008 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7173: [doc] add FAQ document

2021-11-22 Thread GitBox
github-actions[bot] commented on pull request #7173: URL: https://github.com/apache/incubator-doris/pull/7173#issuecomment-976101161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7174: [doc] Add build-dev image 1.4.2 to compilation document

2021-11-22 Thread GitBox
github-actions[bot] commented on pull request #7174: URL: https://github.com/apache/incubator-doris/pull/7174#issuecomment-976101286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [incubator-doris] luzhijing opened a new pull request #7182: [docs]Created commit-format-specification.md

2021-11-22 Thread GitBox
luzhijing opened a new pull request #7182: URL: https://github.com/apache/incubator-doris/pull/7182 ## Proposed changes We found that many commit messages submitted at present have ambiguous information. Clear commit messages can help developers submit pull requests more readable, c

[GitHub] [incubator-doris] HappenLee commented on a change in pull request #7181: [Bug] Fix mem limit -1 in partition aggregate node

2021-11-22 Thread GitBox
HappenLee commented on a change in pull request #7181: URL: https://github.com/apache/incubator-doris/pull/7181#discussion_r754773344 ## File path: be/src/exec/partitioned_aggregation_node.cc ## @@ -849,7 +849,7 @@ Status PartitionedAggregationNode::Partition::Spill(bool more_

[GitHub] [incubator-doris] littleeleventhwolf opened a new pull request #7183: [BUG] Fix `curdate()+0` behave like mysql

2021-11-22 Thread GitBox
littleeleventhwolf opened a new pull request #7183: URL: https://github.com/apache/incubator-doris/pull/7183 ## Proposed changes I proposed this point in [PR-6005](https://github.com/apache/incubator-doris/pull/6005). Now I try to make `curdate()+0` behave like mysql. ## Ty

[GitHub] [incubator-doris] LangYuanzh opened a new issue #7185: 【routine load】kafka 消息有堆积的情况下为什么仍然存在 abortedTask

2021-11-22 Thread GitBox
LangYuanzh opened a new issue #7185: URL: https://github.com/apache/incubator-doris/issues/7185 ### Discussed in https://github.com/apache/incubator-doris/discussions/7184 Originally posted by **LangYuanzh** November 23, 2021 环境信息 : 1. kafka topic 3个patition 2.

[GitHub] [incubator-doris] luzhijing closed pull request #7182: [docs]Created commit-format-specification.md

2021-11-22 Thread GitBox
luzhijing closed pull request #7182: URL: https://github.com/apache/incubator-doris/pull/7182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: comm

[GitHub] [incubator-doris] luzhijing opened a new pull request #7190: [doc]Created commit-format-specification.md

2021-11-22 Thread GitBox
luzhijing opened a new pull request #7190: URL: https://github.com/apache/incubator-doris/pull/7190 ## Proposed changes We found that many commit messages submitted at present have ambiguous information. Clear commit messages can help developers submit pull requests more readable, c

[GitHub] [incubator-doris] luzhijing closed pull request #7189: [docs]Created commit-format-specification.md

2021-11-22 Thread GitBox
luzhijing closed pull request #7189: URL: https://github.com/apache/incubator-doris/pull/7189 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: comm

[GitHub] [incubator-doris] minghong opened a new issue #7191: [Bug] compile error

2021-11-22 Thread GitBox
minghong opened a new issue #7191: URL: https://github.com/apache/incubator-doris/issues/7191 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version commi

[GitHub] [incubator-doris] e0c9 commented on pull request #7157: [enhancement] Optimize get_json_xx function

2021-11-22 Thread GitBox
e0c9 commented on pull request #7157: URL: https://github.com/apache/incubator-doris/pull/7157#issuecomment-976194131 > The BE unit test failed. And if you change the signature of functions, it may cause incompatible issue. Fixed -- This is an automated message from the Apache Git

[GitHub] [incubator-doris] morningman commented on pull request #7157: [enhancement] Optimize get_json_xx function

2021-11-22 Thread GitBox
morningman commented on pull request #7157: URL: https://github.com/apache/incubator-doris/pull/7157#issuecomment-976195531 > And if you change the signature of functions, it may cause incompatible issue. hi @e0c9 What about this problem? -- This is an automated message from t

[GitHub] [incubator-doris] morningman opened a new issue #7192: [Bug] preceding filter may cause BE crash

2021-11-22 Thread GitBox
morningman opened a new issue #7192: URL: https://github.com/apache/incubator-doris/issues/7192 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version 0.1

[GitHub] [incubator-doris] e0c9 commented on pull request #7157: [enhancement] Optimize get_json_xx function

2021-11-22 Thread GitBox
e0c9 commented on pull request #7157: URL: https://github.com/apache/incubator-doris/pull/7157#issuecomment-976200987 > > And if you change the signature of functions, it may cause incompatible issue. > > hi @e0c9 What about this problem? I modified it locally based on the old

[GitHub] [incubator-doris] morningman opened a new pull request #7193: [fix](broker-load) BE may crash when using preceding filter in broker or routine load

2021-11-22 Thread GitBox
morningman opened a new pull request #7193: URL: https://github.com/apache/incubator-doris/pull/7193 ## Proposed changes The broker scan node has two tuple descriptors: One is dest tuple and the other is src tuple. The src tuple is used to read the lines of the original file,

[GitHub] [incubator-doris] qidaye commented on issue #7078: [Bug] ES Extern Table Crash

2021-11-22 Thread GitBox
qidaye commented on issue #7078: URL: https://github.com/apache/incubator-doris/issues/7078#issuecomment-976209643 I can not reproduce this bug. Here is my steps to reproduce: 1. Turn on ASAN before build BE, adding `export BUILD_TYPE=ASAN` in `custom_env.sh` 2. Create in

[GitHub] [incubator-doris] qidaye edited a comment on issue #7078: [Bug] ES Extern Table Crash

2021-11-22 Thread GitBox
qidaye edited a comment on issue #7078: URL: https://github.com/apache/incubator-doris/issues/7078#issuecomment-976209643 I can not reproduce this bug. Here is my steps to reproduce: 1. Turn on ASAN before build BE, adding `export BUILD_TYPE=ASAN` in `custom_env.sh` 2. Cr

[GitHub] [incubator-doris] qidaye commented on pull request #7079: Fix ES Extern Table Crash

2021-11-22 Thread GitBox
qidaye commented on pull request #7079: URL: https://github.com/apache/incubator-doris/pull/7079#issuecomment-976211328 I can not reproduce this bug. I add my steps to reproduce in the issues. If my steps are wrong, please let me know. -- This is an automated message from the Apache

[GitHub] [incubator-doris] anneji-dev opened a new pull request #7194: Predicates contains invalid date should be throw exception

2021-11-22 Thread GitBox
anneji-dev opened a new pull request #7194: URL: https://github.com/apache/incubator-doris/pull/7194 ## Proposed changes When predicates contains invalid date should be throw exception, MYSQL database is like this. cases are as follows: create table t3 (tc1 datetime,tc2 dat

[GitHub] [incubator-doris] minghong opened a new pull request #7195: [fix][Bug] compile error (#7191)

2021-11-22 Thread GitBox
minghong opened a new pull request #7195: URL: https://github.com/apache/incubator-doris/pull/7195 update compilation.md -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [incubator-doris] xinyiZzz opened a new issue #7196: [Feature] Refactored memory statistics framework MemTracker

2021-11-22 Thread GitBox
xinyiZzz opened a new issue #7196: URL: https://github.com/apache/incubator-doris/issues/7196 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Description h

[GitHub] [incubator-doris] morningman commented on pull request #7195: [fix][Bug] compile error (#7191)

2021-11-22 Thread GitBox
morningman commented on pull request #7195: URL: https://github.com/apache/incubator-doris/pull/7195#issuecomment-976219275 Hi @minghong , thanks, but it duplicated with #7174 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7181: [Bug] Fix mem limit -1 in partition aggregate node

2021-11-22 Thread GitBox
github-actions[bot] commented on pull request #7181: URL: https://github.com/apache/incubator-doris/pull/7181#issuecomment-976219616 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [incubator-doris] yiguolei opened a new pull request #7197: [Fix compile bug] could not find protobuf lib during compile

2021-11-22 Thread GitBox
yiguolei opened a new pull request #7197: URL: https://github.com/apache/incubator-doris/pull/7197 Failed to compile thirdparty brpc package, because could not find protobuf lib -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7172: [Memory] fix BUG crash when ~BitShufflePageDecoder destroys uninitialized chunk

2021-11-22 Thread GitBox
github-actions[bot] commented on pull request #7172: URL: https://github.com/apache/incubator-doris/pull/7172#issuecomment-976220066 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [incubator-doris] morningman merged pull request #7172: [Memory] fix BUG crash when ~BitShufflePageDecoder destroys uninitialized chunk

2021-11-22 Thread GitBox
morningman merged pull request #7172: URL: https://github.com/apache/incubator-doris/pull/7172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: com

[incubator-doris] branch master updated (ce7fa5d -> ad0d2b8)

2021-11-22 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from ce7fa5d [typo] Update multi-tenant.md (#7162) add ad0d2b8 [fix](memory) fix bug that ~BitShuffleP

[GitHub] [incubator-doris] morningman closed issue #7171: [Bug] ~BitShufflePageDecoder destroys uninitialized chunk

2021-11-22 Thread GitBox
morningman closed issue #7171: URL: https://github.com/apache/incubator-doris/issues/7171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7190: [doc]Created commit-format-specification.md

2021-11-22 Thread GitBox
github-actions[bot] commented on pull request #7190: URL: https://github.com/apache/incubator-doris/pull/7190#issuecomment-976221088 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [incubator-doris] morningman commented on a change in pull request #7197: [Fix compile bug] could not find protobuf lib during compile

2021-11-22 Thread GitBox
morningman commented on a change in pull request #7197: URL: https://github.com/apache/incubator-doris/pull/7197#discussion_r754858875 ## File path: thirdparty/build-thirdparty.sh ## @@ -502,6 +502,7 @@ build_brpc() { rm -rf CMakeCache.txt CMakeFiles/ LDFLAGS="-L${TP_

[GitHub] [incubator-doris] xinyiZzz opened a new pull request #7198: [Memory] Use TCMalloc Hook to count the real Process and Query MemTracker

2021-11-22 Thread GitBox
xinyiZzz opened a new pull request #7198: URL: https://github.com/apache/incubator-doris/pull/7198 ## Proposed changes 1. Add thread local variable ThreadStatus, save queryID, MemTracker, etc. 2. Use TCMalloc Hook to consume and release MemTracker in ThreadStatus. 3. Add real BE

[GitHub] [incubator-doris] morningman commented on a change in pull request #7151: Optimize bitmap function count, use roaring cardinality method

2021-11-22 Thread GitBox
morningman commented on a change in pull request #7151: URL: https://github.com/apache/incubator-doris/pull/7151#discussion_r754001296 ## File path: be/src/exprs/bitmap_function.cpp ## @@ -333,10 +333,10 @@ BigIntVal BitmapFunctions::bitmap_count(FunctionContext* ctx, const St