[GitHub] [incubator-doris] zuochunwei opened a new pull request #7144: bugfix: ReportProfile

2021-11-18 Thread GitBox
zuochunwei opened a new pull request #7144: URL: https://github.com/apache/incubator-doris/pull/7144 issue description: 1. setting _report_thread_active to false is not necessary protected by _report_thread_lock, because _report_thread_active's type is bool, writing data is multi-thread

[GitHub] [incubator-doris] zuochunwei opened a new pull request #7145: no static_cast

2021-11-18 Thread GitBox
zuochunwei opened a new pull request #7145: URL: https://github.com/apache/incubator-doris/pull/7145 provider interface in abstract-class replace static_cast static_cast is not good for oop -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [incubator-doris] tianhui5 opened a new issue #7146: [Proposal] limit meta size to affend too much BE memory usage

2021-11-18 Thread GitBox
tianhui5 opened a new issue #7146: URL: https://github.com/apache/incubator-doris/issues/7146 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version 1238f

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7144: bugfix: ReportProfile

2021-11-18 Thread GitBox
github-actions[bot] commented on pull request #7144: URL: https://github.com/apache/incubator-doris/pull/7144#issuecomment-972732890 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [incubator-doris] hf200012 opened a new pull request #7147: Doris grafana monitoring metrics description

2021-11-18 Thread GitBox
hf200012 opened a new pull request #7147: URL: https://github.com/apache/incubator-doris/pull/7147 1.Doris grafana monitoring metrics description 2.At the same time, all the pictures under the doc will be compressed losslessly to reduce the size of the website ## Proposed changes

[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request #7148: [Lateral View] Pruning output slot of TableFunctionNode

2021-11-18 Thread GitBox
EmmyMiao87 opened a new pull request #7148: URL: https://github.com/apache/incubator-doris/pull/7148 ## Proposed changes If the calculation of the lateral view function is completed, the result will be directly returned to the upper layer. It will cause a lot of memory copy and

[GitHub] [incubator-doris] xinghuayu007 opened a new pull request #7149: [Feature] Z-Order Implement

2021-11-18 Thread GitBox
xinghuayu007 opened a new pull request #7149: URL: https://github.com/apache/incubator-doris/pull/7149 ## Proposed changes **For issue: #6359** ### Background ![image](https://user-images.githubusercontent.com/12771191/142423932-6a2c3349-3f7d-4161-9626-62e4d1eafc16.png

[GitHub] [incubator-doris] morningman commented on pull request #7149: [Feature] Z-Order Implement

2021-11-18 Thread GitBox
morningman commented on pull request #7149: URL: https://github.com/apache/incubator-doris/pull/7149#issuecomment-972889829 Nice work! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [incubator-doris] dadahelloworld opened a new pull request #7150: Add version rollback information

2021-11-18 Thread GitBox
dadahelloworld opened a new pull request #7150: URL: https://github.com/apache/incubator-doris/pull/7150 ## Proposed changes 1.Add version rollback information. 2.Fix typos. ## Types of changes What types of changes does your code introduce to Doris? _Put an `x

[GitHub] [incubator-doris] morningman commented on a change in pull request #7149: [Feature] Z-Order Implement

2021-11-18 Thread GitBox
morningman commented on a change in pull request #7149: URL: https://github.com/apache/incubator-doris/pull/7149#discussion_r752370650 ## File path: be/src/util/tuple_row_zorder_compare.h ## @@ -0,0 +1,70 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7119: extract duplicate code to writePropertiesToFile

2021-11-18 Thread GitBox
github-actions[bot] commented on pull request #7119: URL: https://github.com/apache/incubator-doris/pull/7119#issuecomment-973009997 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [incubator-doris] morningman commented on a change in pull request #7134: [enhancement] display load bytes in show load stmt

2021-11-18 Thread GitBox
morningman commented on a change in pull request #7134: URL: https://github.com/apache/incubator-doris/pull/7134#discussion_r752399627 ## File path: fe/fe-core/src/main/java/org/apache/doris/load/loadv2/BrokerLoadJob.java ## @@ -346,6 +346,16 @@ private void updateLoadingStat

[GitHub] [incubator-doris] morningman commented on a change in pull request #7145: no static_cast

2021-11-18 Thread GitBox
morningman commented on a change in pull request #7145: URL: https://github.com/apache/incubator-doris/pull/7145#discussion_r752408214 ## File path: be/src/exec/exec_node.h ## @@ -135,6 +135,12 @@ class ExecNode { // each implementation should start out by calling the defa

[GitHub] [incubator-doris] hf200012 commented on pull request #7149: [Feature] Z-Order Implement

2021-11-18 Thread GitBox
hf200012 commented on pull request #7149: URL: https://github.com/apache/incubator-doris/pull/7149#issuecomment-973628484 apache carbondata also has this min/max index,nice -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-doris] hf200012 commented on a change in pull request #7150: Add version rollback information

2021-11-18 Thread GitBox
hf200012 commented on a change in pull request #7150: URL: https://github.com/apache/incubator-doris/pull/7150#discussion_r752805654 ## File path: docs/zh-CN/installing/upgrade.md ## @@ -80,3 +80,12 @@ Doris 可以通过滚动升级的方式,平滑进行升级。建议按照以 1. 确认新版本的文件部署完成后。逐台重启 FE 和 BE 实例即可。 2. 建议逐台

[GitHub] [incubator-doris] morningman commented on a change in pull request #7150: Add version rollback information

2021-11-18 Thread GitBox
morningman commented on a change in pull request #7150: URL: https://github.com/apache/incubator-doris/pull/7150#discussion_r752811009 ## File path: docs/zh-CN/installing/upgrade.md ## @@ -80,3 +80,12 @@ Doris 可以通过滚动升级的方式,平滑进行升级。建议按照以 1. 确认新版本的文件部署完成后。逐台重启 FE 和 BE 实例即可。 2. 建议

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7041: [enhancement] Increase compatibility with mysql

2021-11-18 Thread GitBox
github-actions[bot] commented on pull request #7041: URL: https://github.com/apache/incubator-doris/pull/7041#issuecomment-973664583 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [incubator-doris] zuochunwei commented on a change in pull request #7145: no static_cast

2021-11-18 Thread GitBox
zuochunwei commented on a change in pull request #7145: URL: https://github.com/apache/incubator-doris/pull/7145#discussion_r752819977 ## File path: be/src/exec/exec_node.h ## @@ -135,6 +135,12 @@ class ExecNode { // each implementation should start out by calling the defa

[GitHub] [incubator-doris] xinghuayu007 commented on a change in pull request #7149: [Feature] Z-Order Implement

2021-11-18 Thread GitBox
xinghuayu007 commented on a change in pull request #7149: URL: https://github.com/apache/incubator-doris/pull/7149#discussion_r752819893 ## File path: be/src/util/tuple_row_zorder_compare.h ## @@ -0,0 +1,70 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// o

[GitHub] [incubator-doris] zuochunwei commented on a change in pull request #7145: no static_cast

2021-11-18 Thread GitBox
zuochunwei commented on a change in pull request #7145: URL: https://github.com/apache/incubator-doris/pull/7145#discussion_r752819977 ## File path: be/src/exec/exec_node.h ## @@ -135,6 +135,12 @@ class ExecNode { // each implementation should start out by calling the defa

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #7150: Add version rollback information

2021-11-18 Thread GitBox
EmmyMiao87 commented on a change in pull request #7150: URL: https://github.com/apache/incubator-doris/pull/7150#discussion_r752824258 ## File path: docs/zh-CN/getting-started/data-partition.md ## @@ -146,7 +146,7 @@ Doris 支持两层的数据划分。第一层是 Partition,支持 Range 和 Li 1. Partition

[GitHub] [incubator-doris] yangzhg opened a new pull request #7151: Optimize bitmap function count, use roaring cardinality method

2021-11-18 Thread GitBox
yangzhg opened a new pull request #7151: URL: https://github.com/apache/incubator-doris/pull/7151 ## Proposed changes optimize bitmap function count, use roaring cardinality method, this will more fast than current version ## Types of changes What types of changes does

[GitHub] [incubator-doris] morningman commented on pull request #7151: Optimize bitmap function count, use roaring cardinality method

2021-11-18 Thread GitBox
morningman commented on pull request #7151: URL: https://github.com/apache/incubator-doris/pull/7151#issuecomment-973700997 Do you have benchmark result for this improvement? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [incubator-doris] renzhimin7 opened a new pull request #7152: Update multi-tenant.md

2021-11-18 Thread GitBox
renzhimin7 opened a new pull request #7152: URL: https://github.com/apache/incubator-doris/pull/7152 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature re

[GitHub] [incubator-doris] renzhimin7 commented on pull request #7152: Update multi-tenant.md

2021-11-18 Thread GitBox
renzhimin7 commented on pull request #7152: URL: https://github.com/apache/incubator-doris/pull/7152#issuecomment-973723674 Lost a double quote ![image](https://user-images.githubusercontent.com/29918146/142564587-15708327-c56d-44c6-9c28-aa8a12d133da.png) -- This is an automat

[GitHub] [incubator-doris] morningman commented on issue #7141: [Feature] [Stream Load] Two-Phase Commit for stream load

2021-11-18 Thread GitBox
morningman commented on issue #7141: URL: https://github.com/apache/incubator-doris/issues/7141#issuecomment-973723783 Looking forward your PR! And as we discussed before, the `pre-commit` status has be cleared somehow finally. -- This is an automated message from the Apache Git Serv

[GitHub] [incubator-doris] renzhimin7 opened a new pull request #7153: Update multi-tenant.md

2021-11-18 Thread GitBox
renzhimin7 opened a new pull request #7153: URL: https://github.com/apache/incubator-doris/pull/7153 `show proc "/cluster_balance/` Lost a double quote ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pul

[GitHub] [incubator-doris] renzhimin7 closed pull request #7152: Update multi-tenant.md

2021-11-18 Thread GitBox
renzhimin7 closed pull request #7152: URL: https://github.com/apache/incubator-doris/pull/7152 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: com

[GitHub] [incubator-doris] renzhimin7 commented on pull request #7153: Update multi-tenant.md

2021-11-18 Thread GitBox
renzhimin7 commented on pull request #7153: URL: https://github.com/apache/incubator-doris/pull/7153#issuecomment-973725880 ![image](https://user-images.githubusercontent.com/29918146/142565078-7616b883-d304-42d5-8577-1c062a0ffad1.png) -- This is an automated message from the Apache

[GitHub] [incubator-doris] morningman commented on issue #7129: [Feature] Limit cluster resource usage in user granularity

2021-11-18 Thread GitBox
morningman commented on issue #7129: URL: https://github.com/apache/incubator-doris/issues/7129#issuecomment-973726928 I see. Doris already has `max_connection` limit which can be set for each user. But I think what you need is not just limit the number of connection, but to limit th

[GitHub] [incubator-doris] morningman commented on issue #7110: [Bug] Build ZSTD failed due to inappropriate Cmake option

2021-11-18 Thread GitBox
morningman commented on issue #7110: URL: https://github.com/apache/incubator-doris/issues/7110#issuecomment-973727218 Fixed by #7111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [incubator-doris] morningman closed issue #7110: [Bug] Build ZSTD failed due to inappropriate Cmake option

2021-11-18 Thread GitBox
morningman closed issue #7110: URL: https://github.com/apache/incubator-doris/issues/7110 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-

[GitHub] [incubator-doris] morningman commented on issue #7110: [Bug] Build ZSTD failed due to inappropriate Cmake option

2021-11-18 Thread GitBox
morningman commented on issue #7110: URL: https://github.com/apache/incubator-doris/issues/7110#issuecomment-973727807 Hi @zhengshengjun , next time , you can write a `Fix #issue_number` in your Pull request. So that github can automatically link this issue to the PR and will also close t

[GitHub] [incubator-doris] morningman commented on issue #7001: [Feature] use io_uring for file io?

2021-11-18 Thread GitBox
morningman commented on issue #7001: URL: https://github.com/apache/incubator-doris/issues/7001#issuecomment-973731043 > @morningman yes, io_uring(sorry for typo) and higher linux kernel version. There's one PR from rocksdb community, using io_uring to improve performance. [facebook/rocks

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7124: [Feature] Add minidump support

2021-11-18 Thread GitBox
github-actions[bot] commented on pull request #7124: URL: https://github.com/apache/incubator-doris/pull/7124#issuecomment-973748367 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [incubator-doris] morningman opened a new issue #7154: [Bug] Update with subquery cause NPE

2021-11-18 Thread GitBox
morningman opened a new issue #7154: URL: https://github.com/apache/incubator-doris/issues/7154 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version 0.1

[GitHub] [incubator-doris] caiconghui opened a new pull request #7155: [Config] Set default value to 1 for max_query_retry_time and add decommissioned backend to unavailable backend list when do simpl

2021-11-18 Thread GitBox
caiconghui opened a new pull request #7155: URL: https://github.com/apache/incubator-doris/pull/7155 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature re

[GitHub] [incubator-doris] morningman commented on a change in pull request #7155: [Config] Set default value to 1 for max_query_retry_time and add decommissioned backend to unavailable backend list w

2021-11-18 Thread GitBox
morningman commented on a change in pull request #7155: URL: https://github.com/apache/incubator-doris/pull/7155#discussion_r752898623 ## File path: fe/fe-core/src/main/java/org/apache/doris/qe/SimpleScheduler.java ## @@ -195,7 +195,7 @@ public static void addToBlacklist(Long b

[GitHub] [incubator-doris] caiconghui commented on a change in pull request #7155: [Config] Set default value to 1 for max_query_retry_time and add decommissioned backend to unavailable backend list w

2021-11-18 Thread GitBox
caiconghui commented on a change in pull request #7155: URL: https://github.com/apache/incubator-doris/pull/7155#discussion_r752899291 ## File path: fe/fe-core/src/main/java/org/apache/doris/qe/SimpleScheduler.java ## @@ -195,7 +195,7 @@ public static void addToBlacklist(Long b

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7087: add replica num limit per tablet

2021-11-18 Thread GitBox
github-actions[bot] commented on pull request #7087: URL: https://github.com/apache/incubator-doris/pull/7087#issuecomment-973798521 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [incubator-doris] luzhijing opened a new pull request #7156: [docs]Created commit-format-specification.md

2021-11-18 Thread GitBox
luzhijing opened a new pull request #7156: URL: https://github.com/apache/incubator-doris/pull/7156 ## Proposed changes We found that many commit messages submitted at present have ambiguous information. Clear commit messages can help developers submit pull requests more readable, c