[GitHub] [incubator-doris] Gabriel39 opened a new pull request #6861: [Optimize][Runtime Filter] Init left node asynchronously in join node

2021-10-17 Thread GitBox
Gabriel39 opened a new pull request #6861: URL: https://github.com/apache/incubator-doris/pull/6861 ## Proposed changes Currently, when runtime filters is specified, left child node will be initialed after building process is done in HashJoinNode. Obviously it will hurt performance

[GitHub] [incubator-doris] Gabriel39 commented on pull request #6861: [Optimize][Runtime Filter] Init left node asynchronously in join node

2021-10-17 Thread GitBox
Gabriel39 commented on pull request #6861: URL: https://github.com/apache/incubator-doris/pull/6861#issuecomment-945078892 cc @stdpain @morningman -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [incubator-doris] morningman merged pull request #6839: [BUG] fix bug for schema schange

2021-10-17 Thread GitBox
morningman merged pull request #6839: URL: https://github.com/apache/incubator-doris/pull/6839 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: com

[incubator-doris] branch master updated: [BUG] fix bug for schema schange (#6839)

2021-10-17 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new bc069ea [BUG] fix bug for schema s

[GitHub] [incubator-doris] morningman merged pull request #6852: add type BOOLEAN when enter 'help create table' in mysql client.

2021-10-17 Thread GitBox
morningman merged pull request #6852: URL: https://github.com/apache/incubator-doris/pull/6852 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: com

[incubator-doris] branch master updated (bc069ea -> bb2b29c)

2021-10-17 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from bc069ea [BUG] fix bug for schema schange (#6839) add bb2b29c [Doc] Add type BOOLEAN when enter 'h

[incubator-doris] branch master updated: [Bug] Fix bug that BE will crash when backup using S3 (#6855)

2021-10-17 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new da99749 [Bug] Fix bug that BE will

[GitHub] [incubator-doris] morningman closed issue #6854: [Bug] Core of BE when backup use in S3

2021-10-17 Thread GitBox
morningman closed issue #6854: URL: https://github.com/apache/incubator-doris/issues/6854 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-

[GitHub] [incubator-doris] morningman merged pull request #6855: [Bug] Fix bug of backup core of BE use S3

2021-10-17 Thread GitBox
morningman merged pull request #6855: URL: https://github.com/apache/incubator-doris/pull/6855 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: com

[GitHub] [incubator-doris] morningman opened a new pull request #6862: [UT] Fix ut bugs

2021-10-17 Thread GitBox
morningman opened a new pull request #6862: URL: https://github.com/apache/incubator-doris/pull/6862 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature re

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #6862: [UT] Fix ut bugs

2021-10-17 Thread GitBox
github-actions[bot] commented on pull request #6862: URL: https://github.com/apache/incubator-doris/pull/6862#issuecomment-945303373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [incubator-doris] yangzhg merged pull request #6862: [UT] Fix ut bugs

2021-10-17 Thread GitBox
yangzhg merged pull request #6862: URL: https://github.com/apache/incubator-doris/pull/6862 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commit

[incubator-doris] branch master updated: [UT] Fix ut bugs (#6862)

2021-10-17 Thread yangzhg
This is an automated email from the ASF dual-hosted git repository. yangzhg pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 63dbcbc [UT] Fix ut bugs (#6862) 63db

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #6853: [Manager] Improve agent part code

2021-10-17 Thread GitBox
github-actions[bot] commented on pull request #6853: URL: https://github.com/apache/incubator-doris/pull/6853#issuecomment-945303692 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [incubator-doris] songchuangyuan opened a new pull request #6863: change build script

2021-10-17 Thread GitBox
songchuangyuan opened a new pull request #6863: URL: https://github.com/apache/incubator-doris/pull/6863 ## Proposed changes Modify the bugs in readme documents and some running scripts -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [incubator-doris] stdpain commented on pull request #6861: [Optimize][Runtime Filter] Init left node asynchronously in join node

2021-10-17 Thread GitBox
stdpain commented on pull request #6861: URL: https://github.com/apache/incubator-doris/pull/6861#issuecomment-945317805 @Gabriel39 Thank you for your contribute! If the open phase is completed before the RF is generated, it may result in the generated expressions not being pushed down t

[GitHub] [incubator-doris] EmmyMiao87 commented on pull request #6861: [Optimize][Runtime Filter] Init left node asynchronously in join node

2021-10-17 Thread GitBox
EmmyMiao87 commented on pull request #6861: URL: https://github.com/apache/incubator-doris/pull/6861#issuecomment-945324169 This is actually a strategic trade-off. Move to execute left node or wait for RT and push to the storage layer. It depends on the filtering rate of RT at the storage

[GitHub] [incubator-doris] EmmyMiao87 edited a comment on pull request #6861: [Optimize][Runtime Filter] Init left node asynchronously in join node

2021-10-17 Thread GitBox
EmmyMiao87 edited a comment on pull request #6861: URL: https://github.com/apache/incubator-doris/pull/6861#issuecomment-945324169 This is actually a strategic trade-off. Execute left node asynchronously or wait for RT and push to the storage layer. It depends on the filtering rate of RT a

[GitHub] [incubator-doris] xy720 commented on a change in pull request #6859: [Doc] Add documents for MySQL Binlog Load

2021-10-17 Thread GitBox
xy720 commented on a change in pull request #6859: URL: https://github.com/apache/incubator-doris/pull/6859#discussion_r730541529 ## File path: docs/zh-CN/administrator-guide/load-data/binlog-load-manual.md ## @@ -0,0 +1,470 @@ +--- +{ +"title": "Binlog Load", +"languag

[GitHub] [incubator-doris] wunan1210 opened a new pull request #6864: fix exporter document error

2021-10-17 Thread GitBox
wunan1210 opened a new pull request #6864: URL: https://github.com/apache/incubator-doris/pull/6864 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature req

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #6846: [bug] fix NumberFormatException for partition cache

2021-10-17 Thread GitBox
EmmyMiao87 commented on a change in pull request #6846: URL: https://github.com/apache/incubator-doris/pull/6846#discussion_r730543440 ## File path: fe/fe-core/src/main/java/org/apache/doris/qe/cache/PartitionRange.java ## @@ -149,17 +148,26 @@ public void Debug() { p

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #6843: [Bug] Fix bug to reject request with no SQL in TableQueryPlanAction

2021-10-17 Thread GitBox
github-actions[bot] commented on pull request #6843: URL: https://github.com/apache/incubator-doris/pull/6843#issuecomment-945329459 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #6864: fix exporter document error

2021-10-17 Thread GitBox
EmmyMiao87 commented on a change in pull request #6864: URL: https://github.com/apache/incubator-doris/pull/6864#discussion_r730544646 ## File path: docs/zh-CN/administrator-guide/export-manual.md ## @@ -112,14 +112,14 @@ PROPERTIES ( "label" = "mylabel", "column_

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #6859: [Doc] Add documents for MySQL Binlog Load

2021-10-17 Thread GitBox
github-actions[bot] commented on pull request #6859: URL: https://github.com/apache/incubator-doris/pull/6859#issuecomment-945358454 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [incubator-doris] morningman merged pull request #6863: [Manager] change build script

2021-10-17 Thread GitBox
morningman merged pull request #6863: URL: https://github.com/apache/incubator-doris/pull/6863 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: com

[incubator-doris] branch doris-manager updated: [Manager] Change build script (#6863)

2021-10-17 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch doris-manager in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/doris-manager by this push: new 07cacca [Manager] Ch

[GitHub] [incubator-doris] wunan1210 commented on pull request #6864: [Docs] Fix exporter document error

2021-10-17 Thread GitBox
wunan1210 commented on pull request #6864: URL: https://github.com/apache/incubator-doris/pull/6864#issuecomment-945369526 update en exporter doc. ^_^ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [incubator-doris] morningman commented on pull request #6838: [Bug] Fix potential NPE when cancel DorisSourceFunction

2021-10-17 Thread GitBox
morningman commented on pull request #6838: URL: https://github.com/apache/incubator-doris/pull/6838#issuecomment-945377108 > @morningman Thanks for your reply, I just starts to read Doris code and choose flink-doris-connector as a beginning. I found some code could be improved and this is

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #6838: [Bug] Fix potential NPE when cancel DorisSourceFunction

2021-10-17 Thread GitBox
github-actions[bot] commented on pull request #6838: URL: https://github.com/apache/incubator-doris/pull/6838#issuecomment-945377161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [incubator-doris] Gabriel39 commented on pull request #6861: [Optimize][Runtime Filter] Init left node asynchronously in join node

2021-10-17 Thread GitBox
Gabriel39 commented on pull request #6861: URL: https://github.com/apache/incubator-doris/pull/6861#issuecomment-945379270 > @Gabriel39 Thank you for your contribute! If the open phase is completed before the RF is generated, it may result in the generated expressions not being pushed down

[GitHub] [incubator-doris] HappenLee opened a new issue #6865: [Refactor] Refactor the code of reader

2021-10-17 Thread GitBox
HappenLee opened a new issue #6865: URL: https://github.com/apache/incubator-doris/issues/6865 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Description

[GitHub] [incubator-doris] HappenLee opened a new pull request #6866: [Refactor] Refactor the reader code

2021-10-17 Thread GitBox
HappenLee opened a new pull request #6866: URL: https://github.com/apache/incubator-doris/pull/6866 1. Removed useless redundant code logic 2. change reader to interface, add tuple reader to simplify the structure of reader ## Proposed changes Describe the big picture of

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #6864: [Docs] Fix exporter document error

2021-10-17 Thread GitBox
github-actions[bot] commented on pull request #6864: URL: https://github.com/apache/incubator-doris/pull/6864#issuecomment-945418983 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c