[GitHub] [incubator-doris] xinyiZzz opened a new issue #6116: [Feature] Runtime Filtering for Doris[zh-CN]

2021-06-29 Thread GitBox
xinyiZzz opened a new issue #6116: URL: https://github.com/apache/incubator-doris/issues/6116 # Runtime Filtering for Doris[zh-CN] Runtime filter的概念、在Doris中的现状、BE的实现思路,见:https://github.com/apache/incubator-doris/issues/6075 Impala runtime filter的源码解析见: https://docs.google.com/documen

[GitHub] [incubator-doris] xinyiZzz commented on issue #6075: [Feature] Support RuntimeFilter In Doris

2021-06-29 Thread GitBox
xinyiZzz commented on issue #6075: URL: https://github.com/apache/incubator-doris/issues/6075#issuecomment-870377767 @xinghuayu007 If the left table has only 1000 rows of data, the use of runtime filter may result in performance degradation, even if only the smallest overhead `IN` filter

[GitHub] [incubator-doris] yangzhg opened a new pull request #6117: Add update time to show table status result

2021-06-29 Thread GitBox
yangzhg opened a new pull request #6117: URL: https://github.com/apache/incubator-doris/pull/6117 ## Proposed changes Add update time to show table status result ``` MySQL [test_query_qa]> show table status; +--++-++--+

[GitHub] [incubator-doris] qidaye commented on pull request #5996: [Bug] Create dynamic partition table failed with enable create_history_partition and not specify the start value

2021-06-29 Thread GitBox
qidaye commented on pull request #5996: URL: https://github.com/apache/incubator-doris/pull/5996#issuecomment-870451825 Hi @harveyyue , thanks for your PR. > one more thing, i want to keep 100 partitions with set dynamic_partition.start=-100, and want to create 20 old partitions rather t

[GitHub] [incubator-doris] Albus001 opened a new issue #6118: flink doris connector 支持flink 1.13.0吗?

2021-06-29 Thread GitBox
Albus001 opened a new issue #6118: URL: https://github.com/apache/incubator-doris/issues/6118 请问这个连接器支持flink1.13.0吗? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [incubator-doris] JNSimba commented on issue #6118: flink doris connector 支持flink 1.13.0吗?

2021-06-29 Thread GitBox
JNSimba commented on issue #6118: URL: https://github.com/apache/incubator-doris/issues/6118#issuecomment-870501315 support -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [incubator-doris] morningman opened a new issue #6119: [Bug] BE core when validating rowset after finished schema change job

2021-06-29 Thread GitBox
morningman opened a new issue #6119: URL: https://github.com/apache/incubator-doris/issues/6119 **Describe the bug** ``` #0 0x019fb29f in doris::SchemaChangeHandler::_validate_alter_result (this=, new_tablet=std::shared_ptr (use count 3, weak count 1) = {...}, request=...)

[GitHub] [incubator-doris] morningman opened a new pull request #6120: [Bug] Add readlock when calling get_rowset_by_version()

2021-06-29 Thread GitBox
morningman opened a new pull request #6120: URL: https://github.com/apache/incubator-doris/pull/6120 ## Proposed changes Alter doing schema change job, Doris will check all rowsets of the new tablet. It will first get all versions of the new tablet by calling `rowset->list_versio

[GitHub] [incubator-doris] stdpain commented on pull request #6120: [Bug] Add readlock when calling get_rowset_by_version()

2021-06-29 Thread GitBox
stdpain commented on pull request #6120: URL: https://github.com/apache/incubator-doris/pull/6120#issuecomment-870554424 Is it a better way to provide a method such as ``` std::vector> Tablet::acquire_version_and_rowset() const { std::vector> res; ReadLock rdlock(&_meta_

[GitHub] [incubator-doris] stalary commented on pull request #6110: [Feature] ADD: show create routine load

2021-06-29 Thread GitBox
stalary commented on pull request #6110: URL: https://github.com/apache/incubator-doris/pull/6110#issuecomment-869760105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [incubator-doris] hf200012 commented on a change in pull request #6056: [DOC]Doris BE development and debugging environment construction

2021-06-29 Thread GitBox
hf200012 commented on a change in pull request #6056: URL: https://github.com/apache/incubator-doris/pull/6056#discussion_r659914771 ## File path: docs/.vuepress/sidebar/zh-CN.js ## @@ -546,6 +546,7 @@ module.exports = [ "debug-tool", "fe-eclipse-dev",

[GitHub] [incubator-doris] morningman commented on pull request #6069: [Metrics] Add metrics for load average.

2021-06-29 Thread GitBox
morningman commented on pull request #6069: URL: https://github.com/apache/incubator-doris/pull/6069#issuecomment-869804215 > Is this metric can dispplay in grafana? We need to update grafana template -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [incubator-doris] ucasFL commented on a change in pull request #6023: Support alter default bucket_num of table

2021-06-29 Thread GitBox
ucasFL commented on a change in pull request #6023: URL: https://github.com/apache/incubator-doris/pull/6023#discussion_r659925578 ## File path: fe/fe-core/src/main/java/org/apache/doris/catalog/Catalog.java ## @@ -5545,6 +5547,74 @@ public void replayModifyTableProperty(short

[GitHub] [incubator-doris] morningman commented on a change in pull request #6083: [Feature] Extract wide common factors

2021-06-29 Thread GitBox
morningman commented on a change in pull request #6083: URL: https://github.com/apache/incubator-doris/pull/6083#discussion_r659923262 ## File path: fe/fe-core/src/main/java/org/apache/doris/rewrite/ExprRewriter.java ## @@ -36,11 +37,17 @@ public class ExprRewriter { priv

[GitHub] [incubator-doris] morningman commented on a change in pull request #6056: [DOC]Doris BE development and debugging environment construction

2021-06-29 Thread GitBox
morningman commented on a change in pull request #6056: URL: https://github.com/apache/incubator-doris/pull/6056#discussion_r659912769 ## File path: docs/.vuepress/sidebar/zh-CN.js ## @@ -546,6 +546,7 @@ module.exports = [ "debug-tool", "fe-eclipse-dev",

[GitHub] [incubator-doris] morningman commented on a change in pull request #6051: [Bug-fix] Decimal Divide, Mod Zero Result Should be NULL.

2021-06-29 Thread GitBox
morningman commented on a change in pull request #6051: URL: https://github.com/apache/incubator-doris/pull/6051#discussion_r659909692 ## File path: be/src/runtime/decimalv2_value.cpp ## @@ -192,7 +192,7 @@ DecimalV2Value operator/(const DecimalV2Value& v1, const DecimalV2Valu

[GitHub] [incubator-doris] stalary commented on pull request #6102: WIP: 添加create table as select

2021-06-29 Thread GitBox
stalary commented on pull request #6102: URL: https://github.com/apache/incubator-doris/pull/6102#issuecomment-869710891 wait support string -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [incubator-doris] morningman commented on a change in pull request #6023: Support alter default bucket_num of table

2021-06-29 Thread GitBox
morningman commented on a change in pull request #6023: URL: https://github.com/apache/incubator-doris/pull/6023#discussion_r659902634 ## File path: fe/fe-core/src/main/java/org/apache/doris/catalog/Catalog.java ## @@ -5545,6 +5547,74 @@ public void replayModifyTableProperty(sh

[GitHub] [incubator-doris] stalary closed pull request #6067: [Feature] ADD: show create routine load

2021-06-29 Thread GitBox
stalary closed pull request #6067: URL: https://github.com/apache/incubator-doris/pull/6067 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commit

[GitHub] [incubator-doris] morningman commented on a change in pull request #6027: [Feature] Export data supports parquet format

2021-06-29 Thread GitBox
morningman commented on a change in pull request #6027: URL: https://github.com/apache/incubator-doris/pull/6027#discussion_r659895133 ## File path: gensrc/thrift/DataSinks.thrift ## @@ -114,7 +114,10 @@ struct TExportSink { 4: required string line_delimiter // proper

[GitHub] [incubator-doris] stalary edited a comment on issue #6103: [Feature] Support configuring blacklists by user level

2021-06-29 Thread GitBox
stalary edited a comment on issue #6103: URL: https://github.com/apache/incubator-doris/issues/6103#issuecomment-870189635 ruleId | user | rule 111| test_user | select * from .* -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [incubator-doris] wangbo merged pull request #6087: (#6009) fix bucket key distribute error when using spark load

2021-06-29 Thread GitBox
wangbo merged pull request #6087: URL: https://github.com/apache/incubator-doris/pull/6087 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[GitHub] [incubator-doris] yangzhg merged pull request #6104: [Docs] ADD: fe-idea-dev.md add thrift version notice

2021-06-29 Thread GitBox
yangzhg merged pull request #6104: URL: https://github.com/apache/incubator-doris/pull/6104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commit

[GitHub] [incubator-doris] yangzhg closed issue #6078: complie error

2021-06-29 Thread GitBox
yangzhg closed issue #6078: URL: https://github.com/apache/incubator-doris/issues/6078 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [incubator-doris] HappenLee commented on a change in pull request #6051: [Bug-fix] Decimal Divide, Mod Zero Result Should be NULL.

2021-06-29 Thread GitBox
HappenLee commented on a change in pull request #6051: URL: https://github.com/apache/incubator-doris/pull/6051#discussion_r660254448 ## File path: be/src/runtime/decimalv2_value.cpp ## @@ -192,7 +192,7 @@ DecimalV2Value operator/(const DecimalV2Value& v1, const DecimalV2Value

[GitHub] [incubator-doris] JNSimba commented on issue #6118: flink doris connector 支持flink 1.13.0吗?

2021-06-29 Thread GitBox
JNSimba commented on issue #6118: URL: https://github.com/apache/incubator-doris/issues/6118#issuecomment-870501315 support -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [incubator-doris] stalary commented on issue #6103: [Feature] Support configuring blacklists by user level

2021-06-29 Thread GitBox
stalary commented on issue #6103: URL: https://github.com/apache/incubator-doris/issues/6103#issuecomment-870189635 ruleId | user | rule -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [incubator-doris] yangzhg merged pull request #6097: [Docs] Add contact us in README

2021-06-29 Thread GitBox
yangzhg merged pull request #6097: URL: https://github.com/apache/incubator-doris/pull/6097 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commit

[GitHub] [incubator-doris] yangzhg merged pull request #6030: Fix timeout error when delete condition contains invalid datetime format

2021-06-29 Thread GitBox
yangzhg merged pull request #6030: URL: https://github.com/apache/incubator-doris/pull/6030 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commit

[GitHub] [incubator-doris] wangbo closed issue #6009: [Spark Load]Got incorrect bucket when distributed by int

2021-06-29 Thread GitBox
wangbo closed issue #6009: URL: https://github.com/apache/incubator-doris/issues/6009 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [incubator-doris] xinyiZzz commented on issue #6075: [Feature] Support RuntimeFilter In Doris

2021-06-29 Thread GitBox
xinyiZzz commented on issue #6075: URL: https://github.com/apache/incubator-doris/issues/6075#issuecomment-870377767 @xinghuayu007 If the left table has only 1000 rows of data, the use of runtime filter may result in performance degradation, even if only the smallest overhead `IN` filter

[GitHub] [incubator-doris] qidaye commented on pull request #5996: [Bug] Create dynamic partition table failed with enable create_history_partition and not specify the start value

2021-06-29 Thread GitBox
qidaye commented on pull request #5996: URL: https://github.com/apache/incubator-doris/pull/5996#issuecomment-870451825 Hi @harveyyue , thanks for your PR. > one more thing, i want to keep 100 partitions with set dynamic_partition.start=-100, and want to create 20 old partitions rather t

[GitHub] [incubator-doris] stdpain commented on pull request #6120: [Bug] Add readlock when calling get_rowset_by_version()

2021-06-29 Thread GitBox
stdpain commented on pull request #6120: URL: https://github.com/apache/incubator-doris/pull/6120#issuecomment-870554424 Is it a better way to provide a method such as ``` std::vector> Tablet::acquire_version_and_rowset() const { std::vector> res; ReadLock rdlock(&_meta_

[GitHub] [incubator-doris] xinyiZzz opened a new pull request #6121: [Feature] Support RuntimeFilter in Doris (FE Implement)

2021-06-29 Thread GitBox
xinyiZzz opened a new pull request #6121: URL: https://github.com/apache/incubator-doris/pull/6121 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature requ

[GitHub] [incubator-doris] morningman opened a new pull request #6122: [Doc] Provide precautions for jdk version switching in the compilation document

2021-06-29 Thread GitBox
morningman opened a new pull request #6122: URL: https://github.com/apache/incubator-doris/pull/6122 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature re

[GitHub] [incubator-doris] morningman commented on pull request #6120: [Bug] Add readlock when calling get_rowset_by_version()

2021-06-29 Thread GitBox
morningman commented on pull request #6120: URL: https://github.com/apache/incubator-doris/pull/6120#issuecomment-870734242 > ReadLock rdlock(&_meta_lock); > for (const auto& it : _rs_version_map) { > res.emplace_back(it.first, it.second); > } > return res;

[GitHub] [incubator-doris] morningman merged pull request #5787: [Metrics] Add tablet count on different status metrics

2021-06-29 Thread GitBox
morningman merged pull request #5787: URL: https://github.com/apache/incubator-doris/pull/5787 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: com

[incubator-doris] branch master updated: [Metrics] Add tablet count on different status metrics (#5787)

2021-06-29 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new e3899aa [Metrics] Add tablet count

[GitHub] [incubator-doris] morningman merged pull request #5915: fix ExportJob ErrorMsg is UNKNOWN when job cancelled cause by time out

2021-06-29 Thread GitBox
morningman merged pull request #5915: URL: https://github.com/apache/incubator-doris/pull/5915 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: com

[incubator-doris] branch master updated (e3899aa -> a475d3e)

2021-06-29 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from e3899aa [Metrics] Add tablet count on different status metrics (#5787) add a475d3e [Bug][Export]E

[incubator-doris] branch master updated (a475d3e -> 28e7d01)

2021-06-29 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from a475d3e [Bug][Export]ExportJob ErrorMsg is UNKNOWN when job cancelled cause by time out (#5915) a

[GitHub] [incubator-doris] morningman merged pull request #5934: [Feature]Support time interval for flink connector

2021-06-29 Thread GitBox
morningman merged pull request #5934: URL: https://github.com/apache/incubator-doris/pull/5934 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: com

[GitHub] [incubator-doris] morningman closed issue #5959: Support time interval for flink connector

2021-06-29 Thread GitBox
morningman closed issue #5959: URL: https://github.com/apache/incubator-doris/issues/5959 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-

[GitHub] [incubator-doris] morningman merged pull request #6036: [optimization] _Tuple_ptrs into mempool when RowBatch is initialized

2021-06-29 Thread GitBox
morningman merged pull request #6036: URL: https://github.com/apache/incubator-doris/pull/6036 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: com

[incubator-doris] branch master updated: [Optimize] Put _Tuple_ptrs into mempool when RowBatch is initialized (#6036)

2021-06-29 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new f254870 [Optimize] Put _Tuple_ptrs

[GitHub] [incubator-doris] morningman closed issue #6037: [Proposal] _Tuple_ptrs into mempool when RowBatch is initialized

2021-06-29 Thread GitBox
morningman closed issue #6037: URL: https://github.com/apache/incubator-doris/issues/6037 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-

[GitHub] [incubator-doris] morningman closed issue #6052: [Bug][Dynamic Partition] When two tables has the same name in different database, show dynamic partition tables return wrong result

2021-06-29 Thread GitBox
morningman closed issue #6052: URL: https://github.com/apache/incubator-doris/issues/6052 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-

[GitHub] [incubator-doris] morningman merged pull request #6053: [Bug] take table_id not table_name as key of runtimeInfo

2021-06-29 Thread GitBox
morningman merged pull request #6053: URL: https://github.com/apache/incubator-doris/pull/6053 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: com

[incubator-doris] branch master updated: [Bug][DynamicPartition] Take table_id as key of runtimeInfo (#6053)

2021-06-29 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new ce49fa5 [Bug][DynamicPartition] Ta

[incubator-doris] branch master updated: [Metrics] Add metrics for load average. (#6069)

2021-06-29 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 6441a4c [Metrics] Add metrics for

[GitHub] [incubator-doris] morningman closed issue #6068: Support load average metrics

2021-06-29 Thread GitBox
morningman closed issue #6068: URL: https://github.com/apache/incubator-doris/issues/6068 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-

[GitHub] [incubator-doris] morningman merged pull request #6069: [Metrics] Add metrics for load average.

2021-06-29 Thread GitBox
morningman merged pull request #6069: URL: https://github.com/apache/incubator-doris/pull/6069 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: com

[GitHub] [incubator-doris] harveyyue closed pull request #5996: [Bug] Create dynamic partition table failed with enable create_history_partition and not specify the start value

2021-06-29 Thread GitBox
harveyyue closed pull request #5996: URL: https://github.com/apache/incubator-doris/pull/5996 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: comm

[GitHub] [incubator-doris] harveyyue commented on pull request #5996: [Bug] Create dynamic partition table failed with enable create_history_partition and not specify the start value

2021-06-29 Thread GitBox
harveyyue commented on pull request #5996: URL: https://github.com/apache/incubator-doris/pull/5996#issuecomment-871034801 > Hi @harveyyue , thanks for your PR. > > > one more thing, i want to keep 100 partitions with set dynamic_partition.start=-100, and want to create 20 old partit

[GitHub] [incubator-doris] harveyyue removed a comment on pull request #5996: [Bug] Create dynamic partition table failed with enable create_history_partition and not specify the start value

2021-06-29 Thread GitBox
harveyyue removed a comment on pull request #5996: URL: https://github.com/apache/incubator-doris/pull/5996#issuecomment-871034801 > Hi @harveyyue , thanks for your PR. > > > one more thing, i want to keep 100 partitions with set dynamic_partition.start=-100, and want to create 20 ol

[incubator-doris] branch master updated: [Extension] Add DataX doriswriter extension directory (#6111)

2021-06-29 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new b69ebc3 [Extension] Add DataX dori

[GitHub] [incubator-doris] morningman merged pull request #6111: [Extension] Add DataX doriswriter extension directory

2021-06-29 Thread GitBox
morningman merged pull request #6111: URL: https://github.com/apache/incubator-doris/pull/6111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: com

[GitHub] [incubator-doris] morningman commented on pull request #6107: feat: Implementation Datax doriswriter plugin

2021-06-29 Thread GitBox
morningman commented on pull request #6107: URL: https://github.com/apache/incubator-doris/pull/6107#issuecomment-871038485 Hi @huzk8 ,this PR #6111 has been merged, please move the `doriswriter` dir to the `extension/DataX/doriswriter`. -- This is an automated message from the Apache Gi

[GitHub] [incubator-doris] morningman edited a comment on pull request #6107: feat: Implementation Datax doriswriter plugin

2021-06-29 Thread GitBox
morningman edited a comment on pull request #6107: URL: https://github.com/apache/incubator-doris/pull/6107#issuecomment-871038485 Hi @huzk8 ,this PR #6111 has been merged, please move the `doriswriter` dir to the `extension/DataX/doriswriter`. A little difference, it is `extension/DataX

[GitHub] [incubator-doris] Henry2SS commented on pull request #6092: [Feature] Add an indicator called errorRowsAfterResumed to distinguish between …

2021-06-29 Thread GitBox
Henry2SS commented on pull request #6092: URL: https://github.com/apache/incubator-doris/pull/6092#issuecomment-871039594 > Better refactor the statistic -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [incubator-doris] Henry2SS removed a comment on pull request #6092: [Feature] Add an indicator called errorRowsAfterResumed to distinguish between …

2021-06-29 Thread GitBox
Henry2SS removed a comment on pull request #6092: URL: https://github.com/apache/incubator-doris/pull/6092#issuecomment-871039594 > Better refactor the statistic -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-doris] Henry2SS closed pull request #6092: [Feature] Add an indicator called errorRowsAfterResumed to distinguish between …

2021-06-29 Thread GitBox
Henry2SS closed pull request #6092: URL: https://github.com/apache/incubator-doris/pull/6092 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commi

[GitHub] [incubator-doris] lqjack opened a new issue #6123: centos build be error

2021-06-29 Thread GitBox
lqjack opened a new issue #6123: URL: https://github.com/apache/incubator-doris/issues/6123 y-assignment; use assignment or value-initialization instead [-Wclass-memaccess] 131 | memset(_array, 0, sizeof(_array)); | ~~^~~

[GitHub] [incubator-doris] stdpain commented on issue #6123: centos build be error

2021-06-29 Thread GitBox
stdpain commented on issue #6123: URL: https://github.com/apache/incubator-doris/issues/6123#issuecomment-871054249 It looks like the link failed due to insufficient memory on the compiling machine You could try to increase your SWAP disk -- This is an automated message from the Apa

[GitHub] [incubator-doris] banjin opened a new issue #6124: pyflink已经 引入doris-flink-1.0-SNAPSHOT.jar 仍然报错

2021-06-29 Thread GitBox
banjin opened a new issue #6124: URL: https://github.com/apache/incubator-doris/issues/6124 Traceback (most recent call last): File "mysql_to_doris.py", line 142, in t_env.execute_sql(sql).wait() File "/Library/Python/3.7/site-packages/pyflink/table/table_environment.py",

[GitHub] [incubator-doris] morningman commented on a change in pull request #6117: Add update time to show table status

2021-06-29 Thread GitBox
morningman commented on a change in pull request #6117: URL: https://github.com/apache/incubator-doris/pull/6117#discussion_r661087822 ## File path: fe/fe-core/src/main/java/org/apache/doris/qe/ShowExecutor.java ## @@ -628,16 +630,50 @@ private void handleShowTableStatus() thro

[GitHub] [incubator-doris] BiteTheDDDDt opened a new issue #6125: document typo on CREATE TABLE.md

2021-06-29 Thread GitBox
BiteThet opened a new issue #6125: URL: https://github.com/apache/incubator-doris/issues/6125 I found a problem, resulting in an abnormal display on CREATE TABLE.md. ![图片](https://user-images.githubusercontent.com/7939630/123894640-14f4b980-d991-11eb-98e8-2c050588bf02.png) --

[GitHub] [incubator-doris] BiteTheDDDDt opened a new pull request #6126: typo fix on CREATE TABLE.md

2021-06-29 Thread GitBox
BiteThet opened a new pull request #6126: URL: https://github.com/apache/incubator-doris/pull/6126 ## Proposed changes I add a blank line , and remove some blank. ## Types of changes What types of changes does your code introduce to Doris? _Put an `x` in the boxes

[GitHub] [incubator-doris] lqjack commented on issue #6123: centos build be error

2021-06-29 Thread GitBox
lqjack commented on issue #6123: URL: https://github.com/apache/incubator-doris/issues/6123#issuecomment-871059628 docker update --memory 20g --memory-swap -1 858a683c2ac4 still same issue -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-doris] JNSimba commented on issue #6124: pyflink已经 引入doris-flink-1.0-SNAPSHOT.jar 仍然报错

2021-06-29 Thread GitBox
JNSimba commented on issue #6124: URL: https://github.com/apache/incubator-doris/issues/6124#issuecomment-871059880 It looks like the jar package conflicts,what is the flink version and scala version you are using? -- This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-doris] lqjack commented on issue #6123: centos build be error

2021-06-29 Thread GitBox
lqjack commented on issue #6123: URL: https://github.com/apache/incubator-doris/issues/6123#issuecomment-871060126 @stdpain thanks reply, Could you provide the link which download the Doris image ? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #6083: [Feature] Extract wide common factors

2021-06-29 Thread GitBox
EmmyMiao87 commented on a change in pull request #6083: URL: https://github.com/apache/incubator-doris/pull/6083#discussion_r661097089 ## File path: fe/fe-core/src/main/java/org/apache/doris/rewrite/ExprRewriter.java ## @@ -36,11 +37,17 @@ public class ExprRewriter { priv

[GitHub] [incubator-doris] Henry2SS commented on pull request #6092: [Feature] Add an indicator called errorRowsAfterResumed to distinguish between …

2021-06-29 Thread GitBox
Henry2SS commented on pull request #6092: URL: https://github.com/apache/incubator-doris/pull/6092#issuecomment-871062545 > Better refactor the statistic Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #6023: Support alter default bucket_num of table

2021-06-29 Thread GitBox
EmmyMiao87 commented on a change in pull request #6023: URL: https://github.com/apache/incubator-doris/pull/6023#discussion_r661098615 ## File path: fe/fe-core/src/main/java/org/apache/doris/catalog/Catalog.java ## @@ -5545,6 +5547,76 @@ public void replayModifyTableProperty(sh

[GitHub] [incubator-doris] banjin commented on issue #6124: pyflink已经 引入doris-flink-1.0-SNAPSHOT.jar 仍然报错

2021-06-29 Thread GitBox
banjin commented on issue #6124: URL: https://github.com/apache/incubator-doris/issues/6124#issuecomment-871065432 > It looks like the jar package conflicts,what is the flink version and scala version you are using? flink version: 1.13 scala version: 2.12 -- This i

[GitHub] [incubator-doris] banjin edited a comment on issue #6124: pyflink已经 引入doris-flink-1.0-SNAPSHOT.jar 仍然报错

2021-06-29 Thread GitBox
banjin edited a comment on issue #6124: URL: https://github.com/apache/incubator-doris/issues/6124#issuecomment-871065432 > It looks like the jar package conflicts,what is the flink version and scala version you are using? flink version: 1.13 scala version: 2.12 @J

[GitHub] [incubator-doris] EmmyMiao87 commented on pull request #5271: Update data-model-rollup.md

2021-06-29 Thread GitBox
EmmyMiao87 commented on pull request #5271: URL: https://github.com/apache/incubator-doris/pull/5271#issuecomment-871065809 Are you still working in this PR? @XKange -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [incubator-doris] qidaye opened a new issue #6127: [Bug] `show dynamic partition tables;` ReplicationNum is wrong

2021-06-29 Thread GitBox
qidaye opened a new issue #6127: URL: https://github.com/apache/incubator-doris/issues/6127 **Describe the bug** `show dynamic partition tables;` ReplicationNum of the result is wrong, it's always default (3). **To Reproduce** Steps to reproduce the behavior: 1. create dynam

[GitHub] [incubator-doris] qidaye opened a new pull request #6128: [Bug] fix `show dynamic partition tables;` replicationNum is wrong

2021-06-29 Thread GitBox
qidaye opened a new pull request #6128: URL: https://github.com/apache/incubator-doris/pull/6128 fix #6127 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolve

[GitHub] [incubator-doris] ucasFL commented on a change in pull request #6023: Support alter default bucket_num of table

2021-06-29 Thread GitBox
ucasFL commented on a change in pull request #6023: URL: https://github.com/apache/incubator-doris/pull/6023#discussion_r661113651 ## File path: fe/fe-core/src/main/java/org/apache/doris/analysis/ModifyDistributionClause.java ## @@ -0,0 +1,57 @@ +// Licensed to the Apache Soft

[GitHub] [incubator-doris] morningman commented on a change in pull request #6115: [Feature] Support data encrypt/decrypt

2021-06-29 Thread GitBox
morningman commented on a change in pull request #6115: URL: https://github.com/apache/incubator-doris/pull/6115#discussion_r661097875 ## File path: fe/fe-core/src/main/java/org/apache/doris/analysis/CreateEncryptKeyStmt.java ## @@ -0,0 +1,65 @@ +// Licensed to the Apache Soft

[GitHub] [incubator-doris] JNSimba edited a comment on issue #6118: flink doris connector 支持flink 1.13.0吗?

2021-06-29 Thread GitBox
JNSimba edited a comment on issue #6118: URL: https://github.com/apache/incubator-doris/issues/6118#issuecomment-870501315 support datastream now , flink sql 1.13 will be updated soon -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] JNSimba commented on issue #6124: pyflink已经 引入doris-flink-1.0-SNAPSHOT.jar 仍然报错

2021-06-29 Thread GitBox
JNSimba commented on issue #6124: URL: https://github.com/apache/incubator-doris/issues/6124#issuecomment-871083896 flink-doris-connector version may need to be upgraded, It is currently possible to access doris through datastream. -- This is an automated message from the Apache Git Se

[GitHub] [incubator-doris] JNSimba edited a comment on issue #6124: pyflink已经 引入doris-flink-1.0-SNAPSHOT.jar 仍然报错

2021-06-29 Thread GitBox
JNSimba edited a comment on issue #6124: URL: https://github.com/apache/incubator-doris/issues/6124#issuecomment-871083896 The flink1.13.0 **DynamicTableFactory** part has been updated,flink-doris-connector version may need to be upgraded, It is currently possible to access doris through

[GitHub] [incubator-doris] morningman commented on a change in pull request #6079: [refactor] Remove decimal v1 related code from code base

2021-06-29 Thread GitBox
morningman commented on a change in pull request #6079: URL: https://github.com/apache/incubator-doris/pull/6079#discussion_r661123903 ## File path: fe/fe-core/src/main/java/org/apache/doris/catalog/ColumnType.java ## @@ -115,7 +114,8 @@ public static void write(DataOutput out,

[GitHub] [incubator-doris] morningman commented on a change in pull request #6092: [Feature] Add an indicator called errorRowsAfterResumed to distinguish between …

2021-06-29 Thread GitBox
morningman commented on a change in pull request #6092: URL: https://github.com/apache/incubator-doris/pull/6092#discussion_r661125837 ## File path: fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadJob.java ## @@ -1436,15 +1420,20 @@ public void write(Data

[GitHub] [incubator-doris] morningman commented on a change in pull request #6114: fix bug on colocate agg (name error)

2021-06-29 Thread GitBox
morningman commented on a change in pull request #6114: URL: https://github.com/apache/incubator-doris/pull/6114#discussion_r661128958 ## File path: fe/fe-core/src/test/java/org/apache/doris/planner/QueryPlanTest.java ## @@ -1360,6 +1376,32 @@ public void testAggregateSatisfyOl

[GitHub] [incubator-doris] harveyyue opened a new pull request #6129: [Bug] Create dynamic partition table failed with enable create_history_partition and not specify the start value

2021-06-29 Thread GitBox
harveyyue opened a new pull request #6129: URL: https://github.com/apache/incubator-doris/pull/6129 fix the issue #5995 Add the property "dynamic_partition.history_partition_num" to specify the history partition number when enable create_history_partition to fix the invalid date format

[GitHub] [incubator-doris] harveyyue commented on pull request #5996: [Bug] Create dynamic partition table failed with enable create_history_partition and not specify the start value

2021-06-29 Thread GitBox
harveyyue commented on pull request #5996: URL: https://github.com/apache/incubator-doris/pull/5996#issuecomment-871096649 hi @qidaye I have completed these code changes according your suggestion, I use "git rebase" to merge these two commits to one, and resubmit the following pr. Plea

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #6079: [refactor] Remove decimal v1 related code from code base

2021-06-29 Thread GitBox
yangzhg commented on a change in pull request #6079: URL: https://github.com/apache/incubator-doris/pull/6079#discussion_r661137202 ## File path: be/src/exprs/expr_context.cpp ## @@ -202,25 +202,6 @@ void ExprContext::get_value(TupleRow* row, bool as_ascii, TColumnValue* col_v

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #6079: [refactor] Remove decimal v1 related code from code base

2021-06-29 Thread GitBox
yangzhg commented on a change in pull request #6079: URL: https://github.com/apache/incubator-doris/pull/6079#discussion_r661137475 ## File path: gensrc/thrift/Types.thrift ## @@ -66,7 +66,7 @@ enum TPrimitiveType { DATE, DATETIME, BINARY, - DECIMAL, + DECIMAL_DEPRAC

[GitHub] [incubator-doris] qidaye commented on pull request #5996: [Bug] Create dynamic partition table failed with enable create_history_partition and not specify the start value

2021-06-29 Thread GitBox
qidaye commented on pull request #5996: URL: https://github.com/apache/incubator-doris/pull/5996#issuecomment-871116423 > hi @qidaye > I have completed these code changes according your suggestion, I use "git rebase" to merge these two commits to one, and resubmit the following pr. Plea

[GitHub] [incubator-doris] BiteTheDDDDt opened a new issue #6130: safety problem about machine name and accesskey

2021-06-29 Thread GitBox
BiteThet opened a new issue #6130: URL: https://github.com/apache/incubator-doris/issues/6130 I received a safety issue ticket from the company. machine name leak: * incubator-doris/blob/master/fe/fe-core/src/test/java/org/apache/doris/backup/BrokerStorageTest.java > xa

[GitHub] [incubator-doris] morningman commented on pull request #6013: Spring boot http upload file maximum limit parameterization

2021-06-29 Thread GitBox
morningman commented on pull request #6013: URL: https://github.com/apache/incubator-doris/pull/6013#issuecomment-871121767 > @morningman @hf200012 > Using StreamLoad to upload large files of 3-7GB will report a "connection reset" error. Will this patch fix this problem? No, not r

[GitHub] [incubator-doris] Userwhite commented on a change in pull request #6114: fix bug on colocate agg (name error)

2021-06-29 Thread GitBox
Userwhite commented on a change in pull request #6114: URL: https://github.com/apache/incubator-doris/pull/6114#discussion_r661155984 ## File path: fe/fe-core/src/test/java/org/apache/doris/planner/QueryPlanTest.java ## @@ -1360,6 +1376,32 @@ public void testAggregateSatisfyOla

[GitHub] [incubator-doris] BiteTheDDDDt opened a new pull request #6131: [refactor] fix machine_name&accesskey leak

2021-06-29 Thread GitBox
BiteThet opened a new pull request #6131: URL: https://github.com/apache/incubator-doris/pull/6131 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature

[GitHub] [incubator-doris] Henry2SS commented on a change in pull request #6092: [Feature] Add an indicator called errorRowsAfterResumed to distinguish between …

2021-06-29 Thread GitBox
Henry2SS commented on a change in pull request #6092: URL: https://github.com/apache/incubator-doris/pull/6092#discussion_r661176013 ## File path: fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadJob.java ## @@ -1436,15 +1420,20 @@ public void write(DataOu

[GitHub] [incubator-doris] Henry2SS commented on a change in pull request #6092: [Feature] Add an indicator called errorRowsAfterResumed to distinguish between …

2021-06-29 Thread GitBox
Henry2SS commented on a change in pull request #6092: URL: https://github.com/apache/incubator-doris/pull/6092#discussion_r661176013 ## File path: fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadJob.java ## @@ -1436,15 +1420,20 @@ public void write(DataOu