[GitHub] [incubator-doris] morningman commented on a change in pull request #4401: [Bug-Fix] Some deleted tablets are not recycled on BE

2020-08-23 Thread GitBox
morningman commented on a change in pull request #4401: URL: https://github.com/apache/incubator-doris/pull/4401#discussion_r475222531 ## File path: be/src/olap/tablet_manager.cpp ## @@ -1086,6 +1094,52 @@ OLAPStatus TabletManager::start_trash_sweep() { return OLAP_SUCCESS

[GitHub] [incubator-doris] morningman closed issue #4420: [Bug] CORE in debug mode Memtracker DECHECK, when use sort node

2020-08-23 Thread GitBox
morningman closed issue #4420: URL: https://github.com/apache/incubator-doris/issues/4420 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-doris] morningman merged pull request #4421: [MemTracker][Bug-Fix] Fix core in DECHECK in memory tracker

2020-08-23 Thread GitBox
morningman merged pull request #4421: URL: https://github.com/apache/incubator-doris/pull/4421 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[incubator-doris] branch master updated: [MemTracker][Bug-Fix] Fix core in DECHECK in memory tracker (#4421)

2020-08-23 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 5fc7956 [MemTracker][Bug-Fix] Fix

[GitHub] [incubator-doris] xinghuayu007 opened a new pull request #4429: Parse url bug

2020-08-23 Thread GitBox
xinghuayu007 opened a new pull request #4429: URL: https://github.com/apache/incubator-doris/pull/4429 ## Proposed changes The parameter 'part' of parse_url function does not support lower case, and parse protocol not right. And This function does not support parse 'port'. This PR t

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #4005: LRU cache for sql/partition cache #2581

2020-08-23 Thread GitBox
wuyunfeng commented on a change in pull request #4005: URL: https://github.com/apache/incubator-doris/pull/4005#discussion_r475302348 ## File path: be/src/common/config.h ## @@ -570,6 +570,16 @@ namespace config { // Soft memory limit as a fraction of hard memory limit.

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #4425: Support batch delete[part 2]

2020-08-23 Thread GitBox
yangzhg commented on a change in pull request #4425: URL: https://github.com/apache/incubator-doris/pull/4425#discussion_r475302606 ## File path: be/src/olap/field.h ## @@ -535,4 +535,4 @@ class FieldFactory { } // namespace doris -#endif // DORIS_BE_SRC_OLAP_FIELD_H +#en

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #4005: LRU cache for sql/partition cache #2581

2020-08-23 Thread GitBox
wuyunfeng commented on a change in pull request #4005: URL: https://github.com/apache/incubator-doris/pull/4005#discussion_r475302348 ## File path: be/src/common/config.h ## @@ -570,6 +570,16 @@ namespace config { // Soft memory limit as a fraction of hard memory limit.

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #4425: Support batch delete[part 2]

2020-08-23 Thread GitBox
yangzhg commented on a change in pull request #4425: URL: https://github.com/apache/incubator-doris/pull/4425#discussion_r475303849 ## File path: be/src/olap/row_cursor.h ## @@ -109,6 +109,14 @@ class RowCursor { return column_schema(index)->index_size(); } +

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #4425: Support batch delete[part 2]

2020-08-23 Thread GitBox
yangzhg commented on a change in pull request #4425: URL: https://github.com/apache/incubator-doris/pull/4425#discussion_r475303962 ## File path: be/src/olap/schema.h ## @@ -158,4 +158,4 @@ class Schema { int32_t _delete_sign_idx = -1; }; -} // namespace doris +} // nam

[GitHub] [incubator-doris] morningman commented on pull request #4387: [SegmentV2] Change the default storage format to SegmentV2

2020-08-23 Thread GitBox
morningman commented on pull request #4387: URL: https://github.com/apache/incubator-doris/pull/4387#issuecomment-678880183 > > > Why not change the default value of config `default_rowset_type` in `common/config.h` to `BETA` > > > > > > Modifying this config will cause BE to aut

[GitHub] [incubator-doris] morningman commented on pull request #4387: [SegmentV2] Change the default storage format to SegmentV2

2020-08-23 Thread GitBox
morningman commented on pull request #4387: URL: https://github.com/apache/incubator-doris/pull/4387#issuecomment-678889358 > Should we remove the config of storage format in BE? Can not. Because some user already use it. -

[GitHub] [incubator-doris] HappenLee opened a new pull request #4430: [ODBC SCAN NODE] 3/4 Add ODBC_TABLE and ODBC_SCAN NODE in FE.

2020-08-23 Thread GitBox
HappenLee opened a new pull request #4430: URL: https://github.com/apache/incubator-doris/pull/4430 we can create odbc_table use SQL like ``` CREATE EXTERNAL TABLE `baseall_oracle` ( `k1` decimal(9, 3) NOT NULL COMMENT "", `k2` char(10) NOT NULL COMMENT "", `k3` date