[GitHub] [incubator-doris] caiconghui commented on issue #2254: Fix bug for showing columns from non exist table doesn't prompt error

2019-11-19 Thread GitBox
caiconghui commented on issue #2254: Fix bug for showing columns from non exist table doesn't prompt error URL: https://github.com/apache/incubator-doris/pull/2254#issuecomment-555843147 #2255 This is an automated message fr

[GitHub] [incubator-doris] caiconghui commented on issue #2242: Is that will be better create table with column default enable to be null?

2019-11-19 Thread GitBox
caiconghui commented on issue #2242: Is that will be better create table with column default enable to be null? URL: https://github.com/apache/incubator-doris/issues/2242#issuecomment-555848830 @imay is it ok for table with nullable key ?? MySQL [doris_test]> show columns from doris_tes

[GitHub] [incubator-doris] imay merged pull request #2050: segment_v2: Support bitmap index build

2019-11-19 Thread GitBox
imay merged pull request #2050: segment_v2: Support bitmap index build URL: https://github.com/apache/incubator-doris/pull/2050 This is an automated message from the Apache Git Service. To respond to the message, please log o

[incubator-doris] branch master updated (aedccc4 -> d72fbdf)

2019-11-19 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from aedccc4 fix npe for null stats (#2253) add d72fbdf Support bitmap index build (#2050) No new revision

[GitHub] [incubator-doris] caiconghui commented on issue #2242: Is that will be better create table with column default enable to be null?

2019-11-19 Thread GitBox
caiconghui commented on issue #2242: Is that will be better create table with column default enable to be null? URL: https://github.com/apache/incubator-doris/issues/2242#issuecomment-555850786 or it will be better nullable default for normal column and not nullable default for key column

[GitHub] [incubator-doris] imay commented on a change in pull request #2254: Fix bug for showing columns from non exist table doesn't prompt error

2019-11-19 Thread GitBox
imay commented on a change in pull request #2254: Fix bug for showing columns from non exist table doesn't prompt error URL: https://github.com/apache/incubator-doris/pull/2254#discussion_r348303308 ## File path: fe/src/main/java/org/apache/doris/qe/ShowExecutor.java ## @@

[GitHub] [incubator-doris] imay commented on issue #2242: Is that will be better create table with column default enable to be null?

2019-11-19 Thread GitBox
imay commented on issue #2242: Is that will be better create table with column default enable to be null? URL: https://github.com/apache/incubator-doris/issues/2242#issuecomment-555854684 @caiconghui Now we have no restrict on key columns and value columns. So it is OK to make all

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #2252: Add pipes_as_concat_mode

2019-11-19 Thread GitBox
EmmyMiao87 commented on a change in pull request #2252: Add pipes_as_concat_mode URL: https://github.com/apache/incubator-doris/pull/2252#discussion_r348306895 ## File path: fe/src/main/jflex/sql_scanner.flex ## @@ -352,7 +352,7 @@ import org.apache.doris.common.util.SqlUti

[GitHub] [incubator-doris] vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension

2019-11-19 Thread GitBox
vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348316710 ## File path: extension/spark-doris-connector/pom.xml ## @@ -0,0 +1,162 @@ + Review comment: don

[GitHub] [incubator-doris] vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension

2019-11-19 Thread GitBox
vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348317170 ## File path: extension/spark-doris-connector/README.md ## @@ -0,0 +1,126 @@ +# Spark-Doris-Connector

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension

2019-11-19 Thread GitBox
wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348317327 ## File path: extension/spark-doris-connector/README.md ## @@ -0,0 +1,126 @@ +# Spark-Doris-Connector

[GitHub] [incubator-doris] xy720 commented on a change in pull request #2252: Add pipes_as_concat_mode

2019-11-19 Thread GitBox
xy720 commented on a change in pull request #2252: Add pipes_as_concat_mode URL: https://github.com/apache/incubator-doris/pull/2252#discussion_r348318076 ## File path: fe/src/main/jflex/sql_scanner.flex ## @@ -352,7 +352,7 @@ import org.apache.doris.common.util.SqlUtils;

[GitHub] [incubator-doris] xy720 commented on a change in pull request #2252: Add pipes_as_concat_mode

2019-11-19 Thread GitBox
xy720 commented on a change in pull request #2252: Add pipes_as_concat_mode URL: https://github.com/apache/incubator-doris/pull/2252#discussion_r348318076 ## File path: fe/src/main/jflex/sql_scanner.flex ## @@ -352,7 +352,7 @@ import org.apache.doris.common.util.SqlUtils;

[GitHub] [incubator-doris] vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension

2019-11-19 Thread GitBox
vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348324265 ## File path: extension/spark-doris-connector/README.md ## @@ -0,0 +1,126 @@ +# Spark-Doris-Connector

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension

2019-11-19 Thread GitBox
wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348326095 ## File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/serialization/RowBatch.java

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension

2019-11-19 Thread GitBox
wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348327555 ## File path: extension/spark-doris-connector/README.md ## @@ -0,0 +1,126 @@ +# Spark-Doris-Connector

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension

2019-11-19 Thread GitBox
wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348331072 ## File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java ##

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension

2019-11-19 Thread GitBox
wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348331947 ## File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java ##

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension

2019-11-19 Thread GitBox
wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348327831 ## File path: extension/spark-doris-connector/README.md ## @@ -0,0 +1,126 @@ +# Spark-Doris-Connector

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension

2019-11-19 Thread GitBox
wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348328880 ## File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/cfg/ConfigurationOptions.java

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension

2019-11-19 Thread GitBox
wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348328096 ## File path: extension/spark-doris-connector/README.md ## @@ -0,0 +1,126 @@ +# Spark-Doris-Connector

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension

2019-11-19 Thread GitBox
wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348328510 ## File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/backend/BackendClient.java #

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension

2019-11-19 Thread GitBox
wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348330926 ## File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java ##

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension

2019-11-19 Thread GitBox
wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348330174 ## File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java ##

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension

2019-11-19 Thread GitBox
wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348330380 ## File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java ##

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension

2019-11-19 Thread GitBox
wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348329350 ## File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java ##

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension

2019-11-19 Thread GitBox
wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348330642 ## File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java ##

[GitHub] [incubator-doris] vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension

2019-11-19 Thread GitBox
vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348332359 ## File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/serialization/RowBatch.java

[GitHub] [incubator-doris] caiconghui opened a new pull request #2256: Create table with nullable column for default

2019-11-19 Thread GitBox
caiconghui opened a new pull request #2256: Create table with nullable column for default URL: https://github.com/apache/incubator-doris/pull/2256 on production enviroment, create table usually with so many nullable columns,so default nullable for column will be better ---

[GitHub] [incubator-doris] caiconghui commented on issue #2256: Create table with nullable column for default

2019-11-19 Thread GitBox
caiconghui commented on issue #2256: Create table with nullable column for default URL: https://github.com/apache/incubator-doris/pull/2256#issuecomment-555884900 #2242 This is an automated message from the Apache Git Servic

<    1   2