Re: [PR] reserve bock in scanner [doris]

2024-11-19 Thread via GitHub
yiguolei merged PR #44185: URL: https://github.com/apache/doris/pull/44185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

Re: [PR] reserve bock in scanner [doris]

2024-11-19 Thread via GitHub
github-actions[bot] commented on PR #44185: URL: https://github.com/apache/doris/pull/44185#issuecomment-2485296977 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] reserve bock in scanner [doris]

2024-11-19 Thread via GitHub
yiguolei commented on code in PR #44185: URL: https://github.com/apache/doris/pull/44185#discussion_r1848049121 ## fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java: ## @@ -3863,9 +3839,8 @@ public TQueryOptions toThrift() { tResult.setParallelScanMinRo

Re: [PR] reserve bock in scanner [doris]

2024-11-19 Thread via GitHub
yiguolei commented on code in PR #44185: URL: https://github.com/apache/doris/pull/44185#discussion_r1848054901 ## be/src/pipeline/exec/streaming_aggregation_operator.cpp: ## @@ -1154,7 +1154,7 @@ Status StreamingAggOperatorX::init(const TPlanNode& tnode, RuntimeState* state)

Re: [PR] reserve bock in scanner [doris]

2024-11-19 Thread via GitHub
yiguolei commented on code in PR #44185: URL: https://github.com/apache/doris/pull/44185#discussion_r1848048317 ## gensrc/thrift/PaloInternalService.thrift: ## @@ -356,6 +359,11 @@ struct TQueryOptions { 139: optional i32 query_slot_count = 0; 140: optional bool enable_a

Re: [PR] reserve bock in scanner [doris]

2024-11-19 Thread via GitHub
github-actions[bot] commented on PR #44185: URL: https://github.com/apache/doris/pull/44185#issuecomment-2485228877 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] reserve bock in scanner [doris]

2024-11-19 Thread via GitHub
jacktengg commented on code in PR #44185: URL: https://github.com/apache/doris/pull/44185#discussion_r1847893805 ## be/src/vec/spill/spill_stream.cpp: ## @@ -116,7 +116,9 @@ Status SpillStream::prepare() { } SpillReaderUPtr SpillStream::create_separate_reader() const { -

Re: [PR] reserve bock in scanner [doris]

2024-11-19 Thread via GitHub
github-actions[bot] commented on PR #44185: URL: https://github.com/apache/doris/pull/44185#issuecomment-2485047387 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] reserve bock in scanner [doris]

2024-11-19 Thread via GitHub
yiguolei commented on code in PR #44185: URL: https://github.com/apache/doris/pull/44185#discussion_r1847893154 ## be/src/vec/spill/spill_stream.cpp: ## @@ -116,7 +116,9 @@ Status SpillStream::prepare() { } SpillReaderUPtr SpillStream::create_separate_reader() const { -r

Re: [PR] reserve bock in scanner [doris]

2024-11-19 Thread via GitHub
yiguolei commented on code in PR #44185: URL: https://github.com/apache/doris/pull/44185#discussion_r1847892033 ## fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java: ## @@ -2132,6 +2133,14 @@ public void setIgnoreShapePlanNodes(String ignoreShapePlanNodes) {

Re: [PR] reserve bock in scanner [doris]

2024-11-18 Thread via GitHub
doris-robot commented on PR #44185: URL: https://github.com/apache/doris/pull/44185#issuecomment-2482499610 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+proce

Re: [PR] reserve bock in scanner [doris]

2024-11-18 Thread via GitHub
yiguolei commented on code in PR #44185: URL: https://github.com/apache/doris/pull/44185#discussion_r1846265896 ## be/src/vec/exec/scan/scanner_context.cpp: ## @@ -232,9 +232,21 @@ vectorized::BlockUPtr ScannerContext::get_free_block(bool force) { // The caller of get_

Re: [PR] reserve bock in scanner [doris]

2024-11-18 Thread via GitHub
github-actions[bot] commented on PR #44185: URL: https://github.com/apache/doris/pull/44185#issuecomment-2483488984 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] reserve bock in scanner [doris]

2024-11-18 Thread via GitHub
yiguolei commented on code in PR #44185: URL: https://github.com/apache/doris/pull/44185#discussion_r1846265896 ## be/src/vec/exec/scan/scanner_context.cpp: ## @@ -232,9 +232,21 @@ vectorized::BlockUPtr ScannerContext::get_free_block(bool force) { // The caller of get_

Re: [PR] reserve bock in scanner [doris]

2024-11-18 Thread via GitHub
github-actions[bot] commented on PR #44185: URL: https://github.com/apache/doris/pull/44185#issuecomment-2482516669 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL