w41ter merged PR #44997:
URL: https://github.com/apache/doris/pull/44997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apach
github-actions[bot] commented on PR #44997:
URL: https://github.com/apache/doris/pull/44997#issuecomment-2538315680
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
wyxxxcat commented on PR #44997:
URL: https://github.com/apache/doris/pull/44997#issuecomment-2538128010
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
wyxxxcat commented on PR #44997:
URL: https://github.com/apache/doris/pull/44997#issuecomment-2538127612
run build all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
wyxxxcat commented on PR #44997:
URL: https://github.com/apache/doris/pull/44997#issuecomment-2537925168
> please update
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/info/DefaultValue.java
for nereids, too
my suggestion is to deal with it separately
--
Th
wyxxxcat commented on code in PR #44997:
URL: https://github.com/apache/doris/pull/44997#discussion_r1881345082
##
fe/fe-core/src/main/java/org/apache/doris/analysis/ColumnDef.java:
##
@@ -680,7 +670,22 @@ public String toSql() {
}
if (defaultValue.isSet) {
-
wyxxxcat commented on PR #44997:
URL: https://github.com/apache/doris/pull/44997#issuecomment-2537755267
> please update
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/info/DefaultValue.java
for nereids, too
get
--
This is an automated message from the Apac
starocean999 commented on PR #44997:
URL: https://github.com/apache/doris/pull/44997#issuecomment-2537603453
please update
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/info/DefaultValue.java
for nereids, too
--
This is an automated message from the Apache Git Se
starocean999 commented on code in PR #44997:
URL: https://github.com/apache/doris/pull/44997#discussion_r1880310713
##
fe/fe-core/src/main/java/org/apache/doris/analysis/ColumnDef.java:
##
@@ -680,7 +670,22 @@ public String toSql() {
}
if (defaultValue.isSet)
github-actions[bot] commented on PR #44997:
URL: https://github.com/apache/doris/pull/44997#issuecomment-2535071791
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
github-actions[bot] commented on PR #44997:
URL: https://github.com/apache/doris/pull/44997#issuecomment-2535071279
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
wyxxxcat commented on PR #44997:
URL: https://github.com/apache/doris/pull/44997#issuecomment-2534094076
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
doris-robot commented on PR #44997:
URL: https://github.com/apache/doris/pull/44997#issuecomment-2533797259
ClickBench: Total hot run time: 32.65 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #44997:
URL: https://github.com/apache/doris/pull/44997#issuecomment-2533783402
TPC-DS: Total hot run time: 197170 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #44997:
URL: https://github.com/apache/doris/pull/44997#issuecomment-2533767442
TPC-H: Total hot run time: 39826 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
wyxxxcat commented on PR #44997:
URL: https://github.com/apache/doris/pull/44997#issuecomment-2533716048
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
doris-robot commented on PR #44997:
URL: https://github.com/apache/doris/pull/44997#issuecomment-2533499337
TPC-DS: Total hot run time: 197010 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
wyxxxcat commented on PR #44997:
URL: https://github.com/apache/doris/pull/44997#issuecomment-2533549118
run build all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
doris-robot commented on PR #44997:
URL: https://github.com/apache/doris/pull/44997#issuecomment-2533504295
ClickBench: Total hot run time: 32.84 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #44997:
URL: https://github.com/apache/doris/pull/44997#issuecomment-2533482486
TPC-H: Total hot run time: 39836 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
wyxxxcat commented on PR #44997:
URL: https://github.com/apache/doris/pull/44997#issuecomment-2533461778
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
wyxxxcat commented on PR #44997:
URL: https://github.com/apache/doris/pull/44997#issuecomment-2533460551
run build all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
wyxxxcat commented on PR #44997:
URL: https://github.com/apache/doris/pull/44997#issuecomment-2531126920
run fe-ut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
w41ter commented on PR #44997:
URL: https://github.com/apache/doris/pull/44997#issuecomment-2526769748
> @wyxxxcat please add some unit tests.
You can refer https://github.com/apache/doris/pull/41205/files
--
This is an automated message from the Apache Git Service.
To respond to th
w41ter commented on PR #44997:
URL: https://github.com/apache/doris/pull/44997#issuecomment-2526741291
@wyxxxcat please add some unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
w41ter commented on PR #44997:
URL: https://github.com/apache/doris/pull/44997#issuecomment-2522055105
> same as #44958 it is better to escape value
This PR aims to fix `dt DATETIME DEFAULT "CURRENT_TIMESTAMP"`, the correct
syntax is `dt DATETIME DEFAULT CURRENT_TIMESTAMP`.
--
26 matches
Mail list logo
