Re: [PR] [fix](be) Make DorisCallOnce's function exception-safe [doris]

2023-10-22 Thread via GitHub
dataroaring merged PR #25755: URL: https://github.com/apache/doris/pull/25755 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

Re: [PR] [fix](be) Make DorisCallOnce's function exception-safe [doris]

2023-10-22 Thread via GitHub
github-actions[bot] commented on PR #25755: URL: https://github.com/apache/doris/pull/25755#issuecomment-1774517090 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](be) Make DorisCallOnce's function exception-safe [doris]

2023-10-22 Thread via GitHub
Xiaoccer commented on PR #25755: URL: https://github.com/apache/doris/pull/25755#issuecomment-1774508956 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](be) Make DorisCallOnce's function exception-safe [doris]

2023-10-18 Thread via GitHub
dataroaring merged PR #25579: URL: https://github.com/apache/doris/pull/25579 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

Re: [PR] [fix](be) Make DorisCallOnce's function exception-safe [doris]

2023-10-18 Thread via GitHub
doris-robot commented on PR #25579: URL: https://github.com/apache/doris/pull/25579#issuecomment-1768030320 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.42 seconds stream load tsv: 554 seconds loaded 74807831229 Bytes,

Re: [PR] [fix](be) Make DorisCallOnce's function exception-safe [doris]

2023-10-18 Thread via GitHub
doris-robot commented on PR #25579: URL: https://github.com/apache/doris/pull/25579#issuecomment-176803 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.79 seconds stream load tsv: 554 seconds loaded 74807831229 Bytes,

Re: [PR] [fix](be) Make DorisCallOnce's function exception-safe [doris]

2023-10-18 Thread via GitHub
doris-robot commented on PR #25579: URL: https://github.com/apache/doris/pull/25579#issuecomment-1768031596 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.57 seconds stream load tsv: 552 seconds loaded 74807831229 Bytes,

Re: [PR] [fix](be) Make DorisCallOnce's function exception-safe [doris]

2023-10-18 Thread via GitHub
doris-robot commented on PR #25579: URL: https://github.com/apache/doris/pull/25579#issuecomment-1767994949 TeamCity be ut coverage result: Function Coverage: 37.03% (8286/22376) Line Coverage: 29.09% (66443/228383) Region Coverage: 27.75% (34488/124287) Branch Coverage: 24.3

Re: [PR] [fix](be) Make DorisCallOnce's function exception-safe [doris]

2023-10-18 Thread via GitHub
doris-robot commented on PR #25579: URL: https://github.com/apache/doris/pull/25579#issuecomment-1767994508 TeamCity be ut coverage result: Function Coverage: 37.02% (8284/22376) Line Coverage: 29.08% (66422/228383) Region Coverage: 27.74% (34472/124287) Branch Coverage: 24.3

Re: [PR] [fix](be) Make DorisCallOnce's function exception-safe [doris]

2023-10-18 Thread via GitHub
doris-robot commented on PR #25579: URL: https://github.com/apache/doris/pull/25579#issuecomment-1767993964 TeamCity be ut coverage result: Function Coverage: 37.03% (8286/22376) Line Coverage: 29.09% (66445/228383) Region Coverage: 27.74% (34479/124287) Branch Coverage: 24.3

Re: [PR] [fix](be) Make DorisCallOnce's function exception-safe [doris]

2023-10-18 Thread via GitHub
github-actions[bot] commented on PR #25579: URL: https://github.com/apache/doris/pull/25579#issuecomment-1767985957 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](be) Make DorisCallOnce's function exception-safe [doris]

2023-10-18 Thread via GitHub
github-actions[bot] commented on PR #25579: URL: https://github.com/apache/doris/pull/25579#issuecomment-1767985850 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](be) Make DorisCallOnce's function exception-safe [doris]

2023-10-18 Thread via GitHub
github-actions[bot] commented on PR #25579: URL: https://github.com/apache/doris/pull/25579#issuecomment-1767947251 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](be) Make DorisCallOnce's function exception-safe [doris]

2023-10-18 Thread via GitHub
github-actions[bot] commented on PR #25579: URL: https://github.com/apache/doris/pull/25579#issuecomment-1767937884 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](be) Make DorisCallOnce's function exception-safe [doris]

2023-10-18 Thread via GitHub
github-actions[bot] commented on PR #25579: URL: https://github.com/apache/doris/pull/25579#issuecomment-1767934951 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](be) Make DorisCallOnce's function exception-safe [doris]

2023-10-18 Thread via GitHub
Xiaoccer commented on PR #25579: URL: https://github.com/apache/doris/pull/25579#issuecomment-1767927880 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](be) Make DorisCallOnce's function exception-safe [doris]

2023-10-18 Thread via GitHub
Xiaoccer commented on PR #25579: URL: https://github.com/apache/doris/pull/25579#issuecomment-1767920620 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](be) Make DorisCallOnce's function exception-safe [doris]

2023-10-18 Thread via GitHub
Xiaoccer commented on PR #25579: URL: https://github.com/apache/doris/pull/25579#issuecomment-1767917620 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](be) Make DorisCallOnce's function exception-safe [doris]

2023-10-18 Thread via GitHub
github-actions[bot] commented on PR #25579: URL: https://github.com/apache/doris/pull/25579#issuecomment-1767893141 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](be) Make DorisCallOnce's function exception-safe [doris]

2023-10-18 Thread via GitHub
gavinchou commented on code in PR #25579: URL: https://github.com/apache/doris/pull/25579#discussion_r1363414675 ## be/src/olap/rowset/segment_v2/segment.cpp: ## @@ -233,12 +233,25 @@ Status Segment::_load_pk_bloom_filter() { DCHECK(_tablet_schema->keys_type() == UNIQUE_KEY

Re: [PR] [fix](be) Make DorisCallOnce's function exception-safe [doris]

2023-10-18 Thread via GitHub
gavinchou commented on code in PR #25579: URL: https://github.com/apache/doris/pull/25579#discussion_r1363413379 ## be/src/olap/rowset/segment_v2/segment.cpp: ## @@ -247,39 +260,45 @@ Status Segment::load_pk_index_and_bf() { return Status::OK(); } Status Segment::load_ind

Re: [PR] [fix](be) Make DorisCallOnce's function exception-safe [doris]

2023-10-18 Thread via GitHub
gavinchou commented on code in PR #25579: URL: https://github.com/apache/doris/pull/25579#discussion_r1363408789 ## be/src/olap/rowset/segment_v2/segment.cpp: ## @@ -247,39 +260,45 @@ Status Segment::load_pk_index_and_bf() { return Status::OK(); } Status Segment::load_ind

Re: [PR] [fix](be) Make DorisCallOnce's function exception-safe [doris]

2023-10-18 Thread via GitHub
gavinchou commented on code in PR #25579: URL: https://github.com/apache/doris/pull/25579#discussion_r1363407035 ## be/src/olap/rowset/segment_v2/segment_iterator.cpp: ## @@ -211,6 +211,14 @@ SegmentIterator::SegmentIterator(std::shared_ptr segment, SchemaSPtr sc _po

Re: [PR] [fix](be) Make DorisCallOnce's function exception-safe [doris]

2023-10-18 Thread via GitHub
github-actions[bot] commented on PR #25579: URL: https://github.com/apache/doris/pull/25579#issuecomment-1767878956 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](be) Make DorisCallOnce's function exception-safe [doris]

2023-10-18 Thread via GitHub
github-actions[bot] commented on PR #25579: URL: https://github.com/apache/doris/pull/25579#issuecomment-1767872404 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL