morningman merged PR #35812:
URL: https://github.com/apache/doris/pull/35812
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.a
AshinGau commented on PR #35812:
URL: https://github.com/apache/doris/pull/35812#issuecomment-2144880582
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
doris-robot commented on PR #35812:
URL: https://github.com/apache/doris/pull/35812#issuecomment-2144880377
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y
morrySnow merged PR #34681:
URL: https://github.com/apache/doris/pull/34681
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.ap
github-actions[bot] commented on PR #34681:
URL: https://github.com/apache/doris/pull/34681#issuecomment-2126206590
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
wuwenchi commented on PR #34681:
URL: https://github.com/apache/doris/pull/34681#issuecomment-2126174977
LGTM 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
doris-robot commented on PR #34681:
URL: https://github.com/apache/doris/pull/34681#issuecomment-2123802307
ClickBench: Total hot run time: 30.89 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #34681:
URL: https://github.com/apache/doris/pull/34681#issuecomment-2123798531
TPC-DS: Total hot run time: 181302 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #34681:
URL: https://github.com/apache/doris/pull/34681#issuecomment-2123790783
TPC-H: Total hot run time: 42135 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
zhangbutao commented on PR #34681:
URL: https://github.com/apache/doris/pull/34681#issuecomment-2123727221
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
zhangbutao commented on PR #34681:
URL: https://github.com/apache/doris/pull/34681#issuecomment-2120173604
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
zhangbutao commented on code in PR #34681:
URL: https://github.com/apache/doris/pull/34681#discussion_r1606578056
##
fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HMSExternalTable.java:
##
@@ -169,6 +170,7 @@ public class HMSExternalTable extends ExternalTable
imple
zhangbutao commented on code in PR #34681:
URL: https://github.com/apache/doris/pull/34681#discussion_r1606573735
##
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/BindRelation.java:
##
@@ -273,6 +273,7 @@ private LogicalPlan getLogicalPlan(TableIf table,
Unbo
zhangbutao commented on code in PR #34681:
URL: https://github.com/apache/doris/pull/34681#discussion_r1606572386
##
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##
@@ -1362,15 +1363,27 @@ public LogicalPlan visitTableName(TableNameContext ct
zhangbutao commented on code in PR #34681:
URL: https://github.com/apache/doris/pull/34681#discussion_r1606571735
##
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4:
##
@@ -966,6 +966,11 @@ sampleMethod
| INTEGER_VALUE ROWS
zhangbutao commented on code in PR #34681:
URL: https://github.com/apache/doris/pull/34681#discussion_r1604572540
##
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/BindRelation.java:
##
@@ -273,6 +273,7 @@ private LogicalPlan getLogicalPlan(TableIf table,
Unbo
wuwenchi commented on code in PR #34681:
URL: https://github.com/apache/doris/pull/34681#discussion_r1604433431
##
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/BindRelation.java:
##
@@ -273,6 +273,7 @@ private LogicalPlan getLogicalPlan(TableIf table,
Unboun
wuwenchi commented on code in PR #34681:
URL: https://github.com/apache/doris/pull/34681#discussion_r1604421627
##
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##
@@ -1362,15 +1363,27 @@ public LogicalPlan visitTableName(TableNameContext ctx)
morningman commented on PR #34681:
URL: https://github.com/apache/doris/pull/34681#issuecomment-2116595342
@wuwenchi PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
morrySnow commented on PR #34681:
URL: https://github.com/apache/doris/pull/34681#issuecomment-2116564775
> @morrySnow Gentle ping. Can we merge this change? Or Is there anything
else that needs to be done?
we need 2 approve to merge pr. let's find another reviewer to review this PR
zhangbutao commented on PR #34681:
URL: https://github.com/apache/doris/pull/34681#issuecomment-2115692662
@morrySnow Gentle ping. Can we merge this change? Or Is there anything else
that needs to be done?
--
This is an automated message from the Apache Git Service.
To respond to the mess
doris-robot commented on PR #34681:
URL: https://github.com/apache/doris/pull/34681#issuecomment-2113947012
ClickBench: Total hot run time: 30.16 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #34681:
URL: https://github.com/apache/doris/pull/34681#issuecomment-2113935285
TPC-DS: Total hot run time: 186741 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #34681:
URL: https://github.com/apache/doris/pull/34681#issuecomment-2109219781
TPC-DS: Total hot run time: 187388 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #34681:
URL: https://github.com/apache/doris/pull/34681#issuecomment-2109209310
TPC-H: Total hot run time: 40423 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
github-actions[bot] commented on PR #34681:
URL: https://github.com/apache/doris/pull/34681#issuecomment-2109207268
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
github-actions[bot] commented on PR #34681:
URL: https://github.com/apache/doris/pull/34681#issuecomment-2109207241
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
zhangbutao commented on PR #34681:
URL: https://github.com/apache/doris/pull/34681#issuecomment-2109192782
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
zhangbutao commented on code in PR #34681:
URL: https://github.com/apache/doris/pull/34681#discussion_r1599310349
##
fe/fe-core/src/main/java/org/apache/doris/nereids/analyzer/UnboundRelation.java:
##
@@ -59,41 +60,46 @@ public class UnboundRelation extends LogicalRelation
impl
morrySnow commented on code in PR #34681:
URL: https://github.com/apache/doris/pull/34681#discussion_r1599282199
##
fe/fe-core/src/main/java/org/apache/doris/nereids/analyzer/UnboundRelation.java:
##
@@ -59,41 +60,46 @@ public class UnboundRelation extends LogicalRelation
imple
zhangbutao commented on PR #34681:
URL: https://github.com/apache/doris/pull/34681#issuecomment-2106114670
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
doris-robot commented on PR #34681:
URL: https://github.com/apache/doris/pull/34681#issuecomment-2105928787
TPC-DS: Total hot run time: 186552 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #34681:
URL: https://github.com/apache/doris/pull/34681#issuecomment-2105926033
TPC-H: Total hot run time: 39892 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
zhangbutao commented on PR #34681:
URL: https://github.com/apache/doris/pull/34681#issuecomment-2105900079
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
zhangbutao commented on code in PR #34681:
URL: https://github.com/apache/doris/pull/34681#discussion_r1597458343
##
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4:
##
@@ -966,6 +966,10 @@ sampleMethod
| INTEGER_VALUE ROWS
morrySnow commented on code in PR #34681:
URL: https://github.com/apache/doris/pull/34681#discussion_r1597396449
##
fe/fe-core/src/main/java/org/apache/doris/nereids/analyzer/UnboundRelation.java:
##
@@ -59,41 +60,46 @@ public class UnboundRelation extends LogicalRelation
imple
zhangbutao commented on PR #34681:
URL: https://github.com/apache/doris/pull/34681#issuecomment-2105432896
@morningman @morrySnow kindly request your review. Thx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
zhangbutao commented on PR #34681:
URL: https://github.com/apache/doris/pull/34681#issuecomment-2105430999
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
doris-robot commented on PR #34681:
URL: https://github.com/apache/doris/pull/34681#issuecomment-2105430787
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y
39 matches
Mail list logo
