ChenMiaoi commented on code in PR #48476:
URL: https://github.com/apache/doris/pull/48476#discussion_r1988325184
##
regression-test/suites/nereids_p0/expression/fold_constant/fold_constant_numeric_arithmatic.groovy:
##
@@ -440,6 +477,14 @@ suite("fold_constant_numeric_arithmatic
ChenMiaoi commented on code in PR #48476:
URL: https://github.com/apache/doris/pull/48476#discussion_r1988865294
##
fe/pom.xml:
##
@@ -793,6 +794,12 @@ under the License.
commons-lang3
${commons-lang3.version}
+
+
ChenMiaoi commented on code in PR #48476:
URL: https://github.com/apache/doris/pull/48476#discussion_r1988825037
##
fe/pom.xml:
##
@@ -793,6 +794,12 @@ under the License.
commons-lang3
${commons-lang3.version}
+
+
doris-robot commented on PR #48476:
URL: https://github.com/apache/doris/pull/48476#issuecomment-2713459063
# BE UT Coverage Report
Increment line coverage `21.43% (6/28)` :tada:
[Increment coverage
report](http://coverage.selectdb-in.cc/coverage/2bd3b4762bf91fa18f52295c897b85dfeab
CalvinKirs commented on code in PR #48476:
URL: https://github.com/apache/doris/pull/48476#discussion_r1988816647
##
fe/pom.xml:
##
@@ -793,6 +794,12 @@ under the License.
commons-lang3
${commons-lang3.version}
+
+
doris-robot commented on PR #48476:
URL: https://github.com/apache/doris/pull/48476#issuecomment-2713190847
ClickBench: Total hot run time: 31.34 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #48476:
URL: https://github.com/apache/doris/pull/48476#issuecomment-2713175040
TPC-DS: Total hot run time: 185366 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #48476:
URL: https://github.com/apache/doris/pull/48476#issuecomment-2713144394
TPC-H: Total hot run time: 32706 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
zclllyybb commented on PR #48476:
URL: https://github.com/apache/doris/pull/48476#issuecomment-2713083513
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
aytrack commented on code in PR #48476:
URL: https://github.com/apache/doris/pull/48476#discussion_r1988241628
##
regression-test/suites/nereids_p0/expression/fold_constant/fold_constant_numeric_arithmatic.groovy:
##
@@ -440,6 +477,14 @@ suite("fold_constant_numeric_arithmatic")
ChenMiaoi commented on code in PR #48476:
URL: https://github.com/apache/doris/pull/48476#discussion_r1988319940
##
regression-test/suites/nereids_p0/expression/fold_constant/fold_constant_numeric_arithmatic.groovy:
##
@@ -440,6 +477,14 @@ suite("fold_constant_numeric_arithmatic
morrySnow commented on code in PR #48476:
URL: https://github.com/apache/doris/pull/48476#discussion_r1987118313
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/Atanh.java:
##
@@ -0,0 +1,68 @@
+// Licensed to the Apache Software Foundation
github-actions[bot] commented on PR #48476:
URL: https://github.com/apache/doris/pull/48476#issuecomment-2709395457
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
doris-robot commented on PR #48476:
URL: https://github.com/apache/doris/pull/48476#issuecomment-2702758334
# BE UT Coverage Report
Increment line coverage `21.43% (6/28)` :tada:
[Increment coverage
report](http://coverage.selectdb-in.cc/coverage/b095acbdb0c389a20270f32d6336f7d2790
doris-robot commented on PR #48476:
URL: https://github.com/apache/doris/pull/48476#issuecomment-2702730405
ClickBench: Total hot run time: 31.43 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #48476:
URL: https://github.com/apache/doris/pull/48476#issuecomment-2702724436
TPC-DS: Total hot run time: 193240 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #48476:
URL: https://github.com/apache/doris/pull/48476#issuecomment-2702711285
TPC-H: Total hot run time: 33314 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
LiBinfeng-01 commented on PR #48476:
URL: https://github.com/apache/doris/pull/48476#issuecomment-2702617375
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
github-actions[bot] commented on PR #48476:
URL: https://github.com/apache/doris/pull/48476#issuecomment-2702616598
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
ChenMiaoi commented on PR #48476:
URL: https://github.com/apache/doris/pull/48476#issuecomment-2693826002
> please add fe impl in
`org.apache.doris.nereids.trees.expressions.functions.executable.NumericArithmetic`
and add fe constant folding in
`regression-test/suites/nereids_p0/expression
ChenMiaoi commented on code in PR #48476:
URL: https://github.com/apache/doris/pull/48476#discussion_r1977177395
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/executable/NumericArithmetic.java:
##
@@ -892,6 +894,17 @@ public static Expression s
ChenMiaoi commented on code in PR #48476:
URL: https://github.com/apache/doris/pull/48476#discussion_r1976914976
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/executable/NumericArithmetic.java:
##
@@ -892,6 +894,17 @@ public static Expression s
zclllyybb commented on code in PR #48476:
URL: https://github.com/apache/doris/pull/48476#discussion_r1976816277
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/executable/NumericArithmetic.java:
##
@@ -892,6 +894,17 @@ public static Expression s
zclllyybb commented on code in PR #48476:
URL: https://github.com/apache/doris/pull/48476#discussion_r1976686943
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/executable/NumericArithmetic.java:
##
@@ -892,6 +894,17 @@ public static Expression s
ChenMiaoi commented on code in PR #48476:
URL: https://github.com/apache/doris/pull/48476#discussion_r1976804117
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/executable/NumericArithmetic.java:
##
@@ -892,6 +894,17 @@ public static Expression s
zclllyybb commented on code in PR #48476:
URL: https://github.com/apache/doris/pull/48476#discussion_r1976686943
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/executable/NumericArithmetic.java:
##
@@ -892,6 +894,17 @@ public static Expression s
zclllyybb commented on code in PR #48476:
URL: https://github.com/apache/doris/pull/48476#discussion_r1976686809
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/executable/NumericArithmetic.java:
##
@@ -892,6 +894,17 @@ public static Expression s
ChenMiaoi commented on code in PR #48476:
URL: https://github.com/apache/doris/pull/48476#discussion_r1976532779
##
be/test/vec/function/function_math_test.cpp:
##
@@ -54,6 +68,20 @@ TEST(MathFunctionTest, asin_test) {
static_cast(check_function(func_name,
input_types, dat
ChenMiaoi commented on code in PR #48476:
URL: https://github.com/apache/doris/pull/48476#discussion_r1976530375
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/executable/NumericArithmetic.java:
##
@@ -892,6 +894,17 @@ public static Expression s
ChenMiaoi commented on code in PR #48476:
URL: https://github.com/apache/doris/pull/48476#discussion_r1976529888
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/executable/NumericArithmetic.java:
##
@@ -892,6 +894,17 @@ public static Expression s
zclllyybb commented on code in PR #48476:
URL: https://github.com/apache/doris/pull/48476#discussion_r1976476002
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/executable/NumericArithmetic.java:
##
@@ -892,6 +894,17 @@ public static Expression s
zclllyybb commented on code in PR #48476:
URL: https://github.com/apache/doris/pull/48476#discussion_r1976475757
##
be/test/vec/function/function_math_test.cpp:
##
@@ -54,6 +68,20 @@ TEST(MathFunctionTest, asin_test) {
static_cast(check_function(func_name,
input_types, dat
ChenMiaoi commented on PR #48476:
URL: https://github.com/apache/doris/pull/48476#issuecomment-2690144435
> please add fe impl in
`org.apache.doris.nereids.trees.expressions.functions.executable.NumericArithmetic`
and add fe constant folding in
`regression-test/suites/nereids_p0/expression
ChenMiaoi commented on code in PR #48476:
URL: https://github.com/apache/doris/pull/48476#discussion_r1975033015
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/Atanh.java:
##
@@ -0,0 +1,68 @@
+// Licensed to the Apache Software Foundation
morrySnow commented on code in PR #48476:
URL: https://github.com/apache/doris/pull/48476#discussion_r1975016425
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/Atanh.java:
##
@@ -0,0 +1,68 @@
+// Licensed to the Apache Software Foundation
hello-stephen commented on PR #48476:
URL: https://github.com/apache/doris/pull/48476#issuecomment-2689904142
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+pro
ChenMiaoi closed pull request #48469: [Enhancement] Support some math functions
URL: https://github.com/apache/doris/pull/48469
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
hello-stephen commented on PR #48469:
URL: https://github.com/apache/doris/pull/48469#issuecomment-2689867930
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+pro
38 matches
Mail list logo
