Re: [PR] [Chore](build) add -Wconversion and remove some unused code [doris]

2024-04-03 Thread via GitHub
AcKing-Sam commented on PR #33127: URL: https://github.com/apache/doris/pull/33127#issuecomment-2034205692 @BiteThet Hi, when I compiled the BE using command `./build.sh --be`, there's an error: ```shell doris/be/src/util/mem_info.cpp:517:38: error: implicit conversion turn

Re: [PR] [Chore](build) add -Wconversion and remove some unused code [doris]

2024-04-02 Thread via GitHub
BiteThet merged PR #33127: URL: https://github.com/apache/doris/pull/33127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris

Re: [PR] [Chore](build) add -Wconversion and remove some unused code [doris]

2024-04-02 Thread via GitHub
github-actions[bot] commented on PR #33127: URL: https://github.com/apache/doris/pull/33127#issuecomment-2033468340 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [Chore](build) add -Wconversion and remove some unused code [doris]

2024-04-02 Thread via GitHub
github-actions[bot] commented on PR #33127: URL: https://github.com/apache/doris/pull/33127#issuecomment-2033468309 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Chore](build) add -Wconversion and remove some unused code [doris]

2024-04-02 Thread via GitHub
doris-robot commented on PR #33127: URL: https://github.com/apache/doris/pull/33127#issuecomment-2031323819 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 1aab889d614902e7199bf70a6c60436aa48531fe with default session variables Stream

Re: [PR] [Chore](build) add -Wconversion and remove some unused code [doris]

2024-04-02 Thread via GitHub
doris-robot commented on PR #33127: URL: https://github.com/apache/doris/pull/33127#issuecomment-2031317154 ClickBench: Total hot run time: 29.95 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Chore](build) add -Wconversion and remove some unused code [doris]

2024-04-02 Thread via GitHub
doris-robot commented on PR #33127: URL: https://github.com/apache/doris/pull/33127#issuecomment-2031307023 TPC-DS: Total hot run time: 182677 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Chore](build) add -Wconversion and remove some unused code [doris]

2024-04-02 Thread via GitHub
doris-robot commented on PR #33127: URL: https://github.com/apache/doris/pull/33127#issuecomment-2031282519 TPC-H: Total hot run time: 38841 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Chore](build) add -Wconversion and remove some unused code [doris]

2024-04-02 Thread via GitHub
doris-robot commented on PR #33127: URL: https://github.com/apache/doris/pull/33127#issuecomment-2031261906 TeamCity be ut coverage result: Function Coverage: 35.59% (8852/24869) Line Coverage: 27.30% (72540/265762) Region Coverage: 26.49% (37546/141719) Branch Coverage: 23.2

Re: [PR] [Chore](build) add -Wconversion and remove some unused code [doris]

2024-04-01 Thread via GitHub
BiteThet commented on PR #33127: URL: https://github.com/apache/doris/pull/33127#issuecomment-2031188516 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Chore](build) add -Wconversion and remove some unused code [doris]

2024-04-01 Thread via GitHub
BiteThet commented on PR #33127: URL: https://github.com/apache/doris/pull/33127#issuecomment-2030958386 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Chore](build) add -Wconversion and remove some unused code [doris]

2024-04-01 Thread via GitHub
github-actions[bot] commented on code in PR #33127: URL: https://github.com/apache/doris/pull/33127#discussion_r1546343554 ## be/test/vec/core/block_test.cpp: ## @@ -165,7 +165,7 @@ void serialize_and_deserialize_test(segment_v2::CompressionTypePB compression_ty

Re: [PR] [Chore](build) add -Wconversion and remove some unused code [doris]

2024-04-01 Thread via GitHub
BiteThet commented on PR #33127: URL: https://github.com/apache/doris/pull/33127#issuecomment-2029764583 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Chore](build) add -Wconversion and remove some unused code [doris]

2024-04-01 Thread via GitHub
github-actions[bot] commented on code in PR #33127: URL: https://github.com/apache/doris/pull/33127#discussion_r1546235706 ## be/src/cloud/cloud_cumulative_compaction_policy.cpp: ## @@ -182,7 +182,7 @@ int CloudSizeBasedCumulativeCompactionPolicy::pick_input_rowsets( } int6

Re: [PR] [Chore](build) add -Wconversion and remove some unused code [doris]

2024-04-01 Thread via GitHub
BiteThet commented on PR #33127: URL: https://github.com/apache/doris/pull/33127#issuecomment-2029609144 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Chore](build) add -Wconversion and remove some unused code [doris]

2024-04-01 Thread via GitHub
doris-robot commented on PR #33127: URL: https://github.com/apache/doris/pull/33127#issuecomment-2029609024 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y