github-actions[bot] commented on PR #29907:
URL: https://github.com/apache/doris/pull/29907#issuecomment-1908643407
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
HappenLee closed pull request #29907: save code
URL: https://github.com/apache/doris/pull/29907
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-
github-actions[bot] commented on PR #29907:
URL: https://github.com/apache/doris/pull/29907#issuecomment-1888474897
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
HappenLee opened a new pull request, #29907:
URL: https://github.com/apache/doris/pull/29907
## Proposed changes
Issue Number: close #xxx
## Further comments
If this is a relatively large or complex change, kick off the discussion at
[d...@doris.apache.org](mailt
github-actions[bot] commented on code in PR #25278:
URL: https://github.com/apache/doris/pull/25278#discussion_r1365136282
##
be/src/vec/common/hash_table/hash_map.h:
##
@@ -193,10 +195,112 @@ class HashMapTable : public HashTable {
bool has_null_key_data() const { return f
HappenLee closed pull request #25278: save code
URL: https://github.com/apache/doris/pull/25278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-
github-actions[bot] commented on code in PR #25278:
URL: https://github.com/apache/doris/pull/25278#discussion_r1357640403
##
be/src/vec/common/hash_table/hash_map_context.h:
##
@@ -126,6 +126,10 @@ struct MethodBase {
}
}
+std::span get_keys() const { return
github-actions[bot] commented on code in PR #25278:
URL: https://github.com/apache/doris/pull/25278#discussion_r1353894018
##
be/src/vec/exec/join/join_op.h:
##
@@ -109,21 +111,17 @@ class ForwardIterator {
return;
}
-if (batch) {
+if (bat
HappenLee opened a new pull request, #25278:
URL: https://github.com/apache/doris/pull/25278
## Proposed changes
Issue Number: close #xxx
## Further comments
If this is a relatively large or complex change, kick off the discussion at
[d...@doris.apache.org](mailt
