Re: [PR] memtable flush reserve process mem and improve logs [doris]

2024-12-24 Thread via GitHub
yiguolei merged PR #45743: URL: https://github.com/apache/doris/pull/45743 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

Re: [PR] memtable flush reserve process mem and improve logs [doris]

2024-12-23 Thread via GitHub
jacktengg commented on code in PR #45743: URL: https://github.com/apache/doris/pull/45743#discussion_r1896498990 ## be/src/vec/exec/scan/scanner_scheduler.cpp: ## @@ -268,16 +301,17 @@ void ScannerScheduler::_scanner_scan(std::shared_ptr ctx, } size_

Re: [PR] memtable flush reserve process mem and improve logs [doris]

2024-12-23 Thread via GitHub
yiguolei commented on code in PR #45743: URL: https://github.com/apache/doris/pull/45743#discussion_r1896497374 ## be/src/vec/exec/scan/scanner_scheduler.cpp: ## @@ -268,16 +301,17 @@ void ScannerScheduler::_scanner_scan(std::shared_ptr ctx, } size_t

Re: [PR] memtable flush reserve process mem and improve logs [doris]

2024-12-23 Thread via GitHub
yiguolei commented on code in PR #45743: URL: https://github.com/apache/doris/pull/45743#discussion_r1896442875 ## be/src/vec/exec/scan/scanner_scheduler.cpp: ## @@ -254,6 +287,14 @@ void ScannerScheduler::_scanner_scan(std::shared_ptr ctx, } if (!eo

Re: [PR] memtable flush reserve process mem and improve logs [doris]

2024-12-23 Thread via GitHub
yiguolei commented on code in PR #45743: URL: https://github.com/apache/doris/pull/45743#discussion_r1896439810 ## be/src/vec/exec/scan/scanner_scheduler.cpp: ## @@ -254,6 +287,14 @@ void ScannerScheduler::_scanner_scan(std::shared_ptr ctx, } if (!eo

Re: [PR] memtable flush reserve process mem and improve logs [doris]

2024-12-23 Thread via GitHub
yiguolei commented on code in PR #45743: URL: https://github.com/apache/doris/pull/45743#discussion_r1896438342 ## be/src/olap/memtable_flush_executor.cpp: ## @@ -150,10 +181,18 @@ Status FlushToken::_do_flush_memtable(MemTable* memtable, int32_t segment_id, in SCOPED_ATTA

Re: [PR] memtable flush reserve process mem and improve logs [doris]

2024-12-21 Thread via GitHub
yiguolei commented on code in PR #45743: URL: https://github.com/apache/doris/pull/45743#discussion_r1894593784 ## be/src/olap/memtable_flush_executor.cpp: ## @@ -140,6 +141,36 @@ Status FlushToken::wait() { return Status::OK(); } +Status FlushToken::_try_reserve_memory(

Re: [PR] memtable flush reserve process mem and improve logs [doris]

2024-12-21 Thread via GitHub
yiguolei commented on code in PR #45743: URL: https://github.com/apache/doris/pull/45743#discussion_r1894593201 ## be/src/olap/memtable_flush_executor.cpp: ## @@ -140,6 +141,36 @@ Status FlushToken::wait() { return Status::OK(); } +Status FlushToken::_try_reserve_memory(

Re: [PR] memtable flush reserve process mem and improve logs [doris]

2024-12-21 Thread via GitHub
yiguolei commented on code in PR #45743: URL: https://github.com/apache/doris/pull/45743#discussion_r1894592567 ## be/src/runtime/thread_context.h: ## @@ -249,13 +249,22 @@ class ThreadContext { thread_mem_tracker_mgr->consume(size, skip_large_memory_check); } +

Re: [PR] memtable flush reserve process mem and improve logs [doris]

2024-12-21 Thread via GitHub
yiguolei commented on code in PR #45743: URL: https://github.com/apache/doris/pull/45743#discussion_r1894592503 ## be/src/runtime/memory/thread_mem_tracker_mgr.h: ## @@ -278,34 +278,44 @@ inline void ThreadMemTrackerMgr::flush_untracked_mem() { _stop_consume = false; } -

Re: [PR] memtable flush reserve process mem and improve logs [doris]

2024-12-20 Thread via GitHub
Thearas commented on PR #45743: URL: https://github.com/apache/doris/pull/45743#issuecomment-2556827301 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] memtable flush reserve process mem and improve logs [doris]

2024-12-20 Thread via GitHub
jacktengg opened a new pull request, #45743: URL: https://github.com/apache/doris/pull/45743 ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Tes