Re: [PR] [refactor](column) remove unused method and column definitions [doris]

2023-10-09 Thread via GitHub
yiguolei merged PR #25152: URL: https://github.com/apache/doris/pull/25152 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

Re: [PR] [refactor](column) remove unused method and column definitions [doris]

2023-10-09 Thread via GitHub
github-actions[bot] commented on PR #25152: URL: https://github.com/apache/doris/pull/25152#issuecomment-1752523546 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [refactor](column) remove unused method and column definitions [doris]

2023-10-09 Thread via GitHub
github-actions[bot] commented on PR #25152: URL: https://github.com/apache/doris/pull/25152#issuecomment-1752523479 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [refactor](column) remove unused method and column definitions [doris]

2023-10-09 Thread via GitHub
doris-robot commented on PR #25152: URL: https://github.com/apache/doris/pull/25152#issuecomment-1752462731 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.64 seconds stream load tsv: 558 seconds loaded 74807831229 Bytes,

Re: [PR] [refactor](column) remove unused method and column definitions [doris]

2023-10-08 Thread via GitHub
doris-robot commented on PR #25152: URL: https://github.com/apache/doris/pull/25152#issuecomment-1752440183 TeamCity be ut coverage result: Function Coverage: 36.32% (8149/22437) Line Coverage: 28.44% (65186/229185) Region Coverage: 27.38% (33780/123393) Branch Coverage: 24.0

Re: [PR] [refactor](column) remove unused method and column definitions [doris]

2023-10-08 Thread via GitHub
yiguolei commented on PR #25152: URL: https://github.com/apache/doris/pull/25152#issuecomment-1752385250 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [refactor](column) remove unused method and column definitions [doris]

2023-10-08 Thread via GitHub
github-actions[bot] commented on PR #25152: URL: https://github.com/apache/doris/pull/25152#issuecomment-1752340572 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [refactor](column) remove unused method and column definitions [doris]

2023-10-08 Thread via GitHub
github-actions[bot] commented on PR #25152: URL: https://github.com/apache/doris/pull/25152#issuecomment-1752339391 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [refactor](column) remove unused method and column definitions [doris]

2023-10-08 Thread via GitHub
github-actions[bot] commented on PR #25152: URL: https://github.com/apache/doris/pull/25152#issuecomment-1752290210 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] [refactor](column) remove unused method and column definitions [doris]

2023-10-08 Thread via GitHub
yiguolei opened a new pull request, #25152: URL: https://github.com/apache/doris/pull/25152 ## Proposed changes 1. remove unused method and column definitions 2. using primitive type in predicate column to check datev1 and datev2 ## Further comments If this is a relat