github-actions[bot] commented on PR #32614:
URL: https://github.com/apache/doris/pull/32614#issuecomment-2065833311
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
zhiqiang- closed pull request #32614: [opt](pointer cast) better typeid_cast
URL: https://github.com/apache/doris/pull/32614
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
zclllyybb commented on code in PR #32614:
URL: https://github.com/apache/doris/pull/32614#discussion_r1536663881
##
be/src/vec/common/typeid_cast.h:
##
@@ -43,34 +43,20 @@
*/
template
requires std::is_reference_v
-To typeid_cast(From& from) {
-try {
-if (ty
zhiqiang- commented on code in PR #32614:
URL: https://github.com/apache/doris/pull/32614#discussion_r1536591881
##
be/src/vec/common/typeid_cast.h:
##
@@ -43,34 +43,20 @@
*/
template
requires std::is_reference_v
-To typeid_cast(From& from) {
-try {
-if
zhiqiang- commented on code in PR #32614:
URL: https://github.com/apache/doris/pull/32614#discussion_r1536591316
##
be/src/vec/common/typeid_cast.h:
##
@@ -43,34 +43,20 @@
*/
template
requires std::is_reference_v
-To typeid_cast(From& from) {
-try {
-if
yiguolei commented on code in PR #32614:
URL: https://github.com/apache/doris/pull/32614#discussion_r1536290469
##
be/src/vec/common/typeid_cast.h:
##
@@ -43,34 +43,20 @@
*/
template
requires std::is_reference_v
-To typeid_cast(From& from) {
-try {
-if (typ
yiguolei commented on code in PR #32614:
URL: https://github.com/apache/doris/pull/32614#discussion_r1536288571
##
be/src/vec/common/typeid_cast.h:
##
@@ -43,34 +43,20 @@
*/
template
requires std::is_reference_v
-To typeid_cast(From& from) {
-try {
-if (typ
github-actions[bot] commented on PR #32614:
URL: https://github.com/apache/doris/pull/32614#issuecomment-2013674217
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
github-actions[bot] commented on PR #32614:
URL: https://github.com/apache/doris/pull/32614#issuecomment-2011540579
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
zhiqiang- commented on PR #32614:
URL: https://github.com/apache/doris/pull/32614#issuecomment-2011494309
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
doris-robot commented on PR #32614:
URL: https://github.com/apache/doris/pull/32614#issuecomment-2011493400
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y
zhiqiang- opened a new pull request, #32614:
URL: https://github.com/apache/doris/pull/32614
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
12 matches
Mail list logo