Re: [PR] [opt](pointer cast) better typeid_cast [doris]

2024-04-18 Thread via GitHub
github-actions[bot] commented on PR #32614: URL: https://github.com/apache/doris/pull/32614#issuecomment-2065833311 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [opt](pointer cast) better typeid_cast [doris]

2024-04-18 Thread via GitHub
zhiqiang- closed pull request #32614: [opt](pointer cast) better typeid_cast URL: https://github.com/apache/doris/pull/32614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [opt](pointer cast) better typeid_cast [doris]

2024-03-23 Thread via GitHub
zclllyybb commented on code in PR #32614: URL: https://github.com/apache/doris/pull/32614#discussion_r1536663881 ## be/src/vec/common/typeid_cast.h: ## @@ -43,34 +43,20 @@ */ template requires std::is_reference_v -To typeid_cast(From& from) { -try { -if (ty

Re: [PR] [opt](pointer cast) better typeid_cast [doris]

2024-03-23 Thread via GitHub
zhiqiang- commented on code in PR #32614: URL: https://github.com/apache/doris/pull/32614#discussion_r1536591881 ## be/src/vec/common/typeid_cast.h: ## @@ -43,34 +43,20 @@ */ template requires std::is_reference_v -To typeid_cast(From& from) { -try { -if

Re: [PR] [opt](pointer cast) better typeid_cast [doris]

2024-03-23 Thread via GitHub
zhiqiang- commented on code in PR #32614: URL: https://github.com/apache/doris/pull/32614#discussion_r1536591316 ## be/src/vec/common/typeid_cast.h: ## @@ -43,34 +43,20 @@ */ template requires std::is_reference_v -To typeid_cast(From& from) { -try { -if

Re: [PR] [opt](pointer cast) better typeid_cast [doris]

2024-03-22 Thread via GitHub
yiguolei commented on code in PR #32614: URL: https://github.com/apache/doris/pull/32614#discussion_r1536290469 ## be/src/vec/common/typeid_cast.h: ## @@ -43,34 +43,20 @@ */ template requires std::is_reference_v -To typeid_cast(From& from) { -try { -if (typ

Re: [PR] [opt](pointer cast) better typeid_cast [doris]

2024-03-22 Thread via GitHub
yiguolei commented on code in PR #32614: URL: https://github.com/apache/doris/pull/32614#discussion_r1536288571 ## be/src/vec/common/typeid_cast.h: ## @@ -43,34 +43,20 @@ */ template requires std::is_reference_v -To typeid_cast(From& from) { -try { -if (typ

Re: [PR] [opt](pointer cast) better typeid_cast [doris]

2024-03-21 Thread via GitHub
github-actions[bot] commented on PR #32614: URL: https://github.com/apache/doris/pull/32614#issuecomment-2013674217 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [opt](pointer cast) better typeid_cast [doris]

2024-03-21 Thread via GitHub
github-actions[bot] commented on PR #32614: URL: https://github.com/apache/doris/pull/32614#issuecomment-2011540579 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [opt](pointer cast) better typeid_cast [doris]

2024-03-21 Thread via GitHub
zhiqiang- commented on PR #32614: URL: https://github.com/apache/doris/pull/32614#issuecomment-2011494309 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [opt](pointer cast) better typeid_cast [doris]

2024-03-21 Thread via GitHub
doris-robot commented on PR #32614: URL: https://github.com/apache/doris/pull/32614#issuecomment-2011493400 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [opt](pointer cast) better typeid_cast [doris]

2024-03-21 Thread via GitHub
zhiqiang- opened a new pull request, #32614: URL: https://github.com/apache/doris/pull/32614 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe