Re: [PR] [improvement](binlog)Support inverted index in CCR [doris]

2024-03-10 Thread via GitHub
github-actions[bot] commented on PR #31743: URL: https://github.com/apache/doris/pull/31743#issuecomment-1987544350 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [improvement](binlog)Support inverted index in CCR [doris]

2024-03-10 Thread via GitHub
xiaokang merged PR #31743: URL: https://github.com/apache/doris/pull/31743 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

Re: [PR] [improvement](binlog)Support inverted index in CCR [doris]

2024-03-07 Thread via GitHub
doris-robot commented on PR #31743: URL: https://github.com/apache/doris/pull/31743#issuecomment-1983183413 TeamCity be ut coverage result: Function Coverage: 35.39% (8561/24189) Line Coverage: 27.13% (69505/256189) Region Coverage: 26.36% (36066/136795) Branch Coverage: 23.2

Re: [PR] [improvement](binlog)Support inverted index in CCR [doris]

2024-03-07 Thread via GitHub
qidaye commented on PR #31743: URL: https://github.com/apache/doris/pull/31743#issuecomment-1983072617 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [improvement](binlog)Support inverted index in CCR [doris]

2024-03-07 Thread via GitHub
github-actions[bot] commented on PR #31743: URL: https://github.com/apache/doris/pull/31743#issuecomment-1983000225 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [improvement](binlog)Support inverted index in CCR [doris]

2024-03-07 Thread via GitHub
github-actions[bot] commented on PR #31743: URL: https://github.com/apache/doris/pull/31743#issuecomment-1982978432 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [improvement](binlog)Support inverted index in CCR [doris]

2024-03-07 Thread via GitHub
github-actions[bot] commented on PR #31743: URL: https://github.com/apache/doris/pull/31743#issuecomment-1982976749 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [improvement](binlog)Support inverted index in CCR [doris]

2024-03-07 Thread via GitHub
qidaye commented on PR #31743: URL: https://github.com/apache/doris/pull/31743#issuecomment-1982950359 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [improvement](binlog)Support inverted index in CCR [doris]

2024-03-05 Thread via GitHub
doris-robot commented on PR #31743: URL: https://github.com/apache/doris/pull/31743#issuecomment-1978739931 TeamCity be ut coverage result: Function Coverage: 35.42% (8557/24157) Line Coverage: 27.16% (69436/255661) Region Coverage: 26.39% (36033/136553) Branch Coverage: 23.2

Re: [PR] [improvement](binlog)Support inverted index in CCR [doris]

2024-03-05 Thread via GitHub
github-actions[bot] commented on PR #31743: URL: https://github.com/apache/doris/pull/31743#issuecomment-1978670378 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [improvement](binlog)Support inverted index in CCR [doris]

2024-03-05 Thread via GitHub
github-actions[bot] commented on PR #31743: URL: https://github.com/apache/doris/pull/31743#issuecomment-1978670333 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [improvement](binlog)Support inverted index in CCR [doris]

2024-03-05 Thread via GitHub
qidaye commented on PR #31743: URL: https://github.com/apache/doris/pull/31743#issuecomment-1978657198 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [improvement](binlog)Support inverted index in CCR [doris]

2024-03-05 Thread via GitHub
qidaye commented on PR #31743: URL: https://github.com/apache/doris/pull/31743#issuecomment-1978631929 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [improvement](binlog)Support inverted index in CCR [doris]

2024-03-05 Thread via GitHub
qidaye commented on code in PR #31743: URL: https://github.com/apache/doris/pull/31743#discussion_r1512721756 ## be/src/service/backend_service.cpp: ## @@ -286,8 +286,121 @@ void _ingest_binlog(StorageEngine& engine, IngestBinlogArg* arg) { } } -// Step 6: c

Re: [PR] [improvement](binlog)Support inverted index in CCR [doris]

2024-03-05 Thread via GitHub
qidaye commented on code in PR #31743: URL: https://github.com/apache/doris/pull/31743#discussion_r1512721283 ## be/src/olap/rowset/beta_rowset.cpp: ## @@ -470,6 +470,27 @@ Status BetaRowset::add_to_binlog() { } } +// link inverted index files +for (const

Re: [PR] [improvement](binlog)Support inverted index in CCR [doris]

2024-03-05 Thread via GitHub
qidaye commented on PR #31743: URL: https://github.com/apache/doris/pull/31743#issuecomment-1978630463 > please add cases. Case is here: https://github.com/selectdb/ccr-syncer/pull/48 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] [improvement](binlog)Support inverted index in CCR [doris]

2024-03-05 Thread via GitHub
github-actions[bot] commented on PR #31743: URL: https://github.com/apache/doris/pull/31743#issuecomment-1978270720 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [improvement](binlog)Support inverted index in CCR [doris]

2024-03-04 Thread via GitHub
xiaokang commented on code in PR #31743: URL: https://github.com/apache/doris/pull/31743#discussion_r1511970268 ## be/src/olap/rowset/beta_rowset.cpp: ## @@ -470,6 +470,27 @@ Status BetaRowset::add_to_binlog() { } } +// link inverted index files +for (con

Re: [PR] [improvement](binlog)Support inverted index in CCR [doris]

2024-03-04 Thread via GitHub
doris-robot commented on PR #31743: URL: https://github.com/apache/doris/pull/31743#issuecomment-1976322958 TeamCity be ut coverage result: Function Coverage: 35.42% (8554/24152) Line Coverage: 27.18% (69414/255410) Region Coverage: 26.40% (36016/136425) Branch Coverage: 23.2

Re: [PR] [improvement](binlog)Support inverted index in CCR [doris]

2024-03-04 Thread via GitHub
qidaye commented on PR #31743: URL: https://github.com/apache/doris/pull/31743#issuecomment-1976203196 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [improvement](binlog)Support inverted index in CCR [doris]

2024-03-04 Thread via GitHub
dataroaring commented on PR #31743: URL: https://github.com/apache/doris/pull/31743#issuecomment-1976173565 please add cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [improvement](binlog)Support inverted index in CCR [doris]

2024-03-04 Thread via GitHub
github-actions[bot] commented on PR #31743: URL: https://github.com/apache/doris/pull/31743#issuecomment-1976163093 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [improvement](binlog)Support inverted index in CCR [doris]

2024-03-04 Thread via GitHub
doris-robot commented on PR #31743: URL: https://github.com/apache/doris/pull/31743#issuecomment-1976135480 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [improvement](binlog)Support inverted index in CCR [doris]

2024-03-04 Thread via GitHub
qidaye opened a new pull request, #31743: URL: https://github.com/apache/doris/pull/31743 Support inverted index in several occasions: 1. Creating binlog files 2. Downloading binlog files 3. During engine clone tasks 4. Binlog gc ## Proposed changes Issue Number: clo