Re: [PR] [improve] add JdbcSourceSchema extends SourceSchema [doris-flink-connector]

2024-02-22 Thread via GitHub
bingquanzhao closed pull request #303: [improve] add JdbcSourceSchema extends SourceSchema URL: https://github.com/apache/doris-flink-connector/pull/303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [improve] add JdbcSourceSchema extends SourceSchema [doris-flink-connector]

2024-02-20 Thread via GitHub
bingquanzhao commented on PR #303: URL: https://github.com/apache/doris-flink-connector/pull/303#issuecomment-1953826266 > please rebase master, there is a conflict 👌 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [improve] add JdbcSourceSchema extends SourceSchema [doris-flink-connector]

2024-02-18 Thread via GitHub
JNSimba commented on PR #303: URL: https://github.com/apache/doris-flink-connector/pull/303#issuecomment-1951765807 please rebase master, there is a conflict -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] [improve] add JdbcSourceSchema extends SourceSchema [doris-flink-connector]

2024-01-22 Thread via GitHub
JNSimba commented on code in PR #303: URL: https://github.com/apache/doris-flink-connector/pull/303#discussion_r1461567449 ## flink-doris-connector/src/main/java/org/apache/doris/flink/tools/cdc/JdbcSourceSchema.java: ## @@ -0,0 +1,50 @@ +package org.apache.doris.flink.tools.cd

Re: [PR] [improve] add JdbcSourceSchema extends SourceSchema [doris-flink-connector]

2024-01-22 Thread via GitHub
JNSimba commented on code in PR #303: URL: https://github.com/apache/doris-flink-connector/pull/303#discussion_r1461567174 ## flink-doris-connector/src/main/java/org/apache/doris/flink/tools/cdc/SourceSchema.java: ## @@ -33,57 +31,23 @@ import java.util.StringJoiner; public

[PR] [improve] add JdbcSourceSchema extends SourceSchema [doris-flink-connector]

2024-01-22 Thread via GitHub
bingquanzhao opened a new pull request, #303: URL: https://github.com/apache/doris-flink-connector/pull/303 add jdbc source schema extends source schema .Making SourceSchema more than just a JDBC-related implementation -- This is an automated message from the Apache Git Service. To respon