Re: [PR] [function](char) change char function behaviour same with mysql [doris]

2024-01-17 Thread via GitHub
yiguolei merged PR #30034: URL: https://github.com/apache/doris/pull/30034 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

Re: [PR] [function](char) change char function behaviour same with mysql [doris]

2024-01-16 Thread via GitHub
doris-robot commented on PR #30034: URL: https://github.com/apache/doris/pull/30034#issuecomment-1893883526 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit d0b70afe284c51d989ea86c633496b4b2cf41b6c with default session variables Stream

Re: [PR] [function](char) change char function behaviour same with mysql [doris]

2024-01-16 Thread via GitHub
doris-robot commented on PR #30034: URL: https://github.com/apache/doris/pull/30034#issuecomment-1893877538 ClickBench: Total hot run time: 30.7 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools C

Re: [PR] [function](char) change char function behaviour same with mysql [doris]

2024-01-16 Thread via GitHub
doris-robot commented on PR #30034: URL: https://github.com/apache/doris/pull/30034#issuecomment-1893869258 TeamCity be ut coverage result: Function Coverage: 36.67% (8648/23581) Line Coverage: 28.73% (70611/245787) Region Coverage: 27.62% (36436/131932) Branch Coverage: 24.3

Re: [PR] [function](char) change char function behaviour same with mysql [doris]

2024-01-16 Thread via GitHub
doris-robot commented on PR #30034: URL: https://github.com/apache/doris/pull/30034#issuecomment-1893867191 TPC-DS: Total hot run time: 177038 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [function](char) change char function behaviour same with mysql [doris]

2024-01-16 Thread via GitHub
doris-robot commented on PR #30034: URL: https://github.com/apache/doris/pull/30034#issuecomment-1893841610 TPC-H: Total hot run time: 38946 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [function](char) change char function behaviour same with mysql [doris]

2024-01-16 Thread via GitHub
github-actions[bot] commented on PR #30034: URL: https://github.com/apache/doris/pull/30034#issuecomment-1893711975 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [function](char) change char function behaviour same with mysql [doris]

2024-01-16 Thread via GitHub
github-actions[bot] commented on PR #30034: URL: https://github.com/apache/doris/pull/30034#issuecomment-1893711829 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [function](char) change char function behaviour same with mysql [doris]

2024-01-16 Thread via GitHub
zhangstar333 commented on PR #30034: URL: https://github.com/apache/doris/pull/30034#issuecomment-1893708091 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [function](char) change char function behaviour same with mysql [doris]

2024-01-16 Thread via GitHub
github-actions[bot] commented on PR #30034: URL: https://github.com/apache/doris/pull/30034#issuecomment-1893703362 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] [function](char) change char function behaviour same with mysql [doris]

2024-01-16 Thread via GitHub
zhangstar333 opened a new pull request, #30034: URL: https://github.com/apache/doris/pull/30034 ## Proposed changes select char(0) = '\0'; should return true; Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kic