doris-robot commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2032142495
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 3d07e35fe99eee61324d6a8a67b382334b924bcc with
default session variables
Stream
doris-robot commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2032132737
ClickBench: Total hot run time: 30.68 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2032118586
TPC-DS: Total hot run time: 180269 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2032116743
TeamCity be ut coverage result:
Function Coverage: 35.64% (8879/24911)
Line Coverage: 27.37% (72908/266376)
Region Coverage: 26.56% (37708/141993)
Branch Coverage: 23.3
doris-robot commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2032089495
TPC-H: Total hot run time: 38861 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
zhiqiang- commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2032088447
> @zhiqiang- Hi, I have added the deduction from template arguments.
However, the bot said the function is a read-hard. Could you please give me
some hints about how to optimize
AcKing-Sam commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2031997443
@zhiqiang- Hi, I have added the deduction from template arguments.
However, the bot said the function is a read-hard. Could you please give me
some hints about how to optimize the
github-actions[bot] commented on code in PR #32518:
URL: https://github.com/apache/doris/pull/32518#discussion_r1547823646
##
be/src/vec/data_types/data_type_decimal.h:
##
@@ -410,40 +411,113 @@ template
constexpr bool IsDataTypeDecimalOrNumber =
IsDataTypeDecimal ||
AcKing-Sam commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2031957277
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
zhiqiang- commented on code in PR #32518:
URL: https://github.com/apache/doris/pull/32518#discussion_r1540928087
##
be/src/vec/data_types/data_type_decimal.h:
##
@@ -411,39 +412,86 @@ constexpr bool IsDataTypeDecimalOrNumber =
IsDataTypeDecimal || IsDataTypeNumber;
AcKing-Sam commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2022537980
@zhiqiang- Got it. Thanks for your review and I will add more regression
tests to it. ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, p
zhiqiang- commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2022521875
> @zhiqiang-
>
> Hi, I wonder what is the correct answer of this sql: `select cast(a as
decimal(30, 4)) from (select cast("-12-31 23:59:59.99" as datetime(6))
a)
doris-robot commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2022481489
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit c900f8a33fa62f06d136ccb2c623510fe2a6294d with
default session variables
Stream
doris-robot commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2022462088
TPC-DS: Total hot run time: 181430 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2022446215
TeamCity be ut coverage result:
Function Coverage: 35.25% (8741/24796)
Line Coverage: 27.03% (71552/264701)
Region Coverage: 26.27% (37123/141292)
Branch Coverage: 23.1
doris-robot commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2022437220
TPC-H: Total hot run time: 38486 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
github-actions[bot] commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2022324957
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2022324504
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
AcKing-Sam commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2022317175
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
AcKing-Sam commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2022288989
@zhiqiang-
Hi, I wonder what is the correct answer of this sql:
`select cast(a as decimal(30, 4)) from (select cast("-12-31
23:59:59.99" as datetime(6)) a) t1;`
zhiqiang- commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2020161566
@AcKing-Sam
```sql
mysql [demo]>select *, cast(str as Datetime(3)) from str;
--
select *, cast(str as Datetime(3)) from str
--
+
doris-robot commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2020159473
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 9b90c00c075f5c922e7e2dcacf2ac577dfc30def with
default session variables
Stream
zhiqiang- commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2020155914
> @yiguolei @zhiqiang-
>
> Hi, I added the cast from datetime to decimal. Also, I modified the logic
in `cast_to_decimals()`. However, there is an exception, to test this
doris-robot commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2020153769
TPC-DS: Total hot run time: 181874 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2020138509
TeamCity be ut coverage result:
Function Coverage: 35.27% (8738/24776)
Line Coverage: 27.04% (71537/264530)
Region Coverage: 26.28% (37109/141221)
Branch Coverage: 23.1
doris-robot commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2020131436
TPC-H: Total hot run time: 37996 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
AcKing-Sam commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2020035424
@yiguolei @zhiqiang-
Hi, I added the cast from datetime to decimal. Also, I modified the logic in
`cast_to_decimals()`.
However, there is an exception, to test this SQL:
github-actions[bot] commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-201160
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
AcKing-Sam commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2019979383
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
AcKing-Sam commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2017983182
@yiguolei Got it, and thanks for the review. I am going to add the cast
from datetime to decimal and add the cases. ;)
--
This is an automated message from the Apache Git Service.
T
yiguolei commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2017978812
@AcKing-Sam We should add some test cases for datetime with precision value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
yiguolei commented on code in PR #32518:
URL: https://github.com/apache/doris/pull/32518#discussion_r1537571529
##
regression-test/suites/query_p0/cast/test_cast_from_date_to_decimal.groovy:
##
@@ -0,0 +1,33 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// o
AcKing-Sam commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2017528076
> @AcKing-Sam btw, maybe we should modify logical in `convert_to_decimals`
instead of using a temporary array which costs more memory and does not have
performance benefits. For exampl
zhiqiang- commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2017509317
@AcKing-Sam btw, maybe we should modify logical in `convert_to_decimals`
instead of using a temporary array which costs more memory and does not have
performance benefits. For examp
AcKing-Sam commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2017483265
@zhiqiang- Got it, I am willing to fix it! :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
zhiqiang- commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2017470658
> @zhiqiang- Hi, I just tested below in Doris:
>
> ```sql
> mysql> select cast(c as decimal) from (select cast("-12-31" as
datetime) c) t3;
> ERROR 1105 (HY000):
AcKing-Sam commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2017425595
@zhiqiang-
Hi, I just tested below in Doris:
```sql
mysql> select cast(c as decimal) from (select cast("-12-31" as datetime)
c) t3;
ERROR 1105 (HY000): errCode = 2
zhiqiang- commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2017411397
@AcKing-Sam Do we have same issue for Datetime?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
github-actions[bot] commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2017407516
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
doris-robot commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2016552686
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit d29cb284fd6f4258f182d0319f06763c3fb80baf with
default session variables
Stream
doris-robot commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2016551923
TPC-DS: Total hot run time: 186876 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2016548901
TPC-H: Total hot run time: 38236 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
doris-robot commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2016547961
TeamCity be ut coverage result:
Function Coverage: 35.26% (8733/24766)
Line Coverage: 27.05% (71508/264307)
Region Coverage: 26.29% (37101/141096)
Branch Coverage: 23.1
AcKing-Sam commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2016530928
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
github-actions[bot] commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2016530740
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2016530603
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
zhiqiang- commented on code in PR #32518:
URL: https://github.com/apache/doris/pull/32518#discussion_r1536588367
##
be/src/vec/data_types/data_type_decimal.h:
##
@@ -655,6 +656,10 @@ void convert_to_decimal(typename ToDataType::FieldType*
dst,
for (size_t i = 0; i
doris-robot commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2016366963
TeamCity be ut coverage result:
Function Coverage: 35.26% (8732/24766)
Line Coverage: 27.06% (71510/264305)
Region Coverage: 26.29% (37091/141099)
Branch Coverage: 23.1
github-actions[bot] commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2016345912
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2016345703
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
AcKing-Sam commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2016344327
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
yiguolei commented on code in PR #32518:
URL: https://github.com/apache/doris/pull/32518#discussion_r1536279403
##
be/src/vec/data_types/data_type_decimal.h:
##
@@ -655,6 +656,10 @@ void convert_to_decimal(typename ToDataType::FieldType*
dst,
for (size_t i = 0; i < siz
doris-robot commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2009071193
TeamCity be ut coverage result:
Function Coverage: 35.29% (8728/24730)
Line Coverage: 27.09% (71382/263532)
Region Coverage: 26.33% (37050/140705)
Branch Coverage: 23.2
AcKing-Sam commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2009045106
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
github-actions[bot] commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2009040132
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
doris-robot commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2009011009
TeamCity be ut coverage result:
Function Coverage: 35.30% (8730/24730)
Line Coverage: 27.10% (71409/263532)
Region Coverage: 26.34% (37057/140705)
Branch Coverage: 23.2
github-actions[bot] commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2008984318
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
AcKing-Sam commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2008978317
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
AcKing-Sam commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2008744597
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
AcKing-Sam commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2008710803
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
github-actions[bot] commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2008666107
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
AcKing-Sam opened a new pull request, #32518:
URL: https://github.com/apache/doris/pull/32518
## Proposed changes
Issue Number: [#31517](https://github.com/apache/doris/issues/31517)
**[Bug] cast date to decimal get wrong result**
Below case got the wrong result:
```mysql
doris-robot commented on PR #32518:
URL: https://github.com/apache/doris/pull/32518#issuecomment-2008662891
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y
63 matches
Mail list logo
