Re: [PR] [fix](thrift)cancel thrift msg max size limit [doris]

2023-10-13 Thread via GitHub
morningman merged PR #25194: URL: https://github.com/apache/doris/pull/25194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.a

Re: [PR] [fix](thrift)cancel thrift msg max size limit [doris]

2023-10-12 Thread via GitHub
github-actions[bot] commented on PR #25194: URL: https://github.com/apache/doris/pull/25194#issuecomment-1760956210 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](thrift)cancel thrift msg max size limit [doris]

2023-10-12 Thread via GitHub
github-actions[bot] commented on PR #25194: URL: https://github.com/apache/doris/pull/25194#issuecomment-1760956102 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](thrift)cancel thrift msg max size limit [doris]

2023-10-12 Thread via GitHub
doris-robot commented on PR #25194: URL: https://github.com/apache/doris/pull/25194#issuecomment-1760709070 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 47.42 seconds stream load tsv: 554 seconds loaded 74807831229 Bytes,

Re: [PR] [fix](thrift)cancel thrift msg max size limit [doris]

2023-10-12 Thread via GitHub
doris-robot commented on PR #25194: URL: https://github.com/apache/doris/pull/25194#issuecomment-1760701327 TeamCity be ut coverage result: Function Coverage: 36.30% (8147/22446) Line Coverage: 28.43% (65275/229593) Region Coverage: 27.11% (33809/124726) Branch Coverage: 23.9

Re: [PR] [fix](thrift)cancel thrift msg max size limit [doris]

2023-10-12 Thread via GitHub
github-actions[bot] commented on PR #25194: URL: https://github.com/apache/doris/pull/25194#issuecomment-1760693981 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](thrift)cancel thrift msg max size limit [doris]

2023-10-12 Thread via GitHub
doris-robot commented on PR #25194: URL: https://github.com/apache/doris/pull/25194#issuecomment-1760688984 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.66 seconds stream load tsv: 551 seconds loaded 74807831229 Bytes,

Re: [PR] [fix](thrift)cancel thrift msg max size limit [doris]

2023-10-12 Thread via GitHub
morningman commented on PR #25194: URL: https://github.com/apache/doris/pull/25194#issuecomment-1760688941 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [fix](thrift)cancel thrift msg max size limit [doris]

2023-10-12 Thread via GitHub
doris-robot commented on PR #25194: URL: https://github.com/apache/doris/pull/25194#issuecomment-1760678142 TeamCity be ut coverage result: Function Coverage: 36.30% (8147/22446) Line Coverage: 28.43% (65284/229593) Region Coverage: 27.10% (33805/124726) Branch Coverage: 23.9

Re: [PR] [fix](thrift)cancel thrift msg max size limit [doris]

2023-10-12 Thread via GitHub
doris-robot commented on PR #25194: URL: https://github.com/apache/doris/pull/25194#issuecomment-1760669558 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.64 seconds stream load tsv: 555 seconds loaded 74807831229 Bytes,

Re: [PR] [fix](thrift)cancel thrift msg max size limit [doris]

2023-10-12 Thread via GitHub
github-actions[bot] commented on PR #25194: URL: https://github.com/apache/doris/pull/25194#issuecomment-1760667751 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](thrift)cancel thrift msg max size limit [doris]

2023-10-12 Thread via GitHub
wsjz commented on PR #25194: URL: https://github.com/apache/doris/pull/25194#issuecomment-1760663701 run external -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] [fix](thrift)cancel thrift msg max size limit [doris]

2023-10-12 Thread via GitHub
wsjz commented on PR #25194: URL: https://github.com/apache/doris/pull/25194#issuecomment-1760663568 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] [fix](thrift)cancel thrift msg max size limit [doris]

2023-10-12 Thread via GitHub
doris-robot commented on PR #25194: URL: https://github.com/apache/doris/pull/25194#issuecomment-1760662532 TeamCity be ut coverage result: Function Coverage: 36.30% (8147/22446) Line Coverage: 28.43% (65283/229593) Region Coverage: 27.11% (33813/124726) Branch Coverage: 23.9

Re: [PR] [fix](thrift)cancel thrift msg max size limit [doris]

2023-10-12 Thread via GitHub
wsjz commented on PR #25194: URL: https://github.com/apache/doris/pull/25194#issuecomment-1760640751 run external -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] [fix](thrift)cancel thrift msg max size limit [doris]

2023-10-12 Thread via GitHub
wsjz commented on PR #25194: URL: https://github.com/apache/doris/pull/25194#issuecomment-1760639694 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] [fix](thrift)cancel thrift msg max size limit [doris]

2023-10-12 Thread via GitHub
github-actions[bot] commented on PR #25194: URL: https://github.com/apache/doris/pull/25194#issuecomment-1760194050 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](thrift)cancel thrift msg max size limit [doris]

2023-10-12 Thread via GitHub
github-actions[bot] commented on PR #25194: URL: https://github.com/apache/doris/pull/25194#issuecomment-1759537714 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](thrift)cancel thrift msg max size limit [doris]

2023-10-12 Thread via GitHub
github-actions[bot] commented on PR #25194: URL: https://github.com/apache/doris/pull/25194#issuecomment-1759078340 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](thrift)cancel thrift msg max size limit [doris]

2023-10-10 Thread via GitHub
github-actions[bot] commented on PR #25194: URL: https://github.com/apache/doris/pull/25194#issuecomment-1756495128 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](thrift)cancel thrift msg max size limit [doris]

2023-10-10 Thread via GitHub
github-actions[bot] commented on PR #25194: URL: https://github.com/apache/doris/pull/25194#issuecomment-1756491311 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](thrift)cancel thrift msg max size limit [doris]

2023-10-09 Thread via GitHub
morningman commented on code in PR #25194: URL: https://github.com/apache/doris/pull/25194#discussion_r1350492099 ## be/src/util/thrift_util.h: ## @@ -135,8 +135,12 @@ Status deserialize_thrift_msg(const uint8_t* buf, uint32_t* len, bool compact, // Deserialize msg bytes i

Re: [PR] [fix](thrift)cancel thrift msg max size limit [doris]

2023-10-09 Thread via GitHub
github-actions[bot] commented on PR #25194: URL: https://github.com/apache/doris/pull/25194#issuecomment-1752824885 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] [fix](thrift)cancel thrift msg max size limit [doris]

2023-10-09 Thread via GitHub
wsjz opened a new pull request, #25194: URL: https://github.com/apache/doris/pull/25194 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d..